From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E29E9C77B7C for ; Wed, 25 Jun 2025 15:22:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 80A136B00AF; Wed, 25 Jun 2025 11:22:20 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7BB046B00B0; Wed, 25 Jun 2025 11:22:20 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6AA0F6B00B4; Wed, 25 Jun 2025 11:22:20 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 58ABD6B00AF for ; Wed, 25 Jun 2025 11:22:20 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id D2F61B9D76 for ; Wed, 25 Jun 2025 15:22:19 +0000 (UTC) X-FDA: 83594289198.26.9A21092 Received: from mail-oa1-f54.google.com (mail-oa1-f54.google.com [209.85.160.54]) by imf24.hostedemail.com (Postfix) with ESMTP id DAC9A18000A for ; Wed, 25 Jun 2025 15:22:17 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b=Wh0icibG; spf=pass (imf24.hostedemail.com: domain of dan.carpenter@linaro.org designates 209.85.160.54 as permitted sender) smtp.mailfrom=dan.carpenter@linaro.org; dmarc=pass (policy=none) header.from=linaro.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750864937; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding:in-reply-to: references:dkim-signature; bh=U+WU1qicrpfWVxiSKMDNqBCOmYnFjqwgecK16bJOOCw=; b=1A/VPLDnP2SBRPWUCIuZQUZ7q5uBOVlQFoRiHsaKPoYg2U/r7Al2+KAEpn/FBH0xSCrCD2 Hp6+kyLB3vd30n3Tz4yfPCckvKkUIsfbkeUtyJ7KQF9Oofesa0VoasTw0VgfA7fwQwTm9Y TjXg2VeQt9UOSzm8+F+vNi1UzX8LrHs= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b=Wh0icibG; spf=pass (imf24.hostedemail.com: domain of dan.carpenter@linaro.org designates 209.85.160.54 as permitted sender) smtp.mailfrom=dan.carpenter@linaro.org; dmarc=pass (policy=none) header.from=linaro.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750864937; a=rsa-sha256; cv=none; b=bft8qyD7YzSleRzBFYn/y6fMb0zCYquSAPbTMhfot7yFI9vfWxFWlEVqdIrx2vJM6oWMHq Dzjv1USq+zdYp+2dEFGar+C51bAQ5Yv7dgTvEo8v5hqUkuWYuVYl0nzp+Vx07Ab7BZjN75 l+SRmm+w2lWyoziycgYk0XqYp1rqVjg= Received: by mail-oa1-f54.google.com with SMTP id 586e51a60fabf-2eaad5eb1easo15713fac.3 for ; Wed, 25 Jun 2025 08:22:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1750864937; x=1751469737; darn=kvack.org; h=content-disposition:mime-version:subject:cc:to:from:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=U+WU1qicrpfWVxiSKMDNqBCOmYnFjqwgecK16bJOOCw=; b=Wh0icibG9TdhInB/mtPJA9XWgapWnY+Z7K3J0/rvhBVXeLrFNr6CewLekLMFDYexQJ BJFN7mUm5IOSOCTRF1ms1xXuondFxEKDiDIxauvbKnPMGEr0EjUyFT4nSoYOtxXtgGZv W8I+bYg+u6zT9nWRi+VdccjiFSE7BUqFGVR8lBpGCw+3y9mWkqsA0LLikMeV+Q8GHWmm OclFiq6S+OD7k/3YD3/wDt8YLtxubNeIdA6PcYR97p976cs9+cDcL472mnVSMWzG1OJb tfQ2kc02JqCONEOCFXCIeJkGDJyoA90QpZ/YsIRmeRDtibUQQPGLbefr2L6Ke2OuBsel zctw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750864937; x=1751469737; h=content-disposition:mime-version:subject:cc:to:from:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=U+WU1qicrpfWVxiSKMDNqBCOmYnFjqwgecK16bJOOCw=; b=sXfhiRV+KdldUbt6l8akFCTCVrMCiWUrg4NeL4l+yUaAFbiMuIfUPhn0TKiPlvUQCu wuFkAEthBiN8sodkzSdzyEHcjsXspLrzX++O7sDMGSDvBqP2HulxAf2swV1ebkbuPsaJ rgc0ONfK2wqHnwpMLGrbkbSgLgUs68FxYK1m98XRz8UhlrTyjJde2OCUGsrqu3TBu+yv fjQ8IaWTI9vFlNjibrSdBHXpfzhEd9l93HZTJ0UXavSzL95pCzkv/4IA6mVkYFU/eiD1 uS5kVwhzMts0QyXBYVqryZfoOzE4nHMoHAjEwRjfRQxO5NNir4jCcpS0Jnwo5AufsclU 4QUA== X-Forwarded-Encrypted: i=1; AJvYcCWJptdNaJ0GcndC0osF9XiP+Ydv9LLap6HgU7teaHqDhFxs22GDOcw7vXeJ0q2nC+PZVdctsPpjOA==@kvack.org X-Gm-Message-State: AOJu0YwRmVcZH9d+X4PgkCSzhPaCivN4xtEnfdrJYri95x80Bdy8/b+F VRYaNUncRoLC0PGQNOcqbn2LHlfawbh2jdC4VnT10tmDSpTRfadr6yx9jhA64MKRLq4= X-Gm-Gg: ASbGncvEzuL+AvgqBXgAw8oizIA6yQQrQOk03He5w+6rDOMaiUTukY4Aw2NkadZS8h3 q3cNSmDUfBChXd+GYyQAjM6L/mKniftyF5Yx9wpuTOMNJLUW8iHBectJhzUfYyfdKzTWGjSSvym Kx0s7upu8leMNI061Npqe668QQnXMzTbLkvA5h28fpslWx0zpd01zglEX29aV9XNLVbucdrsPn7 c80NPApwt6uCLJ4dgcZp/XPjwFkvcDAPLiZ19g1t+MK9xj55c1Fqe2O28aJPDpLJRhZXmRHAQGI 65TK1CcygwbcGgb9LRGtdM26fZznntOe0Q2mad/pekNzNwjiUXnr2wTWGIO1qNbgtxO2Zg== X-Google-Smtp-Source: AGHT+IErLXYfNY1HcYwO06oS9rTd+ujnf6KFvXKf60FWeDN2HmwrG9jFGq4oLf9AmCw0fBHgkeUDew== X-Received: by 2002:a05:6870:e254:b0:2b7:f58d:6dcf with SMTP id 586e51a60fabf-2efce2d359amr92580fac.18.1750864936838; Wed, 25 Jun 2025 08:22:16 -0700 (PDT) Received: from localhost ([2603:8080:b800:f700:1fca:a60b:12ab:43a3]) by smtp.gmail.com with UTF8SMTPSA id 586e51a60fabf-2ee8dd151d9sm2595012fac.33.2025.06.25.08.22.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Jun 2025 08:22:16 -0700 (PDT) Message-ID: <685c1428.050a0220.346d5e.eafa@mx.google.com> X-Google-Original-Message-ID: <@sabinyo.mountain> Date: Wed, 25 Jun 2025 10:22:15 -0500 From: Dan Carpenter To: David Hildenbrand Cc: Oscar Salvador , Andrew Morton , Harry Yoo , Jonathan Cameron , Vlastimil Babka , linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [PATCH] mm,memory_hotplug: set failure reason in offline_pages() MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Mailer: git-send-email haha only kidding X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: DAC9A18000A X-Stat-Signature: cectquatgdkfgwec4eaq1mtpk56oxbn1 X-Rspam-User: X-HE-Tag: 1750864937-789698 X-HE-Meta: U2FsdGVkX18hSQVuOHQUEw4pVCCMUFcZkt2CiLx54QhHdHkiP245H3g7lmWsSopT0sSYqV8bgZxUYWisvWxFqE8B/rSmcPrQJmyWKAtwdXEZUbjfTYDnwmsMY4VRcSAu0y6QetsAM2AOPcNGwJCiXcw3eXGBsFmjqx5qxt0V523ubWHpzXlJkwMqREgU8TKxHzebnHhn0PETW0gdxzozK4iO/1GiPKDX/08HV+Vbm7MBi6Lts7l7zGXPUhThHFO/fZqsWtegtYy2pk+76qlvlXn7JjmILMhrcP7Jnk3WBy+JDyhNeNMizh793koqr+64gJT75GulA8nRfGDdUyqSRVfhii0t3z9QZhLubuBsbDqN4GojcG98Z1un/HO3IGFDKn/Jh3rA4xjCIeaBtE1qZ/Okrr1n2xjHpilY6UHk0qUIYK0mEMvL4bThhZd+YQCWFsBkGlZKwqnfLLjNL0cyBqKE0fM7qk6cVI0xpS69pQF08NzIQ5zsSwux/qQNF1PbjvxVevu98UqTTjcWkFRUYZRVMcgmK029VCAGT49M10i5vq6PwgsHAut4zhVtpGr5yzO+gk7HGVMV1pABRQDpo62nePfjyI95pASppbgDH5l5O6Nv2Ac4KKg0JoybZ8CVAnFdhRPp4QNHbF9O0zCSnosjjLBRM1pUlkntBB+GjKZ1/sZbjBPtQzs7spZ2QDp3GoFqSjNrwo92K8noobU1QMjpwjPc5xmb4RPsHu9iVxdcvcd6wU77J+IYLB971xo8IiQ3XluB5l/QxmWrkut3WUZjtyNnwAStr5IALTz9U2iYR0kvdVDZycmG480XNzrRQ1y2T+wAliX5WKyq9psqyd0v1NZ7r+MqSbmLT9gMVJR7SmaZpQ1MZyHOJjuVJpLCyUUUnw2lh6POUsvP+3FqbNosyA3hpimhVNlgEZeLIeVvHpNo/GR5RnAY8GCSRZ19+HxakMzIW517Eke7+Ef 8URq6NBr 7yvLaaTI4tCWtS4uzhQ30PY+0mq12kIhIJ8pgAKaeAl700ko8i+QUEUr6FnJ69bpf2OAhtRN79PDPB3nFsxIwKz+prPKBKg36HHd8TtC72+CfCCb6iHTAR+PWLeyTR6t42cUw8KvP0tawLwDYmNBSmXMwtdBxEwmuBm6WSGqqhP4+3L94ISEScz2a9S5qR5uLBvc1HeVG/8zvgd8cDz/HZrOEWpBAaMLi2V/0sltNrit22HgBDehGbVNhH3/GA6C7jd4Ng3mCa0bQGcfzdgIO1OOBojoVTqiOyVKNHDwBkeZ6HikzqDD2I7ylCbvIHHdAFDsno4QR87e/Vv1cQuI6+vDOARTLFIvkut8mR4tfcCxZ47saV7+U1H6jSw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: The "reason" variable is uninitialized on this error path. It's supposed to explain why the function failed. Fixes: e4e2806b639c ("mm,memory_hotplug: implement numa node notifier") Signed-off-by: Dan Carpenter --- mm/memory_hotplug.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c index 4d864b4fb891..e954f81b55a0 100644 --- a/mm/memory_hotplug.c +++ b/mm/memory_hotplug.c @@ -1977,8 +1977,10 @@ int offline_pages(unsigned long start_pfn, unsigned long nr_pages, node_arg.nid = node; ret = node_notify(NODE_REMOVING_LAST_MEMORY, &node_arg); ret = notifier_to_errno(ret); - if (ret) + if (ret) { + reason = "nr_pages more than present_pages"; goto failed_removal_isolated; + } } ret = memory_notify(MEM_GOING_OFFLINE, &mem_arg);