From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D39C2C35FE4 for ; Sun, 15 Sep 2024 12:01:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1C3CC6B007B; Sun, 15 Sep 2024 08:01:59 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 175066B0082; Sun, 15 Sep 2024 08:01:59 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F2F3C6B0083; Sun, 15 Sep 2024 08:01:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id D83156B007B for ; Sun, 15 Sep 2024 08:01:58 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 916A8141E7A for ; Sun, 15 Sep 2024 12:01:58 +0000 (UTC) X-FDA: 82566833916.03.9089E34 Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by imf26.hostedemail.com (Postfix) with ESMTP id B0946140012 for ; Sun, 15 Sep 2024 12:01:54 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=LzPqLME9; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=uGrf5Too; spf=pass (imf26.hostedemail.com: domain of lorenzo.stoakes@oracle.com designates 205.220.165.32 as permitted sender) smtp.mailfrom=lorenzo.stoakes@oracle.com; dmarc=pass (policy=reject) header.from=oracle.com; arc=pass ("microsoft.com:s=arcselector10001:i=1") ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1726401660; a=rsa-sha256; cv=pass; b=g2YS6GUZrxiQ5IHICJWK5sj25vO9fqZlnsxSCsvljF5OQPYe6Ai2VbPbHHuis/8epsI2GN 0LFTGvxaPsZWJM7irsU7o3091sZmLRv8FWx6Exn9xO0O6Y7n9QKKOWiU2TOT4tOyqboydd 1r8X0oW3IUtP7TWpDYQ8owed46V26sI= ARC-Authentication-Results: i=2; imf26.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=LzPqLME9; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=uGrf5Too; spf=pass (imf26.hostedemail.com: domain of lorenzo.stoakes@oracle.com designates 205.220.165.32 as permitted sender) smtp.mailfrom=lorenzo.stoakes@oracle.com; dmarc=pass (policy=reject) header.from=oracle.com; arc=pass ("microsoft.com:s=arcselector10001:i=1") ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1726401660; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=KPCoYpr9BogDZzXjZCgP5SpzNnZpgVS4TnVC6eobEJ0=; b=P2qCrK4SZwUL+RUdly03wucGz07eoVlTSc76U67rYVMrLap7KOIgbp0iYUVzQy3NbU6mpl QKa4fRKqLP55ASfw4sSJkA++6z+jtAU5Q2lVy34f/DAYLx4bpHNPBq6ugeABRzBCmLbgE9 10/6P7SkfbkCt9Y3zTN7JTSoQnowTZw= Received: from pps.filterd (m0246629.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 48F4NwYW029026; Sun, 15 Sep 2024 12:01:53 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h= date:from:to:cc:subject:message-id:references:content-type :in-reply-to:mime-version; s=corp-2023-11-20; bh=KPCoYpr9BogDZzX jZCgP5SpzNnZpgVS4TnVC6eobEJ0=; b=LzPqLME9V0n1JXDEDIeRSjHbk4Rwrik hYG7Jy30arRJ4Igvy0+n1iKEEt4DG8cRp0opjFB3upmGZ2GNcgRnvQn0jALknQzw 5j/Bb4AiLROl3xSk8WPOYqKMK4fuMfkwb+jyf/n50XH5ArsfWcYifTIiQcG0T43z 70NpLWd62dCLu2HZDOGIHT8Srg1IF4gOOyf8/bmx8jwi3vt2WbiodRHUVrt30iqg t9k8hzPZsPGPY48OBoMF1HcRP7ZkbpHLv/dtF4+pve+jL6VkzMgtwnFwKubKTTnT RO2BXpdbd11XpIBgk8rj7C44b5/3nvMJfEzNGO2acy41+xbkzOQg/vw== Received: from phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta02.appoci.oracle.com [147.154.114.232]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 41n3n39jpk-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sun, 15 Sep 2024 12:01:52 +0000 (GMT) Received: from pps.filterd (phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (8.18.1.2/8.18.1.2) with ESMTP id 48F7dFbX012198; Sun, 15 Sep 2024 12:01:52 GMT Received: from nam10-bn7-obe.outbound.protection.outlook.com (mail-bn7nam10lp2044.outbound.protection.outlook.com [104.47.70.44]) by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 41n0x7353f-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sun, 15 Sep 2024 12:01:52 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=wzhPTE9kgTda/3Q6pt19ipR9tQX21Q7Sy/W6qR461O7+bQwu3J88w14vzsYyi7o4VtHXBhnLTml1saUu0DZWbTB8uICgI0cULTL+NqtZuQbbZ9LDJzdWJ02rJsg/L7tK+JL3ZUw6M71QHcKbtWUdZOHUPBL96FV5hXROyx0jYeRYmgwTJtyCSV3tW7HbgDA24M/V3pkbd89jffzGnePzM7qVyUaJgRGkYAtecG4MG9TSA0M/5Re+agtxB33aa2sT0ZS3ZzpNfer9wg77go2DSiibi8G54MUzq3WOeNlJahtMKfCbWPayMrPyKmZgMzyWGIZ8H2GofMWUvwk+7CRmug== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=KPCoYpr9BogDZzXjZCgP5SpzNnZpgVS4TnVC6eobEJ0=; b=MhLqvmPcbG56bMn8CsVGpAujATCgmEtRQgLjOX8SM/5NO1qMqnGR8kv+lxGYsLsojuPD+p/Y8It/sW7CUBwES1mOAO9adSfdxiKcMBUpHUyckfQZZCHQE5aA9Y3D9MEcwQZMqg4bZxNqMTUWzww/dZ+p2aJ82+tKXphPbfYFY4cgfxY0fqJtnQlLkCiYPWMZGB96/HhSNKoVbeCQrpjBnv4bmLVDLSAeiqRWcc/2bGDqf/iKFHG5KMZEKeZCXTutgbrcMSYOo8cFIWjlO3dzG6zZkyDOjhspHVDP6zXY0F/JgsbsRFAB6ecRZL8S2+3VpPI4bIIYvyc/v7BsG2Z0PA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=KPCoYpr9BogDZzXjZCgP5SpzNnZpgVS4TnVC6eobEJ0=; b=uGrf5TooML+OczM7T58/NYKE+TwppomlZ6QJwPexjKaMEXKaPr5IwGztvChGyOj/IZ0g1FDgQiTlVx+PSxv9rSnvwMK8cY8IsNViLChh+bMmuuf62A55V39zxv6d0PjK086kNtBWWYkKc+lr7Mj2P3syuBuxxV8WDt9sQFEHDD8= Received: from SJ0PR10MB5613.namprd10.prod.outlook.com (2603:10b6:a03:3d0::5) by PH0PR10MB5595.namprd10.prod.outlook.com (2603:10b6:510:f7::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7982.11; Sun, 15 Sep 2024 12:01:49 +0000 Received: from SJ0PR10MB5613.namprd10.prod.outlook.com ([fe80::4239:cf6f:9caa:940e]) by SJ0PR10MB5613.namprd10.prod.outlook.com ([fe80::4239:cf6f:9caa:940e%5]) with mapi id 15.20.7982.011; Sun, 15 Sep 2024 12:01:49 +0000 Date: Sun, 15 Sep 2024 13:01:43 +0100 From: Lorenzo Stoakes To: Dan Carpenter Cc: Linus Torvalds , linux-mm@kvack.org Subject: Re: [bug report] mm: avoid leaving partial pfn mappings around in error case Message-ID: <68590155-fd3c-4ce4-9a1f-d314efada198@lucifer.local> References: <8e3ffaf2-358f-479c-8de6-46e1b0bb0c5f@stanley.mountain> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8e3ffaf2-358f-479c-8de6-46e1b0bb0c5f@stanley.mountain> X-ClientProxiedBy: LO2P123CA0077.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:138::10) To SJ0PR10MB5613.namprd10.prod.outlook.com (2603:10b6:a03:3d0::5) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR10MB5613:EE_|PH0PR10MB5595:EE_ X-MS-Office365-Filtering-Correlation-Id: 939e601f-bdae-4da4-0f9c-08dcd57e2dc1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|376014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?QBGZYAgnSFl0q7zHUwP5vmf4XL6xCxm6X8W69r/Q5R/ZXckA0lkv62CnGafs?= =?us-ascii?Q?7gKCQ1EVmSqVCvDPJxdxjtcorxJzO0gxUAWIFRdxkHGPT83/3VWFag/pmMag?= =?us-ascii?Q?c7uRORpoI8up6abU9XsVDLyxkhV6tVnhNpxiLW5Xbw2+5l3p3ZdA3ABJeveL?= =?us-ascii?Q?j+JOlMAiZLpTEuxggTa2wtJULPJDsNrQI16OwnklNSjK1mvx80WlhiRnmbQk?= =?us-ascii?Q?oilz6auUg1j3/csOnRDo5HvO1ALd6wpKCrPuSBIb+y6bfjFzZyvJ8YV0P19G?= =?us-ascii?Q?jllLBuEo4udtn/4ViypA9oEqge32uiQphFnll0WVW/D9TYKGARYa0mKlgWYe?= =?us-ascii?Q?aneVmsee7dmEQlJ9ZJs+WE5TwhcC4bX0wFCkGC1BheMJr05RZfa3pRzWifRu?= =?us-ascii?Q?6ilZotjDNIn7VfQZU0//oQzh+6FvM6uDoFTFL1KuoituUBGeEjsFHIpQH1EI?= =?us-ascii?Q?YAStkRAXYXmC7w0Xeccy/AbVYSF9QMOOYs77VCr+kN3XhHsgJfexfvThm3uG?= =?us-ascii?Q?VUAfV7dczxQ4eVbga/AEZe2U+vST3pjU8N+G0GT7q3GGvb5u1mJR0O9YluRQ?= =?us-ascii?Q?Qg5odvJAj+OtzIPk5kxMGfVkzZ/M87K1hmc4MNg2676bz0Hfsuvgp7kM/JYC?= =?us-ascii?Q?tclUdetTN9EGeNHGhWJqJXYz9lgkt97CCaexPjuASAXw3V2e4isfJtEiPR64?= =?us-ascii?Q?pNjB0e2pTi0Usp81C97Ib1je/DxksTFsv5I6FRLv56guF38f9zj6m4Qy6CKf?= =?us-ascii?Q?nmMeeouX0lR0zg+UXxrClPz9Z/k5OfLROvgpEMQ0hrOJnXqLi0a6B29tS7h+?= =?us-ascii?Q?TpxWfU0mjegIJ100H0BPdsNj7VrVWHq5w3zBuK7jNnHQW0GmrD8JmjxBaaqR?= =?us-ascii?Q?WB+k0wcUnTM5PSeWfCdYzDq6ZxIncul2VPH49i9Rx0FaYJ0iYXf6WiojhRRA?= =?us-ascii?Q?GLJaGRbqsXQdzAGOSnfT3cysCjMFuN5F3u7AeA0ezFlgZMAJ5tYq2dUe93Zp?= =?us-ascii?Q?daoTT2gpJ0ztFHHis99AGPUikHkoxGh5Vjej/WDroFpJMoA+t9Z7A7ZSxMur?= =?us-ascii?Q?R/KMp4aD+yKjOC8y2SPEuytpQFd0pQ4U0dYZU6uWYuSkUR+16tj2PX8uxx3d?= =?us-ascii?Q?7OQwHSJtMVSmPxgZJTQo3vWxm13fghtVWJyDVelKjXS8r/XKiwDgNjxjJu1p?= =?us-ascii?Q?rK5Ox4uamdFv9Sf47DNo/N7p+kExyLYrFAMgtblPD0G3Zepbc/CM71W8G5Xi?= =?us-ascii?Q?200hPTLx1JL4x200vVGUdRdXJ0BoUfIbkz4+n5f5jrB2XAsUWaP/GcsM2OD5?= =?us-ascii?Q?Ov8ruME99KIeOh3wKzwJk5O35sXwjznB0p0RGppVwUvzgQ=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR10MB5613.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(366016)(376014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Sj3EtGyTQjWXWNElySp2hxafqU0wUIB1lcqY25wHAZxTLChqJ9QQGqsqIeuA?= =?us-ascii?Q?r9k+mKTcnDOlkeqTXdX3p5Wwzs0TYB5xlWMfV5VTy8ow1Y6dO43KArw12VH8?= =?us-ascii?Q?7LxFqBxzmVkKLL0YH+p79/ifxOjfm8oXayerAwse9gwoy3i+n9PplmwpkbOC?= =?us-ascii?Q?4BDnQYRrZk+/jPpJEw4gNYvm5FckD9qBlBLj15ue1L8ABzlaSY1y7IGVGPLD?= =?us-ascii?Q?pVZ/4rsPgaOWzeSr3Ph0jXlb341NQkS8fZml6K358+T/mrWkjTbuZtT6HqLC?= =?us-ascii?Q?FhrTD74xSCt2Nvk/oJ5dEjQ/6dj7d/BzPySSVTQF86Px+hNHiwLwRRKdWjcm?= =?us-ascii?Q?uKndPR2+q9XSPF6L/Lz/0hfNBnMkK7DociICucs5Aqh6MzvVqq/DNNRZ9vlq?= =?us-ascii?Q?mbILekcUacyFRUyh518jWPJOicY8dpjgup+YcGbl5jrN+12xmV6glE/b8k8O?= =?us-ascii?Q?2fJZ4tU6ets0NLW+GBCs2epDfqcg3vEF4KgFa7DcsfrvhPauwlQzDrmDtd9J?= =?us-ascii?Q?WXgibid/+WAjd3ePmlhuq7xQSy6obl18XyZb+CNmbvWNHdRkzGn/cryXoTll?= =?us-ascii?Q?imx7eAS0o4WU3tAMd2CenXYfSAyiPfIIJakYR0V7nJL66qteR2q6O8RxPDFf?= =?us-ascii?Q?CYnPMecGItE9IWG7Afi4+WWyWQhJKjfB0tOzS5STfcWz10tPaXaM9UeF/bRv?= =?us-ascii?Q?O0funTSrb0R57Ep0/94jHUsDfy/vSgazUgQtC3kZD5xkIvVQZ3bQy/nNNl9G?= =?us-ascii?Q?GgXmIHqQL5t3z1P9zNvWrI+c146eMsr7LftYPVfa9N0bFj32DnHwHzEBqlGX?= =?us-ascii?Q?eM53IlonaxiNNqQFxDqU5SU1rMM2yD5xv6gsgylAzlQFqzY7Uag7r+Atq/p9?= =?us-ascii?Q?0qlpkPxX/urf5AEvzQlSgPIEzSI6iLINu5HUVzwR4p32obI6SU20/LbnNv8s?= =?us-ascii?Q?ZcXxOTTJTs77jK5dkqh2XkvYh6gwiAwyQU314gA5DW8dbSMNEeF4SCJp4EMo?= =?us-ascii?Q?PcFoVzm8FvIDCh92uVqTuxJcxKvrW+cziHqEZWsoZEe8MyFGFo/xKLDX2noO?= =?us-ascii?Q?BjhriXTz8H02wPzgvZoOmqZbDeDQ26nnWCUx5yNT6R6s738tgSKjFR0ILtdG?= =?us-ascii?Q?NOuSF2L2pFryDJoV92oo9B3CXPxWtYFDiiuZJRyUKaNiFcZCEwNe646mrI8S?= =?us-ascii?Q?gnmiT1BU1kzBZ7c1/2KTM/KeeR783rC4TlttLx4dj5LbamS9SsNYIQUuwJ91?= =?us-ascii?Q?59TVb0FOP4548qAAnIFMdph44REr55nnS9CJFZrd4DGxpYyLwj1PrOwPzkxd?= =?us-ascii?Q?9rQa8N0j2YA9nHkKhPXYVG4O5O6l88pjhHy+wS+0/hq+9ZjydiE/vk7qDAnh?= =?us-ascii?Q?uNbJn8erL+IjYuS1l7805HCcuxI+aumzEphWzsxArj3Vohq8diifJjn5PmkB?= =?us-ascii?Q?QqI2ovezHb43T9KAfpVabB3B6Ourx9nTGwYnzjdACmryxi04CHwMXExiqfwP?= =?us-ascii?Q?Wwhs8NvtFeScyN7WuN0Mx5pvAKKYYCcCSZYqFkbWkyfv71XlTCaFwN33Q+jQ?= =?us-ascii?Q?ZxhpCjo9vNXEtnjl3VgS/YjIy4E2hHxuujjr6fvxlbhH8JzYQLs69ZPxqfIt?= =?us-ascii?Q?RA=3D=3D?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: Nev2bFKA5AOb+pdxvjv2atR9ekKlvHOWM3qLIGGQVd6uA+outZ8vb2Yxc9k4tWPGUSm9Q9N6N+TSSUv38ZzNZAYnxB4bCUuPgjy+MjVckktLWiTB1Qoinfp7iEzV4BMxjymbFeTebkwLe/5a4GeTYFaQA9c1jYol6vFgd4CZpDHZUnWCo1eXcDraLN+/TPnAKLF0suIu6mEquFQN0CWi4rSznrNKIzU4zJnJKabXeFojte0cGgdFGhwi8a0dQ28ukPeaZfQ8xTn2VvVwp05aVk6iFEu2GxDnJ/G/H15MHDUnTvnYfOHzOSQyvqGtR2c2HCzqe2ZzaT/SmTHKqjIWz0CoUJHwG/pRSdfzn6GgRCVk/pJ9rJS7TA6yyucvoeNMlbchOy2TOUROsDj1PdjxK7Y1k0KQOZjs1ZGnKg1BGyCow9yIbQcZpD8ogKXkWzAwX0B8oI0rom4F8CLnmUGXldr8/nbjQnDNHtQpddHB1q5IibA6liIseuIrAupqWiK3sTIQVk8JjgVEtKbp41Tk96bTSXoBxs5jxMNqvQ7+7hpxZ10WC2OtkJOC2xVjNTYiAPfQkBw+Laxq7QXe4jLlx5SNczp8Rn9w+peGGS8WdRk= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 939e601f-bdae-4da4-0f9c-08dcd57e2dc1 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR10MB5613.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Sep 2024 12:01:49.2496 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: g99lMuvl2+gc53vXqZp6qKR0iSJc51vYLTnMZuK6/rt/7ip+8y4FniV1brWkOER9csFIawDDjli5OocNGiikND0VyeFrZ77pmOYmdg2tk9o= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR10MB5595 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.60.29 definitions=2024-09-15_03,2024-09-13_02,2024-09-02_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 adultscore=0 bulkscore=0 spamscore=0 mlxlogscore=346 phishscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2408220000 definitions=main-2409150090 X-Proofpoint-GUID: yCmtZygK4Wtct_JRtZW3u09jgqXGACCV X-Proofpoint-ORIG-GUID: yCmtZygK4Wtct_JRtZW3u09jgqXGACCV X-Stat-Signature: 8hq4xzbx6449jkp4diyu76of4f8xfajc X-Rspamd-Queue-Id: B0946140012 X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1726401714-375063 X-HE-Meta: U2FsdGVkX19siNdH8Vmi6cp8RCyL5rfPVPXWsmZk1tjsTtuHQUgmpijNU5TCiY44r8hFa9LS3PkXa7FTMpkZq4Xylsi/iSLsAHGPJ6ptEuTM29fOQ+jSYJn3MW23gPlIb5T6TX5bpko/soaY5SZzB8i+5OudZ9TOBfjDL2actxDatb0nTbcKQ3D+plKWiMx9VyBS53dAynmM/B6lI+pX2fn9YlweGUgL6q9mW500RcgUsF9yghON8tNP9OuU6e2zBUmklKHsj3KH3WEUBW53AhjzCsPI/3S2cNLZnBBnHxCsnr3ncBI8Wg0BDVP1xjpdqnUgz0DOi69fx5Aak0PQE4aHqcDD6HX/5K8bQkBIUN16aBTM5HhIoaqo8iyhOTDTplrFAy6dkmIMt+/c03sGNAX48YpVt7XrDHzq8v++ViZPX/MfA+CImk1ePaImRtetMeMgZfjCr8kuLTULpdKJYkMzHufLS0oidWBucc+o7PJpNuprT47BQJ0Wd9TYzqSP02DprInOQD9LNF9Z9Hfd7SsPrpOdMPjkNDDUQQp8Gr6pVQdjDPsJSdjT+YdEWSN1Ph4r6vVNE0yM2BLnqhNFBTzbImMerSCPmZdQZPicaqxlkfs4ECvBLZQfJWRdtXq0qOxnBhraUX2pcnmugUYM1/zXUqTsuexAlFzW3iam45MbSZtbJVU9GtjGu5QPYLAG2ZGfmVd/98DxqdGuz94sWiJ+5iuYnVA361n+UI6bhixYR/f8hDyRshh50qxM/l5wprI4GM7NwvE/4bBgqHKv+kkvm75bEcbXxiN7hGSgKrHAPFgsW4LfTXs5JaOtKGAlSZIxNt+10T/rwBj7UO1kKwheYq7G6d30eQVuIs5ygHq2pKaB3NNOc4KtnBIcmnq8dcur4vynkyMlG3YdQ6NFLLHHVApibrlWrLMfC+P7+WmOHnnOTFeNji1pUUOclPVczu0z++s3AlSu712ZXa5 Hxj79cc9 yNSeDOMtnnuPNpnVdjQXNtVpnWoJu0jP/wwGAyQTSyUjZeBBVgaIHvjaZxXg0PUhjgjeFCwYUUGNd07sBMlleUR7FpXpnHHpSP3voNohf2lfj5Er0X5c7ayg2z0JTmQRVLj+JHBNccc8+Th0EmqFccrX5hCCgB56/zdgOx9M4A+i+1FAYEmib5rmyY2eZ+kES777XquzCU6ZKVhIonH4+wjvAhGgMuHekDa/u/QrDng6PXKrT/iMcJP6dtpyIGgwFAj6TwOcb3RYfZ60vPuqD9LoFjItQLfMOy6GiG4bR1ZFk9JNccjQZVBzF4RCBcSiV24eCVf/BMTRBpDW7LR6h6Cou7jzfDhsbRSfmvoJvOwhjdQ+kJ0eE/gXoR72crDtcJMAwgN4jYjkdG48GEn3pqaO47pmmin5kiccuPxyjQ05ljX4VwSDzR+zcXpMO4v5GyrqR6eg/WWDd00ibjoO8nhoyw6f+T/1CBSn7xvCPezr70To= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sun, Sep 15, 2024 at 01:08:27PM GMT, Dan Carpenter wrote: > Hi Linus, > > Commit 79a61cc3fc04 ("mm: avoid leaving partial pfn mappings around in > error case") from Sep 11, 2024 (linux-next), leads to the following > Smatch static checker warning: > > mm/memory.c:2709 remap_pfn_range_notrack() > warn: sleeping in atomic context > > mm/memory.c > 2696 int remap_pfn_range_notrack(struct vm_area_struct *vma, unsigned long addr, > 2697 unsigned long pfn, unsigned long size, pgprot_t prot) > 2698 { > 2699 int error = remap_pfn_range_internal(vma, addr, pfn, size, prot); > 2700 > 2701 if (!error) > 2702 return 0; > 2703 > 2704 /* > 2705 * A partial pfn range mapping is dangerous: it does not > 2706 * maintain page reference counts, and callers may free > 2707 * pages due to the error. So zap it early. > 2708 */ > --> 2709 zap_page_range_single(vma, addr, size, NULL); > > The lru_add_drain() function at the start of zap_page_range_single() takes a > mutext. Hm does it? I see a local lock, and some folio batch locking which are local locks too? Unless this is hugetlb, I see: -> hugetlb_zap_begin() -> __hugetlb_zap_begin() -> hugetlb_vma_lock_write() -> down_write() -> might_sleep() (Also __hugetlb_zap_begin() -> i_mmap_lock_write() -> down_write()) I see only spin locks in the page table allocation paths (unless I'm missing something). I may be missing something, however! > > 2710 return error; > 2711 } > > It's the preempt_disable() in gru_fault() which is the issue. The call tree > is: > > gru_fault() <- disables preempt > -> remap_pfn_range() > -> remap_pfn_range_notrack() > > regards, > dan carpenter >