From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A76CDC61CE8 for ; Thu, 12 Jun 2025 04:40:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2AE766B0088; Thu, 12 Jun 2025 00:40:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 269DA6B008A; Thu, 12 Jun 2025 00:40:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 134A46B008C; Thu, 12 Jun 2025 00:40:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id E8FE26B0088 for ; Thu, 12 Jun 2025 00:40:35 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 8D9A31D459A for ; Thu, 12 Jun 2025 04:40:35 +0000 (UTC) X-FDA: 83545497630.25.CFBE621 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.15]) by imf27.hostedemail.com (Postfix) with ESMTP id 0EE0340004 for ; Thu, 12 Jun 2025 04:40:31 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=Cln53Mvq; spf=pass (imf27.hostedemail.com: domain of dan.j.williams@intel.com designates 198.175.65.15 as permitted sender) smtp.mailfrom=dan.j.williams@intel.com; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749703232; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=PFly3u8PdBtws8pkqduf5yrNd9To6si6LYrmPiMsrnY=; b=YbOjRh9lACCBgl0FGtGePqXcPrdqK3XfVkHSbYtSluRzks7DNYR5NTbjXhIgtmWe9R4nzR phMgLdkOOZ90FSyBx8yCrqnEkkY1kbokGnMBUlA1NdOmzU3aZxAM5SDMffg0GKC6eaH6Uo HnU9rL2ZuZZdVrs0ew/Hqa4agEDmSng= ARC-Authentication-Results: i=2; imf27.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=Cln53Mvq; spf=pass (imf27.hostedemail.com: domain of dan.j.williams@intel.com designates 198.175.65.15 as permitted sender) smtp.mailfrom=dan.j.williams@intel.com; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1749703232; a=rsa-sha256; cv=fail; b=jKTz88Pvz+4ajJXp5LZeFX5J/0PbiAAmDRdE/epvnXvOkaB3ssFN+qoxgaNZq+m8k4fyPg Dmt6xwcYTlE4DY9pcMtFG2AwJFvEHTKrssHk5kQLZh2SPJjzgxZH7NELTJVmg/6rX+YkjH FejJTzV0KUaTXvhFIPMflO+O8jLlTOU= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1749703232; x=1781239232; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=Z1SrkUzsMRJETIeekxQDQ1mrTj2TLEA6fkqpbZSu0iw=; b=Cln53MvqLmDEFTZvaKmeaY1PagZZVKJA7mz7+xMztSxEoms5TjR9iMIO lqHCgeUomNAgr3HqmKfmFkxkmFZrjQ9lV37MVDfm6t3gESSzfjV65SpiJ 1EqWcqxDd05SVxmhkQkSL94U6TlpJoyWYPJfD/0802AygHMM0mH+qq/XA eS/Iol8qDC2r4EXFbyJqRvThaEws+5j2c7CRAOMmDyZLRtH45Ev5QhtrD wr7QaH2G07dZ+vfGazTReCNF3w8W5sUQN/7zR6jh4BQSno81cUWLu9LM8 rss9OZMFZUvvW+1mVC8kPs3G9Yku/ulNzbyQF10LSHQYyyUaMSZLCL7RO Q==; X-CSE-ConnectionGUID: VlLLFZd5TVWXIVfpG3u+Qg== X-CSE-MsgGUID: nud19YLkRxOA/nwTefmcjw== X-IronPort-AV: E=McAfee;i="6800,10657,11461"; a="55535410" X-IronPort-AV: E=Sophos;i="6.16,229,1744095600"; d="scan'208";a="55535410" Received: from orviesa005.jf.intel.com ([10.64.159.145]) by orvoesa107.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Jun 2025 21:40:30 -0700 X-CSE-ConnectionGUID: SK8Q1cglT3KRZtTbQ6J2RA== X-CSE-MsgGUID: nWNpeGLyS6G5KmeJp3voLg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.16,229,1744095600"; d="scan'208";a="152682539" Received: from orsmsx903.amr.corp.intel.com ([10.22.229.25]) by orviesa005.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Jun 2025 21:40:31 -0700 Received: from ORSMSX901.amr.corp.intel.com (10.22.229.23) by ORSMSX903.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.25; Wed, 11 Jun 2025 21:40:30 -0700 Received: from ORSEDG902.ED.cps.intel.com (10.7.248.12) by ORSMSX901.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.25 via Frontend Transport; Wed, 11 Jun 2025 21:40:30 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (40.107.236.72) by edgegateway.intel.com (134.134.137.112) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.25; Wed, 11 Jun 2025 21:40:29 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=mMSi3EirCWyaSs3kxcFCeRqwLEm9B3euIFtlGQVA/YmudGFn4uXARGhDXso0zerPFr7Xoo10egx33wn8ftDX8laaia4tmTIOSeX0bqoP/Bze4SoGQe1mS+0Cd5SgcLwX/RSp6sBwC4jDlILNWS7AfeqVhIq61RKwlaQAb6YAzxdPYPLgG2FCAV6GFxl5xvo6V9c407UlvYGQSu4tE/48CG4eB0eiJHUznzuBLtv9NzVcXB4BWif8ftxR/oP8y7UFQ9jm9LFZYXpDcp0Ij8tpUb3QAwY3Ir55OLAv/fWXU1caMiXLImxYEc3dOEZRD1d28UNXuyTlB8rKyNdi89W74w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PFly3u8PdBtws8pkqduf5yrNd9To6si6LYrmPiMsrnY=; b=I3M2/RbVgR410EkzWbe9xGY0U+dg0fK6K6o1JNQQqSmQY590IpD1bogXvrXcC46SlkR14A9UcF+elsa+Qus1pKS7vhjtBAFQcQ/Nbf28mQTUX7eFb52H04qZYkuH/Bk57LGkIzdKL++RVrvpcBPcoLi7OqxqjY/jmUcZr/lL/xaBOYLRgqvYyWCLwxOwEO/77hUsfc+uyPqQI4VOyyJZfM5jZbRNEZ/14U3C1+pKY70dA78sVtIRNc8HjtEFpyZ73g0p8I5LrgP4SfLnXfI3eYktJNoNFa1uvh3B1KBkSjqwCIh+O++71Qt0/JagNmlZQMvCot5+e++jTBHz4YXu9w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from SA3PR11MB8118.namprd11.prod.outlook.com (2603:10b6:806:2f1::13) by DS7PR11MB7738.namprd11.prod.outlook.com (2603:10b6:8:e0::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8813.30; Thu, 12 Jun 2025 04:40:22 +0000 Received: from SA3PR11MB8118.namprd11.prod.outlook.com ([fe80::c4e2:f07:bdaa:21ec]) by SA3PR11MB8118.namprd11.prod.outlook.com ([fe80::c4e2:f07:bdaa:21ec%3]) with mapi id 15.20.8835.018; Thu, 12 Jun 2025 04:40:22 +0000 Date: Wed, 11 Jun 2025 21:40:19 -0700 From: Dan Williams To: David Hildenbrand , CC: , , , David Hildenbrand , "Andrew Morton" , Alistair Popple , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Zi Yan , Baolin Wang , Nico Pache , Ryan Roberts , Dev Jain , Dan Williams , Oscar Salvador Subject: Re: [PATCH v2 3/3] mm/huge_memory: don't mark refcounted folios special in vmf_insert_folio_pud() Message-ID: <684a5a32ee1dd_249110080@dwillia2-xfh.jf.intel.com.notmuch> References: <20250611120654.545963-1-david@redhat.com> <20250611120654.545963-4-david@redhat.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20250611120654.545963-4-david@redhat.com> X-ClientProxiedBy: BYAPR05CA0009.namprd05.prod.outlook.com (2603:10b6:a03:c0::22) To SA3PR11MB8118.namprd11.prod.outlook.com (2603:10b6:806:2f1::13) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SA3PR11MB8118:EE_|DS7PR11MB7738:EE_ X-MS-Office365-Filtering-Correlation-Id: 67d316b1-fe49-4f41-6f84-08dda96b3ddb X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|376014|7416014|7053199007; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?CdEKRiSSmeIYUpRqBdakiCJ68Z6Wj4/n5cT0hjKI1t2xGVAbR4skjfBRVqg1?= =?us-ascii?Q?TwaoQhy44Tt7lBQFQTazAN4AyIYaClG3SgvfhyYVuSpyjzKJnd1ogiAINur3?= =?us-ascii?Q?XbtHqLjxTR/rgUj2jZMLfrJqUY6FNVDGq0FwC5miYXfwZ0G0BSWF6+qr2MVW?= =?us-ascii?Q?4RZIXk3OsFjCEugOqrCWCjfHv6xKYWxIAag/ACTFgqSwM6TknT5IDZLK/Tcp?= =?us-ascii?Q?fxJegM7YkISWdiu6A/3vIjgc8pSwAA/YOAzp52mqeWFeJgtQ3mbFkbqX8Iqy?= =?us-ascii?Q?mKtJAmtyor9FvHurOUnN+pNVK13iR3HJLZJQJ1Q+EzFrwL/vq3aa+/EdMe9c?= =?us-ascii?Q?CC26kYsxC0nGBJAQdPxn/rJW4o6/XB8GnWlQeZ+tpzTWw2SUkjnIVa63wIjX?= =?us-ascii?Q?Dn/KpXMz9AgkM4wcuJ41ueoaugUdCuDFF3N7WbuPGEuGbEA+HR3nRNkcK4v1?= =?us-ascii?Q?CZS30i0RAvhPL3/3R6ehoLmD3SPsNwxn94E1J03qmr4TxD7UAaq7EvMY7ST2?= =?us-ascii?Q?k9c5a7NvpAl1J+63SrQjp7JJ/TKnurokEuUsxobj1tXx3U9WVIGe9EQEPhGS?= =?us-ascii?Q?K/9N5GVIJ/AU42CE5os7JmRL/bYZQvE6/HCl9ZGpwlT0LF26k/358PN1rVtq?= =?us-ascii?Q?w7A75GJ48B4oMr1et7Kpxsa6pODnHTHXVf1nAdW+At5ru7Uyi5N5ySU0479d?= =?us-ascii?Q?RSEC1B6WWMMG/IybXpN3xAoyQWE28sOV5dOoMvAnA9gs5xq3r3/68z1pfWHn?= =?us-ascii?Q?XOBWUlfakP1kL3Tw8Ot5RUtf8DzlSFxt6LkOfqXcngUm5JhUEuwJI/gNLazG?= =?us-ascii?Q?1UE65ZkIJltmV7tSw7oIc/gtJjIcmyAL0Dt9TePQNoLOsGAGCr41KrL5iUqm?= =?us-ascii?Q?iF5X7QeIGRfMKqcXhh/pUrof9g4ksLDrvLex95g6HsE8K8Etlr3DrFzv6NEL?= =?us-ascii?Q?RasqMOdi4QEhQVrn4S6UGieHZXrNDwzIleL3djwBjak6iuKPZ2lx7Ezmstkn?= =?us-ascii?Q?gq90k8mN4VF5fdyx+JHQXGLF6yVFDcWfS/2Bh/SV8Bzgz+LnH0ypBa6XzjQx?= =?us-ascii?Q?8OjbJQJ2Q/M7VFMhHIWmT5DE3iRm19bUTXEWT7Mg/HpVsyPg/NQYrP3turPc?= =?us-ascii?Q?Pn/ybDRiF1shPSwhXSjxWMcJvZHY5aYjpWID/EkHRkeZIOcask8upfy85JJ+?= =?us-ascii?Q?2vTEMj6yX5g2o5Hv2SzPcLEC6cKX6YuPeHYqEvtAVcdNw/5C9wMU+z9zVu2A?= =?us-ascii?Q?dDfHZWQbXKg2IGQASQh8fbHoo/DNWQuBQeM9mII6gZb/+bjppphjNo3xDy5J?= =?us-ascii?Q?e9v6ukU1CstS6kWJpxnTKEUU3e2okBGNNZJTbxKA9aVHv1begrX7CVkRk6m+?= =?us-ascii?Q?R+lcXWIZBMbxKUmu+5UrVuxM3VMAE/WWigoyt4Te2nzA1ywLX6CdtPO2Vrl5?= =?us-ascii?Q?O+QcK9xrRvM=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SA3PR11MB8118.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(366016)(376014)(7416014)(7053199007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Z9U4svh+B+9FYsD/jybP4EYLWL23CYng0O4l5bvQF7cbJ8EOVME70M3v7FLt?= =?us-ascii?Q?O0/fCVGIHeAz0c7KUMi9t4Xn1xu5z1T6gU4hDgP/qkm3p20BGd5g46cuVl90?= =?us-ascii?Q?+nYvyuGIKXhQ8qxJE93G/7NORmo7cqT/+mnplifGSy7mkL5RjJCox/kIZwMJ?= =?us-ascii?Q?EKTgihmnnnbcmOpvdSxLf9XbgNv7Wyjh25kzZd8pBuyNusdXHaAIra9wKrXP?= =?us-ascii?Q?UWI5CAZgSnqSkSgt6LboLdeJk/ZIVP0AZMsUxf0jUiuGbaHgFgt+4x+c2wKd?= =?us-ascii?Q?PF2qnQkeCDQKEBMAMizZ98ovZ7ZCehENhepDtW/5Hc2Vgch0SnF2baCNEU0O?= =?us-ascii?Q?y978bqLnJPXmKi7pwDCDDJV+gXH3b6RETgSGwB/OtFJ/Iri62EmFXXJC1mBS?= =?us-ascii?Q?0d40YAZ7Fm0lbRl504saKiuc9IPXWdt5fZwcQOY/h2II5oCZfWXqElaVl2Qe?= =?us-ascii?Q?hz7o+gdxA/gna0Bs0SPYcetZ6jlW3RHYwQmGvJcngdrgw/+nS+9C5X57U6aG?= =?us-ascii?Q?CUSVehC72SptOB8QtiLmutmGNK/0sCDaeMzaeLyN7qF3dq3ZTz55U5xMwdco?= =?us-ascii?Q?ge4GIvkz8KeoNSpYkXAcjeqOO/wcjDJt7j7A5Yk0h/r69nz7cSoPlXlihngN?= =?us-ascii?Q?aqzgx/b8wmti1FiShzgsFCQ/Vug9oR1Y0S5pWsWI2rAz/ffYClTnqVeErEK1?= =?us-ascii?Q?P1GCbfDxxyp6Gh/av1IkBC1EDuBRO1u9uTi3PTx8vNW/kqKBq6d4rBFnOphq?= =?us-ascii?Q?XSSjHZdlm+ys3peLfjfBmD9IVmXTsGKf/EjveEJynQZwN7nxDQf7RE4Lt/ks?= =?us-ascii?Q?fQ7ECaUUdmi96FnBhhogshzWzVaTr+7fdXQFbyu2rej7G97FY7sybKaOBNyS?= =?us-ascii?Q?tfpiTwVNQyrpNpBBTqd9s0yL8xVoIbYTen2lK0voHAk5Dur0LuBcxc/0Iq5t?= =?us-ascii?Q?ZQu3Tb6wc1VDRJ9xH+CCpUQL/mIdDM4oWmS0H1gtfWFx3j4s3RZKbM8ej+U9?= =?us-ascii?Q?haomIILFubVUx61mWStYtHS6duMCICRouGZc6DE/CCXPJPsqzDpyxC8EpRcx?= =?us-ascii?Q?s2rg3IHVwda4qbnfg6tsRaulk/F9spqhgBx3g8GxlMTV1ylliLpa1W4jyBfw?= =?us-ascii?Q?QcHV0jx9DFCrN4UDRHAGSuTjzeVkilfolNSCq3XTMqH7l2FZWMjLv8V2SWii?= =?us-ascii?Q?bDM11BsSHAEsQ9pVFcXrkRhJ2ghxNqzo9NVIQXQANfV4elvtclLTr/yNrdea?= =?us-ascii?Q?+k4rJqCF9G0wFw+CUSz4CChp+VMssrGRf9kZQ+G4jnoBegvF/q4RVBARRAno?= =?us-ascii?Q?CKvF/Xz1DkASr1bhFHkX4H21o6YP//wBDwuC07XG9n1QbZTkSrnsST1n+wHk?= =?us-ascii?Q?pfxh2zfWHuHJNio2hUJnAZFgExi83xdPgVUfOCOF2RVAUowqb22igvXeBjwX?= =?us-ascii?Q?It+KHPYRUPVHHOTAz0VA3goCHs+HjIa5+DgGFhylyXaTpdha+rNFQhfh3ip8?= =?us-ascii?Q?9EEYrpAI3feGJ5JMiTbAL259x8eogfB5WHID+SMngVPIYjltIzfRm+ollCZM?= =?us-ascii?Q?UNCdZwxry7uiGZcVPjLeKqUp8ZJNdkaUBUoeh8ubcUbd/utjs79HSyGSL2IE?= =?us-ascii?Q?bQ=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 67d316b1-fe49-4f41-6f84-08dda96b3ddb X-MS-Exchange-CrossTenant-AuthSource: SA3PR11MB8118.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jun 2025 04:40:22.3838 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: mnR6VNuZ2RYN0K0uZz/93+im0KHekeaA8iwpgEnNrCD6KZudFV2E68zmVhN+fmJHYbKtUDsQJtsKuTpDUX2DclLizwKmYAuHGkdw2veITbE= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR11MB7738 X-OriginatorOrg: intel.com X-Rspamd-Queue-Id: 0EE0340004 X-Rspamd-Server: rspam03 X-Rspam-User: X-Stat-Signature: c3tsf51ms1p5c1bw6exnndasxhrnmefw X-HE-Tag: 1749703231-292815 X-HE-Meta: U2FsdGVkX1+TCl44uCLaEK6Sn9P+3Xb1C1lJDyLbzKJKsnC6EHrJYn/fsXWVdRoq5iH66oWEyz9jtwxfkW362XmeMm/hiNbLoIlnloJghnWNrHKotUKyQ+thN53VUZk7Cez9VMorzmn6gWQs166XvF5CmbGfAgq/yW5GmqdBLBQ9NU4Gc+QQ5dVUWaP3mpDiBGFwX/WUWr38z9LV+ElR63x5eE3GXS1OpTZBOCvvMVIAqCmzMRfhORDaBFFmDNYl39NvvGqxmtmCUTYCjsOkou3WsZ1iFLsPFYq27vFP7Qghn749/2bYJk0TVXFw8ioAdk9wH3WxpLouQrfIFAPDBPJTND9sCLYWuMCozSLIRc40qSVwTRiO0S7d2fo0O935/t1sChcdpHYghbsz7Tvl4keLe5BarPKOqQK2TVHd1a2D9ksFgfrQzAWj1Cn89N/Jr0uyF69uW4Vt1jyzwLzaWyGM/FEUAYf26FcaRymlQKtsDgkEduEAcQNX0vHtlZBuDn3usZcPVT3zsmvggl/qtanr9nRqu0gprVvjSUPogPqdQVQ7swWv4EUQXlgOEGcotrahKh2u0LAYc/8+sLKdWetVpacWKgCw10zvXTRBO1B+laPJTe6oWX+Io+ciZnNKhhjtzyR/yiz1+bQLnt9ywcny4biPO8p81P7+mamjHy0fmxUbTPY6qpVf7JCO2nBHvu0GhX6pX7kFslU0G++jm6Q35nCangz8+LzSqpnjutX3jpVTSr8PftPdJZ7Cxt1eTu4+Y+XZIBNQv9O+uDWKJ0UkAgeJ/2iUStu99hdD9mOsDl1zbpz6tbKpXfdXvr+mpcQHad4otx8d5GdZJT3I27cYFKCN6eiyqYboagZGyQCq2onh/ZQy0jELSH1dJDNyDdGZyYqWZbc/6jJFmhWoD4edceQ62rXJUqh5TmVYWDAjmNiOopsgPKna7VoKbvJfwr/DxIQ9jHERg2qkChh ALDoBNDW FxHoytvMsokKcIFSiczofWGlF7+ol8rcZl0WH5Sz8agtIlZr3i0Ohl8Qwnu3zILraXRwwXlF/NTYTAD7DvkfmS4FuRZtH457Z6hS3iUbBXlrYWDCCdTom0mYEewwLZoIfjASW8ySXFUEXseRomkxJWscBC2QfCTpWjLKMqjov8jMCmBvMmy69ZPGDDIHYXU5BXBs3/C/ijqtKpbjUDyosQ+Y/3Ch7W9jQcPamQLv3461YeTTFrsKexj85i9ckxESGhuHJs/NfKAb6uT/6HsZoFNQZPT/Hj6cD8xpE1taCEmTifCpKzoRu9rWrOXhpVug4HOcWl9wxLjsuk36D31sUOq3Ttj0LaYP1RZTxzTLmYmrxwX8y7BYf2/Wx7XPTmX+ezwrT2BP8EtRq25+uA25+zqCF32KZQuGFXKf3A0Dy5LwY2VLxWms5o34DhR+qXQUMjnc3dpN+o1j966RCdCi6KfJRCYH4gf93Ca5TuRubNZtBVMSKnvvOIPzXiuWmNm2vuYZ5CY0QInCNO/zkegh6lM2+P6RA7TR7UqN4OIY2y1CybX3GMttLPMWeGJbB3iX5Swqy4W4qrD+mqFo= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: David Hildenbrand wrote: > Marking PUDs that map a "normal" refcounted folios as special is > against our rules documented for vm_normal_page(). > > Fortunately, there are not that many pud_special() check that can be > mislead and are right now rather harmless: e.g., none so far > bases decisions whether to grab a folio reference on that decision. > > Well, and GUP-fast will fallback to GUP-slow. All in all, so far no big > implications as it seems. > > Getting this right will get more important as we introduce > folio_normal_page_pud() and start using it in more place where we > currently special-case based on other VMA flags. > > Fix it just like we fixed vmf_insert_folio_pmd(). > > Add folio_mk_pud() to mimic what we do with folio_mk_pmd(). > > Fixes: dbe54153296d ("mm/huge_memory: add vmf_insert_folio_pud()") > Signed-off-by: David Hildenbrand Looks good to me. Reviewed-by: Dan Williams