From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 05CCFC71136 for ; Thu, 12 Jun 2025 04:37:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 992FF6B0089; Thu, 12 Jun 2025 00:37:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 96BF06B008A; Thu, 12 Jun 2025 00:37:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 834016B008C; Thu, 12 Jun 2025 00:37:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 646126B0089 for ; Thu, 12 Jun 2025 00:37:39 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 03EE3140560 for ; Thu, 12 Jun 2025 04:37:38 +0000 (UTC) X-FDA: 83545490238.02.4F1A5CA Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.16]) by imf15.hostedemail.com (Postfix) with ESMTP id F1699A000D for ; Thu, 12 Jun 2025 04:37:34 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b="hGIC/5gN"; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); spf=pass (imf15.hostedemail.com: domain of dan.j.williams@intel.com designates 198.175.65.16 as permitted sender) smtp.mailfrom=dan.j.williams@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749703055; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=+MQi07pNx4wjB1+cHPRljnDBNizKbfw0j8ovpGkWXao=; b=YLspzDghq2cbu9AVjwaFveekV5YIFLRnRiLDZN8vmzOW2Qf/AevT2kf015LURPEV+et/IE 2fhgdrqA8QlRjScp7DgFKOTtYrSoKZoa4siPv0d3es1guKX6LKMA4/pgc0HvER/1nEmgZA TgjI8wIfGso2RZJRlrOhBHRI39tNxSc= ARC-Authentication-Results: i=2; imf15.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b="hGIC/5gN"; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); spf=pass (imf15.hostedemail.com: domain of dan.j.williams@intel.com designates 198.175.65.16 as permitted sender) smtp.mailfrom=dan.j.williams@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1749703055; a=rsa-sha256; cv=fail; b=coH8hHTLGkbWBzk2Lgme7nJiWuuD6WCZv2r3Wm0gPjan2R7JzHF9VEoT/XzzUu/SEalS+O Vsk8MuIFp68cN8OOch81ZJjUA7tUCa6TfyVDy93j+98C5iNlxQ6e0hNCsNdJKzdCQIERy6 CR06ckl4UohUMvQatZb0A5M+WCwTPyk= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1749703055; x=1781239055; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=RRpFm/BLkkBQeUd5D4/wC5lSk7ZrESJW7MTw47t2odk=; b=hGIC/5gNOJCaGGuMnOiTPJ9PoDYpLlS+r3azlcfJgF4c+Bko0pEkBjHX xa256LMUsa+VQ7dFmyB9QV+8zQumZaNG8zfT+pun8kZsdYQ9u7nk4oeKH j/1H1KY777p915PzHeIXbpZAz/mZ4OWQm6n6mNVUeSSSmiYwnvdR5vHc7 EaqNltB4nDXp4XaxhB7RPybno8MH4eNn67RVU32cg8LmMqqZDbONlphX2 TcW1rmRr1csq0neRS5yqEek8dcslqpxvfremk+pm2eSu8XT0vgfPG2mLd 31VNwfQ9iWc/NAy70rmUKXCJ2AQ/ioPXsgJ9VQOJvvT7D/9bNdJQJgfKM A==; X-CSE-ConnectionGUID: M3BxbFFNQV6+XugdMuO1mw== X-CSE-MsgGUID: ih6PiBNHRICSiONMAqbqBQ== X-IronPort-AV: E=McAfee;i="6800,10657,11461"; a="51950979" X-IronPort-AV: E=Sophos;i="6.16,229,1744095600"; d="scan'208";a="51950979" Received: from fmviesa010.fm.intel.com ([10.60.135.150]) by orvoesa108.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Jun 2025 21:37:33 -0700 X-CSE-ConnectionGUID: ePEsvukESsa2FkGU/prH3Q== X-CSE-MsgGUID: 74Qk0nIQQ6ej214Y5PmGNg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.16,229,1744095600"; d="scan'208";a="147890848" Received: from orsmsx903.amr.corp.intel.com ([10.22.229.25]) by fmviesa010.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Jun 2025 21:37:33 -0700 Received: from ORSMSX902.amr.corp.intel.com (10.22.229.24) by ORSMSX903.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.25; Wed, 11 Jun 2025 21:37:32 -0700 Received: from ORSEDG901.ED.cps.intel.com (10.7.248.11) by ORSMSX902.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.25 via Frontend Transport; Wed, 11 Jun 2025 21:37:32 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (40.107.236.49) by edgegateway.intel.com (134.134.137.111) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.25; Wed, 11 Jun 2025 21:37:31 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=OHvpvfYLNFhug/NAT0xN8HY28/g1cZtPqujEe9fK22632JfbrdorKT/Q8vCoHxBwnbRx41Lvu6K3C0PSrmkuC466/pOjVVmBnhYnAwIYOxrUraH6rXfHj2vi/Lxy9u18PWlL33mJ2XbBXKG2ZRqJJFYKs7MZKgPa8m/+HwX3WBjYm/iZKohp9Obyb1Hc63SXYUTyN94DHI5HbjjownABGXCzvGFT8K/4em0RqccI7/tO5P2EXy8W2FkcqHrGEwzJAsZYjIcAPSFH8uGAFcbIC0/ocx5lgXYj9YrIq2NhnvNyqnoZuQ1tGxa1uzQq3J2EVWvGbC+PB5tKVmdXH2j0MA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+MQi07pNx4wjB1+cHPRljnDBNizKbfw0j8ovpGkWXao=; b=JLtyS0MPs0L9g7LLAEbrccSxbjjXJuruGUGtZGX6R09xl6/srIzZ8E03BeP+o3ojEvb0sFWK2hGp2ezye7adbbm+M7gT9uHDNAPFaIWwQd1kYWjWszl+oi6etXaFOuyyMM5DJtcmazr45YWWMmP6dqYj7bHuVroKwYdEEL6xOldxy8BWaRiag9iz0MUsUj04o7BHuR/i/lPa+70PFNuMA/BmNjqwufP8S76L/fjBdFQoJZtE3qrVtwd3KGKwa7OL780q4MOHET4QKhH240jXonEs+rZAdBNECY4TDo9mOQIY1/ASzu9sFBKH/Q3wy6trwvHO5maeJ9yLXhvZm9bHFw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from SA3PR11MB8118.namprd11.prod.outlook.com (2603:10b6:806:2f1::13) by DS7PR11MB7738.namprd11.prod.outlook.com (2603:10b6:8:e0::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8813.30; Thu, 12 Jun 2025 04:37:22 +0000 Received: from SA3PR11MB8118.namprd11.prod.outlook.com ([fe80::c4e2:f07:bdaa:21ec]) by SA3PR11MB8118.namprd11.prod.outlook.com ([fe80::c4e2:f07:bdaa:21ec%3]) with mapi id 15.20.8835.018; Thu, 12 Jun 2025 04:37:21 +0000 Date: Wed, 11 Jun 2025 21:36:58 -0700 From: Dan Williams To: David Hildenbrand , CC: , , , David Hildenbrand , "Andrew Morton" , Alistair Popple , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Zi Yan , Baolin Wang , Nico Pache , Ryan Roberts , Dev Jain , Dan Williams , Oscar Salvador Subject: Re: [PATCH v2 2/3] mm/huge_memory: don't mark refcounted folios special in vmf_insert_folio_pmd() Message-ID: <684a5969ed654_24911000@dwillia2-xfh.jf.intel.com.notmuch> References: <20250611120654.545963-1-david@redhat.com> <20250611120654.545963-3-david@redhat.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20250611120654.545963-3-david@redhat.com> X-ClientProxiedBy: SJ0PR13CA0207.namprd13.prod.outlook.com (2603:10b6:a03:2c3::32) To SA3PR11MB8118.namprd11.prod.outlook.com (2603:10b6:806:2f1::13) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SA3PR11MB8118:EE_|DS7PR11MB7738:EE_ X-MS-Office365-Filtering-Correlation-Id: 2e5944a5-b9ed-48b9-dabb-08dda96ac604 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|376014|7416014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?GBWA0t0NQEJer++Ctf7isF9eOdHFbS95eD+UjRNN17IiYjHwgl2V8OBLD5oA?= =?us-ascii?Q?h+ZSt1XzN48IXzXrHe60dTC7b4t2o93ql3PCXZkfyV2HAjoRy8L40OKO6XLM?= =?us-ascii?Q?59dtg4vCyhOnlVxPbxeVy8GBHOVAiLvpmp9EOVPMxbRI2dUxQu2L6m3aCrrJ?= =?us-ascii?Q?7A6cIh6R4h5jv6FB/6PU1TwllPYmbrZoEechHal6EmDIcuvVuqhyZc5oIhcg?= =?us-ascii?Q?qDxOx8f48pnG6miPEcSrBJcZhhGrqsfowT50yCW9vmvcGiuVFzbeJQEvmBYh?= =?us-ascii?Q?eoDucJitTowchPAVDGt2Ot7KbDWdLz5NODiMqW4pKugkP1C/VPtzHwKRHJmj?= =?us-ascii?Q?VME4hecmMYrQjaP7aRAUH0WB2OK7DnW2KwpQqL0OFGu+s3F0SSNMvCrlJgx4?= =?us-ascii?Q?7BFNB8LZR67N0fN8KCzGpCNbyj7gEf0xzqC1/Ort4XD5t0k8smIkvFguBu4m?= =?us-ascii?Q?A0gKs2XG5KyvZEnsD7moHTv7Adm3DVHRPuUtYBrlDQTNxD8fBEnfgi0rfICF?= =?us-ascii?Q?20K4lwubzWzF8hYfx99rHGewccJw31T/5HJb2aaHqgbyYImmsCG3T/80mXA4?= =?us-ascii?Q?42AaAmS40DKpslaLb4hcNm6W7MSH/edqz0wY8xj+9kpSQ+TPUD7mRB9JYLw7?= =?us-ascii?Q?ALTE8dhg0x5qj2MGhH+XYKXW9oiRIunXO/3RO/AtHpEBcm/ltt+0DpW9DgX5?= =?us-ascii?Q?KutIyA1mI12zTz7M9lEdJ11iWtNehkREAgpfgVKbZYt8u2i05UI6O/GiODzC?= =?us-ascii?Q?50OFevUeWXRBBDMRVoYmcfOffNQ/PIfcFAYc78L06qPSXhG674v7vD+DuRNB?= =?us-ascii?Q?hciFhXXMslsgl+D01aHDt5CQcs3kNCz5bubXSRvXQm5V1WoFMj+XzXliXeNC?= =?us-ascii?Q?/VrF4OeG0Tb4mmaD2XBqZL7kewydcXMrQbgv0YxQJGZ/L1BSEQFWRPFKugaE?= =?us-ascii?Q?WExy8rvAW1lvgGl/nH2+L0JikynyDwMmya6GhdRXCmIJeE9iMednlpUcWOu1?= =?us-ascii?Q?dvZOFsjbJptNdZAPD3yqjq9kfYHQ0jrJz4KTzYn582PIR2P+KTU+6mHZCSMZ?= =?us-ascii?Q?aTo+YzgcphKDzkvDLTWg2HVN3YyglSqFgfdQaq7DN9BEPmPJ2I97+kxIuI53?= =?us-ascii?Q?C1aQbtXbQQnTehTDzESxtMvK2yprql+wLFYL0dGNIHVoJg8ka82to53yI1TZ?= =?us-ascii?Q?IdcagQDmZQTd4+5vWcVqYaQdeGcpkzXOCuJA4NHEyWZWXiaLhEjlkkm1C7x0?= =?us-ascii?Q?7kCidv28v+1ddFecepVG7Elw+ZZsvrZKICivz1UBXpqBU9KS87BuPrwSD2pU?= =?us-ascii?Q?oqHVsACoOiu6i/o/9KjNw/mN0Cd76ooxuQLLi1MkYLRn6dDtY0ycaILybRKO?= =?us-ascii?Q?Io5Pxp31Nsq9opbbeUhvSwRgaCkhKIYNXeN3u59Ev2zd20iGDznz5RxKV99X?= =?us-ascii?Q?bjFaErTDkZM=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SA3PR11MB8118.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(366016)(376014)(7416014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?3r58RdXufQTxURFl18Xk4ltQN3jIm5rEs/hNGFOJpv1V9nRFrHoh4SvIQVWg?= =?us-ascii?Q?HAWBFFOcOv6QKWEeCat91ffxIjepynzjeOPEf10+cog6pO4c6AWlLwpZY18h?= =?us-ascii?Q?UV+SHPWgM6DR8FHPu5dsHznkG+BBQVLmSlFbE6pqsLox0T3XBR48DTya8wFm?= =?us-ascii?Q?yV+EZzgkUknAoz5GGJgLHXhHURRXYG1B0CGCGzYy0AdHtjzRxOAePNynADBK?= =?us-ascii?Q?CwJuAvmJqAkujUWjyoYo6voQhwC9LLNGCHMyOf3P5J0xGpcmIGxkyqJx7O13?= =?us-ascii?Q?PxgYplb83riUu/cDcB228hdbLX1lag9Qah7bkAVv0MC5o5qS2Jx897mEDGuR?= =?us-ascii?Q?jctE/ofydpESptrVLU592bmW1ERS0lBAn7UVpkqXllaIJKiuYcSjyRrEeF2A?= =?us-ascii?Q?pvVSQ9Rz0Y/YshXOC82M4L3enwmInWKB3fyIQbvKlxgeAmHqE1JzhspxeDMJ?= =?us-ascii?Q?Nxb0Cv9W/02/Nv0hKAqAtrw04+ZZ6D+HV/N67H9SOt1hM/3bFbotZAglHAj7?= =?us-ascii?Q?mbxymPJCcaPkgNvfNEcMoIPM+MX5WshHmfvOY7RED3SaLnerMax0XMmVenAe?= =?us-ascii?Q?pP37dcMAolJZuq4tbCvOdrjTtkAVlJOh46kZJLP6+vvBV5X3HFaY4xdLtdtO?= =?us-ascii?Q?IGdNzu3s2dwozPtIOiacqLC6TkHaGiwZJttmMC75DbUWYk8yaqe3sxTOC/13?= =?us-ascii?Q?LUnbmD4B0GZiR0xYloKW12//87ueKPy4zFujjcs1qpc3y4Le0E73p48spRtl?= =?us-ascii?Q?VqmIbDM5A1bmbMsW3fSxmj7shcOQOxhc5wOW/fZzXW4hpIEchXUXyMviuRCD?= =?us-ascii?Q?HBn2EhKb0HSc4iONEWlxT2WlmLxCC/oB1fa34XmGXr5oTPxvb1fKA/NFUd0H?= =?us-ascii?Q?pv0ElwdRNSUXlVxhOvBJ4dtU4c1El8B7b0apQJscXaGjieyHkL6B28Dp+a3P?= =?us-ascii?Q?b5v/RcxfARPuC/k9pK2MeREjqzMa0RO284rwF/jzFoVGGj3B8QFN4bpFd2Sr?= =?us-ascii?Q?uRrRYODRDM+ZDR5QYcKkBPeonMr8f9c6ZGELVOQUhWY23qbwji57RdY0+XR0?= =?us-ascii?Q?diGkJbKdF9gtQYBX6PgZ5EIlnL6mxBXBqvFRyV36kmtLTurS9s2GEBqDzdco?= =?us-ascii?Q?DDFshX0so6Cxbt4ediAIwFtTJJv78bRhjZ/2dFnjlXrunoch2SDdf9oL9onE?= =?us-ascii?Q?YJwpgcOvvwXvwiShyRmS12lk93MUsKi9Ixbs/y4k1SDol+4dCOU2JmbH/RuY?= =?us-ascii?Q?MRgEnZqQQEuMTG4HeMpcVAcpVJCLU7o9x0B+Qga/76WbcijM6nFVFZ5D83KP?= =?us-ascii?Q?ZBbgq8k48WrOdRCJdahAcP3sbr+Ab9d4HzvOa01jvEXu7OCUgZfePrw251N5?= =?us-ascii?Q?DJBXZ6Uav+vv8XEgVmQc41uf9R13EOhyGLEzhr0wBWVRI4fcL7l8EcaXp/CO?= =?us-ascii?Q?DQY7PAk99/bt/zm3/TPIEzrA/zIZh0OVJDU4yFAsuqOfOVkQCUmFELTfPpWN?= =?us-ascii?Q?XHmEOP9SREKthbBIMqzmB94keeEQ4vPs9UCtAhM2gsOd3R8pkaF05g3SLT15?= =?us-ascii?Q?DeC4ZgHxi+pMk3va9kkMR9tZgaBkdrqOqtu0ppDV+e/FjAvyOvmGUc9TsOyA?= =?us-ascii?Q?HQ=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 2e5944a5-b9ed-48b9-dabb-08dda96ac604 X-MS-Exchange-CrossTenant-AuthSource: SA3PR11MB8118.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jun 2025 04:37:21.3833 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: xXuWGBZYqraY388lhzaEZ/vnwaXVqYDRtyh1+ZUlC77lkOXtBpJ2NjrbiGrSCMyMVsjMCctOiyFgRq7ojUoSPMhD3tp9BafdLhHA242B9Vk= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR11MB7738 X-OriginatorOrg: intel.com X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: F1699A000D X-Stat-Signature: 5mitt7hw6pxno1p1nprwhwcfsnnmq73n X-Rspam-User: X-HE-Tag: 1749703054-795450 X-HE-Meta: U2FsdGVkX188QvQIwTubeunhMHwn8ku3jk5QRsWTf/7U1B18KohBofruX1crMrKQp/558SFh7rQZTzaDEHmdkw/VS12qtNgAm8JHa4iTmnhlaVCk6Eejbbw54QvL+mCqIfI3y+jQcRmqp1Qn3OrlaWY4F20+2rlf/1+cn7LSyCsG+ffOEFVj/NYbcOz8dpRWeUpaM5yAQIter5/54xZPWGBgfIEUSL9BcXNh4/WePQgAFwq958qHnX9aJ0/ppVEDoc1X1CFxc1sgHKvBgtc7ulFoDCPVlS/AZtZBfgDcHCqM0SifV2sUXaXo1WhJvLGFbNOisQA12smP22BpMmgQPACyeJYNnL2Igky+eTo2mKjEDL6MtAYgPHxJECKLhuoR2ID/zFpiGmtBCSmj36pYY0dRsToGYqDHKjydRJOzmf9THy9QOMmSLyIcUFfckealsPeuPxBOciFDDbm3HUCEswxMJfeHkVWQy1R1dbSOJAM1QLD/cIvJWZcY0Gwh+P1SzwDMGcw+LZVkxYIfV8aH5qtHvcm2dcdFvkLprq5919EiU5qicWMUGEwv2c8cMYkuCnF96c/jA3AOdMLqqpJj1JQ8DbT2l83N4reHGK3kYO6ZPuBF4thow1DnPVVdPgTw46yOH/QqGgkL7PMK0mveKWvYKVQObGkMnKw3+K541FJDdprD1s4vULOfhF2XTy0mMNstUp7NO4k8dLuf3VZ36zDxzjwW976tTuDoiL1KK+rA/TInr2pPPNCpNg3eyGZWPxCRftWZyoQo6kYA8PLcEf22dUOjzWgzZPuNYacjm5RWJkf6BxDyeruTRSr3UwkTz6btglge7iHhMnWA6SfC276TLa2ieWvjI8fWwLzETMV5TD07og+OOjmeaTL6LF2VRnlAxa5C2CkWnxECYWUGB2dr8hN56Waj+vDKvdSlGnmDeSZHYTtBDpB3TTQbTEW5N+y7pxzYjQP3KlwfLnc Zj2W1lI1 QYTXjg8KOTYiUXXk1H+ZIPlrWghbpFHPXm+SEm2OoBrFtnjOMO/+UjVYI4C6BLvvgz0dln+sfNQekmMQTJU/w6yMi6h7EyDeMGSLhHmOmTEZkFzdxs8DPA03cCQiFKoVLxrVSl6NuL95fCL7WfDkNuT+SvNjNvs14SokH3caN+hJMULjZ609KgWkQQVt6v0lPzqCKH09fXbsvKAB6d3p+W5It8CpXO80qBmVBdlyzno8He0hq10XnWkQTRBRNYO+fBO4Ugxr8u/Woyn/UIwI196m58gbpfbm1AWApSTGaui/96e032POei+cAOynaRmZ/Bd5F9CSGf0Cxg0ERXYITRZnCQ2GJPD01s9m4yMjoxXXvyXANLoPlnQJhmZTCOIc8ZtNY7TWjciHrI9cYffk3qS84yiOELsYpsQUZyQvfILqlrMmNr8PT5VSaC8bIkYDArhyhpQ56ry0+/5eR+e9qBbNPuQNykK4N+69inHnFNcBy93cqCoi3/MXeXcSw8vgqOn0XL8hP2C3yTH8MInvJOM1r9oWWHFfuaZ5Zvonw23WGbBU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: David Hildenbrand wrote: > Marking PMDs that map a "normal" refcounted folios as special is > against our rules documented for vm_normal_page(). > > Fortunately, there are not that many pmd_special() check that can be > mislead, and most vm_normal_page_pmd()/vm_normal_folio_pmd() users that > would get this wrong right now are rather harmless: e.g., none so far > bases decisions whether to grab a folio reference on that decision. > > Well, and GUP-fast will fallback to GUP-slow. All in all, so far no big > implications as it seems. > > Getting this right will get more important as we use > folio_normal_page_pmd() in more places. > > Fix it by teaching insert_pfn_pmd() to properly handle folios and > pfns -- moving refcount/mapcount/etc handling in there, renaming it to > insert_pmd(), and distinguishing between both cases using a new simple > "struct folio_or_pfn" structure. > > Use folio_mk_pmd() to create a pmd for a folio cleanly. Looks good, I like copying the sockptr_t approach for this, and agree that this seems to not cause any problems in practice today, but definitely will be a trip hazard going forward. Reviewed-by: Dan Williams