From: Dan Williams <dan.j.williams@intel.com>
To: David Hildenbrand <david@redhat.com>, <linux-kernel@vger.kernel.org>
Cc: <linux-mm@kvack.org>, <nvdimm@lists.linux.dev>,
<linux-cxl@vger.kernel.org>, David Hildenbrand <david@redhat.com>,
"Andrew Morton" <akpm@linux-foundation.org>,
Alistair Popple <apopple@nvidia.com>,
Lorenzo Stoakes <lorenzo.stoakes@oracle.com>,
"Liam R. Howlett" <Liam.Howlett@oracle.com>,
Vlastimil Babka <vbabka@suse.cz>, Mike Rapoport <rppt@kernel.org>,
Suren Baghdasaryan <surenb@google.com>,
Michal Hocko <mhocko@suse.com>, Zi Yan <ziy@nvidia.com>,
Baolin Wang <baolin.wang@linux.alibaba.com>,
Nico Pache <npache@redhat.com>,
Ryan Roberts <ryan.roberts@arm.com>, Dev Jain <dev.jain@arm.com>,
Dan Williams <dan.j.williams@intel.com>,
Oscar Salvador <osalvador@suse.de>, <stable@vger.kernel.org>
Subject: Re: [PATCH v2 1/3] mm/huge_memory: don't ignore queried cachemode in vmf_insert_pfn_pud()
Date: Wed, 11 Jun 2025 21:34:07 -0700 [thread overview]
Message-ID: <684a58bf34666_2491100d7@dwillia2-xfh.jf.intel.com.notmuch> (raw)
In-Reply-To: <20250611120654.545963-2-david@redhat.com>
David Hildenbrand wrote:
> We setup the cache mode but ... don't forward the updated pgprot to
> insert_pfn_pud().
>
> Only a problem on x86-64 PAT when mapping PFNs using PUDs that
> require a special cachemode.
This is only a problem if the kernel mapped the pud in advance of userspace
mapping it, right?
The change looks good.
Reviewed-by: Dan Williams <dan.j.williams@intel.com>
...but I am struggling with the scenario where this causes problems in
practice, where vm_page_prot is the wrong cachemode.
next prev parent reply other threads:[~2025-06-12 4:34 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-11 12:06 [PATCH v2 0/3] mm/huge_memory: vmf_insert_folio_*() and vmf_insert_pfn_pud() fixes David Hildenbrand
2025-06-11 12:06 ` [PATCH v2 1/3] mm/huge_memory: don't ignore queried cachemode in vmf_insert_pfn_pud() David Hildenbrand
2025-06-12 1:56 ` Alistair Popple
2025-06-12 6:55 ` David Hildenbrand
2025-06-12 4:34 ` Dan Williams [this message]
2025-06-12 6:46 ` David Hildenbrand
2025-06-12 15:28 ` Lorenzo Stoakes
2025-06-12 15:36 ` David Hildenbrand
2025-06-12 15:59 ` Lorenzo Stoakes
2025-06-12 16:00 ` David Hildenbrand
2025-06-12 17:59 ` Jason Gunthorpe
2025-06-11 12:06 ` [PATCH v2 2/3] mm/huge_memory: don't mark refcounted folios special in vmf_insert_folio_pmd() David Hildenbrand
2025-06-12 2:17 ` Alistair Popple
2025-06-12 7:06 ` David Hildenbrand
2025-06-12 4:36 ` Dan Williams
2025-06-12 16:10 ` Lorenzo Stoakes
2025-06-13 7:44 ` David Hildenbrand
2025-06-12 18:02 ` Jason Gunthorpe
2025-06-11 12:06 ` [PATCH v2 3/3] mm/huge_memory: don't mark refcounted folios special in vmf_insert_folio_pud() David Hildenbrand
2025-06-12 4:40 ` Dan Williams
2025-06-12 16:49 ` Lorenzo Stoakes
2025-06-12 17:00 ` David Hildenbrand
2025-06-12 17:08 ` Lorenzo Stoakes
2025-06-12 17:41 ` David Hildenbrand
2025-06-12 18:02 ` Jason Gunthorpe
2025-06-11 23:08 ` [PATCH v2 0/3] mm/huge_memory: vmf_insert_folio_*() and vmf_insert_pfn_pud() fixes Andrew Morton
2025-06-12 7:34 ` David Hildenbrand
2025-06-12 2:26 ` Alistair Popple
2025-06-12 4:20 ` Dan Williams
2025-06-12 7:18 ` David Hildenbrand
2025-06-12 8:27 ` David Hildenbrand
2025-06-12 16:56 ` Marc Herbert
2025-06-12 16:19 ` Lorenzo Stoakes
2025-06-12 16:22 ` David Hildenbrand
2025-06-12 16:30 ` Lorenzo Stoakes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=684a58bf34666_2491100d7@dwillia2-xfh.jf.intel.com.notmuch \
--to=dan.j.williams@intel.com \
--cc=Liam.Howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=apopple@nvidia.com \
--cc=baolin.wang@linux.alibaba.com \
--cc=david@redhat.com \
--cc=dev.jain@arm.com \
--cc=linux-cxl@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=mhocko@suse.com \
--cc=npache@redhat.com \
--cc=nvdimm@lists.linux.dev \
--cc=osalvador@suse.de \
--cc=rppt@kernel.org \
--cc=ryan.roberts@arm.com \
--cc=stable@vger.kernel.org \
--cc=surenb@google.com \
--cc=vbabka@suse.cz \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox