From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 41EBCCAC5B0 for ; Fri, 3 Oct 2025 16:54:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 83EDB8E0014; Fri, 3 Oct 2025 12:54:15 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 814F48E0005; Fri, 3 Oct 2025 12:54:15 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 752748E0014; Fri, 3 Oct 2025 12:54:15 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 5D22F8E0005 for ; Fri, 3 Oct 2025 12:54:15 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 07CF7451CD for ; Fri, 3 Oct 2025 16:54:15 +0000 (UTC) X-FDA: 83957400870.16.5FC3B22 Received: from out-178.mta1.migadu.com (out-178.mta1.migadu.com [95.215.58.178]) by imf27.hostedemail.com (Postfix) with ESMTP id 43E6D4000E for ; Fri, 3 Oct 2025 16:54:13 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b="sHZI/SdY"; spf=pass (imf27.hostedemail.com: domain of qi.zheng@linux.dev designates 95.215.58.178 as permitted sender) smtp.mailfrom=qi.zheng@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1759510453; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Jx/up15hgoocFMTTmoEqLtWBcwNy2yCwXsVyYpG2qec=; b=23Vzfld/EcP1gJ+GOY6CrmZmvcLdho/j4spn3Q3HNrKWkCWqDpy8cUBcsZL26kdal4+9b8 Fi2cEmKfoE16QMf+x8sYoxw0Tl+USbHsIWSLFH7bc/Tm7sIgx7rhQ0BJ55xqqGgkSBWoXl hk+lJnjKEp/qBNKQ4uqPS1ICw+vpQQM= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1759510453; a=rsa-sha256; cv=none; b=Qq8esO7I+//jGd+b+cjNMjyVNJUlE6EAdHxFgr8mHX6QYHLEcJ7V9XDffBlyhghKJ9eeGZ EM8n7jCQOqv6yGl+AsxUVl3d7gENpKK+oRW78NtRQSiqRZrBcrsYXGVZ3FF5PfEzW0siaC qyZkc66QpNnh7NFjn3LdkQaUDnPc1Ts= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b="sHZI/SdY"; spf=pass (imf27.hostedemail.com: domain of qi.zheng@linux.dev designates 95.215.58.178 as permitted sender) smtp.mailfrom=qi.zheng@linux.dev; dmarc=pass (policy=none) header.from=linux.dev X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1759510447; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Jx/up15hgoocFMTTmoEqLtWBcwNy2yCwXsVyYpG2qec=; b=sHZI/SdYJexk3J7ukbM/EEnC/7bI/bjQrZNFcUYz/sorUAWS6rT/d0Ktx6P1KYiqd+xYze JoTDu7a60Xy/6AiG/ZmFJ2ThTyUb0BPL188CyhbXUCtDYzjQ2km5dueSVGnw/ATv85ayvC 9KkyfS0EKwTfM6ZsKOzt1/DOQNJ4WHo= From: Qi Zheng To: hannes@cmpxchg.org, hughd@google.com, mhocko@suse.com, roman.gushchin@linux.dev, shakeel.butt@linux.dev, muchun.song@linux.dev, david@redhat.com, lorenzo.stoakes@oracle.com, ziy@nvidia.com, harry.yoo@oracle.com, baolin.wang@linux.alibaba.com, Liam.Howlett@oracle.com, npache@redhat.com, ryan.roberts@arm.com, dev.jain@arm.com, baohua@kernel.org, lance.yang@linux.dev, akpm@linux-foundation.org Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, Muchun Song , Qi Zheng Subject: [PATCH v4 2/4] mm: thp: introduce folio_split_queue_lock and its variants Date: Sat, 4 Oct 2025 00:53:16 +0800 Message-ID: <68492101fa51d4bab4ade327354b986c0959250e.1759510072.git.zhengqi.arch@bytedance.com> In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT X-Stat-Signature: 73aohkhkm3635aj1qzxfuxbpe1gpg8m7 X-Rspam-User: X-Rspamd-Queue-Id: 43E6D4000E X-Rspamd-Server: rspam10 X-HE-Tag: 1759510453-124800 X-HE-Meta: U2FsdGVkX1+QmJSwzZO2RoF2JP9ONIOAn39K8tWVmh+jK8ONUmgQ/FFmM+PKoOXYlFOFyJvlqrltgxuZqZqpMTZ3/EoKmAfxLOo8Ok5LWcUOXGf4CxZPVX68IFsTdOXniRq1wwVWMu00/v2k/p6n7wRfuQGH8vqcIZ0kS4cKXbJd05zl1vrS2JuZ+eq3slj3k84uQ4D4p8BbMooyc5bdpWuyIOC1CHNxwNCGjLz8WibWCQSaXoboCwKTJTFIbs+q0ooeuoJVKZXF7hSzYVdsWwG1mYRjVtcytlZgKC2WTplxuavhdr/fgpDR+QK7b38MVKewOChHV5NYakSOuG4S4aju+Lh3ihtuQI8uyyn+lkJJeOHEnQYKQKZ5+uxvGJ+QoB/QD7cv5Ndti2fzfOllGNB1lZb3++AWvV75X22rHIxw4TA1PMJrbj+BHqEiAuAJIhoEssbgiyXGg1+VK1cUhsYjOHoRzc3gSRxz+55wPCV+JCFbzzMFvYIjO2ZXQt+Ap9t3UxMVKrlWLftOe1hSZ7bA3oNlqqs2dSfBBptXv1o6cip/r0V7R/hQKk+/hd0cFaqkMA5MhQjHRPWyvI2MyrnsS2+G2ZSgKaXaNnsXAPtZhs3FB3Dzk5fMvte+65IQvk9St/YrgtBpKTt2l0Qlr7EoZjJ5zn67FyvYMeGuqK3ySxAYdAKgbJ9JlIp/cm70uGpzDKkFVwSAjc6ZCCRh+6gyZ0g0/VteaQs0suybo57r2EjRORPpYnC4LLUt2GsruInQlGIQsO3ND8vT0JsapqFClFngzoZzLWGH0C1kMJIQyhjM4k2BUpEAIBPEo4Y4OX64GKCI5pe1H7jrSiJzQg/9ZrZDUaglo9fk0kAO45WmixYqThfQ1/YeqrCtQhAhZbpWrajPFoRhDVrfqeDUokkwaCZfafYCVBMHo/D4uCxTgsPtDUG9lK9tYoSwWEx8ycGe4cs4vCTVirg9meE mZcaM8zf 3bN0qUY0WVlVcH/65w6SQU81SUQxThLnYGH793y8VXmcAQ9c87Jpb9HBp3czHkWn7xoE3rkGEdtKYmElH72qAjumdYANKo8NXvkiJ/KJgmAN8Hd8dr0tvEVgazZYm7qngrmBb0h3MJt/mx+w3Jx7gSyAN4RXw9ChG28tVpXtANKD/7jKLj0cOlWmlzZ7l4g5hhH5JGkNGa0NTUBny80L9vnSUvQC3cYWITm/np67fJSQ09qZSngkHBYcwiX0ZNt78DpCasfenkcNa+HlfaG335ClQvVY0jtqB5LjgRNkCYYQNFxK+lCcQJsGOgrkkvc66YMzzqRmJxz87ReXdpaJHFD3yFyvnSh5MfmDBI7LyXKIiz11aj4QjcYk9UIopg4QrWbcv6S2vBhwFvCY= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: From: Muchun Song In future memcg removal, the binding between a folio and a memcg may change, making the split lock within the memcg unstable when held. A new approach is required to reparent the split queue to its parent. This patch starts introducing a unified way to acquire the split lock for future work. It's a code-only refactoring with no functional changes. Signed-off-by: Muchun Song Signed-off-by: Qi Zheng Acked-by: Johannes Weiner Reviewed-by: Zi Yan Acked-by: Shakeel Butt Acked-by: David Hildenbrand Reviewed-by: Harry Yoo --- include/linux/memcontrol.h | 10 ++++ mm/huge_memory.c | 119 ++++++++++++++++++++++++++----------- 2 files changed, 94 insertions(+), 35 deletions(-) diff --git a/include/linux/memcontrol.h b/include/linux/memcontrol.h index 873e510d6f8d9..0b2d4ec79adfe 100644 --- a/include/linux/memcontrol.h +++ b/include/linux/memcontrol.h @@ -1674,6 +1674,11 @@ int alloc_shrinker_info(struct mem_cgroup *memcg); void free_shrinker_info(struct mem_cgroup *memcg); void set_shrinker_bit(struct mem_cgroup *memcg, int nid, int shrinker_id); void reparent_shrinker_deferred(struct mem_cgroup *memcg); + +static inline int shrinker_id(struct shrinker *shrinker) +{ + return shrinker->id; +} #else #define mem_cgroup_sockets_enabled 0 @@ -1705,6 +1710,11 @@ static inline void set_shrinker_bit(struct mem_cgroup *memcg, int nid, int shrinker_id) { } + +static inline int shrinker_id(struct shrinker *shrinker) +{ + return -1; +} #endif #ifdef CONFIG_MEMCG diff --git a/mm/huge_memory.c b/mm/huge_memory.c index 6db24b3a57005..134666503440d 100644 --- a/mm/huge_memory.c +++ b/mm/huge_memory.c @@ -1076,28 +1076,86 @@ pmd_t maybe_pmd_mkwrite(pmd_t pmd, struct vm_area_struct *vma) return pmd; } +static struct deferred_split *split_queue_node(int nid) +{ + struct pglist_data *pgdata = NODE_DATA(nid); + + return &pgdata->deferred_split_queue; +} + #ifdef CONFIG_MEMCG static inline -struct deferred_split *get_deferred_split_queue(struct folio *folio) +struct mem_cgroup *folio_split_queue_memcg(struct folio *folio, + struct deferred_split *queue) { - struct mem_cgroup *memcg = folio_memcg(folio); - struct pglist_data *pgdat = NODE_DATA(folio_nid(folio)); + if (mem_cgroup_disabled()) + return NULL; + if (split_queue_node(folio_nid(folio)) == queue) + return NULL; + return container_of(queue, struct mem_cgroup, deferred_split_queue); +} - if (memcg) - return &memcg->deferred_split_queue; - else - return &pgdat->deferred_split_queue; +static struct deferred_split *memcg_split_queue(int nid, struct mem_cgroup *memcg) +{ + return memcg ? &memcg->deferred_split_queue : split_queue_node(nid); } #else static inline -struct deferred_split *get_deferred_split_queue(struct folio *folio) +struct mem_cgroup *folio_split_queue_memcg(struct folio *folio, + struct deferred_split *queue) { - struct pglist_data *pgdat = NODE_DATA(folio_nid(folio)); + return NULL; +} - return &pgdat->deferred_split_queue; +static struct deferred_split *memcg_split_queue(int nid, struct mem_cgroup *memcg) +{ + return split_queue_node(nid); } #endif +static struct deferred_split *split_queue_lock(int nid, struct mem_cgroup *memcg) +{ + struct deferred_split *queue; + + queue = memcg_split_queue(nid, memcg); + spin_lock(&queue->split_queue_lock); + + return queue; +} + +static struct deferred_split * +split_queue_lock_irqsave(int nid, struct mem_cgroup *memcg, unsigned long *flags) +{ + struct deferred_split *queue; + + queue = memcg_split_queue(nid, memcg); + spin_lock_irqsave(&queue->split_queue_lock, *flags); + + return queue; +} + +static struct deferred_split *folio_split_queue_lock(struct folio *folio) +{ + return split_queue_lock(folio_nid(folio), folio_memcg(folio)); +} + +static struct deferred_split * +folio_split_queue_lock_irqsave(struct folio *folio, unsigned long *flags) +{ + return split_queue_lock_irqsave(folio_nid(folio), folio_memcg(folio), flags); +} + +static inline void split_queue_unlock(struct deferred_split *queue) +{ + spin_unlock(&queue->split_queue_lock); +} + +static inline void split_queue_unlock_irqrestore(struct deferred_split *queue, + unsigned long flags) +{ + spin_unlock_irqrestore(&queue->split_queue_lock, flags); +} + static inline bool is_transparent_hugepage(const struct folio *folio) { if (!folio_test_large(folio)) @@ -3579,7 +3637,7 @@ static int __folio_split(struct folio *folio, unsigned int new_order, struct page *split_at, struct page *lock_at, struct list_head *list, bool uniform_split) { - struct deferred_split *ds_queue = get_deferred_split_queue(folio); + struct deferred_split *ds_queue; XA_STATE(xas, &folio->mapping->i_pages, folio->index); struct folio *end_folio = folio_next(folio); bool is_anon = folio_test_anon(folio); @@ -3718,7 +3776,7 @@ static int __folio_split(struct folio *folio, unsigned int new_order, } /* Prevent deferred_split_scan() touching ->_refcount */ - spin_lock(&ds_queue->split_queue_lock); + ds_queue = folio_split_queue_lock(folio); if (folio_ref_freeze(folio, 1 + extra_pins)) { struct swap_cluster_info *ci = NULL; struct lruvec *lruvec; @@ -3740,7 +3798,7 @@ static int __folio_split(struct folio *folio, unsigned int new_order, */ list_del_init(&folio->_deferred_list); } - spin_unlock(&ds_queue->split_queue_lock); + split_queue_unlock(ds_queue); if (mapping) { int nr = folio_nr_pages(folio); @@ -3835,7 +3893,7 @@ static int __folio_split(struct folio *folio, unsigned int new_order, if (ci) swap_cluster_unlock(ci); } else { - spin_unlock(&ds_queue->split_queue_lock); + split_queue_unlock(ds_queue); ret = -EAGAIN; } fail: @@ -4016,8 +4074,7 @@ bool __folio_unqueue_deferred_split(struct folio *folio) WARN_ON_ONCE(folio_ref_count(folio)); WARN_ON_ONCE(!mem_cgroup_disabled() && !folio_memcg_charged(folio)); - ds_queue = get_deferred_split_queue(folio); - spin_lock_irqsave(&ds_queue->split_queue_lock, flags); + ds_queue = folio_split_queue_lock_irqsave(folio, &flags); if (!list_empty(&folio->_deferred_list)) { ds_queue->split_queue_len--; if (folio_test_partially_mapped(folio)) { @@ -4028,7 +4085,7 @@ bool __folio_unqueue_deferred_split(struct folio *folio) list_del_init(&folio->_deferred_list); unqueued = true; } - spin_unlock_irqrestore(&ds_queue->split_queue_lock, flags); + split_queue_unlock_irqrestore(ds_queue, flags); return unqueued; /* useful for debug warnings */ } @@ -4036,10 +4093,7 @@ bool __folio_unqueue_deferred_split(struct folio *folio) /* partially_mapped=false won't clear PG_partially_mapped folio flag */ void deferred_split_folio(struct folio *folio, bool partially_mapped) { - struct deferred_split *ds_queue = get_deferred_split_queue(folio); -#ifdef CONFIG_MEMCG - struct mem_cgroup *memcg = folio_memcg(folio); -#endif + struct deferred_split *ds_queue; unsigned long flags; /* @@ -4062,7 +4116,7 @@ void deferred_split_folio(struct folio *folio, bool partially_mapped) if (folio_test_swapcache(folio)) return; - spin_lock_irqsave(&ds_queue->split_queue_lock, flags); + ds_queue = folio_split_queue_lock_irqsave(folio, &flags); if (partially_mapped) { if (!folio_test_partially_mapped(folio)) { folio_set_partially_mapped(folio); @@ -4077,15 +4131,16 @@ void deferred_split_folio(struct folio *folio, bool partially_mapped) VM_WARN_ON_FOLIO(folio_test_partially_mapped(folio), folio); } if (list_empty(&folio->_deferred_list)) { + struct mem_cgroup *memcg; + + memcg = folio_split_queue_memcg(folio, ds_queue); list_add_tail(&folio->_deferred_list, &ds_queue->split_queue); ds_queue->split_queue_len++; -#ifdef CONFIG_MEMCG if (memcg) set_shrinker_bit(memcg, folio_nid(folio), - deferred_split_shrinker->id); -#endif + shrinker_id(deferred_split_shrinker)); } - spin_unlock_irqrestore(&ds_queue->split_queue_lock, flags); + split_queue_unlock_irqrestore(ds_queue, flags); } static unsigned long deferred_split_count(struct shrinker *shrink, @@ -4128,19 +4183,13 @@ static bool thp_underused(struct folio *folio) static unsigned long deferred_split_scan(struct shrinker *shrink, struct shrink_control *sc) { - struct pglist_data *pgdata = NODE_DATA(sc->nid); - struct deferred_split *ds_queue = &pgdata->deferred_split_queue; + struct deferred_split *ds_queue; unsigned long flags; LIST_HEAD(list); struct folio *folio, *next, *prev = NULL; int split = 0, removed = 0; -#ifdef CONFIG_MEMCG - if (sc->memcg) - ds_queue = &sc->memcg->deferred_split_queue; -#endif - - spin_lock_irqsave(&ds_queue->split_queue_lock, flags); + ds_queue = split_queue_lock_irqsave(sc->nid, sc->memcg, &flags); /* Take pin on all head pages to avoid freeing them under us */ list_for_each_entry_safe(folio, next, &ds_queue->split_queue, _deferred_list) { @@ -4159,7 +4208,7 @@ static unsigned long deferred_split_scan(struct shrinker *shrink, if (!--sc->nr_to_scan) break; } - spin_unlock_irqrestore(&ds_queue->split_queue_lock, flags); + split_queue_unlock_irqrestore(ds_queue, flags); list_for_each_entry_safe(folio, next, &list, _deferred_list) { bool did_split = false; -- 2.20.1