From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C7E29C4345F for ; Thu, 25 Apr 2024 06:25:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 545C16B0089; Thu, 25 Apr 2024 02:25:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4F5256B008A; Thu, 25 Apr 2024 02:25:33 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3E2EB6B008C; Thu, 25 Apr 2024 02:25:33 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 25EBA6B0089 for ; Thu, 25 Apr 2024 02:25:33 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id CDD44A02A3 for ; Thu, 25 Apr 2024 06:25:32 +0000 (UTC) X-FDA: 82047067704.29.9335D1A Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by imf24.hostedemail.com (Postfix) with ESMTP id 8892B180003 for ; Thu, 25 Apr 2024 06:25:30 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf24.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1714026331; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=z2lxszA74jUE1IDOr0qFrQzirimkkw5QVVQj3DPDu3Q=; b=4VSL4BAwQ44fiZ4jUW08ChHoN/uqmrbvbWFz7XureCUvzXJSr9wBPmSvPsMcThE24b+Bch v7fHJq2Y5Ein0QKdx15kKHNBh6OHeU4o8BqIFsn8i4s3hKKGipEZwYQOzWI5RvqPZ01551 36r1u06E51jjVS96r14bKx6Eoy/eHiM= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1714026331; a=rsa-sha256; cv=none; b=LPDZFB19yHq5MD6CiA8NfJb/2Mpi2WOLWxXSrTZjXb9vWKJTPWWtZpopugcQbTeADznoli ZwYwgRWBnwRucNGcfFvOXYIFTXNiRAdDtINLaiFveFiLTyKUyB32Ulhjm0A+0yjQ1+jqpx A2+D/KrT/2+5ziG1btwFb7KFYeWXTMQ= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf24.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com Received: from mail.maildlp.com (unknown [172.19.163.174]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4VQ5P16LyYzwSLJ; Thu, 25 Apr 2024 14:22:13 +0800 (CST) Received: from canpemm500002.china.huawei.com (unknown [7.192.104.244]) by mail.maildlp.com (Postfix) with ESMTPS id 8F9BE140258; Thu, 25 Apr 2024 14:25:25 +0800 (CST) Received: from [10.173.135.154] (10.173.135.154) by canpemm500002.china.huawei.com (7.192.104.244) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Thu, 25 Apr 2024 14:25:25 +0800 Subject: Re: [PATCH v2 1/1] mm: page_alloc: Avoid defining unused function To: Andy Shevchenko CC: Rasmus Villemoes , Andrew Morton , , References: <20240423161506.2637177-1-andriy.shevchenko@linux.intel.com> From: Miaohe Lin Message-ID: <68489f85-5579-5cff-eed1-55ae585916f3@huawei.com> Date: Thu, 25 Apr 2024 14:25:24 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <20240423161506.2637177-1-andriy.shevchenko@linux.intel.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.173.135.154] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To canpemm500002.china.huawei.com (7.192.104.244) X-Stat-Signature: 7ohegom6n7rt9hg3xaj3hdhhdmc6tt1u X-Rspamd-Queue-Id: 8892B180003 X-Rspamd-Server: rspam06 X-Rspam-User: X-HE-Tag: 1714026330-470144 X-HE-Meta: U2FsdGVkX19iwU0ylpJFbk2oDdr+BhwD6Qo+JJ3aacNQPJrItLwxBHzyAFQ/4ZVc9DbtH4DeI30y14rT/5Lgp9Av4kBlffjsfpxjkioM89mYlZzdhA4+Si58pKTNIniAzyINVAMRGN2Ftf+rjHIbe6h6zltTZMCm7fWc/OZTrKOhKdoj9BDdjDLq+KbsuUUBiJ6kgvZt8pOGj7XKPjY7LAIXlKysCGmoJVMa2QfxUScShhLhMnUr1VMMWLlUf3StxPwgb/67/cavHBIzIXlRkEhNHPcmG3Tdwd11ianuZ+DQR0z8q0CTMQjTHPvYM4JiHfj8aWNrCV7+zZdFFB49+rNVoqXvXI5alYtmyrn86uFH/eMtjgO3RcMgHprkEdCpHk5TUXEVE5CfZbyqfF/AdqycNcdub6N0rTSyl2w8+3SOUC/Do3NDwMi4g4B0Dia2bipMSIbbqTrgsjKBJOfOAG5y08qfxQtUCUtA3Q9KWDyC+Vet5QNJDfR3nkJjephauPdlFEdJEhOSnmQFZthCDRYm6fbimhgHlzHXvgKssE28pfVc82xTRZFSlVHI42qZJmvEVsvZ2hOToKJ1AUGHcpWTlmWI9Zb2ankjCIVHljNlQmx8IFC8QtB5YY3M/swOpDZ+TuFPqgvmgjyTg3RW2p8WGB8B+Uy+AcqwgYu4CUzTzJOqISBL/DisqlxTiEKUFFP2puY6xoeaSq1xt5SgyC1rDwmadJC6EuyuYm+OTbZm5q0A+U79C+k2RRiYykOd4RaI9x3t50Di6ryTUek3mQeiBgi80c0utLUbzq5R4tpkXlm4sbLXFFsdIMPK80dOYE4xy7wpF5iN8UVPDk77KxQsZFlph9Q0XcLRCNCallNLjwbryWaAlDrtwQJ0DJxzzjdHTII/eCyQQULqlZEQJ7au0/seB7DN0xjwM+igEeo4/tYyQsWHFLUGW9pprTgBQOBrsulRiVDQLrZC31X Ip/2VRQK mDweRbGOvEDAuX3ppiHxyRuvIbtOwdTiQ7YBRqc78iG6wRUKhvgoAlsOBkRAl2OUSpxgB3Q/TxqEsRkGjwwt4+Xsk3zmK0tUIiKmMA1y34YB2g/05DAIRQvL4m4MkE2kxQozLdA+LOyAysVQDTUHBb/pkaPsc1wA0yZVk0A9rDqEmJ7o2LuvgdQvJnA9AFhcf0Qt3U/Z9ExdBA5igHEjDBEcxhcYEeM8/E+Oe X-Bogosity: Ham, tests=bogofilter, spamicity=0.000005, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/4/24 0:14, Andy Shevchenko wrote: > In some configurations I got > mm/page_alloc.c:656:20: warning: unused function 'add_to_free_list' [-Wunused-function] > Becuase the only user is guarged with a certain ifdeffery, guarged? ifdeffery? > do the same for add_to_free_list(). A Fixes tag might be needed. > > Signed-off-by: Andy Shevchenko Anyway, this patch looks good to me. Thanks. Reviewed-by: Miaohe Lin Thanks. .