From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4B511ECAAA1 for ; Sun, 18 Sep 2022 02:36:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3E8A680008; Sat, 17 Sep 2022 22:36:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 370B180007; Sat, 17 Sep 2022 22:36:46 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1EA0D80008; Sat, 17 Sep 2022 22:36:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 0962580007 for ; Sat, 17 Sep 2022 22:36:46 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id CC7541605EF for ; Sun, 18 Sep 2022 02:36:45 +0000 (UTC) X-FDA: 79923643170.09.62E2F1D Received: from out2.migadu.com (out2.migadu.com [188.165.223.204]) by imf11.hostedemail.com (Postfix) with ESMTP id 52F8C40019 for ; Sun, 18 Sep 2022 02:36:45 +0000 (UTC) Content-Type: text/plain; charset=us-ascii DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1663468603; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=mt4EevSP2UXpOuDshgDqIVBSaTOuTupp17SEl5NDqXg=; b=TJvEPU5EJxYQYfqjeqgXwtBInyVyBZ9dIKb7eJCybflERk/L6hMKDFVlSpHNOVON8Tey/m DSCEb9RgIRzqUnB9f+AQLBzUD3udAl/bn2PFN9r/Lr8xwJg5W37xRYbRY8KsLPX/KUSL46 PwOhViZkUj8Q5M5elAIVdQs7HM/kApA= MIME-Version: 1.0 Subject: Re: [PATCH] mm/damon: return void from damon_set_schemes() X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Muchun Song In-Reply-To: <1663341635-12675-1-git-send-email-kaixuxia@tencent.com> Date: Sun, 18 Sep 2022 10:36:39 +0800 Cc: sj@kernel.org, Andrew Morton , damon@lists.linux.dev, Linux MM , linux-kernel@vger.kernel.org, Kaixu Xia Content-Transfer-Encoding: 7bit Message-Id: <6843CCD1-F6F3-40AA-9A5C-7DFD65475864@linux.dev> References: <1663341635-12675-1-git-send-email-kaixuxia@tencent.com> To: xiakaixu1987@gmail.com X-Migadu-Flow: FLOW_OUT X-Migadu-Auth-User: linux.dev ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=TJvEPU5E; spf=pass (imf11.hostedemail.com: domain of muchun.song@linux.dev designates 188.165.223.204 as permitted sender) smtp.mailfrom=muchun.song@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1663468605; a=rsa-sha256; cv=none; b=4yGdaIRAGtI5uAFPokzuoQcprdTdRcJ7PtNl1EydEo3tJCBB3douAw8KoMqs6DrqqzMVxQ lnJJcNHkL3FtG+6gVOIZTLXSB9w08w/ld/0Cu38jBZJDGViTtxN3IvqS9e2b+emOsmmuiJ CRPsnemWYt87BwAzQqT3crsZl/ZR86U= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1663468605; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=mt4EevSP2UXpOuDshgDqIVBSaTOuTupp17SEl5NDqXg=; b=02ytCMMrL+1sXf1wXm2VqbLQLZv4rsAsXy0S6C8w7R85hjxTlbssYe1UKJCzB8ugJZ2pyz 3172nwZvyzX3lqNSU/Yxt6IXvnCz4wEDAIlmQHOR9THPJllrrRAN7gGfElExSKancr4sZo xnEtzFEn45XWw45Ep/tLrjfhXvBiwQ8= X-Rspam-User: X-Stat-Signature: qfszmqezsgud3whzmqc4c36h9b7cjs7a X-Rspamd-Queue-Id: 52F8C40019 Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=TJvEPU5E; spf=pass (imf11.hostedemail.com: domain of muchun.song@linux.dev designates 188.165.223.204 as permitted sender) smtp.mailfrom=muchun.song@linux.dev; dmarc=pass (policy=none) header.from=linux.dev X-Rspamd-Server: rspam04 X-HE-Tag: 1663468605-37423 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > On Sep 16, 2022, at 23:20, xiakaixu1987@gmail.com wrote: > > From: Kaixu Xia > > There is no point in returning an int from damon_set_schemes(). > It always returns 0 which is meaningless for the caller, so > change it to return void directly. > > Signed-off-by: Kaixu Xia Reviewed-by: Muchun Song Thanks.