From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 548EBC433EF for ; Sat, 4 Jun 2022 01:24:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AB2308D0002; Fri, 3 Jun 2022 21:24:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A5CBE8D0001; Fri, 3 Jun 2022 21:24:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 922BA8D0002; Fri, 3 Jun 2022 21:24:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 822138D0001 for ; Fri, 3 Jun 2022 21:24:47 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay11.hostedemail.com (Postfix) with ESMTP id 568FE81704 for ; Sat, 4 Jun 2022 01:24:47 +0000 (UTC) X-FDA: 79538809014.12.F513E5C Received: from mail-pg1-f176.google.com (mail-pg1-f176.google.com [209.85.215.176]) by imf27.hostedemail.com (Postfix) with ESMTP id E69784002E for ; Sat, 4 Jun 2022 01:24:41 +0000 (UTC) Received: by mail-pg1-f176.google.com with SMTP id d129so8457136pgc.9 for ; Fri, 03 Jun 2022 18:24:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20210112.gappssmtp.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=H5GzO1GVZTXiX6PTnZ0maVWHXWhxKwJkxQUe242iFjg=; b=IhocYC3qHy8EUVb5O0v/ELOjI6SsqyJxjKf/Vu8dLAiHITnBEkWby7B4+ZNGaEqDjZ e/DBzSAm/IFgW10mDHfNUIwmrHI8YTpXqXdqGwbC32iHYtxJ4/0rn+5m8mzQ4vFbaBAw oPGAiSYv+WCSjvluB4FT0nP11wfPhnUdLvrHu2zXZ3ohwNKcr4OljPj7JqbJFZe/okca 6FogBD7fWTBSaA1+Ld4DfHeJ1j1ald9nZ++kKpSSvAh0vIoYZ82LduuKRiCtLHM/Mb5/ R8sINUYQkO9mK/H10qcDYXe+OWlB5JHIDPkwrlNgeDNFhz0yjincgxl0VJMvJLh2QwjE wiCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=H5GzO1GVZTXiX6PTnZ0maVWHXWhxKwJkxQUe242iFjg=; b=40kszEadPrrMifalJKZY+nskd2hwiAT6BtDHfipnlb3cLl237oYx4nRuWOpoVEzIIr IP5OYqhc+i+J/efb/X/xvQiYfONoiHHThRMgA+DDwYhZ2E7kHyUiGFFKPSEKV81tffNO j9lLiZ4xHkdSpWeSikhBsUgRO82xCv7TwTtHn3U1TW7soXjM8G40BzBYFHIWG27YSQKE Y/pR4vL2Es2cKpz0TGHG2TV8kqSv1M7TMqefjhgHvS18LI0PiC5kpYK7aYOrK2gJb3iL Zenu4yO55TQNOdNInPqtENK4U0mqxHxh4T4I+n1Pdt8nhuPPlkh4oer2ywUfrsX+QENa JN+A== X-Gm-Message-State: AOAM533mLKPGTq1gFfSx0513hdDr3ryqKpT4QYOPuz5susb0JWXcVC6W SWcJhBU7n20U7BWlaFoK5Zb1QA== X-Google-Smtp-Source: ABdhPJx1//CyJ20BJCZkSYLm20hSsC3pDU2Dr4uzutt5qYu615ZOTb8FPdNEj/A4wW+9CG7lFUBURw== X-Received: by 2002:a65:4bc5:0:b0:3da:ec0c:c5f2 with SMTP id p5-20020a654bc5000000b003daec0cc5f2mr11018632pgr.221.1654305884726; Fri, 03 Jun 2022 18:24:44 -0700 (PDT) Received: from [10.4.187.25] ([139.177.225.224]) by smtp.gmail.com with ESMTPSA id p17-20020a17090adf9100b001df2f8f0a45sm5983115pjv.1.2022.06.03.18.24.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 03 Jun 2022 18:24:44 -0700 (PDT) Message-ID: <68433856-6b7b-2e9e-6e86-77293da7453b@bytedance.com> Date: Sat, 4 Jun 2022 09:24:38 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH] mm: memcontrol: separate {pgscan,pgsteal}_{kswapd,direct} items in memory.stat of cgroup v2 Content-Language: en-US To: Shakeel Butt Cc: Michal Hocko , Johannes Weiner , Roman Gushchin , Muchun Song , Andrew Morton , Jonathan Corbet , Linux MM , LKML , "open list:DOCUMENTATION" References: <20220603070423.10025-1-zhengqi.arch@bytedance.com> From: Qi Zheng In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: n8fwdci41orq78g6i6sdcdotuk5ke6io Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=bytedance-com.20210112.gappssmtp.com header.s=20210112 header.b=IhocYC3q; dmarc=pass (policy=none) header.from=bytedance.com; spf=pass (imf27.hostedemail.com: domain of zhengqi.arch@bytedance.com designates 209.85.215.176 as permitted sender) smtp.mailfrom=zhengqi.arch@bytedance.com X-Rspam-User: X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: E69784002E X-HE-Tag: 1654305881-715632 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2022/6/4 8:47 AM, Shakeel Butt wrote: > On Fri, Jun 3, 2022 at 12:06 AM Qi Zheng wrote: >> > [...] >> >> diff --git a/Documentation/admin-guide/cgroup-v2.rst b/Documentation/admin-guide/cgroup-v2.rst >> index 176298f2f4de..0b9ca7e7df34 100644 >> --- a/Documentation/admin-guide/cgroup-v2.rst >> +++ b/Documentation/admin-guide/cgroup-v2.rst >> @@ -1442,11 +1442,17 @@ PAGE_SIZE multiple when read back. >> pgrefill (npn) >> Amount of scanned pages (in an active LRU list) >> >> - pgscan (npn) >> - Amount of scanned pages (in an inactive LRU list) >> + pgscan_kswapd (npn) >> + Amount of scanned pages by kswapd (in an inactive LRU list) >> >> - pgsteal (npn) >> - Amount of reclaimed pages >> + pgscan_direct (npn) >> + Amount of scanned pages directly (in an inactive LRU list) >> + >> + pgsteal_kswapd (npn) >> + Amount of reclaimed pages by kswapd >> + >> + pgsteal_direct (npn) >> + Amount of reclaimed pages directly > > No objection to adding new fields but removing 'pgsteal' and 'pgscan' > from the user visible API might break some applications. Oh, got it. So do we need to keep pgscan and pgsteal fields? If it is, I can add it back in patch v2. Thanks, Qi