From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7299CC19F32 for ; Sun, 2 Mar 2025 13:54:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B0B966B0082; Sun, 2 Mar 2025 08:54:06 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id ABC366B0083; Sun, 2 Mar 2025 08:54:06 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9D1246B0085; Sun, 2 Mar 2025 08:54:06 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 8016A6B0082 for ; Sun, 2 Mar 2025 08:54:06 -0500 (EST) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 29A30535E3 for ; Sun, 2 Mar 2025 13:54:06 +0000 (UTC) X-FDA: 83176754892.26.6711DF2 Received: from shelob.surriel.com (shelob.surriel.com [96.67.55.147]) by imf07.hostedemail.com (Postfix) with ESMTP id 5CABF40002 for ; Sun, 2 Mar 2025 13:54:04 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf07.hostedemail.com: domain of riel@shelob.surriel.com designates 96.67.55.147 as permitted sender) smtp.mailfrom=riel@shelob.surriel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740923644; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rYEMtaAqhcl0W6Na9iyomnGyNe8dbzqmMmV9bEHBkQM=; b=YnxJ57eDSM1JlmWhzj64Fgv9Kj2d+nm1OReNqml+wgIzfWfNVWPeJ3VmH8QVlS3VIDbtOA 0sDu1rkamXmxzfWw3EM3lbsktwPh7QrjvHm5GFbYMina5gJWL5heQgqILr6XBd2Mr1TAm2 xQI+ePJjwzw/wx3BWKBdRpvmkh8wSbE= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740923644; a=rsa-sha256; cv=none; b=ItYuTgJM8WbDdoVHohMEywrWv4xi1WKzkY2isnasYvgEZLxmQeOD5xWy+Ezw+hCY6qxrim rzCV1NgvJdz0hz3mA1ifo6Y6psYyAQ+IIzTVv/79DETNkZdWRCL6ibxz0E5xW/2D+Tc09C r6xDJ/SH+98odkO4c59wmzifgd9RdnM= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf07.hostedemail.com: domain of riel@shelob.surriel.com designates 96.67.55.147 as permitted sender) smtp.mailfrom=riel@shelob.surriel.com Received: from fangorn.home.surriel.com ([10.0.13.7]) by shelob.surriel.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.97.1) (envelope-from ) id 1tojkk-000000005wN-3mFJ; Sun, 02 Mar 2025 08:53:10 -0500 Message-ID: <683d34253e2bdef9f74d8c44b2eff7ae9cfea5f9.camel@surriel.com> Subject: Re: [PATCH v14 09/13] x86/mm: global ASID process exit helpers From: Rik van Riel To: Borislav Petkov Cc: x86@kernel.org, linux-kernel@vger.kernel.org, peterz@infradead.org, dave.hansen@linux.intel.com, zhengqi.arch@bytedance.com, nadav.amit@gmail.com, thomas.lendacky@amd.com, kernel-team@meta.com, linux-mm@kvack.org, akpm@linux-foundation.org, jackmanb@google.com, jannh@google.com, mhklinux@outlook.com, andrew.cooper3@citrix.com, Manali.Shukla@amd.com, mingo@kernel.org Date: Sun, 02 Mar 2025 08:53:10 -0500 In-Reply-To: <20250302123838.GKZ8RRTgRxvBSry6mk@fat_crate.local> References: <20250226030129.530345-1-riel@surriel.com> <20250226030129.530345-10-riel@surriel.com> <20250302123838.GKZ8RRTgRxvBSry6mk@fat_crate.local> Autocrypt: addr=riel@surriel.com; prefer-encrypt=mutual; keydata=mQENBFIt3aUBCADCK0LicyCYyMa0E1lodCDUBf6G+6C5UXKG1jEYwQu49cc/gUBTTk33A eo2hjn4JinVaPF3zfZprnKMEGGv4dHvEOCPWiNhlz5RtqH3SKJllq2dpeMS9RqbMvDA36rlJIIo47 Z/nl6IA8MDhSqyqdnTY8z7LnQHqq16jAqwo7Ll9qALXz4yG1ZdSCmo80VPetBZZPw7WMjo+1hByv/ lvdFnLfiQ52tayuuC1r9x2qZ/SYWd2M4p/f5CLmvG9UcnkbYFsKWz8bwOBWKg1PQcaYHLx06sHGdY dIDaeVvkIfMFwAprSo5EFU+aes2VB2ZjugOTbkkW2aPSWTRsBhPHhV6dABEBAAG0HlJpayB2YW4gU mllbCA8cmllbEByZWRoYXQuY29tPokBHwQwAQIACQUCW5LcVgIdIAAKCRDOed6ShMTeg05SB/986o gEgdq4byrtaBQKFg5LWfd8e+h+QzLOg/T8mSS3dJzFXe5JBOfvYg7Bj47xXi9I5sM+I9Lu9+1XVb/ r2rGJrU1DwA09TnmyFtK76bgMF0sBEh1ECILYNQTEIemzNFwOWLZZlEhZFRJsZyX+mtEp/WQIygHV WjwuP69VJw+fPQvLOGn4j8W9QXuvhha7u1QJ7mYx4dLGHrZlHdwDsqpvWsW+3rsIqs1BBe5/Itz9o 6y9gLNtQzwmSDioV8KhF85VmYInslhv5tUtMEppfdTLyX4SUKh8ftNIVmH9mXyRCZclSoa6IMd635 Jq1Pj2/Lp64tOzSvN5Y9zaiCc5FucXtB9SaWsgdmFuIFJpZWwgPHJpZWxAc3VycmllbC5jb20+iQE +BBMBAgAoBQJSLd2lAhsjBQkSzAMABgsJCAcDAgYVCAIJCgsEFgIDAQIeAQIXgAAKCRDOed6ShMTe g4PpB/0ZivKYFt0LaB22ssWUrBoeNWCP1NY/lkq2QbPhR3agLB7ZXI97PF2z/5QD9Fuy/FD/jddPx KRTvFCtHcEzTOcFjBmf52uqgt3U40H9GM++0IM0yHusd9EzlaWsbp09vsAV2DwdqS69x9RPbvE/Ne fO5subhocH76okcF/aQiQ+oj2j6LJZGBJBVigOHg+4zyzdDgKM+jp0bvDI51KQ4XfxV593OhvkS3z 3FPx0CE7l62WhWrieHyBblqvkTYgJ6dq4bsYpqxxGJOkQ47WpEUx6onH+rImWmPJbSYGhwBzTo0Mm G1Nb1qGPG+mTrSmJjDRxrwf1zjmYqQreWVSFEt26tBpSaWsgdmFuIFJpZWwgPHJpZWxAZmIuY29tP okBPgQTAQIAKAUCW5LbiAIbIwUJEswDAAYLCQgHAwIGFQgCCQoLBBYCAwECHgECF4AACgkQznneko TE3oOUEQgAsrGxjTC1bGtZyuvyQPcXclap11Ogib6rQywGYu6/Mnkbd6hbyY3wpdyQii/cas2S44N cQj8HkGv91JLVE24/Wt0gITPCH3rLVJJDGQxprHTVDs1t1RAbsbp0XTksZPCNWDGYIBo2aHDwErhI omYQ0Xluo1WBtH/UmHgirHvclsou1Ks9jyTxiPyUKRfae7GNOFiX99+ZlB27P3t8CjtSO831Ij0Ip QrfooZ21YVlUKw0Wy6Ll8EyefyrEYSh8KTm8dQj4O7xxvdg865TLeLpho5PwDRF+/mR3qi8CdGbkE c4pYZQO8UDXUN4S+pe0aTeTqlYw8rRHWF9TnvtpcNzZw== Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.54.3 (3.54.3-1.fc41) MIME-Version: 1.0 X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 5CABF40002 X-Stat-Signature: d4mc9xsr6wfjnzzb1a5w34zqin1urdg7 X-HE-Tag: 1740923644-297790 X-HE-Meta: U2FsdGVkX1+o+qvflpXooYSac8Df/jJ9o+SGBsLdnUaFa5SHuC39kbBwJm0PPcUl6vO43K0KxSvxmfC7+IqbyW4nTphVrhKZm3SmwCOC75sOr328ZBfCCdYTav96VwJ/dRg9shWfss8GX/rkIKJtn/VbtMZ4up5HnLWqXaVAEPq5ZPfCeMCPXS5gm5TYva9xrFOF6hqUMxgX/bflVUfNeAoxb7ItdlnKvKeY7Q0VzZX4l0pgBNTrSdf4O8AR7hRBa+aXPSViFdCgezS+sSl0sqGvdiyRLaGxlQgWFCVbgNH3ezg0XEQE8eefxZbD1AIi1xzNeg9DMug6uoPI+bhHfIp4wvAngmT+Glti9b+lrDliGGMzj+tlNK9QQRkT/8I+Jjw/dqbc4nOYf9XLHd/sO53o9OkpvtdMzVpJjx1FDk9O/3P8ArRILKeH3SLkIIurs4OMRnN2tjXus0n6Vfomzb6Vh5FojAfsGeINDHfYlohSYHf+rPwsdvd38/AqzqQ/McY5FElZX5ZAOAtytudQO5JSU6pzqyL55TwJjK79zt3LBJhP9bMnUocOo47dPsTfkCHV4gQxkKWod8n6qJw9/f5Efu88HWs6iV4pUvirQYuMfVkXiDMyHYnmj+1wuqJCDnQtKGB5Rs/cPdvG92ANZquznFQtEIe+dHhMLHppMZVzH3SpshJrNL8okXb+FHaI00XABrsgUenT9WnzxXuP5qNadLl1e9i4Ex+QNxcSCGEVsmXdzD32kjTe3UzgX/EEiOHab4RT7esIrO3IfZHWxO0Hpk/k/jPknyIICPfk/elKni6dNJVsXWK6i47wPyvhF0ao1H7vlt1R6h3cunJrLvtKZ5tfge4LKAl6Sq1wHa656da23F2ar+n/mLPw8bogWPEfmjeGJBXUglXDl5yWEknqoGEqcIr/3mB6tx6VV3yhD4sc6Bv0a12R22YQI2i+MXtPlFnKUEzgRGJCsP0 apkbiii+ BmRd3Rk03764pN6QsZBm8zhWHwUFLbupbSalp91WcmsRVxtwCX1o/uBBmkPMIj5yJ40z3uPVn+JLRKfwIq+0I89jlNBzoLdxt/eV/TlKaR8wA6RTXr5A51Ce4OJGcfJM0vdI7Lb5S7NEN3fPJXzY17d8K+HnoMgeN5cGDN2hSCYMDf4CUjYtNyDzspKqbGKBZLtCH4T8m5n+Ngv1zAriNBQJKXlFlu+fLBPfC/a9K+/vEqKMg7wSw42TTjJYqiLHNDDl7T6iIroxH5n0JpjK7VxovOiZZJ22t5QWEng0iq/l3ZvHJNYLTFN/xpqqkXy9c4P1xpc2QsM7umPcZoJj2/rQOSKVfLUURR7GIr2tLkBZ1gQ1D5WO435ZPAQ0XsrZWXdnxDYIflHkDqrM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sun, 2025-03-02 at 13:38 +0100, Borislav Petkov wrote: > On Tue, Feb 25, 2025 at 10:00:44PM -0500, Rik van Riel wrote: > > A global ASID is allocated for the lifetime of a process. > >=20 > > Free the global ASID at process exit time. > >=20 > > Signed-off-by: Rik van Riel > > --- > > =C2=A0arch/x86/include/asm/mmu_context.h | 12 ++++++++++++ > > =C2=A01 file changed, 12 insertions(+) >=20 > So I don't like the ifdeffery and tried removing it, see below. >=20 > So I added helpers. >=20 > Then I entered the include hell. >=20 > And then I caught a bug with the DISABLED_FEATURE stuff. I've been there. Repeatedly :) Thank you for these changes, it does look better than before now. --=20 All Rights Reversed.