From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E6066D68BDD for ; Sat, 16 Nov 2024 00:12:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 620179C0019; Fri, 15 Nov 2024 19:12:38 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 5ABEC9C0018; Fri, 15 Nov 2024 19:12:38 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3FC549C0019; Fri, 15 Nov 2024 19:12:38 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 0120B9C0018 for ; Fri, 15 Nov 2024 19:12:37 -0500 (EST) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 79178ACE74 for ; Sat, 16 Nov 2024 00:12:37 +0000 (UTC) X-FDA: 82790031492.28.9F33831 Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by imf08.hostedemail.com (Postfix) with ESMTP id 0CA5A16000D for ; Sat, 16 Nov 2024 00:12:04 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=linux.microsoft.com header.s=default header.b=Pq2k2Nni; spf=pass (imf08.hostedemail.com: domain of eahariha@linux.microsoft.com designates 13.77.154.182 as permitted sender) smtp.mailfrom=eahariha@linux.microsoft.com; dmarc=pass (policy=none) header.from=linux.microsoft.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1731715778; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=xpBEojaRNmZLcf0UaP4ux3dQkOORS/leVLfy1gAywiE=; b=F+6+AeJnwdGsQTMmbieSiVYAjXMYQNJKzONGm/4jBylxLX9bshBU4jRW4vI+s2m6lY7lOI VGA9z3HSn+934Hud352T9lZoszX4t6/YJ0V3ZJ0lEHH7YXA0pLmShfkZSaKiFySw0omunL aQC/7wWsRNkG1swV6vUDynRoVT2sgDY= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=linux.microsoft.com header.s=default header.b=Pq2k2Nni; spf=pass (imf08.hostedemail.com: domain of eahariha@linux.microsoft.com designates 13.77.154.182 as permitted sender) smtp.mailfrom=eahariha@linux.microsoft.com; dmarc=pass (policy=none) header.from=linux.microsoft.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1731715778; a=rsa-sha256; cv=none; b=JeTHTY3/ASgnvkHsc+RCbSC16D3XVTio2OJ9jLCdOZJ48m9YRilA4yyEN/gHzxxCiW9b3A pqrSq5uUIXZNX/pdepYkOEYPlCd+PFYNwYJwWUZ8VwimbW4+Kf2lZm0lE3LwJQS0ZcaLk9 SC/Vy+X0kgs003yuWkRmR2i7HXWi0F4= Received: from [192.168.35.166] (c-73-118-245-227.hsd1.wa.comcast.net [73.118.245.227]) by linux.microsoft.com (Postfix) with ESMTPSA id 1600B2064AEE; Fri, 15 Nov 2024 16:12:32 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 1600B2064AEE DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1731715954; bh=xpBEojaRNmZLcf0UaP4ux3dQkOORS/leVLfy1gAywiE=; h=Date:Cc:Subject:To:References:From:In-Reply-To:From; b=Pq2k2Nni3cFBRk9EH3pyxgnDw6ECvdbg1vXWXgUrnZTvujbQOLePABt8LVR+E9JSZ k4WoN+iIfUxQpiMRt/FU+pwGNrKJBo/0Q2+4KvxqDSAbq0u3pnKwVj+6aACG5ZF/KB j3wJy4AhuvO/DGvU623x7nThkWYs37o8kaDAxg9k= Message-ID: <68331eb9-545f-48a4-9c49-1a3637b3d918@linux.microsoft.com> Date: Fri, 15 Nov 2024 16:12:31 -0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Cc: eahariha@linux.microsoft.com, Pablo Neira Ayuso , Jozsef Kadlecsik , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Julia Lawall , Nicolas Palix , Daniel Mack , Haojian Zhuang , Robert Jarzmik , Russell King , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Ofir Bitton , Oded Gabbay , Lucas De Marchi , =?UTF-8?Q?Thomas_Hellstr=C3=B6m?= , Rodrigo Vivi , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Jeroen de Borst , Praveen Kaligineedi , Shailend Chand , Andrew Lunn , James Smart , Dick Kennedy , "James E.J. Bottomley" , "Martin K. Petersen" , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Jens Axboe , Kalle Valo , Jeff Johnson , Catalin Marinas , Andrew Morton , Jack Wang , Marcel Holtmann , Johan Hedberg , Luiz Augusto von Dentz , Greg Kroah-Hartman , Florian Fainelli , Ray Jui , Scott Branden , Broadcom internal kernel review list , Xiubo Li , Ilya Dryomov , Josh Poimboeuf , Jiri Kosina , Miroslav Benes , Petr Mladek , Joe Lawrence , Jaroslav Kysela , Takashi Iwai , Lucas Stach , Russell King , Christian Gmeiner , Louis Peens , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Naveen N Rao , Madhavan Srinivasan , netfilter-devel@vger.kernel.org, coreteam@netfilter.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, cocci@inria.fr, linux-arm-kernel@lists.infradead.org, linux-s390@vger.kernel.org, dri-devel@lists.freedesktop.org, intel-xe@lists.freedesktop.org, linux-scsi@vger.kernel.org, xen-devel@lists.xenproject.org, linux-block@vger.kernel.org, linux-wireless@vger.kernel.org, ath11k@lists.infradead.org, linux-mm@kvack.org, linux-bluetooth@vger.kernel.org, linux-staging@lists.linux.dev, linux-rpi-kernel@lists.infradead.org, ceph-devel@vger.kernel.org, live-patching@vger.kernel.org, linux-sound@vger.kernel.org, etnaviv@lists.freedesktop.org, oss-drivers@corigine.com, linuxppc-dev@lists.ozlabs.org, Anna-Maria Behnsen Subject: Re: [PATCH 03/22] arm: pxa: Convert timeouts to use secs_to_jiffies() To: Stephen Rothwell References: <20241115-converge-secs-to-jiffies-v1-0-19aadc34941b@linux.microsoft.com> <20241115-converge-secs-to-jiffies-v1-3-19aadc34941b@linux.microsoft.com> <20241116093815.5d37eb43@canb.auug.org.au> Content-Language: en-US From: Easwar Hariharan In-Reply-To: <20241116093815.5d37eb43@canb.auug.org.au> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 0CA5A16000D X-Stat-Signature: 3nc9tiec9wk3fyc3qa1c4dumabnw79e9 X-Rspam-User: X-HE-Tag: 1731715924-503174 X-HE-Meta: U2FsdGVkX19JEFmwe11AKd6jGcGPZFpMezUCRSKH4MqCVKVugBr3GZ29KFMXpAMtKGKzqHVVd9qQg8iGL3QzIZYgdNcqVKWNKll3UCEXZgipf/vjslYJgjEIzY+PlyBHZfWGAYUYHVgjLdsg2C57BFFOpf35pc/F514Ol/g6GhGnkO1Y/03Kar71y+h/zUbiD2bq/0ZSQJ+y/7/WrNcu/1MRHfPl9AQyysO4TEUyOQSh/xX/Z7J2CrFHXoMzQvUjwLh+D9XnOSemhLtNsvCFdi27GnSiy4CmIs3arDpIJrOEqjGrCe6PhTE+0/H83bHn7S20QIwvp1kOVq1FcqmsX1xIToHEM7OEeKBZGKgi2CkoMCgTeZySNj5syJiefrV6ffo3Z0It5FC41XXyKpLz7dag58KS0ZZeuGyeTgvD3g99LpH50En76kBy3Z6NddWvsy8JrZYWG4njnOtSTZGUU6GAyjMhaAeD9BLM5FCRRE0UdGbnh6xf6U+isZz2C5RMJ3N9a/ZkmfF8K4dTLIG1B9879iOeDEPkoCRUBu894mW6O5IoCsWo1hB9FJtESnSA9JiJoErBZgTM3S9gglcRi5bu71Gk3IPGshXEDGF0S0BwyMuWvuBYudsNJwtz9buWE37edq71qMskJph9h2HIzcHV2J9iC/ONeDg2KhkloNjP2SCSan5Q7L/6tl38GsqBEH7bTpY0xvbRAXQNqOtB6a3t74lZZi3XLVK5ZoypMJB0uqnT7Kk6AiEUTr64jHDiP94MyzonZLEs4WlDs8ECFNOSaumsetqgXH24OChhfd9fu9pbkd3Z+SzdfKHRRaqObE3nK0RcvPcPCIVjeziG3GElhYa313QbS2wJLIlWnhseZXLZi6jzZSiq+JCD+lmFKNB46DVWDjK9HKVl6LGpKxD/gB+VmpN/DHh140zfEJ16hlrtSESBZsidQOyTrI00qftWr8SrhFq85VV3hkc RVIFQ/OD OeEKDpD3b6KRLN41paHcViRERlX6srR1ICRovibWjkv8wcvbF4hmLdigvkSa4XJASL1EaF8erYNtUWkRolsTy0M3MForN7g66S2xfiaJLja/QKGQjrxb8mWnsy2YHHJ14cvsLzMy8yn/TKoYLMT8R1bk0NsgTsE2Se80G7n9ae0OotjCT7V1VnkT/e7+A2uYJjiqcUnhY/UoxirDBy4mSgGAiFYAP0VFh63Y/+3aTNvonqlsqZ+jkJCaKJ+savwSL8h5KA1z2CND4ZnVvhEa5sNx1rKJ7bhlTFOS5ztBjBX8Z9XKfZLMvTQZd5A+h6ZVu6sgVOy50tzNOJ7h1tSxkx7/PTV4oG+z7A7V9aduSWx9VBa5c3e05tO7HayC181tHWNYcCOppdW75bXEO5tXXtYnRGVO1ynrDpyaNpmb8ECIdVwrm3umALGj0Q36v2RMIKoP6HnxKnxDWlvVUQiw0dpj/Klx8IXpeBYhA X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 11/15/2024 2:38 PM, Stephen Rothwell wrote: > Hi Easwar, > > On Fri, 15 Nov 2024 21:22:33 +0000 Easwar Hariharan wrote: >> >> -#define SHARPSL_CHARGE_ON_TIME_INTERVAL (msecs_to_jiffies(1*60*1000)) /* 1 min */ >> -#define SHARPSL_CHARGE_FINISH_TIME (msecs_to_jiffies(10*60*1000)) /* 10 min */ >> -#define SHARPSL_BATCHK_TIME (msecs_to_jiffies(15*1000)) /* 15 sec */ >> +#define SHARPSL_CHARGE_ON_TIME_INTERVAL (secs_to_jiffies(60)) /* 1 min */ >> +#define SHARPSL_CHARGE_FINISH_TIME (secs_to_jiffies(10*60)) /* 10 min */ >> +#define SHARPSL_BATCHK_TIME (secs_to_jiffies(15)) /* 15 sec */ > > It might be nice to keep the alignment of the comments here. > Will fix in v3.