From: Easwar Hariharan <eahariha@linux.microsoft.com>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: eahariha@linux.microsoft.com,
"Pablo Neira Ayuso" <pablo@netfilter.org>,
"Jozsef Kadlecsik" <kadlec@netfilter.org>,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>,
"Simon Horman" <horms@kernel.org>,
"Julia Lawall" <Julia.Lawall@inria.fr>,
"Nicolas Palix" <nicolas.palix@imag.fr>,
"Daniel Mack" <daniel@zonque.org>,
"Haojian Zhuang" <haojian.zhuang@gmail.com>,
"Robert Jarzmik" <robert.jarzmik@free.fr>,
"Russell King" <linux@armlinux.org.uk>,
"Heiko Carstens" <hca@linux.ibm.com>,
"Vasily Gorbik" <gor@linux.ibm.com>,
"Alexander Gordeev" <agordeev@linux.ibm.com>,
"Christian Borntraeger" <borntraeger@linux.ibm.com>,
"Sven Schnelle" <svens@linux.ibm.com>,
"Ofir Bitton" <obitton@habana.ai>,
"Oded Gabbay" <ogabbay@kernel.org>,
"Lucas De Marchi" <lucas.demarchi@intel.com>,
"Thomas Hellström" <thomas.hellstrom@linux.intel.com>,
"Rodrigo Vivi" <rodrigo.vivi@intel.com>,
"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
"Maxime Ripard" <mripard@kernel.org>,
"Thomas Zimmermann" <tzimmermann@suse.de>,
"David Airlie" <airlied@gmail.com>,
"Simona Vetter" <simona@ffwll.ch>,
"Jeroen de Borst" <jeroendb@google.com>,
"Praveen Kaligineedi" <pkaligineedi@google.com>,
"Shailend Chand" <shailend@google.com>,
"Andrew Lunn" <andrew+netdev@lunn.ch>,
"James Smart" <james.smart@broadcom.com>,
"Dick Kennedy" <dick.kennedy@broadcom.com>,
"James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
"Roger Pau Monné" <roger.pau@citrix.com>,
"Jens Axboe" <axboe@kernel.dk>, "Kalle Valo" <kvalo@kernel.org>,
"Jeff Johnson" <jjohnson@kernel.org>,
"Catalin Marinas" <catalin.marinas@arm.com>,
"Andrew Morton" <akpm@linux-foundation.org>,
"Jack Wang" <jinpu.wang@cloud.ionos.com>,
"Marcel Holtmann" <marcel@holtmann.org>,
"Johan Hedberg" <johan.hedberg@gmail.com>,
"Luiz Augusto von Dentz" <luiz.dentz@gmail.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Florian Fainelli" <florian.fainelli@broadcom.com>,
"Ray Jui" <rjui@broadcom.com>,
"Scott Branden" <sbranden@broadcom.com>,
"Broadcom internal kernel review list"
<bcm-kernel-feedback-list@broadcom.com>,
"Xiubo Li" <xiubli@redhat.com>,
"Ilya Dryomov" <idryomov@gmail.com>,
"Josh Poimboeuf" <jpoimboe@kernel.org>,
"Jiri Kosina" <jikos@kernel.org>,
"Miroslav Benes" <mbenes@suse.cz>,
"Petr Mladek" <pmladek@suse.com>,
"Joe Lawrence" <joe.lawrence@redhat.com>,
"Jaroslav Kysela" <perex@perex.cz>,
"Takashi Iwai" <tiwai@suse.com>,
"Lucas Stach" <l.stach@pengutronix.de>,
"Russell King" <linux+etnaviv@armlinux.org.uk>,
"Christian Gmeiner" <christian.gmeiner@gmail.com>,
"Louis Peens" <louis.peens@corigine.com>,
"Michael Ellerman" <mpe@ellerman.id.au>,
"Nicholas Piggin" <npiggin@gmail.com>,
"Christophe Leroy" <christophe.leroy@csgroup.eu>,
"Naveen N Rao" <naveen@kernel.org>,
"Madhavan Srinivasan" <maddy@linux.ibm.com>,
netfilter-devel@vger.kernel.org, coreteam@netfilter.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
cocci@inria.fr, linux-arm-kernel@lists.infradead.org,
linux-s390@vger.kernel.org, dri-devel@lists.freedesktop.org,
intel-xe@lists.freedesktop.org, linux-scsi@vger.kernel.org,
xen-devel@lists.xenproject.org, linux-block@vger.kernel.org,
linux-wireless@vger.kernel.org, ath11k@lists.infradead.org,
linux-mm@kvack.org, linux-bluetooth@vger.kernel.org,
linux-staging@lists.linux.dev,
linux-rpi-kernel@lists.infradead.org, ceph-devel@vger.kernel.org,
live-patching@vger.kernel.org, linux-sound@vger.kernel.org,
etnaviv@lists.freedesktop.org, oss-drivers@corigine.com,
linuxppc-dev@lists.ozlabs.org,
"Anna-Maria Behnsen" <anna-maria@linutronix.de>
Subject: Re: [PATCH 03/22] arm: pxa: Convert timeouts to use secs_to_jiffies()
Date: Fri, 15 Nov 2024 16:12:31 -0800 [thread overview]
Message-ID: <68331eb9-545f-48a4-9c49-1a3637b3d918@linux.microsoft.com> (raw)
In-Reply-To: <20241116093815.5d37eb43@canb.auug.org.au>
On 11/15/2024 2:38 PM, Stephen Rothwell wrote:
> Hi Easwar,
>
> On Fri, 15 Nov 2024 21:22:33 +0000 Easwar Hariharan <eahariha@linux.microsoft.com> wrote:
>>
>> -#define SHARPSL_CHARGE_ON_TIME_INTERVAL (msecs_to_jiffies(1*60*1000)) /* 1 min */
>> -#define SHARPSL_CHARGE_FINISH_TIME (msecs_to_jiffies(10*60*1000)) /* 10 min */
>> -#define SHARPSL_BATCHK_TIME (msecs_to_jiffies(15*1000)) /* 15 sec */
>> +#define SHARPSL_CHARGE_ON_TIME_INTERVAL (secs_to_jiffies(60)) /* 1 min */
>> +#define SHARPSL_CHARGE_FINISH_TIME (secs_to_jiffies(10*60)) /* 10 min */
>> +#define SHARPSL_BATCHK_TIME (secs_to_jiffies(15)) /* 15 sec */
>
> It might be nice to keep the alignment of the comments here.
>
Will fix in v3.
next prev parent reply other threads:[~2024-11-16 0:12 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-15 21:22 [PATCH 00/22] Converge on using secs_to_jiffies() Easwar Hariharan
2024-11-15 21:22 ` [PATCH 01/22] netfilter: conntrack: Cleanup timeout definitions Easwar Hariharan
2024-11-15 21:22 ` [PATCH 02/22] coccinelle: misc: Add secs_to_jiffies script Easwar Hariharan
2024-11-15 21:22 ` [PATCH 03/22] arm: pxa: Convert timeouts to use secs_to_jiffies() Easwar Hariharan
2024-11-15 22:38 ` Stephen Rothwell
2024-11-16 0:12 ` Easwar Hariharan [this message]
2024-11-15 21:22 ` [PATCH 04/22] s390: kernel: " Easwar Hariharan
2024-11-15 21:22 ` [PATCH 05/22] powerpc/papr_scm: Convert timeouts to secs_to_jiffies() Easwar Hariharan
2024-11-15 21:22 ` [PATCH 06/22] mm: kmemleak: " Easwar Hariharan
2024-11-15 21:22 ` [PATCH 07/22] accel/habanalabs: " Easwar Hariharan
2024-11-15 21:22 ` [PATCH 08/22] drm/xe: Convert timeout " Easwar Hariharan
2024-11-18 11:27 ` Thomas Hellström
2024-11-15 21:22 ` [PATCH 09/22] drm/etnaviv: Convert timeouts " Easwar Hariharan
2024-12-03 17:45 ` Lucas Stach
2024-11-15 21:22 ` [PATCH 10/22] scsi: lpfc: " Easwar Hariharan
2024-11-15 21:22 ` [PATCH 11/22] scsi: arcmsr: " Easwar Hariharan
2024-11-15 21:22 ` [PATCH 12/22] scsi: pm8001: " Easwar Hariharan
2024-11-15 21:22 ` [PATCH 13/22] xen/blkback: " Easwar Hariharan
2024-11-15 21:22 ` [PATCH 14/22] gve: " Easwar Hariharan
2024-11-15 21:22 ` [PATCH 15/22] wifi: ath11k: " Easwar Hariharan
2024-11-15 21:22 ` [PATCH 16/22] Bluetooth: MGMT: " Easwar Hariharan
2024-11-15 21:22 ` [PATCH 17/22] staging: vc04_services: " Easwar Hariharan
2024-11-15 21:22 ` [PATCH 18/22] ceph: " Easwar Hariharan
2024-11-28 12:29 ` Alex Markuze
2024-11-15 21:22 ` [PATCH 19/22] livepatch: " Easwar Hariharan
2024-11-16 7:59 ` Dan Carpenter
2024-11-15 21:22 ` [PATCH 20/22] ALSA: line6: " Easwar Hariharan
2024-11-15 21:22 ` [PATCH 21/22] nfp: " Easwar Hariharan
2024-11-15 21:22 ` [PATCH 22/22] jiffies: Define secs_to_jiffies() Easwar Hariharan
2024-11-15 21:30 ` Jeff Johnson
2024-11-15 21:34 ` Easwar Hariharan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=68331eb9-545f-48a4-9c49-1a3637b3d918@linux.microsoft.com \
--to=eahariha@linux.microsoft.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=Julia.Lawall@inria.fr \
--cc=agordeev@linux.ibm.com \
--cc=airlied@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=andrew+netdev@lunn.ch \
--cc=anna-maria@linutronix.de \
--cc=ath11k@lists.infradead.org \
--cc=axboe@kernel.dk \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=borntraeger@linux.ibm.com \
--cc=catalin.marinas@arm.com \
--cc=ceph-devel@vger.kernel.org \
--cc=christian.gmeiner@gmail.com \
--cc=christophe.leroy@csgroup.eu \
--cc=cocci@inria.fr \
--cc=coreteam@netfilter.org \
--cc=daniel@zonque.org \
--cc=davem@davemloft.net \
--cc=dick.kennedy@broadcom.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=edumazet@google.com \
--cc=etnaviv@lists.freedesktop.org \
--cc=florian.fainelli@broadcom.com \
--cc=gor@linux.ibm.com \
--cc=gregkh@linuxfoundation.org \
--cc=haojian.zhuang@gmail.com \
--cc=hca@linux.ibm.com \
--cc=horms@kernel.org \
--cc=idryomov@gmail.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=james.smart@broadcom.com \
--cc=jeroendb@google.com \
--cc=jikos@kernel.org \
--cc=jinpu.wang@cloud.ionos.com \
--cc=jjohnson@kernel.org \
--cc=joe.lawrence@redhat.com \
--cc=johan.hedberg@gmail.com \
--cc=jpoimboe@kernel.org \
--cc=kadlec@netfilter.org \
--cc=kuba@kernel.org \
--cc=kvalo@kernel.org \
--cc=l.stach@pengutronix.de \
--cc=linux+etnaviv@armlinux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=linux-wireless@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=live-patching@vger.kernel.org \
--cc=louis.peens@corigine.com \
--cc=lucas.demarchi@intel.com \
--cc=luiz.dentz@gmail.com \
--cc=maarten.lankhorst@linux.intel.com \
--cc=maddy@linux.ibm.com \
--cc=marcel@holtmann.org \
--cc=martin.petersen@oracle.com \
--cc=mbenes@suse.cz \
--cc=mpe@ellerman.id.au \
--cc=mripard@kernel.org \
--cc=naveen@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=nicolas.palix@imag.fr \
--cc=npiggin@gmail.com \
--cc=obitton@habana.ai \
--cc=ogabbay@kernel.org \
--cc=oss-drivers@corigine.com \
--cc=pabeni@redhat.com \
--cc=pablo@netfilter.org \
--cc=perex@perex.cz \
--cc=pkaligineedi@google.com \
--cc=pmladek@suse.com \
--cc=rjui@broadcom.com \
--cc=robert.jarzmik@free.fr \
--cc=rodrigo.vivi@intel.com \
--cc=roger.pau@citrix.com \
--cc=sbranden@broadcom.com \
--cc=sfr@canb.auug.org.au \
--cc=shailend@google.com \
--cc=simona@ffwll.ch \
--cc=svens@linux.ibm.com \
--cc=thomas.hellstrom@linux.intel.com \
--cc=tiwai@suse.com \
--cc=tzimmermann@suse.de \
--cc=xen-devel@lists.xenproject.org \
--cc=xiubli@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox