From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4508EEB64D7 for ; Wed, 21 Jun 2023 17:42:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A4AE48D0003; Wed, 21 Jun 2023 13:42:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9FA2A8D0002; Wed, 21 Jun 2023 13:42:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8C1798D0003; Wed, 21 Jun 2023 13:42:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 7DB9D8D0002 for ; Wed, 21 Jun 2023 13:42:24 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 43B201A07CB for ; Wed, 21 Jun 2023 17:42:24 +0000 (UTC) X-FDA: 80927474208.30.ECF0668 Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by imf17.hostedemail.com (Postfix) with ESMTP id 5FF5840008 for ; Wed, 21 Jun 2023 17:42:21 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=coNSGyS+; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf17.hostedemail.com: domain of dave.hansen@intel.com designates 192.55.52.136 as permitted sender) smtp.mailfrom=dave.hansen@intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1687369342; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ZFUQgHeCcB5gvI6RM07hbdclr7Jwg4KfyVHBv4gPKN4=; b=8SBEUK9jZ9m2tN/FM3IEprcN4UcLvXhhwODDEDzk2NphKkUghHOpcg2rJW24nDPTeJSdGa nxKA6VHi2y160kUcI193h0Q5y7iN//PEBpyvtd/Dv9T9sdJkz5bKiw/hCh+3aR0dvzbg6u wTcgpKUpzbDaOSx7dq6ZzVZw8wcFGH4= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=coNSGyS+; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf17.hostedemail.com: domain of dave.hansen@intel.com designates 192.55.52.136 as permitted sender) smtp.mailfrom=dave.hansen@intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1687369342; a=rsa-sha256; cv=none; b=7C2Uwaayp6l2Uc0sQaJzOplvgNFF04qQAMjyhqAZwbHAb7aj5ugI5lLzy4D25V9W86aEYv rfHD201hFRiSFc6tz9lZNSLsgL/qrHSrN8smvmCMh+tDcJP28v8iyKndDAi4BNPCMnMJoC W89S/NTDXpYU7oQgXo48dfaEZ3huaVE= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1687369341; x=1718905341; h=message-id:date:mime-version:subject:to:references:from: in-reply-to:content-transfer-encoding; bh=LVptCrukcCrf+ulAXv9iJ2UzZRi1STprNI7mWSySJig=; b=coNSGyS+M+l9Y+6d8IEU6GoG9pOL588x1u14IuBubx4kRdKgkg/FFTa4 6Vu+fdiMQ3N0dYhnJnyd9C6RPVKs4bhthIzW80kUxDfKxjX1eGXu7HD55 3e/6iVDR7RzZIv/x8A8i+DFNhZEPSuLgfGsIdvtfxTuWj/ICzzxLt0iqq 6la4whZc8BG5FUOzc3bEs8XFQFZclMZKrP0lQPEKcU8sJCIH3n1dx+cNu +NaU54xLlsusaodNeqTXNTYBcafNPDwd6XH3ngQVg1cc0V7eOYAggPF8w AmvXF/tFgH8/dsH3Y5ba1c18rfhxAU/idf0VoUZx0KkVsAVAYRgnMaMlV g==; X-IronPort-AV: E=McAfee;i="6600,9927,10748"; a="339870189" X-IronPort-AV: E=Sophos;i="6.00,261,1681196400"; d="scan'208";a="339870189" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Jun 2023 10:42:19 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10748"; a="1044816796" X-IronPort-AV: E=Sophos;i="6.00,261,1681196400"; d="scan'208";a="1044816796" Received: from rmathew-mobl2.amr.corp.intel.com (HELO [10.212.134.235]) ([10.212.134.235]) by fmsmga005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Jun 2023 10:42:16 -0700 Message-ID: <680fadba-9104-3914-5175-e207fd3d9246@intel.com> Date: Wed, 21 Jun 2023 10:42:16 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH v2 2/2] mm/mmu_gather: send tlb_remove_table_smp_sync IPI only to MM CPUs Content-Language: en-US To: Yair Podemsky , mtosatti@redhat.com, ppandit@redhat.com, david@redhat.com, linux@armlinux.org.uk, mpe@ellerman.id.au, npiggin@gmail.com, christophe.leroy@csgroup.eu, hca@linux.ibm.com, gor@linux.ibm.com, agordeev@linux.ibm.com, borntraeger@linux.ibm.com, svens@linux.ibm.com, davem@davemloft.net, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, hpa@zytor.com, keescook@chromium.org, paulmck@kernel.org, frederic@kernel.org, will@kernel.org, peterz@infradead.org, ardb@kernel.org, samitolvanen@google.com, juerg.haefliger@canonical.com, arnd@arndb.de, rmk+kernel@armlinux.org.uk, geert+renesas@glider.be, linus.walleij@linaro.org, akpm@linux-foundation.org, sebastian.reichel@collabora.com, rppt@kernel.org, aneesh.kumar@linux.ibm.com, x86@kernel.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, sparclinux@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20230620144618.125703-1-ypodemsk@redhat.com> <20230620144618.125703-3-ypodemsk@redhat.com> From: Dave Hansen In-Reply-To: <20230620144618.125703-3-ypodemsk@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 5FF5840008 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: 1j4suwsinirbb7nu3nkfbh7fcx54ugan X-HE-Tag: 1687369341-622259 X-HE-Meta: U2FsdGVkX1+2llKgfv59KS387ysXrVhldqQhFlDW3guzDZENAPhrcmE2QeecQxtw9Hu9Ckfumok7SDW4tsk5mrvMvrtyZFmbXGte+IwknzGqjFfjXHlfpRbCBlXwoclNovRF6DJ3pSpxiV50CwobBoF9L530yTWjWVK9EEye2jY8GvmehXf/pCOGKZhNC4EMAZzifeb48Hf/oNfco0UA3ej20UfwVutWrcl0YAYQJ1TTm+8hG/qfVHyIC2s815NRLR8srF5KdBZBX3IIdX+i/Bk+XrF6crwYSTYrVNm2nT8x0OI5A65eG9P+1tluKpuyVuyZKy5lo+toQ1+cTMrbrh/nIYHD3Cn3SS0mRkEr0tIXkosPDamJbTILsn8KltrTTn/S01izJO6MMreLoPabqD1X0NvsRZfWWTQxf4P9nNpqM7kOnKLGQcL80BM8nCRJ6tXNjp/5Hy9GDlqx3b11jaYXNiMDHuYXW1/Tm5zgJPHwqL+VIADuehepwGC2bicB3GTMn1PodYVpqPaXb5jzloBaVne8EopXAs8KpzROpkcx1ezhoZJw2j5sFVzPqqyv2A5ZdSeI7g3f22cN50h3sppiRdW04J5ee4xeLTakCX7ymwA2+S55edKVLf+BPTPJiRSshwO48LSKNtwbqwPZw/c9AOL5dGYyVePJnxH1oyMVMUOw83ObPRzfsOMqUpYhtJAh7rXi7EwpfwsPlsBk9wSQRQJehzeSftCKq5QXH7ynWqv4ssy9a1u2SF98z5hLlwNWcOfbVonz8yqkk7H3mxWze29RfDAylovOB+XJfTMdC1dHBXPzkusFZup6+FeVeDwFX76dvlcXntpkGAokRwDvuqJqAEcr9mYdDb7MZRJslpXBpbPUh+nQa2jpH5SYO3McthTBn3aL6NjZOrOi/UlD1ymRDD6rIwjb59of/06nIsQ294IwGlJ0V2UB2e5UkBQnSibXFfL5cqYr5fC P8+yVv7q cY7mHS9MY8zHa1B/soQ0yuojKkrZ6iTXl4L+vgtqv4aQsMDngH3AkniZXO3LHmiMiGs80uZD8ZhsoqY/A/3osnunOk8+bhfD37XE2ReHC8Ic8i+aF13VFtoaV17+qMTb2WuqSw3JlecnbyOYiZDseMANzEAbZ4rSob+DVtTiBvOuOVWqiWd5Jn9okDcUYaPjA9IC3D6GGnYWnftwJwUQJFHvhdBj/+dFuI7KK5l/pp4E/7+SGTmK8i08dMGSzZQvhY81fus8hnr9RFT5FRfmlyGjOrbwiZKmJtKKm X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 6/20/23 07:46, Yair Podemsky wrote: > -void tlb_remove_table_sync_one(void) > +#ifdef CONFIG_ARCH_HAS_CPUMASK_BITS > +#define REMOVE_TABLE_IPI_MASK mm_cpumask(mm) > +#else > +#define REMOVE_TABLE_IPI_MASK cpu_online_mask > +#endif /* CONFIG_ARCH_HAS_CPUMASK_BITS */ > + > +void tlb_remove_table_sync_one(struct mm_struct *mm) > { > /* > * This isn't an RCU grace period and hence the page-tables cannot be > @@ -200,7 +206,8 @@ void tlb_remove_table_sync_one(void) > * It is however sufficient for software page-table walkers that rely on > * IRQ disabling. > */ > - smp_call_function(tlb_remove_table_smp_sync, NULL, 1); > + on_each_cpu_mask(REMOVE_TABLE_IPI_MASK, tlb_remove_table_smp_sync, > + NULL, true); > } That "REMOVE_TABLE_IPI_MASK" thing is pretty confusing. It *looks* like a constant. It does *NOT* look at all like it consumes 'mm'. Worst case, just create a local variable: if (IS_ENABLED(CONFIG_ARCH_HAS_CPUMASK_BITS)) ipi_mask = mm_cpumask(mm); else ipi_mask = cpu_online_mask; on_each_cpu_mask(ipi_mask, ...); That's a billion times more clear and it'll compile down to the same thing. I do think the CONFIG_ARCH_HAS_CPUMASK_BITS naming is also pretty confusing, but I don't have any better suggestions. Maybe something with "MM_CPUMASK" in it?