From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2356AC3DA64 for ; Thu, 1 Aug 2024 20:10:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 73E2A6B007B; Thu, 1 Aug 2024 16:10:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6EDC76B0082; Thu, 1 Aug 2024 16:10:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5B7116B0083; Thu, 1 Aug 2024 16:10:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 401E56B007B for ; Thu, 1 Aug 2024 16:10:37 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id E97C2161005 for ; Thu, 1 Aug 2024 20:10:36 +0000 (UTC) X-FDA: 82404769272.13.9270F24 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf23.hostedemail.com (Postfix) with ESMTP id 90604140016 for ; Thu, 1 Aug 2024 20:10:34 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=NuZycA4p; spf=pass (imf23.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1722542958; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=SXwZJZgHYqUvAjw/CHYzpjHayeFlWmDxv7+uDgQ4bxE=; b=P2plqCQ/UpsU7iY1QLZkViz72vQQg6Sb0CdzWTvF1hC8JERPRvrLGI7NP/WKQrspd9es9n bPc8Ph6XHOBMuUtD6Y8TU0OLa702pvw38UPLU3tdPQlYA+ji8MPz22ZsloxnPA1v5CXLiX m0xiY7v2TGxsz4vbkLZ/zv3s26IGMac= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=NuZycA4p; spf=pass (imf23.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1722542958; a=rsa-sha256; cv=none; b=vDnIvvgzecK5G7y/jR9YQ5hbuLbRJK4CK7h3F+rHs4l5HctEYZJ7Ik95KgFEd+mBDRS2+1 iXR+cLFBXk2EjBLtitSaUgdnCYhoP1WHtzhT7I6C7Qae21RMQ8/W6Y35FUfBkP2YeuuGsF ON5LTI+5HExH2XomHpRhHEXzzHCfRx4= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1722543033; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=SXwZJZgHYqUvAjw/CHYzpjHayeFlWmDxv7+uDgQ4bxE=; b=NuZycA4pi6j9AUMIJKoj6FMtg9uYxPuKsSTpdx9zQj2RiVA76u3tCR9GCelayuQsEHf6Uf 6f/GLkyzzENIImr7r/hkmH7J/nCvkCL1KFWma1D1P+8GI7aZwuhIAZbd2+oVxRbAmFQ9BD GRtez4y9VugSazCYrBlRXEdyFdI8qX0= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-206-nzDV5nO2OZuZICJ-DByLDA-1; Thu, 01 Aug 2024 16:10:31 -0400 X-MC-Unique: nzDV5nO2OZuZICJ-DByLDA-1 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-3685bbd6dfbso3074422f8f.0 for ; Thu, 01 Aug 2024 13:10:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722543030; x=1723147830; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=SXwZJZgHYqUvAjw/CHYzpjHayeFlWmDxv7+uDgQ4bxE=; b=QcEf3D7gi9y8KjPnQjF1ZoVKUYdKseIZa6gBfT7NKHkWr7AAkewqboTXHb7ocUW600 F6+5+2PIHEmEsf5Ua1TAoortS/S9XTTVDCBJQ6G6cKPoabeQiRKNwTat1h90tKEjlahR le12Bg3ASpDvwYKiqmBumXTFw1ELolZN1Yyy49N0a7E7zz60zqLU2TKgUA0Z8f++p1CA 61r2hGishlbH6ogGka10FzTcB+KzPcn+Hb8za/g3VOGN6scH9DIsWcRXq5QuZzRbzoOL eE6Fztp4POL9BXvHwEtz1J3IaI9Y/Radskh6AHO4N3YOWUdH3SOhXcr1YM4L4LLAc7Bb 7DsA== X-Forwarded-Encrypted: i=1; AJvYcCVOd1FC81gTIYkPEkWwK+eClE+AeHygOEjQvUslUxZHxzZRAqUwgl/72PrQKaUq6sBMvmzMiFj/s7P1S9kwxOur4z8= X-Gm-Message-State: AOJu0YyYUNoEf6tc81Z5Wbzg7niBIKp7XoeqTDw39beu1UCHlxlraD8G OOfXy0gNMh2ALPnVPyHdTcZ5cjmVJ032KZJ9wqS8TOzUhnOnz5EQ62A0Db8W+zaox0ifx5eULZ2 7xwV6FNjpIl72YDJHqQLw84t2BUK+a7pFrkcUuHRYoRnDL5eP X-Received: by 2002:a5d:6481:0:b0:36b:aa9d:785c with SMTP id ffacd0b85a97d-36bbc190f58mr720059f8f.52.1722543029854; Thu, 01 Aug 2024 13:10:29 -0700 (PDT) X-Google-Smtp-Source: AGHT+IF8sTuqxzwmDuSUsEl0Bm4STTo8v2YMsbO3NqW5Hb4AjLQiM+5nXsGBZXZICPbuy6U26qelGQ== X-Received: by 2002:a5d:6481:0:b0:36b:aa9d:785c with SMTP id ffacd0b85a97d-36bbc190f58mr720038f8f.52.1722543029284; Thu, 01 Aug 2024 13:10:29 -0700 (PDT) Received: from ?IPV6:2003:cb:c707:5c00:e650:bcd7:e2a0:54fe? (p200300cbc7075c00e650bcd7e2a054fe.dip0.t-ipconnect.de. [2003:cb:c707:5c00:e650:bcd7:e2a0:54fe]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-36bbcf0ccc5sm338567f8f.23.2024.08.01.13.10.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 01 Aug 2024 13:10:28 -0700 (PDT) Message-ID: <68067a56-4b9c-4636-9d07-41fee371d80c@redhat.com> Date: Thu, 1 Aug 2024 22:10:27 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/4] mm: memory_hotplug: check hwpoisoned page firstly in do_migrate_range() To: Kefeng Wang , Andrew Morton Cc: Oscar Salvador , Miaohe Lin , Naoya Horiguchi , linux-mm@kvack.org References: <20240725011647.1306045-1-wangkefeng.wang@huawei.com> <20240725011647.1306045-3-wangkefeng.wang@huawei.com> <56b9a389-4c36-4892-962d-b45878f30f4d@huawei.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <56b9a389-4c36-4892-962d-b45878f30f4d@huawei.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 90604140016 X-Stat-Signature: gcy661isuyscrdztbr4bdma7w31ydu6k X-Rspam-User: X-HE-Tag: 1722543034-93098 X-HE-Meta: U2FsdGVkX1/nkimJTycHXXsuPgQBbVfM/86pR+QGl/irDggnnO7nEgu7t0gzt6g2mRGPXeTB7KZ9ArCmZx4kYDRns1MJLtl1pcnN22BRTxvVw1WVonUxWNOMp5m97FxvDD8o3vb/aUTP+GzHADniIRxZGIOvrrDrS5f0GZPz7AMqOnIPNRIrzxDKOXvnTKZisvZH0lIJ2fBCLxGzNL7V5sMyAsQkq/R0CkzAsfjPBL4q6qIlJ9E8GvSjSGXu6V9OsDiTlxb1ZrWDtiFrrYadOodFRzTtAPa4eKhW2Mc0gXbdBQR/LIrefceh+tsQqv+TPXC2tatcCI74KdUuhgpUQDpA0HDNWqWz1bUIIQpieIH4ieh7hwp5WWFn2mxt7yU0aHDXbSIXH4vt0TS8v5aTtkb8B6nLYpcNvZRDk6Ih7Zprxv85XvPy01i1t/iJm8s3E5UlUPEAhqThX+wPdBbtCl5Gf7HKn6kq6vz5DIAITKsa/cfFLu2kxOULIQfpnyjnuzlcTjv2Gw67yEqAh0QCfXWEiQ7PpHXgOBfWck8g7hKLzuZd+rJTLoPKBPiQFs3sMY0xy11L5kLuuYdgQsF45diH1VhxkwUiJk+ApjVGhjJ14WeeRHHyUpfYYzS1aant49TmxwczSk55Bq+itKoQOtVilYw02DtQi5RkGCg0LlUupCtzGKwDxh4ilMU9sAQfQmUcRzEvoN+QlC2tPCT4X9iXAkmGWQQgM9wjfITa+ffWUYetcHvHtrUsdZ1G7JOXuCMS0ZI/WBFFiwAJAsgVqPfPQmCtvl2aODaOdkRe8FAwV3SwzaDyXGIu++wV23dyzyqUlqMM6SSJwXSP/+8ubJwmw9ZhNBIFgSJ5L6aoOl48dYOwzJt7CJNKRLYXk1x05hRxmRDNvz+sWBV1aQ36If7bW/k+hB8ikEu1qh2c9glJMlCE5hXY/clly0DQM1dVK9DrTNGNYbF3UY388Mz WbQS2Smj Bm6vgzH225rVsWc1TTOd6FNYT7H0eI1Zann3bh2YqM709iQa6mUEmtxRnGTyKxX1Eo3b68zIEeyVcfXQIfsIEIBX+33tEbdj4FvhAb9WCJjw1X0XZcBqNos+clqIC1fmkPLlSQQZAW/x824wg8TWDpuWBq1XvcNzKbEFy/HNeqTduNI9hX7336r+huxmdts8weMPRr64AZ07xEoUe5gaYCqof75X+un/Mm1/Ug2hl+aTW7QkMg9xGim7MzTFpMMU0gh/fW27T/h5LDoeRL/vp8rfknClyGqDtDqefUZ6FmiqKwzMoz6m3bcZwsC4LRV+jnT2qNZvuqNg6q7mZL52FEEt6wGsXqYrnRXETAg7U6jQ1M/hlgGz93xFTNizPbSNnTXcsLPuB3SBtRMO6dzSw5qBtdJTdqb9cPyh17+/i5ltjkV3J1n1Sqb/UjHzfVpkhT3jeFdceO0bRWHKhSycQY1ffMw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: >> >> We're not checking the head page here, will this work reliably for >> hugetlb? (I recall some difference in per-page hwpoison handling between >> hugetlb and THP due to the vmemmap optimization) > > Before this changes, the hwposioned hugetlb page won't try to unmap in > do_migrate_range(), we hope it already unmapped in memory_failure(), as > mentioned from comments, there maybe fail to unmap, so a new safeguard > to try to unmap it again here, but we don't need to guarantee it. Thanks for clarifying! But I do wonder if the PageHWPoison() is the right thing to do for hugetlb. IIUC, hugetlb requires folio_test_hwpoison() -- testing the head page not the subpage. Reason is that due to the vmemmap optimization we might not be able to modify subpages to set hwpoison. -- Cheers, David / dhildenb