From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 537E6C35FF4 for ; Tue, 17 Sep 2024 08:40:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A83C96B0088; Tue, 17 Sep 2024 04:40:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A33676B0089; Tue, 17 Sep 2024 04:40:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8FAE26B008A; Tue, 17 Sep 2024 04:40:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 722576B0088 for ; Tue, 17 Sep 2024 04:40:07 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 1D097160217 for ; Tue, 17 Sep 2024 08:40:07 +0000 (UTC) X-FDA: 82573582854.05.90B024C Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf01.hostedemail.com (Postfix) with ESMTP id 57B4340006 for ; Tue, 17 Sep 2024 08:40:05 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf01.hostedemail.com: domain of ryan.roberts@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=ryan.roberts@arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1726562282; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qZxKFIEkaG0cqASqRcAUn2WjBLK0YX/S8/dHkMtk/vA=; b=1GrtvnYsc6P5Ga4C8CYpCYsLJzBEEsMYUXvMoCAuo2mdASBbln1aOYCilcsQidx0yHCUbT bNytvbGfvptXvaldGhyh2372fIaVa9pFq86h/EEZn6EtsH6abuec2lILM9lxGO3S/vLBYO cGBIbW4eHIT+5sU0LWy0wDiEO5QDTg8= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1726562282; a=rsa-sha256; cv=none; b=dON/ys5eXsx13BkanN6kgMk3NbXTN4vIach7pAbFR0b0vzhKCOvvlHQWFKz1iJlH2QXz2G st2Zq9/PnoMg1E87NpZa2QnFtK3MpmBQ7o9G8pbFcRQ5c8owqhsTtAlCLWuY1SfY8h/X1M bMMG9tuQH7TZacvdxOD2aRcvl348gMI= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf01.hostedemail.com: domain of ryan.roberts@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=ryan.roberts@arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id E3231DA7; Tue, 17 Sep 2024 01:40:33 -0700 (PDT) Received: from [10.57.83.157] (unknown [10.57.83.157]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 5AF643F66E; Tue, 17 Sep 2024 01:40:02 -0700 (PDT) Message-ID: <6800a37f-8a37-4a9b-9e22-a78943d1ecf7@arm.com> Date: Tue, 17 Sep 2024 09:40:00 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH V2 1/7] m68k/mm: Change pmd_val() Content-Language: en-GB To: Anshuman Khandual , linux-mm@kvack.org Cc: Andrew Morton , David Hildenbrand , "Mike Rapoport (IBM)" , Arnd Bergmann , x86@kernel.org, linux-m68k@lists.linux-m68k.org, linux-fsdevel@vger.kernel.org, kasan-dev@googlegroups.com, linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, Geert Uytterhoeven , Guo Ren References: <20240917073117.1531207-1-anshuman.khandual@arm.com> <20240917073117.1531207-2-anshuman.khandual@arm.com> From: Ryan Roberts In-Reply-To: <20240917073117.1531207-2-anshuman.khandual@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 57B4340006 X-Stat-Signature: 883yx6up1doha45wwhysfkpzafq6jdj3 X-Rspam-User: X-HE-Tag: 1726562405-668840 X-HE-Meta: U2FsdGVkX1+RF+yhz5K0DJYmlu9BQbxZYw52l0bN9PeksmOOPNFEE+T75rAZhrf3P04EmMcbvly1Q4hxgLfOCZbcrmVpExbWRUjMG4FNHF5R5cSr+kZ0/WxaHnEnlFq1Nl0npgRit0mQ101NK425ZHZWe741qWEiqX58pg/HAHC1Am/p2hnCnsvCE2FqjZ9cd7TcOIL+yGY+9U8w8F/mDxZ2ioM6eJw7N45dOYPQOdW3XIPCdoQZPktznoyoGrhd7WwBwTUlbD17tZU0p93vvPqDUKD1+TUeugv2NUUoThKmbZnNCh1SjL191bE0A7Uaw/ODeDAbgMBzG9GMjmw1qujj0b1oTBUowpckI7GXiNCMI8mRZckBvkVAboPPy41dc47oGSmxKE5Kweb+U6fOU8kXX0L8OcRV+zIvDCVq+vx5oq/eX9ITA4HlRQuJ61xQCriO8o1l0UAIe1UaukfMFpsxHgo7JUw4/CZyng9FZz2NB2qf8SfWnd5P7iHmFj9YEkARW2lWBMNIoPGUa44bpFdN6UhGeaksqqAbYy2g8RduCTqJpgie6WvpxpIm6Pj7R/ZCU0jSWCLk9XkYs5+Df1DJ+58C0GG7vbh9/2TZe3ez5pfgq8t1wDrlfqLavWWBcFg+KjfPWRNtWshDI7HK64DLqqcPnKvewQaMozCmJpyVBXTDBMTLLyxWYg+g3PeCCne9zmoKSbY/Lt3brkAZ1omcGfDsDkjj6MmhvXZ7LuvPxc7jCgV2GC7h1JC33DOpL26JH1mjmBTBHbGMkXr92Q9b++sFeRNvmNH3/bnztTdnRUvsBwC5WyTuKfN6mp7Z991N2oBIQoJynjUJErGvg4PM8nDyrzmcpC3ZJs8UvauxuB6LXblP9F0E0mpSUVIqluOq1qlNe//ECT1qFDV2HGf6iDIx9DR/NGAlJ36bHDkQjF+CJFLDAvHcVga/hwV8QCgZPgbZ4a6Mn0OjL1x O4acHTJJ Cygrt6plMlpTxvOO/Nkr0JfxCuouLzvvicjbhO4LMSUpMU8FtDkGrsZL3yfK6KslY6e1eCLRiBPt7g3vAPtlQrDaPBV9OSP58Z0jcgMrsNamKOEkdaOMUZ0ES0O8D8VVW29XZGa4bmw8b0Gzq9u8CpC5SbcKbLUwiWpH6IORtDM80kqT4hr8WFu0hCqBUfQE9+PxP1nWxu0UUmrjaD7TKD2Ayl0AJtq/lcRLklpTjAA1YgDAsjaBs3LqbS9LhYanojMVwwgdclDu3YZwu8SAOijaG6lsYNWI5qs2x50vYkAwX1DbgyU/ixkJG8uerkrTjpAl0t8XscrbJggU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 17/09/2024 08:31, Anshuman Khandual wrote: > This changes platform's pmd_val() to access the pmd_t element directly like > other architectures rather than current pointer address based dereferencing > that prevents transition into pmdp_get(). > > Cc: Geert Uytterhoeven > Cc: Guo Ren > Cc: Arnd Bergmann > Cc: linux-m68k@lists.linux-m68k.org > Cc: linux-kernel@vger.kernel.org > Signed-off-by: Anshuman Khandual I know very little about m68k, but for what it's worth: Reviewed-by: Ryan Roberts > --- > arch/m68k/include/asm/page.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/m68k/include/asm/page.h b/arch/m68k/include/asm/page.h > index 8cfb84b49975..be3f2c2a656c 100644 > --- a/arch/m68k/include/asm/page.h > +++ b/arch/m68k/include/asm/page.h > @@ -19,7 +19,7 @@ > */ > #if !defined(CONFIG_MMU) || CONFIG_PGTABLE_LEVELS == 3 > typedef struct { unsigned long pmd; } pmd_t; > -#define pmd_val(x) ((&x)->pmd) > +#define pmd_val(x) ((x).pmd) > #define __pmd(x) ((pmd_t) { (x) } ) > #endif >