From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0E2A5EB64CA for ; Sat, 7 Sep 2024 15:34:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 654B26B00A2; Sat, 7 Sep 2024 11:34:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 604856B00A4; Sat, 7 Sep 2024 11:34:33 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4568F6B00A6; Sat, 7 Sep 2024 11:34:33 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 295866B00A2 for ; Sat, 7 Sep 2024 11:34:33 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id AEBF11A0C3B for ; Sat, 7 Sep 2024 15:34:32 +0000 (UTC) X-FDA: 82538339184.02.303B735 Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by imf07.hostedemail.com (Postfix) with ESMTP id 593EF40007 for ; Sat, 7 Sep 2024 15:34:29 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=DuwIriM3; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=D4CPdCQj; spf=pass (imf07.hostedemail.com: domain of liam.howlett@oracle.com designates 205.220.177.32 as permitted sender) smtp.mailfrom=liam.howlett@oracle.com; arc=pass ("microsoft.com:s=arcselector10001:i=1"); dmarc=pass (policy=reject) header.from=oracle.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725723243; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=INJIx9qpBaBymlVmkq5LLDpVJk6v+bGO/np6zM00xb4=; b=Lq04wTJyKnFWHzEPtvipKznGHp8yEgp4pnuvVF+MDhb/oYJroerF+/52YnHKIm7bVsxvH2 gPL81q8r1/oAnHSuPfjhO0j7FUJ6JxtMFf6J1ka0DwYT6itaeRFIZnGbbXkNOxGAjbPgYk 3iRpv6NqHNhPK8tkySTDKsgNdiN+5/A= ARC-Authentication-Results: i=2; imf07.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=DuwIriM3; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=D4CPdCQj; spf=pass (imf07.hostedemail.com: domain of liam.howlett@oracle.com designates 205.220.177.32 as permitted sender) smtp.mailfrom=liam.howlett@oracle.com; arc=pass ("microsoft.com:s=arcselector10001:i=1"); dmarc=pass (policy=reject) header.from=oracle.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1725723243; a=rsa-sha256; cv=pass; b=NtYFXq658bh2+ayPzjdBgKZbr89RDUf3LLzuOBlQMeqpwouTNehz9nn20JCUnWjUjODO0S 8qVAxk15y1DY/+ta0M7TLWuZMPfqPKFR7vr2DOOOc6fx1hv0//BwhUEGkD/YuJe4Au5sXG fAiXsGfhLwn7SMIo8lyLhmAQYjeRZYU= Received: from pps.filterd (m0246630.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 487CxtIY019129; Sat, 7 Sep 2024 15:34:21 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h= date:from:to:cc:subject:message-id:references:content-type :in-reply-to:mime-version; s=corp-2023-11-20; bh=INJIx9qpBaBymlV mkq5LLDpVJk6v+bGO/np6zM00xb4=; b=DuwIriM3yXVXoQ6kowEzJ/l+wV4bKB4 038EHt60wpX5lY0GkuVHoJXtqxutBLgKuNGnbq8WPhSZMqjIJjWGucd55u6hlwIM kC11Fu9FMItyHEkaK0fV+NoFF/27rp8UzIb4HmAriVIng6ckLLexARpSAOA7Ddq3 vW0Ht4JrcnuxKTzi9VtbQhhgM10i+8sP5Rql+YVQZfX+GuAyKgHcBNo7EI9x7nRq UGd0S0mpwQ0A8MtYYybuKJRHMLm8Fe+fyRYz55K9T0vltnxbcBmry0O4mC4nou82 p+fOhegMWq7x5MJC2MoaxLMbeonl8rWrZSy9+iNQBJ3QNTm4bLgiawQ== Received: from iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta02.appoci.oracle.com [147.154.18.20]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 41gd8crfrd-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sat, 07 Sep 2024 15:34:20 +0000 (GMT) Received: from pps.filterd (iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (8.18.1.2/8.18.1.2) with ESMTP id 487BV9p9032386; Sat, 7 Sep 2024 15:34:20 GMT Received: from nam02-dm3-obe.outbound.protection.outlook.com (mail-dm3nam02lp2048.outbound.protection.outlook.com [104.47.56.48]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 41gd9c3att-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sat, 07 Sep 2024 15:34:20 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=ty+f1rToaOl9kwuY7N8SLtEl2C9t/+fcPt3tA/tBI89v4NUt3XHP/nluZeezkGZzeESPL4osYsWVxfW6gMW3OStDKKnIq2iadpzM7TFG3slkzBtWBwvVARDWqivB4htePZwBnajVaDt59nnuidyJp/hT5kcwNJz3Iyh9mePX1X9zLWkrU1oYKJLKbLUqYdyNozGiVTrXVvoG5aVDzylTqFh31aOETKmAx4I6kuSDuhixfYSz0A2BuBW8f8hwe4ZU64FiXNeOBVWfUmjxvm3VM+8Jpm933AoYNGl5FSPZ9jBVq7z9eCYy2+9McHaCOzBxuEViVLzCBDIz4ADAXzkZSA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=INJIx9qpBaBymlVmkq5LLDpVJk6v+bGO/np6zM00xb4=; b=QZnPgx8QYAkH0VzlxG3zAXzcsn1XIzMw9s71I/3KaJXpjg622WVzIVpJYJlX7ms2pPyHD7wizHT77OTTvXIK6sTLQQU3yuGVwt+pzOPKYUJFC9RJmx5nIxiys3fc1bH1txoOmKXr7IKVxzXEtpFx1aVfZGnT6+TrTHXjeFn5IgeuazgHAEEAU0QCtONzB4/Oo9JuZOWAKdhA4khOSX4jNidJgtxOmyIZ3N7qUfanRGvI6kjZVb7FlTVfMoFAzZrpP4weYUtqYB4kYRvo/Vf34DiW0QSjMDaQs6s7chBaznv6wiEJunKf0si2cVgPjQ4zbKjBw1+U6UB8JwSgas+t8w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=INJIx9qpBaBymlVmkq5LLDpVJk6v+bGO/np6zM00xb4=; b=D4CPdCQjKoDwttFIJnKfM6h8BZH37dBU35aBVUmHyao1AoRiT00tCUiJcHpgVe/z5l1gBm3RdsbuRtvxHURnHDwJMIjvh61Ul4m22uKg2pRHZ/yk0D71onQcGhc2VDnM/DlxVpoSwUUIrVHArZdVJVLfnPC78kigzA1MXhP3xNE= Received: from LV8PR10MB7943.namprd10.prod.outlook.com (2603:10b6:408:1f9::22) by SA2PR10MB4428.namprd10.prod.outlook.com (2603:10b6:806:fa::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7939.14; Sat, 7 Sep 2024 15:34:18 +0000 Received: from LV8PR10MB7943.namprd10.prod.outlook.com ([fe80::a8ec:6b6b:e1a:782d]) by LV8PR10MB7943.namprd10.prod.outlook.com ([fe80::a8ec:6b6b:e1a:782d%7]) with mapi id 15.20.7918.020; Sat, 7 Sep 2024 15:34:16 +0000 Date: Sat, 7 Sep 2024 11:34:14 -0400 From: "Liam R. Howlett" To: Shakeel Butt Cc: Andrew Morton , Matthew Wilcox , Hugh Dickins , Nhat Pham , Baolin Wang , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Meta kernel team , linux-fsdevel@vger.kernel.org Subject: Re: [PATCH] mm: replace xa_get_order with xas_get_order where appropriate Message-ID: <67g6bjo4xu3ba2dc2fat5htwgv3brkom7mhsqlsklgufhac2dy@lnqv2jflatzc> Mail-Followup-To: "Liam R. Howlett" , Shakeel Butt , Andrew Morton , Matthew Wilcox , Hugh Dickins , Nhat Pham , Baolin Wang , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Meta kernel team , linux-fsdevel@vger.kernel.org References: <20240906230512.124643-1-shakeel.butt@linux.dev> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240906230512.124643-1-shakeel.butt@linux.dev> User-Agent: NeoMutt/20240425 X-ClientProxiedBy: YTBP288CA0027.CANP288.PROD.OUTLOOK.COM (2603:10b6:b01:14::40) To LV8PR10MB7943.namprd10.prod.outlook.com (2603:10b6:408:1f9::22) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: LV8PR10MB7943:EE_|SA2PR10MB4428:EE_ X-MS-Office365-Filtering-Correlation-Id: 857f0be5-2bcd-4c89-f430-08dccf528887 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|376014|7416014|1800799024; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?/UJcPKnJ0C0jYiDO0ZMCm9e8j8Gnv/7lPQC4Sxia/tPTk/CDU2/7QPX0XDrn?= =?us-ascii?Q?Mh2GpVSbLkicYVQ1Q4wuM1Nnx/vujsG67Gzo8/Oymg/IEpYlLpd0lxIZutiX?= =?us-ascii?Q?8dMr5w1IyQ2Xt6HZW7W81AjDIHn7NrsusGICCVKZVCxxH2oucO3Y6mTw/dU3?= =?us-ascii?Q?WdIW0MuuBhXEYOc/rxamvQpZFGYilfhiBxiDdK4paRmy0XGLa5EVMZxzwH4s?= =?us-ascii?Q?cp/Jo9PTpDPOudi2IlbsKEYf5sAc59uLbD10IEz9dOiBFYWGqLSzdXvLHqPv?= =?us-ascii?Q?+8ypg3SqwU/0DQUBGtzWdAIzUVL8ad8jLX0W/YsSxRL4mOjf/3yhyXpocpb9?= =?us-ascii?Q?OPb4QwFcN16+Vj9hxZccW14ZaH8o/hvcLI5g+lIAz4sPIjI4eF/utz8Yelws?= =?us-ascii?Q?bH6YTP39CFifMB7PUDlxUFeqR3wUmdN9elZf2opQcATLdNR8UC6MoKlDm+90?= =?us-ascii?Q?gPff30UHR/UC3H9ACn93CqcEdUZBEz0XbJ0or62dt8MgZnG5qFRs1xbBs5Q0?= =?us-ascii?Q?3RoNrhd4YH1CV9/4aeODxODL/4FnMuNQdMGL53QwHToUyH9ve4blzrGNk5Nu?= =?us-ascii?Q?4cm0yPib5gKfyd7PdvWZ7n2Almpk9Q3PDdNZvcvNs1S2zfRWrGTL55RdUZjT?= =?us-ascii?Q?pT6rfRCt02DyPXUnTs+7zePzUHKLxOsZi0zs5puLE3s2SywKJSqNnLH/VrBr?= =?us-ascii?Q?FmB5jicAXae1/0rd4Dx23CkLApqxULv+CLrQ/vJbwGWsoWoPJqtQz9KNyTza?= =?us-ascii?Q?iPYno5c0d18gtxWzftI6h1k9xHXrhI+4FUhsUX31E54rXftmc2gLCoL3HyNZ?= =?us-ascii?Q?jyv+ZMgemW7IqgWYfHfT9yk37Y6sY6pz62KL5bwOMFElt+sKaKIILAasslta?= =?us-ascii?Q?74E86S6/aMcxT/3ZJt1o587MpQw8atkK6BeO9GIJ2uOHtDOF2r9OnVr4eL5Q?= =?us-ascii?Q?iNw1FWeO4W9lQfMZt5fG+lhmnUDbx0EUR3xtkVt4P0rwC8PhJepLV3zIi2BG?= =?us-ascii?Q?k/EqeXh+08FWNjkxVY18b7ZkMFk7wl0EATlqL4uglIssw+cxjyTzL+FX/p1b?= =?us-ascii?Q?7wLBR7YitouyHx23kErDHp7bCst0kutAnTa3pOCG8Rnk7QtQg/HESdhClYys?= =?us-ascii?Q?rSjhAu2CLRETruWJwjTx+3qJRcFev5Wds6xVK3JSMGX4c4G+HQRvoiLhSe4U?= =?us-ascii?Q?ZS83QMTErF+MBi5aNA9Mq+N3qduR3zTSQh1EBAUeVUXsYiWmWZb4WenJSDK4?= =?us-ascii?Q?qskLorBZy8Y9yAd1YjLVUgk4E8IGf9XVqKMW8rVulzzu6uCP5Sg7EJSYUyc4?= =?us-ascii?Q?HGRPGnvrCt6Qv8+GAzJLLs25+omSuYgF02S14GOOcP0/8Q=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:LV8PR10MB7943.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(376014)(7416014)(1800799024);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?E3CvckOW3LOUtuDlFoK9wnn0N/LP5LhxYEQ/kksvbh8+6DR12HfiDg9QH6+A?= =?us-ascii?Q?zFG4LmR0kOsf+RT7iDdKZax6C55dLUHjfCfUWbaIvS2NvdZCYOB5mgpdINyc?= =?us-ascii?Q?yHXuHp8H6RuCgaK63NyFclizhe42VwL86Z9a5n5oAjQ9rlQUyo7ngfG4qcK6?= =?us-ascii?Q?JW8J0CHGtv9NiOYw1ZtWmrqf4/m734XUByC2eOkOJRGZX+HMJzYxC9QfsyTL?= =?us-ascii?Q?ePNEFLBhJWm6YauQCFpzuyzxSK9sZvuu7u2yQ0HClnZkujq7aKDhmnxy4Bkw?= =?us-ascii?Q?fjTBoRItGIvgYN8xhn4yVa2F9YQ9nF96utCOSqc0i8zJ/hkmj6ZuAWP9n1/7?= =?us-ascii?Q?/HyTWPmwDalEyWN10rkUsLzFdTFESYp8vIC9+SNEklD3+nBRtS/tfNjddZGY?= =?us-ascii?Q?uk68dQm9nK2OzQfdkvV/b7IoaAGxZKOyHKkq6MUO123wPHSoMGR4FNej+9wK?= =?us-ascii?Q?rjXcucNxBNYfZGLYaHUfa59qJNUtDdlgOxSAClj3G8qubIZctzuodqFbwcnA?= =?us-ascii?Q?SHc/O914L9KLIuY24GM2DpRB6fqMGL1pMOT7Xo+jRWLE88g6Vz8DUpwyFYhk?= =?us-ascii?Q?fdilc7p9XX0PTWIXiKxqNMk/GgFpfO0FfSYmpRrcXQzTRvyLth8I2CLIrDw6?= =?us-ascii?Q?AV5EU9ApSK1qcxHxE2Q1XdQ1Do+KZvpoBUhdMWHr5MNAoZZ+bAFkXywUjCaQ?= =?us-ascii?Q?pKz526f+fTCre1IfiO1LvkhtkNLLjrAUVRlwB7ZiKcvryRBms90Y1ng+9Dit?= =?us-ascii?Q?ezlA02trmw95KQH5HOoF8SvyRuXkMGp4ad8Xdyzoj+IxVxRIRPDG4GMrKc0F?= =?us-ascii?Q?Rvp+K+SLlFP6pR4oF8hpcbBt0OlvCltDH6T0yPFIJ+whXqhrkaDVETxEtxg0?= =?us-ascii?Q?gb3GzpuvqMtE4GNcWeLZkdtOFpZL62Oaeq0B2tDhJ2BawWlTEe+0eHtnaac+?= =?us-ascii?Q?Tx2NBvzjbv0vEJoy6e/N1pUHsFA2/KnQPV/m4hNAoqSDNLaSvxOAPjW8KTX+?= =?us-ascii?Q?kZ2LokNRsZTmT8rpDvTGNNnUgoARL8MaduzYldMJiOid29WQKWAsHXJVVrs+?= =?us-ascii?Q?NNilkRaphwYsufWjuu6gjZnRgGd+MQiRrzV8McRh9CbaHNvl+cc47jP82tvE?= =?us-ascii?Q?2GbWMnElOxRKeTbaINyWgM3UBie4bDQLGVXVoDKt5uxiBigpoe6ubdzKR1Om?= =?us-ascii?Q?/0mqY6C40negu/u1U949vbuV3s3PKB7aZXnm956MSnsvl36wRpdbjcDWMyLY?= =?us-ascii?Q?5IZD626KZnPRsu04UVjERKSaxIpy16WYqLsglrYTJsbe1BxXhrABDYidZhMi?= =?us-ascii?Q?f2tMSNHZBrA0P8IrflUDRAtID3Fw1SGu0b5Wz0ow6s8d/kY4ptVf3jtJ6y0u?= =?us-ascii?Q?evmIaMqgHudjrDYqV9MFmH0Vf42/x+7RXf0gVuxymCaUpWPN9S2tIcUHeq8V?= =?us-ascii?Q?0orqAAcsT5J4OMHQUDe0Jeqfdp0LWu9+eHBsO8/3RaXmaYIhW+lvHTr4YdfS?= =?us-ascii?Q?i+ER9QKc6D8g2Wa1R3wsDFMF3R3xX4bmjFNWjEbpCVHf94qQ1GNZDfDz4m8+?= =?us-ascii?Q?aErd9ziiZMmeAZ5z42PPbMPMiqDJvtHIo/7Qw0Ir?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: BdmwGFpl/soL5KM6apCGgJOQIjLWmJcDrECjQNqmClPjJ1gIns+6zqs79VORg8UocnXJBJ9+2EBVQv0+05p3wCJCpJyk+h3axCCVsnBD2OrJOgUczD8cVkQ/b8mVa5Oi3/A8ftUoiX+jXK5wSyCfji49+BfhIDl3Kzoj/HhPAvFESKHjyCA+vCDpr8GE9jkcgnxlq0BSXNRqu8v0iL7gA70aRrpBTu95umn6nObX6yhPbO6k1PitltabgdO2iXppxRBUAAZGh+iTtdJZV3TUXy3ccwiqG/hXSkRbYqJCnHRmDnV+GV3cqqkEjtfyJGFjZoXaL348+klm+3YHxPQZtTk4NEnLy5DTJOxhu2s38t/VRyi6fHImvfxoscas6hLQDV+EN0R9UrO1zQqp7PtXoip6z6QrD0xYIytC2pqB6ZVTCokQzsYD1hmYWKrWeYw5yGwHraB3I1sAcR9MDcp1UMFSOx++y9C3819k7PmSaltjQzKRicIy3Mbtx8mQzKLSDtCHHnO7paEECgfRMXBSMwvSCoou8K6RH6xFmuI326P4oENQl7BlBbVLv9mfKPLpTcXARfXudnkx42qn+fdTREyRzmqOJ4cv1fvuV8Sr8Co= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 857f0be5-2bcd-4c89-f430-08dccf528887 X-MS-Exchange-CrossTenant-AuthSource: LV8PR10MB7943.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Sep 2024 15:34:16.6064 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 9U1wv3EwFAbh5p5FjCzknDHFcy3LKeZyHi96jYhfT6lNplue3KBLz4NR0XogCdmi+re17lIzzsI5UHCS9KvPhg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR10MB4428 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.60.29 definitions=2024-09-07_07,2024-09-06_01,2024-09-02_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 suspectscore=0 mlxlogscore=955 malwarescore=0 bulkscore=0 spamscore=0 mlxscore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2408220000 definitions=main-2409070128 X-Proofpoint-ORIG-GUID: QMepSq1cEfPHpeLzlCZ7mw81lWejptJt X-Proofpoint-GUID: QMepSq1cEfPHpeLzlCZ7mw81lWejptJt X-Rspam-User: X-Stat-Signature: 5jpubxf5wgpbe4gsdaw8fa3akcwrktkj X-Rspamd-Queue-Id: 593EF40007 X-Rspamd-Server: rspam11 X-HE-Tag: 1725723269-944857 X-HE-Meta: U2FsdGVkX19l7lxcGOgz9QXHr4q+5dHGVVNPmaWlsW0Giux9dKHzfvxEuI1UCOeB4v2PpUCQsqO+3au0hOvHPCy2KGUYToiBKPUkIsW+mA6GhatJefU0961YaKV3w8KFyESipqJCOkoEMjrhySCHBtblMh4o48v/GAdcyBahrQ5P55MAbziW/7k8e3fT4IOzU26TlH+1oilSYFq5l9y3PfTNnp5ag+R8FrgRN+KtsHUs7M1aFuPwHww71NExQszR4C8s8bGJGWyhmGOPfEFOZ9mtJZ1vO94OGOeQGd7QjBmeWo0O6RuAgWzWJz3+/Sv+ZD0GOAbWd6+9kHp98nJCJ5VljtN8B/DzrXlgk/vCoiaNTgcz5mbuBfJCqPDEEvPzYE47R2brqEFY1L/Rmtdq6j4wdH9KadB7IB3S6zqlgeE7ABXfx3z1FhInJ7Vuy+EhkQ21M5z3vf6hFhpJ3xSjo/JtTJ4N9haZQfbmwW0mUHwS3+faEZG5+GhOq/H0uJF4kiYpZ6HtcGhpMO5XZFNNq/Y0foud0RX+ZcyW5yHXPLsECl9xfcdroE4GtA2e8scN3qQMuaJygMn37C9gr3nyKy1aF62/Ul9Yn871SAVVNUK72TsOKdKLvhjN8gMLa51irD583T5sxbCSxQGwXEx+B18Iaq0PGpP0dUKogUCoO6+a3wXW42n0+3ANLxQKp7CCwf6YCjzB6HXepdjjnfnsqRW7C8sUKOUs2Z5D1HDdGABoknxbwrKECSCRPGZD5RXWIc+XFJ6CcbJwTqRspJ83J5MZxCOsNyFNNCoAG6bj7tg0iOkJvVpOauqWQx9e53Wn8ail7aR0jrCH75Curv258SvaM3ZujmNXU2zVfuNA7c1BP09RZ8YbvIneE24k0+qesocgbtaSgFpBFqpPU6g7CPn7VhO17+eVo5FvkybcYDFyIF8RXR9JJYK5+U7Vgiea2YlLziICZgjprHvEUDc 9eDREEmj VegHQYd0ukzQl0XUQDwfnTO/fA0nJtcS9cQ/xBxhYDzuDAGtxu8gxWh+7xtgZEwsCBxJHZiqI+SZAxQgBVatVS6q2I5EyX7mjYf7Q8m3QXpsUZJDE0X8qr3dZQZvYpBZDJ3JUQCFm0GrqEYtsJnGRMB0xFaOLvUVwCJ7fmyX1S2laZbo2Lzj4yTng45mxRlhF+nyq4mcuqYJ8YVv1xRKMJEWNwjXXeO5rjUy4hxBDdnYpe7NekgIxQMmGH9cGhEws9yLfpZUupqp9d4ux+d+EtR5TCZcYI/AOd8Rcqwn32IhK2Qsv6EtYEPRNjYJS6nAR9OcQ/iBa9c+/TRzLLTZmpoU6k+kg1DS3fGrbSQaBwM1KCKbP3+3dVeULM3Ri/KQfry9DQwIRTV6G/eSfNUepLK25fuv6Nx01YG/EgZe5vVLidmqOvY86R7PIKEW4nxhqu78pF/e8M4kOnqW9l+G99ECdOhp1K16HTuSv4QPzvvNpgs9wko8JPrJ2MQ8iy6yFHKHHp5WOn+0b5mRmB3f6Gtx35v2bAk+u9zVye3b1N2jtjbBON2oedgdEnegMRHDVJIwVkkB/iUTVZQ0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: * Shakeel Butt [240906 19:05]: > The tracing of invalidation and truncation operations on large files > showed that xa_get_order() is among the top functions where kernel > spends a lot of CPUs. xa_get_order() needs to traverse the tree to reach > the right node for a given index and then extract the order of the > entry. However it seems like at many places it is being called within an > already happening tree traversal where there is no need to do another > traversal. Just use xas_get_order() at those places. > > Signed-off-by: Shakeel Butt This change alters areas that already do the rcu locking and the internal state of the xas isn't altered, so the external loops are not affected, afaict. Looks good to me. Reviewed-by: Liam R. Howlett > --- > mm/filemap.c | 6 +++--- > mm/shmem.c | 2 +- > 2 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/mm/filemap.c b/mm/filemap.c > index 070dee9791a9..7e3412941a8d 100644 > --- a/mm/filemap.c > +++ b/mm/filemap.c > @@ -2112,7 +2112,7 @@ unsigned find_lock_entries(struct address_space *mapping, pgoff_t *start, > VM_BUG_ON_FOLIO(!folio_contains(folio, xas.xa_index), > folio); > } else { > - nr = 1 << xa_get_order(&mapping->i_pages, xas.xa_index); > + nr = 1 << xas_get_order(&xas); > base = xas.xa_index & ~(nr - 1); > /* Omit order>0 value which begins before the start */ > if (base < *start) > @@ -3001,7 +3001,7 @@ static inline loff_t folio_seek_hole_data(struct xa_state *xas, > static inline size_t seek_folio_size(struct xa_state *xas, struct folio *folio) > { > if (xa_is_value(folio)) > - return PAGE_SIZE << xa_get_order(xas->xa, xas->xa_index); > + return PAGE_SIZE << xas_get_order(xas); > return folio_size(folio); > } > > @@ -4297,7 +4297,7 @@ static void filemap_cachestat(struct address_space *mapping, > if (xas_retry(&xas, folio)) > continue; > > - order = xa_get_order(xas.xa, xas.xa_index); > + order = xas_get_order(&xas); > nr_pages = 1 << order; > folio_first_index = round_down(xas.xa_index, 1 << order); > folio_last_index = folio_first_index + nr_pages - 1; > diff --git a/mm/shmem.c b/mm/shmem.c > index 866d46d0c43d..4002c4f47d4d 100644 > --- a/mm/shmem.c > +++ b/mm/shmem.c > @@ -893,7 +893,7 @@ unsigned long shmem_partial_swap_usage(struct address_space *mapping, > if (xas_retry(&xas, page)) > continue; > if (xa_is_value(page)) > - swapped += 1 << xa_get_order(xas.xa, xas.xa_index); > + swapped += 1 << xas_get_order(&xas); > if (xas.xa_index == max) > break; > if (need_resched()) { > -- > 2.43.5 > >