From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AC29FEB64D8 for ; Tue, 13 Jun 2023 14:21:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2247F6B0078; Tue, 13 Jun 2023 10:21:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1AD998E0003; Tue, 13 Jun 2023 10:21:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F41938E0002; Tue, 13 Jun 2023 10:20:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id E45E26B0078 for ; Tue, 13 Jun 2023 10:20:59 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id AE4FBA04D7 for ; Tue, 13 Jun 2023 14:20:59 +0000 (UTC) X-FDA: 80897936238.18.DED19F7 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf07.hostedemail.com (Postfix) with ESMTP id EED8E4001E for ; Tue, 13 Jun 2023 14:20:55 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="Uky3/qoA"; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf07.hostedemail.com: domain of dakr@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=dakr@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1686666056; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=cZEUY4eFrIiW2hJOSDRcVK2BXCKkst+J0Ig7f66lGys=; b=ENPwKxWDKN9OEloAMoP/ubfw+SVTcswiIFEJXOJeyo3rW5Ylk9V1Wg663kjpfKqwOzE3Ek B0XzE37cfNwPNfnFQngXbuquqXWOQFTAuHG6WWOcx5rDLXYQQffB8kwIKiVvo+5LhXmMxJ P87EbkYPImJPpVBKt0AfbB8iBgJ8z/s= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="Uky3/qoA"; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf07.hostedemail.com: domain of dakr@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=dakr@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1686666056; a=rsa-sha256; cv=none; b=SSEzUOGVkUcMsuvFDeUc0BGh0oXcO4tF3Fo4iYPRUQerbAgdY0caGN/Tmh1j2N8rnwh8p9 jrnIno78teNqMnU9BY1lLYBc8xYLB7RRIS1zlYWP+8GxKYi9TFfLajVd4ibuQIVFI0MK8X WP/+Jy4g9BX1SOypKIwgkdFSW3esLAU= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1686666054; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=cZEUY4eFrIiW2hJOSDRcVK2BXCKkst+J0Ig7f66lGys=; b=Uky3/qoAbBQ+FGY3/mmGr8RKo7LZtE+Cez03xW9aHOYVAbEgurw9nxfx4+XU+Edo+3IJWm rRMzn3sj0MKq8/KpyT9vX+YRRB/RPTZ3eMdhqbD4LTSVU/2KE5jPaCeJHKjUgUgJsmYx5i BmE8tLRHBBp4CN4w4bQ+hQ/4rQMfU3g= Received: from mail-ej1-f71.google.com (mail-ej1-f71.google.com [209.85.218.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-221-agC_A6KoPRadVjLAYEFl1A-1; Tue, 13 Jun 2023 10:20:47 -0400 X-MC-Unique: agC_A6KoPRadVjLAYEFl1A-1 Received: by mail-ej1-f71.google.com with SMTP id a640c23a62f3a-977e50b0120so607060566b.0 for ; Tue, 13 Jun 2023 07:20:45 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686666044; x=1689258044; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=cZEUY4eFrIiW2hJOSDRcVK2BXCKkst+J0Ig7f66lGys=; b=QovywvCBT5V4oCegaMp3o+Zj531qRhJ82ID/zLSNATikOysEfBlWhpeSzeWMJRZCor GnVsxYCMT1wK84jyG0QYZTCHnH8sJhiiKYkMn4CVST18y4LhY6eiZheLFg/aW6U+HsdI EnTMbCW8O6xJBfbuk3oNJVMlMnSuu3sp0olLOaTCuZHap7iulaUKLQ2+Ui/YL8xycy7b JvLjgV2QOOMdtxCi89yRu3O48jDDappDeUtZn3Ft8xzCJBHIPAYT9UyT0PF8PslJIjR3 E5L4OAVJTKkwI4vv10idXf5tXzksz+LD0YHzTGIJ5mzwA54yCaHd7tblbVNzW8TagfMU LChg== X-Gm-Message-State: AC+VfDxGrpKj86exfOjzYXuaEIwEGSNB+AoYbJDVR7oM4AFW8d6/h2+N o3hNdap1/rvimIZvvBBY1O3yKTkRVoXnsC6KDWdAwA5GUQm51wOrdmq4R2AFhVSOq8XpEjdsnKT /YCJoeD3d8SA= X-Received: by 2002:a17:907:809:b0:977:cbaf:bc56 with SMTP id wv9-20020a170907080900b00977cbafbc56mr13671255ejb.43.1686666044419; Tue, 13 Jun 2023 07:20:44 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4ad5nom20kLaHoCm86c18wBjHdHRHf+yMBQw0AQn5oLgUB+K/pfcP4C4uj6QCUmqL4FWtcyQ== X-Received: by 2002:a17:907:809:b0:977:cbaf:bc56 with SMTP id wv9-20020a170907080900b00977cbafbc56mr13671233ejb.43.1686666044074; Tue, 13 Jun 2023 07:20:44 -0700 (PDT) Received: from ?IPV6:2a02:810d:4b3f:de9c:642:1aff:fe31:a15c? ([2a02:810d:4b3f:de9c:642:1aff:fe31:a15c]) by smtp.gmail.com with ESMTPSA id e24-20020a170906081800b009786c8249d6sm6855650ejd.175.2023.06.13.07.20.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 13 Jun 2023 07:20:43 -0700 (PDT) Message-ID: <67ffef18-fae4-cb84-ff75-c4eed92a8755@redhat.com> Date: Tue, 13 Jun 2023 16:20:41 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH drm-next v4 00/14] [RFC] DRM GPUVA Manager & Nouveau VM_BIND UAPI To: Donald Robson Cc: "corbet@lwn.net" , "jason@jlekstrand.net" , "willy@infradead.org" , "christian.koenig@amd.com" , "tzimmermann@suse.de" , "bagasdotme@gmail.com" , "mripard@kernel.org" , "matthew.brost@intel.com" , "bskeggs@redhat.com" , "ogabbay@kernel.org" , "boris.brezillon@collabora.com" , "Liam.Howlett@oracle.com" , "daniel@ffwll.ch" , "alexdeucher@gmail.com" , "airlied@gmail.com" , "dri-devel@lists.freedesktop.org" , "nouveau@lists.freedesktop.org" , "linux-mm@kvack.org" , "linux-doc@vger.kernel.org" , "linux-kernel@vger.kernel.org" References: <20230606223130.6132-1-dakr@redhat.com> From: Danilo Krummrich Organization: RedHat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: EED8E4001E X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: x8tzfhd1gui5tw96ukojnp9rjseor3me X-HE-Tag: 1686666055-431807 X-HE-Meta: U2FsdGVkX1+QEnjBt1To1CZT/M0NwrJBwmKnR4G3hd/5QV69jf7QLnFtZhe/f/mG479vWi2LzT9AXGWURakzawjrUB78zD3Dqpn02eZ70zW/q/cRtWLeD7hppUcCC/Nh5PQpGwZTzL0ETo3X/I6zhAmyCslf4fv5C5mYowUmZ4VbFyYByShdPfrQ7y4cn1/+LuktwOIYTb5NRaoUJ1UzBfnCYJ3UKl2Y0pgdYZGQFeqBZVNy2k8zD/njXxDrNYTNEBdX8sN/Sgn+me7Tj1RkybREDD8RI6jlaODjIepcYS1S6ioRgs5xkkeU81m4ND7SpnYBafoINlDy7JVFHZ2y78Aq3EQhbPexow50fu+ThEWTS6zB1qoEEVXNdEYhMwG5AQRV6CyATrBnQ3vH/6aDg5+mHmXkEgkLHFZrcMvAGjHchI+gQLgufQCh7B+GO3lEnnVKS9/2uXR7wMNWcwxb4tA188IrZIfQKkRJNkJWRGDw3TaldGi6+dA8kwJdbXAdSB8hOaTJF/5z1LgJUchUvSufa/FY97eVuvmig/eFNh4WlzfBNLKehA87/ojQjrD2gvROtdm0Mw0eWCeoIPWTG2ZQmERv9X7LNkXgsMPUzIqPuFZ8/gxHkzyuuldIMNKKyB86h+xHxMxgzVp0I27Qd/WHUx570OoGtMkyI0wNcGvT9J2Jb+LFoMuZ/AiDZQ99fwfmLiDqQ7nSy185epBIQhVi9Z3ZcnTuI74LgmmMKELKNjbAvjf0Y41y1PM9sNTW+4DOtAEKy5xQK9H8P/nMwCBWYpxhuzfEIvhQCU1XDysA5dWwOqsaLukJxuvbNAMiQbSFtP76UCCH4fODouTPiB7oi2Q2Vs0/r549JofWccvbKtN4SlLXsIBBeevCJl1mfJfU0KPMSANlz2FAu48RnMiJ/QM+QdpocNq1R/lYz/+Mtb5A+2D8hV61obt1zzLa7sPg4OUyGBBaS3oNVe0 oKAlUw31 Mp8S68VW9sdDT6v59xn9zhNa5c3atFfgApohXCyRW7csjG8c6JcZp8YgGfMw1YT+MgwRzh8EKiDnqDsSuyHJMoXb4hlVTVu6UtDjM0nZ2ZlkTNnisD8jRCwuoMAKq4gYtavNLXLmxdDG2GKg7oHOOgsV0Rf8WeoX1zs3jKudZ0x7YqQlrWb6Zx0tftgObaWRBMc0mtuV92bSt+la1faATpW59PsAvMeZP1DtnvtPzV2EQwg3hWv4xSN91kmwmNSw+oaFjgXMXKQsmV4bjLjZ2Ax9jFEWNVxyHkBsgKIN+WwiWNQMIdDJfmh0M8ix72oY68cPxCyaVHXTw74n5NwPrev/wWg4Ee1e3you8eGFDE0Ibr451bfs/63ToTobpY3Ik+GAO4xb7nKQZlruDPxQFZsytBpoBWOw50H1E3SKzIoj9JXVYDoN7DYcwbVq11yovVc1IbqHBRkx4f8dFCiADYW2AovcbF9z/eUmg9XEVbohimUx18HrrVVRYPeuSKJ9bNiEkEHKI5wH6FHJMf0DUHNOIlkKnndG3w5FdH+o53XINg5js5e3ILGGwZJQioAjoe45PkCkodM4knyWnLHQA6Gmn83zeH2OK95rc69TFxtHbiOE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Donald, On 6/9/23 13:56, Donald Robson wrote: > On Wed, 2023-06-07 at 00:31 +0200, Danilo Krummrich wrote: >> >> Christian König (1): >> drm: execution context for GEM buffers v4 >> >> Danilo Krummrich (13): >> maple_tree: split up MA_STATE() macro >> drm: manager to keep track of GPUs VA mappings > > I have tested the drm GPUVA manager as part of using it with our new > driver. The link below shows use of the drm_gpuva_sm_[un]map() > functions. I think this is based on the v3 patches, but I have also > tried it locally using v4 patches. We will be submitting this > driver for review soon. That's awesome - thank your for taking the effort! > > https://gitlab.freedesktop.org/sarah-walker-imgtec/powervr/-/blob/dev/v3/drivers/gpu/drm/imagination/pvr_vm.c > > In a previous incarnation, I used the drm_gpuva_insert() and > drm_gpuva_remove() functions directly. In some now abandoned work I > used the drm_gpuva_sm_[un]map_ops_create() route. > > The only problem I encountered along the way was the maple tree init > issue already reported by Boris and fixed in v4. One caveat - as > our driver is a work in progress our testing is limited to certain > Sascha Willem tests. > > I did find it quite difficult to get the prealloc route with > drm_gpuva_sm_[un]map() working. I'm not sure to what degree this > reflects me being a novice on matters DRM, but I did find myself > wishing for more direction, even with Boris's help. I'm definitely up improving the existing documentation. Anything in particular you think should be described in more detail? - Danilo > > Tested-by: Donald Robson > >> drm: debugfs: provide infrastructure to dump a DRM GPU VA space >> drm/nouveau: new VM_BIND uapi interfaces >> drm/nouveau: get vmm via nouveau_cli_vmm() >> drm/nouveau: bo: initialize GEM GPU VA interface >> drm/nouveau: move usercopy helpers to nouveau_drv.h >> drm/nouveau: fence: separate fence alloc and emit >> drm/nouveau: fence: fail to emit when fence context is killed >> drm/nouveau: chan: provide nouveau_channel_kill() >> drm/nouveau: nvkm/vmm: implement raw ops to manage uvmm >> drm/nouveau: implement new VM_BIND uAPI >> drm/nouveau: debugfs: implement DRM GPU VA debugfs >>