From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E3AD0C433F5 for ; Tue, 29 Mar 2022 02:12:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 372398D0002; Mon, 28 Mar 2022 22:12:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 321AF8D0001; Mon, 28 Mar 2022 22:12:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1E9948D0002; Mon, 28 Mar 2022 22:12:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0027.hostedemail.com [216.40.44.27]) by kanga.kvack.org (Postfix) with ESMTP id 0CA498D0001 for ; Mon, 28 Mar 2022 22:12:32 -0400 (EDT) Received: from smtpin27.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id B4C2AA0A09 for ; Tue, 29 Mar 2022 02:12:31 +0000 (UTC) X-FDA: 79295799702.27.F75A7EF Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by imf21.hostedemail.com (Postfix) with ESMTP id A6B041C0003 for ; Tue, 29 Mar 2022 02:12:30 +0000 (UTC) Received: from canpemm500002.china.huawei.com (unknown [172.30.72.56]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4KSCkM1X1MzZfh8; Tue, 29 Mar 2022 10:12:11 +0800 (CST) Received: from [10.174.177.76] (10.174.177.76) by canpemm500002.china.huawei.com (7.192.104.244) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21; Tue, 29 Mar 2022 10:12:26 +0800 Subject: Re: [PATCH] mm: shmem: make shmem_init return void To: Muchun Song , Andrew Morton CC: Hugh Dickins , Linux Memory Management List , LKML References: <20220328112707.22217-1-linmiaohe@huawei.com> From: Miaohe Lin Message-ID: <67fb3ff7-f46a-985d-94ac-698885eb43c5@huawei.com> Date: Tue, 29 Mar 2022 10:12:26 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.177.76] X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To canpemm500002.china.huawei.com (7.192.104.244) X-CFilter-Loop: Reflected X-Stat-Signature: p19cdodqrzbfwgp1jzfwigiehf7fwar6 X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: A6B041C0003 Authentication-Results: imf21.hostedemail.com; dkim=none; spf=pass (imf21.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com X-Rspam-User: X-HE-Tag: 1648519950-905446 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2022/3/28 22:50, Muchun Song wrote: > On Mon, Mar 28, 2022 at 7:44 PM Miaohe Lin wrote: >> >> The return value of shmem_init is never used. So we can make it >> return void now. >> >> Signed-off-by: Miaohe Lin >> --- >> include/linux/shmem_fs.h | 2 +- >> mm/shmem.c | 9 ++++----- >> 2 files changed, 5 insertions(+), 6 deletions(-) >> >> diff --git a/include/linux/shmem_fs.h b/include/linux/shmem_fs.h >> index ab51d3cd39bd..3e915cc550bc 100644 >> --- a/include/linux/shmem_fs.h >> +++ b/include/linux/shmem_fs.h >> @@ -56,7 +56,7 @@ static inline struct shmem_inode_info *SHMEM_I(struct inode *inode) >> * Functions in mm/shmem.c called directly from elsewhere: >> */ >> extern const struct fs_parameter_spec shmem_fs_parameters[]; >> -extern int shmem_init(void); >> +extern void shmem_init(void); >> extern int shmem_init_fs_context(struct fs_context *fc); >> extern struct file *shmem_file_setup(const char *name, >> loff_t size, unsigned long flags); >> diff --git a/mm/shmem.c b/mm/shmem.c >> index 529c9ad3e926..26e09a022087 100644 >> --- a/mm/shmem.c >> +++ b/mm/shmem.c >> @@ -3879,7 +3879,7 @@ static struct file_system_type shmem_fs_type = { >> .fs_flags = FS_USERNS_MOUNT, >> }; >> >> -int __init shmem_init(void) >> +void __init shmem_init(void) >> { >> int error; >> >> @@ -3904,14 +3904,13 @@ int __init shmem_init(void) >> else >> shmem_huge = SHMEM_HUGE_NEVER; /* just in case it was patched */ >> #endif >> - return 0; >> + return; >> >> out1: >> unregister_filesystem(&shmem_fs_type); >> out2: >> shmem_destroy_inodecache(); >> shm_mnt = ERR_PTR(error); >> - return error; >> } >> >> #if defined(CONFIG_TRANSPARENT_HUGEPAGE) && defined(CONFIG_SYSFS) >> @@ -3989,14 +3988,14 @@ static struct file_system_type shmem_fs_type = { >> .fs_flags = FS_USERNS_MOUNT, >> }; >> >> -int __init shmem_init(void) >> +void __init shmem_init(void) >> { >> BUG_ON(register_filesystem(&shmem_fs_type) != 0); >> >> shm_mnt = kern_mount(&shmem_fs_type); >> BUG_ON(IS_ERR(shm_mnt)); >> >> - return 0; >> + return; > > Weird. Using return at the end of a void function. Thanks for review. And thanks Andrew for kindly fixing this. :) > . >