From: Dan Williams <dan.j.williams@intel.com>
To: Nhat Pham <nphamcs@gmail.com>, Dan Williams <dan.j.williams@intel.com>
Cc: <akpm@linux-foundation.org>, <hannes@cmpxchg.org>,
<yosry.ahmed@linux.dev>, <chengming.zhou@linux.dev>,
<sj@kernel.org>, <linux-mm@kvack.org>, <kernel-team@meta.com>,
<linux-kernel@vger.kernel.org>, <gourry@gourry.net>,
<ying.huang@linux.alibaba.com>, <jonathan.cameron@huawei.com>,
<linux-cxl@vger.kernel.org>, <minchan@kernel.org>,
<senozhatsky@chromium.org>
Subject: Re: [PATCH v2] zsmalloc: prefer the the original page's node for compressed data
Date: Wed, 2 Apr 2025 16:22:23 -0700 [thread overview]
Message-ID: <67edc6af95e8e_1c2c62941a@dwillia2-xfh.jf.intel.com.notmuch> (raw)
In-Reply-To: <CAKEwX=PBp4i4DmCf_7r+Sk6ekB9ckgZEpuR-x4f0CTc00-d+BQ@mail.gmail.com>
Nhat Pham wrote:
> On Wed, Apr 2, 2025 at 2:41 PM Dan Williams <dan.j.williams@intel.com> wrote>
> >
> > Why do the work to pass in @nid only to hardcode 0 to
> > alloc_pages_node()?
>
> That 0 is the order, i.e we want a single page here :)
>
> The node id is the first argument of alloc_pages_node. I made the same
> mistake in one of the earlier versions of this patch series (which,
> fortunately I did not send out) - hopefully this time I'm correct :)
Oops, sorry for the noise. My eyes were so trained on @nid as the final
argument in all the other conversions that I overlooked that.
You can add:
Acked-by: Dan Williams <dan.j.williams@intel.com>
next prev parent reply other threads:[~2025-04-02 23:22 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-02 20:44 Nhat Pham
2025-04-02 21:41 ` Dan Williams
2025-04-02 21:51 ` Nhat Pham
2025-04-02 23:22 ` Dan Williams [this message]
2025-04-03 3:18 ` Chengming Zhou
2025-04-03 3:55 ` Sergey Senozhatsky
2025-04-03 15:05 ` Nhat Pham
2025-04-03 15:55 ` Jonathan Cameron
2025-04-03 16:38 ` Johannes Weiner
2025-04-22 11:47 ` Yosry Ahmed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=67edc6af95e8e_1c2c62941a@dwillia2-xfh.jf.intel.com.notmuch \
--to=dan.j.williams@intel.com \
--cc=akpm@linux-foundation.org \
--cc=chengming.zhou@linux.dev \
--cc=gourry@gourry.net \
--cc=hannes@cmpxchg.org \
--cc=jonathan.cameron@huawei.com \
--cc=kernel-team@meta.com \
--cc=linux-cxl@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=minchan@kernel.org \
--cc=nphamcs@gmail.com \
--cc=senozhatsky@chromium.org \
--cc=sj@kernel.org \
--cc=ying.huang@linux.alibaba.com \
--cc=yosry.ahmed@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox