Re: [PATCH] slub: let need_slab_obj_exts() return false if SLAB_NO_OBJ_EXT is set

[Vlastimil Babka <vbabka@suse.cz>]

On 2/6/26 01:53, Harry Yoo wrote:
> On Thu, Feb 05, 2026 at 08:07:23PM +0800, Hao Li wrote:
>> SLAB_NO_OBJ_EXT is set for boot caches, but need_slab_obj_exts() doesn't
>> check this flag. We should return false unconditionally when
>> SLAB_NO_OBJ_EXT is set.
>> 
>> Signed-off-by: Hao Li <hao.li@linux.dev>
>> ---
> 
> Looks reasonable to me,
> Acked-by: Harry Yoo <harry.yoo@oracle.com>

Thanks, added to slab/for-7.0/obj_metadata
I think it doesn't change anything at the moment? But a correct thing to do.

> Thanks!
> 
>>  mm/slub.c | 3 +++
>>  1 file changed, 3 insertions(+)
>> 
>> diff --git a/mm/slub.c b/mm/slub.c
>> index 865047eaf02b..3b1402e1c39d 100644
>> --- a/mm/slub.c
>> +++ b/mm/slub.c
>> @@ -901,6 +901,9 @@ static inline unsigned long get_orig_size(struct kmem_cache *s, void *object)
>>   */
>>  static inline bool need_slab_obj_exts(struct kmem_cache *s)
>>  {
>> +	if (s->flags & SLAB_NO_OBJ_EXT)
>> +		return false;
>> +
>>  	if (memcg_kmem_online() && (s->flags & SLAB_ACCOUNT))
>>  		return true;
>>  
>