From: Dan Williams <dan.j.williams@intel.com>
To: Nhat Pham <nphamcs@gmail.com>, Dan Williams <dan.j.williams@intel.com>
Cc: <linux-mm@kvack.org>, <akpm@linux-foundation.org>,
<hannes@cmpxchg.org>, <yosry.ahmed@linux.dev>,
<chengming.zhou@linux.dev>, <sj@kernel.org>,
<kernel-team@meta.com>, <linux-kernel@vger.kernel.org>,
<gourry@gourry.net>, <willy@infradead.org>,
<ying.huang@linux.alibaba.com>, <jonathan.cameron@huawei.com>,
<linux-cxl@vger.kernel.org>, <minchan@kernel.org>,
<senozhatsky@chromium.org>
Subject: Re: [RFC PATCH 1/2] zsmalloc: let callers select NUMA node to store the compressed objects
Date: Mon, 31 Mar 2025 16:22:51 -0700 [thread overview]
Message-ID: <67eb23cbcd0b7_11987294fd@dwillia2-xfh.jf.intel.com.notmuch> (raw)
In-Reply-To: <CAKEwX=OEQKdoWbyAO=LKE--ssLzBH0UVhz3EYaCiodpbMtQvKw@mail.gmail.com>
Nhat Pham wrote:
[..]
> That still leaves zram though. zram is more complicated than zswap -
> it has multiple allocation paths, so I don't want to touch it quite
> yet (and preferably a zram maintainer/developer should do it). :) Or
> if zram maintainers are happy with NUMA_NO_NODE, then we can
> completely get rid of the pointer arguments etc.
At a minimum make the argument a "const int *" so it does not look like
the value can be changed by the leaf functions.
...but I would challenge zram folks to ack/nak that change rather than
maintain old behavior based purely on momentum. I.e. add to the commit
message an "exclude zswap from this policy for $explicit_reason"
statement rather than the current $implicit_guess that the old behavior
is there for "reasons".
next prev parent reply other threads:[~2025-03-31 23:23 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-29 11:02 [RFC PATCH 0/2] zswap: fix placement inversion in memory tiering systems Nhat Pham
2025-03-29 11:02 ` [RFC PATCH 1/2] zsmalloc: let callers select NUMA node to store the compressed objects Nhat Pham
2025-03-31 22:17 ` Dan Williams
2025-03-31 23:03 ` Nhat Pham
2025-03-31 23:22 ` Dan Williams [this message]
2025-04-01 1:13 ` Nhat Pham
2025-03-29 11:02 ` [RFC PATCH 2/2] zswap: add sysfs knob for same node mode Nhat Pham
2025-03-29 19:53 ` [RFC PATCH 0/2] zswap: fix placement inversion in memory tiering systems Yosry Ahmed
2025-03-29 22:13 ` Nhat Pham
2025-03-29 22:17 ` Nhat Pham
2025-03-31 16:53 ` Johannes Weiner
2025-03-31 17:32 ` Nhat Pham
2025-03-31 17:06 ` Gregory Price
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=67eb23cbcd0b7_11987294fd@dwillia2-xfh.jf.intel.com.notmuch \
--to=dan.j.williams@intel.com \
--cc=akpm@linux-foundation.org \
--cc=chengming.zhou@linux.dev \
--cc=gourry@gourry.net \
--cc=hannes@cmpxchg.org \
--cc=jonathan.cameron@huawei.com \
--cc=kernel-team@meta.com \
--cc=linux-cxl@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=minchan@kernel.org \
--cc=nphamcs@gmail.com \
--cc=senozhatsky@chromium.org \
--cc=sj@kernel.org \
--cc=willy@infradead.org \
--cc=ying.huang@linux.alibaba.com \
--cc=yosry.ahmed@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox