From: Mark Brown <broonie@kernel.org>
To: Kevin Brodsky <kevin.brodsky@arm.com>
Cc: linux-mm@kvack.org, linux-kselftest@vger.kernel.org,
linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
David Hildenbrand <david@kernel.org>,
Lorenzo Stoakes <lorenzo.stoakes@oracle.com>,
Ryan Roberts <ryan.roberts@arm.com>,
Shuah Khan <shuah@kernel.org>, Usama Anjum <Usama.Anjum@arm.com>
Subject: Re: [PATCH 4/4] selftests/mm: fix exit code in pagemap_ioctl
Date: Wed, 17 Dec 2025 10:08:42 +0000 [thread overview]
Message-ID: <67e61dd6-2a44-42f5-980e-e9196d672540@sirena.org.uk> (raw)
In-Reply-To: <20251216142633.2401447-5-kevin.brodsky@arm.com>
[-- Attachment #1: Type: text/plain, Size: 618 bytes --]
On Tue, Dec 16, 2025 at 02:26:33PM +0000, Kevin Brodsky wrote:
> pagemap_ioctl always reports success, whether the tests succeeded or
> not. Call ksft_finished() to report the right status.
> While at it also fix the exit code in unexpected situations:
This is a general sign that you should have muliple patches...
> - Report FAIL if we failed to open /proc/self/pagemap (returning
> -EINVAL from main() is meaningless)
If you do a new version it's probably worth noting that this is a
non-optional feature introduced a long time ago so the open should never
fail.
Reviewed-by: Mark Brown <broonie@kernel.org>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2025-12-17 10:08 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-16 14:26 [PATCH 0/4] Various mm kselftests improvements/fixes Kevin Brodsky
2025-12-16 14:26 ` [PATCH 1/4] selftests/mm: remove flaky header check Kevin Brodsky
2025-12-17 3:18 ` Yunsheng Lin
2025-12-17 9:58 ` Kevin Brodsky
2025-12-18 7:21 ` Yunsheng Lin
2025-12-17 10:04 ` Mark Brown
2025-12-18 13:24 ` Kevin Brodsky
2025-12-18 14:25 ` Mark Brown
2025-12-29 15:40 ` Kevin Brodsky
2025-12-16 14:26 ` [PATCH 2/4] selftests/mm: pass down full CC and CFLAGS to check_config.sh Kevin Brodsky
2025-12-18 8:04 ` David Hildenbrand (Red Hat)
2025-12-16 14:26 ` [PATCH 3/4] selftests/mm: fix faulting-in code in pagemap_ioctl test Kevin Brodsky
2025-12-16 14:56 ` Ryan Roberts
2025-12-16 15:11 ` Kevin Brodsky
2025-12-18 8:05 ` David Hildenbrand (Red Hat)
2025-12-18 13:18 ` Kevin Brodsky
2025-12-19 8:29 ` David Hildenbrand (Red Hat)
2025-12-29 11:46 ` Kevin Brodsky
2025-12-16 14:26 ` [PATCH 4/4] selftests/mm: fix exit code in pagemap_ioctl Kevin Brodsky
2025-12-16 14:58 ` Ryan Roberts
2025-12-17 10:08 ` Mark Brown [this message]
2025-12-18 13:20 ` Kevin Brodsky
2025-12-18 8:07 ` David Hildenbrand (Red Hat)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=67e61dd6-2a44-42f5-980e-e9196d672540@sirena.org.uk \
--to=broonie@kernel.org \
--cc=Usama.Anjum@arm.com \
--cc=akpm@linux-foundation.org \
--cc=david@kernel.org \
--cc=kevin.brodsky@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=ryan.roberts@arm.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox