From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7CDA1C48286 for ; Tue, 6 Feb 2024 08:18:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 060B56B006E; Tue, 6 Feb 2024 03:18:31 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 0104F6B0071; Tue, 6 Feb 2024 03:18:30 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E1B226B0072; Tue, 6 Feb 2024 03:18:30 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id CFAC06B006E for ; Tue, 6 Feb 2024 03:18:30 -0500 (EST) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 95059C0801 for ; Tue, 6 Feb 2024 08:18:30 +0000 (UTC) X-FDA: 81760677180.17.A67A601 Received: from out30-119.freemail.mail.aliyun.com (out30-119.freemail.mail.aliyun.com [115.124.30.119]) by imf01.hostedemail.com (Postfix) with ESMTP id 5138A40011 for ; Tue, 6 Feb 2024 08:18:26 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=as48I4e6; dmarc=pass (policy=none) header.from=linux.alibaba.com; spf=pass (imf01.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.119 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1707207508; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=n4L712Wu1atDoWRSzGANCoeLDJJJ+/sOVHYz/0n8058=; b=nlyNH5uQQefVy5Y7IzkaOtKRL3B6pIsWTCQ94/SkgsMkIFIC5djAtPtchIkdDPiXkNjGot R+ZmkCXA5zYtmMiYwWEdMjee6fnUyVtNxcq0h/BUmvGRy/56dussLKcSnzZ9Z5hYAbT7eM pC9CFYHLF7Kn8htJTEZw/5ZwQpJzP1Y= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=as48I4e6; dmarc=pass (policy=none) header.from=linux.alibaba.com; spf=pass (imf01.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.119 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1707207508; a=rsa-sha256; cv=none; b=x2rFbaFn73zskpZuxBpehqSys/hNlh5MXlrqiBP5BTFLR0tXpl0EpnjmrCX6ltcqJcwklz fYO92T0fdAD2azBALqbUcdUODqktY5daxbfbWf9kC7aLOCA5j4FQWCj4wSGfSfhKI/Vuyf O3xQES/4piy9tSaV9iCjo2MuCrbhN0g= DKIM-Signature:v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.alibaba.com; s=default; t=1707207504; h=Message-ID:Date:MIME-Version:Subject:To:From:Content-Type; bh=n4L712Wu1atDoWRSzGANCoeLDJJJ+/sOVHYz/0n8058=; b=as48I4e6lOZVB1c5zIx1hULRCIt2645ZSkGQc/pFnXDI7YiwVbCuRG+UK+NCJkl1T0eTo2X+V1fEBacMzgzTZpMz2wDLPt6ifsTLPu85zT7zlh3lHQHk+kRprs/EqMoF9C8miuLdjJ2MMM1RstPCL7JkpnOfWOZ9RrvXJQd89nE= X-Alimail-AntiSpam:AC=PASS;BC=-1|-1;BR=01201311R141e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018045170;MF=baolin.wang@linux.alibaba.com;NM=1;PH=DS;RN=7;SR=0;TI=SMTPD_---0W0CysvU_1707207502; Received: from 30.97.56.127(mailfrom:baolin.wang@linux.alibaba.com fp:SMTPD_---0W0CysvU_1707207502) by smtp.aliyun-inc.com; Tue, 06 Feb 2024 16:18:23 +0800 Message-ID: <67e0d81f-7125-455c-b02f-a9e675d55c6c@linux.alibaba.com> Date: Tue, 6 Feb 2024 16:18:22 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH] mm: hugetlb: remove __GFP_THISNODE flag when dissolving the old hugetlb To: Michal Hocko Cc: akpm@linux-foundation.org, muchun.song@linux.dev, osalvador@suse.de, david@redhat.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <6f26ce22d2fcd523418a085f2c588fe0776d46e7.1706794035.git.baolin.wang@linux.alibaba.com> <3f31cd89-f349-4f9e-bc29-35f29f489633@linux.alibaba.com> <909cee7d-0201-4429-b85d-7d2662516e45@linux.alibaba.com> <2613b670-84f8-4f97-ab4e-0d480fc1a3f8@linux.alibaba.com> From: Baolin Wang In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 5138A40011 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: ib37kqkk5e1jcq5x757oxbgem6rbru5s X-HE-Tag: 1707207506-175771 X-HE-Meta: U2FsdGVkX19eJAkh+ydXfEU3FZ1lEM645qLLQACD/UsNvIKXjcIyjSv4C7lNV5iMVa0fYOazsgcVOVTEtG8NFDzoetx21zDjCkD3kcGPY0N/Gc4H7CJZuQTXLo03zjKeKjFWFB+Ux/34fxAMSI+26mxsF7/Cj3MYr8vgfSJaglSMriIu2JCmEIXw9wsFXpl1RYEqwqwKnm/olNZxAxZMdq9ua0DLfbE0JT9AgFAOk/mykcbzzM/6J+3Xi37+SyEU69r1cil3U1expJaLNWGhr1nJKgY4zYR4Zajqb26aCLni2o92YmO4faD+6Skg9EsdomD3Cbs7tPwNdSy3FQAatbdAP11S3hcIfDEcL49ELQG0u20P7crJk6iLXoGk2y3fLYlWvxHuBSvc10xfy53T0cs0czDWI5TD3AIEhhZAsjTrX28PgieN/nB/PXmIdU24XnQkqJZ6hFd9W2d7824aXXb0a0Fc3bjqfwu+n+mnxwpYljR6ArBVeUiD0xRvVxa8ZHVRP4b0Pxt2m+aYR6iiNkvEaZkEBEoFj0J/F7xaMBC2QMetMWH/3Q4I7rUxoGuZTMK+K9u481BTy+a5gEEbc1jz8e7CIiBjyHcKN7on8BobxeXEt0CE4arNIfY1mtNYx637cO3CBmc91iecfk3OVeXLesNrXUcoYNsIBrSyHv4reG/VCoTJXplZ11whMOZUtIsewWlrBzNw9tnNQe/yF/lZnz3yfrC+nKBOYol++H/ap5+wmHLj33B/qiTIHaelM9YSHQPWpdpv4yoBxwHUceP8xzxjcHsAhLvQYzDiDamTXIAwUtrP80djcpW3GGwUBJoBCVlQgRcc3aF8yjfZBpYfVK2h7AuTgelSX4Tg3keC+RyBQgatd1vvIVylisvmj1vEjt+unoLprXuV+dRVzC0aDk9+O9q8Djf2SnmNH5DeJh+On0cGjXILzHGyEUwKEY6AZlkld5LMTiluGK3 AL04U+uT lu1XjOrFVBZl3AMrMFeiT4GdhFrZfnlMzeQAcbDJTBZYYLbdaHKhAEq8oQXTWzOMxpO1sdc5unMtGPrBlIel3A7TgcDHdu4UUya+dnn9vFW1KZfeHTTu90PvyAOm7MYnXCEyKCJjern8bRcju54DOXzdnjNl4WSS8WCXTucTkqWNrrwtqWtlU0KbnbQDWKstEOCoCmBi/WMkwyQRD7JWyUyClp9adnpJrx5tIy8A8zGp0BTPd2GQvPJ1jd+S/3MfSj5DBJjLGvP7wYJOYWVA5BG4FFd9XKkPY2zfF/44cAxak+ekRSMZwRKxTxJJdB9bntyCkqD+1M8uStCFLyreffMCD9s1bw1+tI9+9 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/2/5 22:23, Michal Hocko wrote: > On Mon 05-02-24 21:06:17, Baolin Wang wrote: > [...] >>> It is quite possible that traditional users (like large DBs) do not use >>> CMA heavily so such a problem was not observed so far. That doesn't mean >>> those problems do not really matter. >> >> CMA is just one case, as I mentioned before, other situations can also break >> the per-node hugetlb pool now. > > Is there any other case than memory hotplug which is arguably different > as it is a disruptive operation already. Yes, like I said before the longterm pinning, memory failure and the users of alloc_contig_pages() may also break the per-node hugetlb pool. >> Let's focus on the main point, why we should still keep inconsistency >> behavior to handle free and in-use hugetlb for alloc_contig_range()? That's >> really confused. > > yes, this should behave consistently. And the least surprising way to > handle that from the user configuration POV is to not move outside of > the original NUMA node. So you mean we should also add __GFP_THISNODE flag in alloc_migration_target() when allocating a new hugetlb as the target for migration, that can unify the behavior and avoid breaking the per-node pool?