From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5D78FC3DA4A for ; Fri, 9 Aug 2024 16:24:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D92056B00A3; Fri, 9 Aug 2024 12:24:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D19466B00B7; Fri, 9 Aug 2024 12:24:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B78236B00B6; Fri, 9 Aug 2024 12:24:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 9CEA56B0092 for ; Fri, 9 Aug 2024 12:24:02 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 35CDB140510 for ; Fri, 9 Aug 2024 16:24:02 +0000 (UTC) X-FDA: 82433228724.30.90FD514 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf14.hostedemail.com (Postfix) with ESMTP id CDFD0100007 for ; Fri, 9 Aug 2024 16:23:59 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=ZW4rn3pK; spf=pass (imf14.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1723220573; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=DoydR2K9jhjEheARXsAR7jPO3nMpWKOxYsEoh1X3iuQ=; b=XvgHCRJORZ1DPezTuh1jKtHQK1e8qAWjggRxXXH1HDWf285AiY2bc5R/AKmSlAfb2kgbqW 5p5bWn8FWtNTxPT97i8addHgmupU5Wl7JU/laYcO4I0DEo+t7FQ3RaBjRDRrpzBuvyaOef 80ovqI05gy8G2GhFaSjxII2yy8m+Hks= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1723220573; a=rsa-sha256; cv=none; b=Mvci+8WC/1zv0L17acX+MQHKWu5CuZh1M2ZE+VvcuwaXhKwd1tKmxqquPnFUW9vZi2m9Y6 GZs1cL1uJRt1dCsW8NJKboDJB5o3tMHUCCSJRVs/RvWhUjCU4+xiJKyF+uwr0KBlWB5Kei 4HLxAV9VdrlGMN6QC6oSf/O903kPNy8= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=ZW4rn3pK; spf=pass (imf14.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1723220639; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=DoydR2K9jhjEheARXsAR7jPO3nMpWKOxYsEoh1X3iuQ=; b=ZW4rn3pKtfmvF81ijF7bNOGbg7SpAxIgzjlDoz2dsdgsW/q4r18fFnIH29D+IDlCGpbQ8E DZr9a5txC0exb7kNfp3tZ9USquHoLji8QmN9Vg9LvjrPSQdBLRbOuMYHY4TCDxBytfgoTZ +4CDBilJ3r8Wu7+4vYlP/ZmbfaCYg44= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-672-CYB6sm6TMpqtM7IOioMn8g-1; Fri, 09 Aug 2024 12:23:57 -0400 X-MC-Unique: CYB6sm6TMpqtM7IOioMn8g-1 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-42820c29a76so16914545e9.2 for ; Fri, 09 Aug 2024 09:23:57 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723220636; x=1723825436; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=DoydR2K9jhjEheARXsAR7jPO3nMpWKOxYsEoh1X3iuQ=; b=mYDGFoIb3zhKzEwfUw0LqFCID9/8uLmOEOzET8LEVMnrsIBh8XdZOBFN2ij78SJ2+T gG9efshlOXfkvYq7wXTiUk75o6lQL2EoYycGLVS6DIcqgjnU6Dr0uQ2xmKZAml/PgV55 il3t94MsV+Zcq1OxGIUc/fpEZhP5dpISk/wywdjGKPzHSKRve7pwgymMj4Cx7PWLEbyE iX1xTlDUVWsthGWXg1uCrUYLXfDyx6exagmld4o8ggDr3q3ImSXg4jUAHZGW/2Pb8N+7 uuoYeUT6C5MjGmJ5NdsXZ3o4d4+dtP7RIFaQO0pXMhGS5y3dFsCEfIec+q+8cdLhTD3e lvpA== X-Forwarded-Encrypted: i=1; AJvYcCW8Gcplmyhv+d8fWzOLbZ3x7r8LTram2UbDz9lJlC8H4rfRBcTh0AI8YMfmZR/orqedV27NgYYQTa9AWf3lck1FZPs= X-Gm-Message-State: AOJu0YyTcpWh4UUbrCJG87Vdq+nf2lHnItJj591J/ZCJOk6QJxcigFWH NfZce+KuiTi/6agDkPYUqbsYnrthNyhQ7kY1s9JnGv04vrXW9E3ewKuN1y1NkJR8FLKAff4wdVy H+DwEtePiO/MCoB9jwzVDfxKV7yRS+OnU31Hz3GF7salicv5S X-Received: by 2002:adf:f001:0:b0:367:8fc3:a25b with SMTP id ffacd0b85a97d-36d5fd7f99dmr1333504f8f.42.1723220636563; Fri, 09 Aug 2024 09:23:56 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGORBUs7LIbRVg/VkWqv1QHv+oMVJI9Ds+Lr9/1kzljagZ7mVmp7Fs9PFUonC+HZscNvafqJg== X-Received: by 2002:adf:f001:0:b0:367:8fc3:a25b with SMTP id ffacd0b85a97d-36d5fd7f99dmr1333465f8f.42.1723220636037; Fri, 09 Aug 2024 09:23:56 -0700 (PDT) Received: from ?IPV6:2003:d8:2f09:3f00:d228:bd67:7baa:d604? (p200300d82f093f00d228bd677baad604.dip0.t-ipconnect.de. [2003:d8:2f09:3f00:d228:bd67:7baa:d604]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-36d271572cdsm5844020f8f.1.2024.08.09.09.23.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 09 Aug 2024 09:23:55 -0700 (PDT) Message-ID: <67d734e4-86ea-462b-b389-6dc14c0b66f9@redhat.com> Date: Fri, 9 Aug 2024 18:23:53 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 05/19] mm/gup: Detect huge pfnmap entries in gup-fast To: Peter Xu , linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: Sean Christopherson , Oscar Salvador , Jason Gunthorpe , Axel Rasmussen , linux-arm-kernel@lists.infradead.org, x86@kernel.org, Will Deacon , Gavin Shan , Paolo Bonzini , Zi Yan , Andrew Morton , Catalin Marinas , Ingo Molnar , Alistair Popple , Borislav Petkov , Thomas Gleixner , kvm@vger.kernel.org, Dave Hansen , Alex Williamson , Yan Zhao References: <20240809160909.1023470-1-peterx@redhat.com> <20240809160909.1023470-6-peterx@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20240809160909.1023470-6-peterx@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: grti4e6ncf61cqdmbaqbp49d9osmqq7w X-Rspamd-Queue-Id: CDFD0100007 X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1723220639-154830 X-HE-Meta: U2FsdGVkX1+/WisdymW/zrxDEn3BteOrROqZOWaT4vR37MSLRUdHs0vqbBeYfXwu2lyxQe0Kf0a55ussiEEd07eD+w2RalWS1jCLS80ZpLAI5MIMvm/O6IVsv7mUojhShFcmQtdAufFOgg583pefDX6bJuIKwQzeuiSaVj9PSHGMqE8yYVGgXMEc763wZwKegnJCuh3xOksdYNbk7nUoLhA0a9dRck0cbvhtCq2yJnDMO4GbnMwiHxYMF5xOKVXkJmDDeuDWoiN8esFB6ZocddM3a8GnY6DuHsJxyMmL9LcJNBlDcZUkcX2eDNcP0VqhnlFBE5pfGGao+FLTsCPQlokuLrD4fskcySxwRSS1phLrXxbtdhmiA1UE8ZRt4K/Nk4kzK5oXDYV7SlN+0rOwnW5LCOpNCPY7FVgZZw84WzFzXKVAJRKGfTdHNpLfdypalFvhw366o/d14retKL2/Q2LNS9VbvTCYTXoy/VSnYEzmXcg3/CkK1QsjkYq+rhYuep8bJQ9lhDIv0oCmoQMFrOOaN8aoKyeNt8bDqkVbESkJv7rX1ebHg5pImJ0IQimOhO29HMf0g/QO+yKjH1cjneLm6g97j1jGLvGiXCyRY52g9hFs2JL3MnzjCJn383FdXfgdiv7AsiHUR5cVx8sNXDd9ZbGKSoj7HBH7285davzf4AgJ1Np6oBaY7qSEouTWXd7PsoFrM8B++ApCavXmpIVjUcawHl1dQIBf5phFcGF+cqG0fPyUR8QQrxVHXSbFyI5lpZ4r9cvBmBHtEgdtge/3le2ED8RCe3ANfiSRsIvqxlDi+WCrhv6vEaBiOYr53Z9JB2HxxXxHkT1Tb0lmPESL0NToXs9WsFPbGRW7txorIuJXnlVkvkfgUAHI67k4It8RUYkgL1XvNCVXCJpp+pADyYntYdRsCu/FWc57MG1QwHB1qlcSCk6fgZztTi7lw3NjCHP+cp4tocVzgzJ +bFL8QYd p5LEUwzJp7bxaKfIUe87M7JlV5cTAOCW5+txr5lG4UPCTly59DnTdwykTlhXtZzaONVkRQhExKEa+xXoXTHgOuE1IG7Wi1A85g/adHt1y9PX3R9Fj9Wg4NvOjRby/LX/BZV6WtUZrBFH0bESYt58awX6dzNKeEBzStFyoZCwuug/YEn630OeIhujIDqPRUZqZhrjM+InDWolkQ0OKsMoOcU/vixfaU2ZPWRXQcwWjuonLXAIxfJQv5A83yYwo64M4oHboPDF9WyBcWkko5vlwd5dnLx7RotdW/oE5AdiisJwMcX1fTCqPV7+tXEQCux6ppupj/5NfDZoEjet5dUDCLLvRblC4vhal7NOCBTgr6j6IWxBq2EZlTEM9nX2SND6K6g1Rt+4BX31n+Vc= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 09.08.24 18:08, Peter Xu wrote: > Since gup-fast doesn't have the vma reference, teach it to detect such huge > pfnmaps by checking the special bit for pmd/pud too, just like ptes. > > Signed-off-by: Peter Xu > --- > mm/gup.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/mm/gup.c b/mm/gup.c > index d19884e097fd..a49f67a512ee 100644 > --- a/mm/gup.c > +++ b/mm/gup.c > @@ -3038,6 +3038,9 @@ static int gup_fast_pmd_leaf(pmd_t orig, pmd_t *pmdp, unsigned long addr, > if (!pmd_access_permitted(orig, flags & FOLL_WRITE)) > return 0; > > + if (pmd_special(orig)) > + return 0; > + > if (pmd_devmap(orig)) { > if (unlikely(flags & FOLL_LONGTERM)) > return 0; > @@ -3082,6 +3085,9 @@ static int gup_fast_pud_leaf(pud_t orig, pud_t *pudp, unsigned long addr, > if (!pud_access_permitted(orig, flags & FOLL_WRITE)) > return 0; > > + if (pud_special(orig)) > + return 0; > + > if (pud_devmap(orig)) { > if (unlikely(flags & FOLL_LONGTERM)) > return 0; In gup_fast_pte_range() we check after checking pte_devmap(). Do we want to do it in a similar fashion here, or is there a reason to do it differently? Acked-by: David Hildenbrand -- Cheers, David / dhildenb