From: Paolo Bonzini <pbonzini@redhat.com>
To: Roman Gushchin <guro@fb.com>, Shakeel Butt <shakeelb@google.com>
Cc: Johannes Weiner <hannes@cmpxchg.org>,
Michal Hocko <mhocko@suse.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
kvm@vger.kernel.org
Subject: Re: [PATCH] mm, kvm: account kvm_vcpu_mmap to kmemcg
Date: Sun, 8 Nov 2020 12:23:27 +0100 [thread overview]
Message-ID: <67c2912d-e861-d660-61f0-912a72eff01d@redhat.com> (raw)
In-Reply-To: <20201106205245.GB2285866@carbon.dhcp.thefacebook.com>
On 06/11/20 21:52, Roman Gushchin wrote:
> On Fri, Nov 06, 2020 at 12:29:23PM -0800, Shakeel Butt wrote:
>> A VCPU of a VM can allocate couple of pages which can be mmap'ed by the
>> user space application. At the moment this memory is not charged to the
>> memcg of the VMM. On a large machine running large number of VMs or
>> small number of VMs having large number of VCPUs, this unaccounted
>> memory can be very significant. So, charge this memory to the memcg of
>> the VMM. Please note that lifetime of these allocations corresponds to
>> the lifetime of the VMM.
>>
>> Signed-off-by: Shakeel Butt <shakeelb@google.com>
>> ---
>
> Acked-by: Roman Gushchin <guro@fb.com>
>
> Thanks, Shakeel!
>
Acked-by: Paolo Bonzini <pbonzini@redhat.com>
If this patch is not merged via -mm, please ping me again once its
dependency is part of Linus's tree.
Thanks,
Paolo
prev parent reply other threads:[~2020-11-08 11:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-06 20:29 Shakeel Butt
2020-11-06 20:52 ` Roman Gushchin
2020-11-08 11:23 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=67c2912d-e861-d660-61f0-912a72eff01d@redhat.com \
--to=pbonzini@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=guro@fb.com \
--cc=hannes@cmpxchg.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=shakeelb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox