From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E0BBBC47DDB for ; Thu, 1 Feb 2024 12:44:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 234106B007E; Thu, 1 Feb 2024 07:44:01 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 1E3B36B0080; Thu, 1 Feb 2024 07:44:01 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0D3246B0081; Thu, 1 Feb 2024 07:44:01 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id F278B6B007E for ; Thu, 1 Feb 2024 07:44:00 -0500 (EST) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id BB430C0DCD for ; Thu, 1 Feb 2024 12:44:00 +0000 (UTC) X-FDA: 81743202240.08.A818F8C Received: from szxga04-in.huawei.com (szxga04-in.huawei.com [45.249.212.190]) by imf15.hostedemail.com (Postfix) with ESMTP id 8E70CA001F for ; Thu, 1 Feb 2024 12:43:56 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf15.hostedemail.com: domain of tongtiangen@huawei.com designates 45.249.212.190 as permitted sender) smtp.mailfrom=tongtiangen@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1706791439; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=FYqH+OWIRAnnWbaqi+/jKJcu7PZrAVd2PkfYoCSpaR8=; b=ORWtOYT7Hf9MRMerACNR0LUgZUZj+jQpNwZUePxuBRdJ23ZWSntMOfJCoA17Ws9qfhGlqw RgnuWrTmJ0D4ve2dVsiqrX1FuFwzZfQU0MELa7IFXnTbOYWS5tCJZ85viwgc2GyBnusYuQ R9S/gv5pYkvTcVUjv8VzL0fxceCCROw= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf15.hostedemail.com: domain of tongtiangen@huawei.com designates 45.249.212.190 as permitted sender) smtp.mailfrom=tongtiangen@huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1706791439; a=rsa-sha256; cv=none; b=LenHNA3d9qPlwTeUxMoMywfnyEw6JFpd8mxs8w9td0N/6lSNAXQ12xzq0FK9nBmHzBXDkj N7BTQ+3JmuX1Ns3xMgPlqx0CXIifCT9GE3KGobsTvH+RSG+9FjRaQp8xmJkPABME4not/h +6Fsh6+qH4YeRjgsDuh4mYepYZW6e0c= Received: from mail.maildlp.com (unknown [172.19.163.44]) by szxga04-in.huawei.com (SkyGuard) with ESMTP id 4TQdpy54rgz1xn48; Thu, 1 Feb 2024 20:42:50 +0800 (CST) Received: from kwepemm600017.china.huawei.com (unknown [7.193.23.234]) by mail.maildlp.com (Postfix) with ESMTPS id CD6D514040D; Thu, 1 Feb 2024 20:43:51 +0800 (CST) Received: from [10.174.179.234] (10.174.179.234) by kwepemm600017.china.huawei.com (7.193.23.234) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Thu, 1 Feb 2024 20:43:50 +0800 Message-ID: <67c1f723-0a5e-6ab5-dd71-a654509fb956@huawei.com> Date: Thu, 1 Feb 2024 20:43:49 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [PATCH -next v4 1/3] x86/mce: remove redundant fixup type EX_TYPE_COPY To: Borislav Petkov CC: Thomas Gleixner , Ingo Molnar , , Dave Hansen , , "H. Peter Anvin" , Tony Luck , Andy Lutomirski , Peter Zijlstra , Andrew Morton , Naoya Horiguchi , , , , Guohanjun References: <20240111135548.3207437-1-tongtiangen@huawei.com> <20240111135548.3207437-2-tongtiangen@huawei.com> <20240130210918.GFZbllfs4jUcd_QHL2@fat_crate.local> From: Tong Tiangen In-Reply-To: <20240130210918.GFZbllfs4jUcd_QHL2@fat_crate.local> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.174.179.234] X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To kwepemm600017.china.huawei.com (7.193.23.234) X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 8E70CA001F X-Stat-Signature: 4u3nokfhysjdhs6u8ccbfn5niydmo7zw X-Rspam-User: X-HE-Tag: 1706791436-133183 X-HE-Meta: U2FsdGVkX1/JOOrsD/07TBNmLHEuyA8meVmBUVII7/uH1MochI5WuZa/dQ7z27Fk46e5JOlvY5dilveDAbEKAm7lyi4jq4ws47VlweTOreIoSB8t6oOQHatcr5a69ScWD7ehAj2mB1mXTA0/+YXLcHQ/NtA/EVSw5zenD+K/989AIyzvnfQt7AXZtImgoXXRM0hFZYpqF/RvW+Oh4DawERve2h0JSVbpFZezR51BzlPNfDEayS71FtRWkAKn3qEraX9Zsin1r1PGoTQ06oXcNxV03NdcJPYy15x8QA4CigA0niIvMOHrdSc79FSJUSdH/AdWzw8AsxNArd3QOx1UJ0elOomfjjjbWSFKlH5OZlha+jde1hRttbwohkFb37vEcJqIjY9cg6BKE++sFN5ZGbAyu02lrGND3oFQdOF8M09e7dqhdUru6oB8Gvxe9JkhUYG01MwYjlk2Tk0g6CcqM3O+weiL/U7jcKqy8gw3NpgYZvvWHQ4A+XTLQUw4zxyc8aAf0ytw15uYuggW4im0/iKHwey4AWelOVMSMrZ8BvR72h3QU/PjxjKuXikGXlsrvHRsQjNKoH2Y+LMegvO9bxY6gOAeHeyMFoNzKMVsaBIPKKa82y+S7ZSQ0w1xTCWdb/m3QeUEQKcyI5bRAwx3rSE4fgpXHIAluGjOv64CPlp0p0I8rzQssgOmQvOy/Fhn32Jc5Sx8F7Z9vVafV5TMRubrP0rVrHq8ikBviXJLwPpP9xkPL+SUgJMq30bnC+IrvF5g2QyXRVzb3WvU6irY/kTdPxGLgKnd3kE1ekzblwiAu366Ci5ppKvf61Tevz4jo2xHnYIfEFNCKom41aLuo4U8Uybj5V6Eru36Nd7g7NE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: 在 2024/1/31 5:09, Borislav Petkov 写道: > On Thu, Jan 11, 2024 at 09:55:46PM +0800, Tong Tiangen wrote: >> In commit 034ff37d3407 ("x86: rewrite '__copy_user_nocache' function"), >> rewrited __copy_user_nocache() uses EX_TYPE_UACCESS instead of >> EX_TYPE_COPY，this change does not broken the MC safe copy for >> __copy_user_nocache(), but as a result, there's no place for EX_TYPE_COPY >> to use. Therefore, we remove the definition of EX_TYPE_COPY. > > Please use passive voice in your commit message: no "we" or "I", etc, > and describe your changes in imperative mood. > > Also, pls read section "2) Describe your changes" in > Documentation/process/submitting-patches.rst for more details. > > Also, see section "Changelog" in > Documentation/process/maintainer-tip.rst Hi Borislav: how about this commit msg change? Since commit 034ff37d3407 ("x86: rewrite '__copy_user_nocache' function") rewrited __copy_user_nocache() uses EX_TYPE_UACCESS instead of EX_TYPE_COPY，there is no user for EX_TYPE_COPY，so remove it. Thanks. Tong. > >> diff --git a/arch/x86/include/asm/extable_fixup_types.h b/arch/x86/include/asm/extable_fixup_types.h >> index fe6312045042..787916ec1e12 100644 >> --- a/arch/x86/include/asm/extable_fixup_types.h >> +++ b/arch/x86/include/asm/extable_fixup_types.h >> @@ -36,18 +36,17 @@ >> #define EX_TYPE_DEFAULT 1 >> #define EX_TYPE_FAULT 2 >> #define EX_TYPE_UACCESS 3 >> -#define EX_TYPE_COPY 4 >> -#define EX_TYPE_CLEAR_FS 5 >> -#define EX_TYPE_FPU_RESTORE 6 >> -#define EX_TYPE_BPF 7 >> -#define EX_TYPE_WRMSR 8 >> -#define EX_TYPE_RDMSR 9 >> -#define EX_TYPE_WRMSR_SAFE 10 /* reg := -EIO */ >> -#define EX_TYPE_RDMSR_SAFE 11 /* reg := -EIO */ >> -#define EX_TYPE_WRMSR_IN_MCE 12 >> -#define EX_TYPE_RDMSR_IN_MCE 13 >> -#define EX_TYPE_DEFAULT_MCE_SAFE 14 >> -#define EX_TYPE_FAULT_MCE_SAFE 15 >> +#define EX_TYPE_CLEAR_FS 4 >> +#define EX_TYPE_FPU_RESTORE 5 >> +#define EX_TYPE_BPF 6 >> +#define EX_TYPE_WRMSR 7 >> +#define EX_TYPE_RDMSR 8 >> +#define EX_TYPE_WRMSR_SAFE 9 /* reg := -EIO */ >> +#define EX_TYPE_RDMSR_SAFE 10 /* reg := -EIO */ >> +#define EX_TYPE_WRMSR_IN_MCE 11 >> +#define EX_TYPE_RDMSR_IN_MCE 12 >> +#define EX_TYPE_DEFAULT_MCE_SAFE 13 >> +#define EX_TYPE_FAULT_MCE_SAFE 14 > > You don't need to renumber them - all you need to do is to comment it > out: > > /* unused, was: #define EX_TYPE_COPY 4 */ >