From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8DAB7CD37B0 for ; Mon, 18 Sep 2023 11:28:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1AB506B02FA; Mon, 18 Sep 2023 07:28:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 15B5B6B0300; Mon, 18 Sep 2023 07:28:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F3DAA6B0303; Mon, 18 Sep 2023 07:28:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id E1B8B6B02FA for ; Mon, 18 Sep 2023 07:28:13 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id B47F240CE9 for ; Mon, 18 Sep 2023 11:28:13 +0000 (UTC) X-FDA: 81249494466.22.FE9720F Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf09.hostedemail.com (Postfix) with ESMTP id 6587F14002D for ; Mon, 18 Sep 2023 11:28:11 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=ZrnGXrkU; spf=pass (imf09.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1695036491; a=rsa-sha256; cv=none; b=r328LSCa/+IWSZmpN+h3wfD+czdf8ljaRZNpI3e5awFBFBsY1+PJ9B29LJsIBagkKsjSNG GercYcx7P8irQ9BGMQ3ecSRUj7Q4lTYOaUilaeCatgigb81R3Np49q3dPzoPdgkR2uB0Fc oc/t2oduux6bFRGyQS9wrYH6ay9Nt8U= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=ZrnGXrkU; spf=pass (imf09.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1695036491; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=2+1DSm32hMfdhO5ZA8UHhTzFRwLr/647M51OqI3DUYU=; b=q7fBdjHGQS4N4rWk+lV4AjetkAtJMVJM6M2+yPAwnwwleMX8FjGJjDExixdDYPSxVc+5z6 hpqwC9MC1vHfoSSNePKEe+gKz0zaFWuQXMr9SwTnEdOCozXhbWDcnlYiWaqOFV8nLNNnwz MVJzmHhishOlsFK/UQLQXF9PqRww2nU= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1695036490; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2+1DSm32hMfdhO5ZA8UHhTzFRwLr/647M51OqI3DUYU=; b=ZrnGXrkU8uOtMoMfrOOOEIlARo9uY9oXBlc5suRYFAEATwFbYW1ZIf9GAB+xWw1jveu9Fs KHTvQZ7y6OIW6yJ9a1QSZL1Wkx885uurX5o+T7eoHFI/LgLjEjPtG1BncJ3+R7ndkE9rjM M2V6xji5u0r4YMCq3t1LYME+7DHJ88M= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-671-fZYSLG6MN3ySJ2XZgu8BcA-1; Mon, 18 Sep 2023 07:28:09 -0400 X-MC-Unique: fZYSLG6MN3ySJ2XZgu8BcA-1 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-401b8089339so33742295e9.3 for ; Mon, 18 Sep 2023 04:28:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695036488; x=1695641288; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=2+1DSm32hMfdhO5ZA8UHhTzFRwLr/647M51OqI3DUYU=; b=A8RkE86axz/JZMn3tk5MiJllkMP8d66gYh7SBnCJv8EdF5AOYif+Kl15ZBynWsZ7px oHhminWyVf08kwvNAxFtNy4oO9PacUgH9TMOtd/XDO/RXsfVONrJlNtgCVnh70HDuTsF 3YWDzOikJYqZd0SORUQ5bzjEgG1SfdeUjDBAWvW88tnX9W8hOInww0kMnfniYqWoYTA+ +qMsCphLIECdQlxG4WKROk9a+f2HGBpVIzS0LyeBreoR7StfpwHTAJWe/DWPnBpjY0YV KLJoQSoanvF3BN+kLAMZO4dNP4xr0oF+lPg/rrhbmCaEmF5h5h+8fKxSesJtSTyETusQ v8Rw== X-Gm-Message-State: AOJu0Yzx7czSkYJc28fPAsrKZ1IAvAPC3hamgHT7isk5Tfr3TDpQwOt8 B7B+KZhiJhe5SVwi9OzayrCfkQaduwbLldzb11T1cKRTMnzrthXMJdeOFhSBOfi/1z37TNzv2Bi 23YMbfnyVLgE= X-Received: by 2002:a05:600c:3781:b0:401:b2c7:349b with SMTP id o1-20020a05600c378100b00401b2c7349bmr6867516wmr.7.1695036488299; Mon, 18 Sep 2023 04:28:08 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEGci4qXIDogvyJYt6l9ZtdNOehLAhFlhO9v1v76ai0+FNRoJ7vZlEt4ipeRiOC9RV3VQ3EAA== X-Received: by 2002:a05:600c:3781:b0:401:b2c7:349b with SMTP id o1-20020a05600c378100b00401b2c7349bmr6867504wmr.7.1695036487866; Mon, 18 Sep 2023 04:28:07 -0700 (PDT) Received: from ?IPV6:2003:cb:c74b:3400:ec51:7a3a:274e:cbee? (p200300cbc74b3400ec517a3a274ecbee.dip0.t-ipconnect.de. [2003:cb:c74b:3400:ec51:7a3a:274e:cbee]) by smtp.gmail.com with ESMTPSA id z9-20020adff1c9000000b0031f07d1edbcsm12516298wro.77.2023.09.18.04.28.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 18 Sep 2023 04:28:07 -0700 (PDT) Message-ID: <67c0bbac-aa4a-28ce-5416-e41af794e899@redhat.com> Date: Mon, 18 Sep 2023 13:28:06 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH v1 2/4] mm/ksm: add pages_skipped metric To: Stefan Roesch , kernel-team@fb.com Cc: akpm@linux-foundation.org, hannes@cmpxchg.org, riel@surriel.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org References: <20230912175228.952039-1-shr@devkernel.io> <20230912175228.952039-3-shr@devkernel.io> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20230912175228.952039-3-shr@devkernel.io> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 6587F14002D X-Stat-Signature: 3iaahsgr8uu1xxrsa69jrecy7ao4qhe3 X-Rspam-User: X-HE-Tag: 1695036491-594130 X-HE-Meta: U2FsdGVkX1/9ugGpYImsR6pg5bXyizos6uFyi0AslSaEgGnnfuScL0JAowezMBCGs80qmikBc4mXg8CPnfA57NS76Oh+QfhhTksImf0D8thj40dugupKpDrbqJl/YtHzBi3pAPs4Du/S+U/S7f1QMvd4c6GSX1N/o0+QPRlzfKgQ2JXXvSdFx1mPwcRnKmbxGGG0oG9RpLoVRYZ3tVYuPILpXFZahq1fjob3s9gx4ZNG3l+nxjGCKhujq3iM2J/G8Yz3mTg9XQjtyHFk9U1KEgcPPTQxfQWqqyb/DYYjlLc6tfG8yDqdRT/eSC2ZgYBczMJKHfDsoSLdwkcxjstV2rf1kreSE80A9Te9GrG5MfBtxE+ZGaOQI3DXpDpUs1ChYXpzCUfBPJtMXyvO3m3LCvvM2wvvMQlm0+c3MA7mIBa+lb4u0r05JU2HrIdDjE38sy7r7ZqSN29/4Aw2b2FGeSq2lL2yMEaavtLFqqkwW76YX1v2Eu8egc6wyHoVtTPXVcT18o3e3ikqMG3cQNSVuGpwzyGMK0eCI75Ke+Di5Au6imwFiYwi9e8bwevwRfUdpNDiV8OzUje7hLH9pB0t6PJX+uc8PuuyHfGB6jCgbmfd8h9Uq1L8DP55EXBVtEEMM5PDFROLvC6axXfUQWuvyfUhZQHO2MHwwwzHM/8whQ4WiS4z/HgAGNXAj1DzcdVc6eVqd6x6aL8nQVEg6RQvjhZjkgt9jJbtMIvL18Pku5PDwYWkJXKM5lXrrDZvD75MKvtjAUVD+U9lOGPujn9vKfkt6kYouuGxdzry8t0LEU8uoiyjtLAv5/Osk/frKI/KJ/sLNuibHQarraztCmsxOE/Q6RDYheX1qzvY8S5Bpwg19kcWLjLrsObFLj48rb2ij6qRvzsYCXhP+e0foqO+WS/gGPmYDd+aRkSSizFC3UhnXEh3xGrVtnPSRFB0sD/7sXRqmZz6pKVjc3DXGT+ gEg3V4Gd hsspGPWiqbY2jHd2qQr1iTpUWvDvVfaoDDjtmYqCPAproZ0Fx3jD5NOjijJG0+ut0GJ608cF3nnmAjrR+Itg6dhBpXqSyfrwKs6c1BM9FJadr8c94uP8nQTOMVSVmFVZTb25h3X8pJU3bBoNbZgG88Ja9YOx3wDRy60ZDBLo2VnhMaURiibMNGnDSX24z6KzB2MAmRxtWNZiRy9E0dUmMdrIBNR1cBOXhxIdNvd4xxyBTRV/Krt77zB0Z+BHIV6qoAW7TcmBWEmH/5Mwhb6liw4eDnQren/OY9583kTpPesdmYpJrzFYGtfdWWB/LZUu+DOT/f7V95KDSefUNFfLJjapzo1P0+9oAyYjqTEMFX2CgRVIOhWbiW6MzP30aGdc4Omp5IMmAz+XOXDCKjXNzb1vxi4Th8LzXSvn9ug1lkwS/87EZ5hz47rrugaAEX2tFl1IF2JgcvJeaKTqMRRct15B2CqZG4uqgOw2Qnn9PiYj3AvdW8P+zYDVFow== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 12.09.23 19:52, Stefan Roesch wrote: > This change adds the "pages skipped" metric. To be able to evaluate how > successful smart page scanning is, the pages skipped metric can be > compared to the pages scanned metric. > > The pages skipped metric is a cumulative counter. The counter is stored > under /sys/kernel/mm/ksm/pages_skipped. > > Signed-off-by: Stefan Roesch > --- > mm/ksm.c | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/mm/ksm.c b/mm/ksm.c > index bfd5087c7d5a..728574a3033e 100644 > --- a/mm/ksm.c > +++ b/mm/ksm.c > @@ -293,6 +293,9 @@ static bool ksm_smart_scan; > /* The number of zero pages which is placed by KSM */ > unsigned long ksm_zero_pages; > > +/* The number of pages that have been skipped due to "smart scanning" */ > +static unsigned long ksm_pages_skipped; > + > #ifdef CONFIG_NUMA > /* Zeroed when merging across nodes is not allowed */ > static unsigned int ksm_merge_across_nodes = 1; > @@ -2345,6 +2348,7 @@ static bool skip_rmap_item(struct page *page, struct ksm_rmap_item *rmap_item) > return false; > } > > + ksm_pages_skipped++; > if (rmap_item->skip_age == 0) { > rmap_item->skip_age = age + inc_skip_age(age); > remove_rmap_item_from_tree(rmap_item); > @@ -3435,6 +3439,13 @@ static ssize_t pages_volatile_show(struct kobject *kobj, > } > KSM_ATTR_RO(pages_volatile); > > +static ssize_t pages_skipped_show(struct kobject *kobj, > + struct kobj_attribute *attr, char *buf) > +{ > + return sysfs_emit(buf, "%lu\n", ksm_pages_skipped); > +} > +KSM_ATTR_RO(pages_skipped); > + > static ssize_t ksm_zero_pages_show(struct kobject *kobj, > struct kobj_attribute *attr, char *buf) > { > @@ -3532,6 +3543,7 @@ static struct attribute *ksm_attrs[] = { > &pages_sharing_attr.attr, > &pages_unshared_attr.attr, > &pages_volatile_attr.attr, > + &pages_skipped_attr.attr, > &ksm_zero_pages_attr.attr, > &full_scans_attr.attr, > #ifdef CONFIG_NUMA Reviewed-by: David Hildenbrand -- Cheers, David / dhildenb