From: Anshuman Khandual <anshuman.khandual@arm.com>
To: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>,
Mike Kravetz <mike.kravetz@oracle.com>
Cc: "linux-mm@kvack.org" <linux-mm@kvack.org>,
Andrew Morton <akpm@linux-foundation.org>,
Michal Hocko <mhocko@kernel.org>,
"xishi.qiuxishi@alibaba-inc.com" <xishi.qiuxishi@alibaba-inc.com>,
"Chen, Jerry T" <jerry.t.chen@intel.com>,
"Zhuo, Qiuxu" <qiuxu.zhuo@intel.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 1/2] mm: soft-offline: return -EBUSY if set_hwpoison_free_buddy_page() fails
Date: Tue, 11 Jun 2019 13:44:46 +0530 [thread overview]
Message-ID: <67bb5891-d0be-ffb8-3161-092c8167a960@arm.com> (raw)
In-Reply-To: <20190611005715.GB5187@hori.linux.bs1.fc.nec.co.jp>
On 06/11/2019 06:27 AM, Naoya Horiguchi wrote:
> On Mon, Jun 10, 2019 at 05:19:45PM -0700, Mike Kravetz wrote:
>> On 6/10/19 1:18 AM, Naoya Horiguchi wrote:
>>> The pass/fail of soft offline should be judged by checking whether the
>>> raw error page was finally contained or not (i.e. the result of
>>> set_hwpoison_free_buddy_page()), but current code do not work like that.
>>> So this patch is suggesting to fix it.
>>>
>>> Signed-off-by: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
>>> Fixes: 6bc9b56433b76 ("mm: fix race on soft-offlining")
>>> Cc: <stable@vger.kernel.org> # v4.19+
>>
>> Reviewed-by: Mike Kravetz <mike.kravetz@oracle.com>
>
> Thank you, Mike.
>
>>
>> To follow-up on Andrew's comment/question about user visible effects. Without
>> this fix, there are cases where madvise(MADV_SOFT_OFFLINE) may not offline the
>> original page and will not return an error.
>
> Yes, that's right.
Then should this be included in the commit message as well ?
next prev parent reply other threads:[~2019-06-11 8:14 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-10 8:18 [PATCH v2 00/02] fix return value issue of soft offlining hugepages Naoya Horiguchi
2019-06-10 8:18 ` [PATCH v2 1/2] mm: soft-offline: return -EBUSY if set_hwpoison_free_buddy_page() fails Naoya Horiguchi
2019-06-10 21:20 ` Andrew Morton
2019-06-10 22:51 ` Naoya Horiguchi
2019-06-11 0:19 ` Mike Kravetz
2019-06-11 0:57 ` Naoya Horiguchi
2019-06-11 8:14 ` Anshuman Khandual [this message]
2019-06-12 6:48 ` Naoya Horiguchi
2019-06-10 8:18 ` [PATCH v2 2/2] mm: hugetlb: soft-offline: dissolve_free_huge_page() return zero on !PageHuge Naoya Horiguchi
2019-06-11 9:50 ` Anshuman Khandual
2019-06-12 7:09 ` Naoya Horiguchi
2019-06-11 17:16 ` Mike Kravetz
2019-06-12 7:24 ` Naoya Horiguchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=67bb5891-d0be-ffb8-3161-092c8167a960@arm.com \
--to=anshuman.khandual@arm.com \
--cc=akpm@linux-foundation.org \
--cc=jerry.t.chen@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=mike.kravetz@oracle.com \
--cc=n-horiguchi@ah.jp.nec.com \
--cc=qiuxu.zhuo@intel.com \
--cc=xishi.qiuxishi@alibaba-inc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox