From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: Mike Kravetz <mike.kravetz@oracle.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Anshuman Khandual <anshuman.khandual@arm.com>,
Xiongchun Duan <duanxiongchun@bytedance.com>,
Barry Song <21cnbao@gmail.com>,
David Rientjes <rientjes@google.com>,
Miaohe Lin <linmiaohe@huawei.com>,
Matthew Wilcox <willy@infradead.org>,
linux-mm@kvack.org, Naoya Horiguchi <naoya.horiguchi@linux.dev>,
Joao Martins <joao.m.martins@oracle.com>,
David Hildenbrand <david@redhat.com>,
Michal Hocko <mhocko@suse.com>,
Oscar Salvador <osalvador@suse.de>,
linux-kernel@vger.kernel.org,
Usama Arif <usama.arif@bytedance.com>
Subject: Re: [PATCH v6 2/8] hugetlb: restructure pool allocations
Date: Wed, 11 Oct 2023 11:36:05 +0200 [thread overview]
Message-ID: <67b34aed-6e0f-400f-a150-1969c5478f4b@linaro.org> (raw)
In-Reply-To: <20231010214533.GC279095@monkey>
On 10/10/23 23:45, Mike Kravetz wrote:
> On 10/10/23 23:30, Konrad Dybcio wrote:
>>
>>
>> On 10/10/23 02:07, Andrew Morton wrote:
>>> On Mon, 9 Oct 2023 08:15:13 -0700 Mike Kravetz <mike.kravetz@oracle.com> wrote:
>>>
>>>>> This should also be empty and a noop.
>>>>>
>>>>> Is it possible that the misaligned kernel image could make these lists
>>>>> appear as non-empty?
>>>>
>>>> Actually, just saw this:
>>>>
>>>> https://lore.kernel.org/linux-mm/20231009145605.2150897-1-usama.arif@bytedance.com/
>>>>
>>>> Will take a look, although as mentioned above prep_and_add_bootmem_folios on
>>>> an empty list should be a noop.
>>>
>>> Konrad, are you able to test Usama's patch? Thanks.
>> I legitimately spent a sad amount of time trying to regain access to the
>> remote board farm. Previously I could hit the bug on SM8550, but now I can't
>> do it on SM8450, SM8350 and SM8250 (previous gens), with the same config.. I
>> have no idea when I'll be able to get access to SM8550 again.
>>
>> I did test it on the QCM6490 Fairphone 5 that I initially reported this on,
>> and neither booting next-20231010 (with your patchset applied) nor adding
>> the below patch on top of it seems to work. I can't get serial output from
>> this device though to find out what it's unhappy about :/
>
> Sorry for causing you to spend so much time on this.
No worries, that was my explanation for why it took me so long to
respond again..
>
> As mentioned in the reply to Usama's patch, the root cause seems to be
> the locking. So, the real change to test is the locking changes in
> that thread; not Usama's patch.
Ack
Konrad
next prev parent reply other threads:[~2023-10-11 9:36 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-25 23:48 [PATCH v6 0/8] Batch hugetlb vmemmap modification operations Mike Kravetz
2023-09-25 23:48 ` [PATCH v6 1/8] hugetlb: optimize update_and_free_pages_bulk to avoid lock cycles Mike Kravetz
2023-09-25 23:48 ` [PATCH v6 2/8] hugetlb: restructure pool allocations Mike Kravetz
2023-09-27 11:26 ` Konrad Dybcio
2023-09-29 20:57 ` Mike Kravetz
2023-10-02 9:57 ` Konrad Dybcio
2023-10-06 3:08 ` Mike Kravetz
2023-10-06 21:39 ` Konrad Dybcio
2023-10-06 22:35 ` Mike Kravetz
2023-10-09 3:29 ` Mike Kravetz
2023-10-09 10:11 ` Konrad Dybcio
2023-10-09 15:04 ` Mike Kravetz
2023-10-09 15:15 ` Mike Kravetz
2023-10-09 21:09 ` Konrad Dybcio
2023-10-10 1:26 ` Mike Kravetz
2023-10-10 0:07 ` Andrew Morton
2023-10-10 21:30 ` Konrad Dybcio
2023-10-10 21:45 ` Mike Kravetz
2023-10-11 9:36 ` Konrad Dybcio [this message]
2023-10-09 21:09 ` Konrad Dybcio
2023-10-07 1:51 ` Jane Chu
2023-10-09 10:13 ` Konrad Dybcio
2023-09-25 23:48 ` [PATCH v6 3/8] hugetlb: perform vmemmap optimization on a list of pages Mike Kravetz
2023-09-25 23:48 ` [PATCH v6 4/8] hugetlb: perform vmemmap restoration " Mike Kravetz
2023-09-26 2:27 ` Muchun Song
2023-09-29 22:10 ` Mike Kravetz
2023-09-25 23:48 ` [PATCH v6 5/8] hugetlb: batch freeing of vmemmap pages Mike Kravetz
2023-09-25 23:48 ` [PATCH v6 6/8] hugetlb: batch PMD split for bulk vmemmap dedup Mike Kravetz
2023-09-25 23:48 ` [PATCH v6 7/8] hugetlb: batch TLB flushes when freeing vmemmap Mike Kravetz
2023-09-25 23:48 ` [PATCH v6 8/8] hugetlb: batch TLB flushes when restoring vmemmap Mike Kravetz
2023-09-26 2:20 ` Muchun Song
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=67b34aed-6e0f-400f-a150-1969c5478f4b@linaro.org \
--to=konrad.dybcio@linaro.org \
--cc=21cnbao@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=anshuman.khandual@arm.com \
--cc=david@redhat.com \
--cc=duanxiongchun@bytedance.com \
--cc=joao.m.martins@oracle.com \
--cc=linmiaohe@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=mike.kravetz@oracle.com \
--cc=naoya.horiguchi@linux.dev \
--cc=osalvador@suse.de \
--cc=rientjes@google.com \
--cc=usama.arif@bytedance.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox