From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 71B25C10DC1 for ; Sat, 2 Dec 2023 18:12:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8E0406B0422; Sat, 2 Dec 2023 13:12:32 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 890946B0423; Sat, 2 Dec 2023 13:12:32 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 730A36B0424; Sat, 2 Dec 2023 13:12:32 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 60F4A6B0422 for ; Sat, 2 Dec 2023 13:12:32 -0500 (EST) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 2B7C54013D for ; Sat, 2 Dec 2023 18:12:32 +0000 (UTC) X-FDA: 81522673344.26.690826E Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf26.hostedemail.com (Postfix) with ESMTP id A3A06140009 for ; Sat, 2 Dec 2023 18:12:28 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=ByOOKiBB; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=1zhMsnvg; dmarc=none; spf=pass (imf26.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1701540749; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=YKKElGndb6jN6rikp3anJK9MKgurw4EhN7S3f9KMiUc=; b=aScHUdlZBQBLBhrpxdUweKQxkQKxD0XYsiY4dGF5fNNburk1aTs2PbTbB3zZI1FdWW2nuE g403e27VSW0A2xET68TQ8jADvj8rNlf8vuKomG+X1W0vypgyPU8R9guir72zYfli3lwJyg FwTJygCDRUtJL8uf2cYHm1OOjm0z9jU= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=ByOOKiBB; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=1zhMsnvg; dmarc=none; spf=pass (imf26.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1701540749; a=rsa-sha256; cv=none; b=ixkyqGVlGqaA98RV+oIWC3cSIkKo9+6kcU+V4bb8m9kktttyZ1+7pLjw+h5BMCjyANDhWN qJKFyFECnFR0iKwPNBhxWn+0rISAY+VF4EpIKecTGItFyDmiQwWJfMiHb9WaEjEVGaZVcg qZZB7b/kLZdSBiO/eYxqJIzcJQXtE3E= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 3B0031FC84; Sat, 2 Dec 2023 18:12:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1701540746; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=YKKElGndb6jN6rikp3anJK9MKgurw4EhN7S3f9KMiUc=; b=ByOOKiBBXs+G3CgixWcwoXU3Hyu4zmCk9TmLBfsVSk8pBxGedDHCd6lkkTPuMpDKhu2LL1 PnSG1s0PGnmUKFe2qe+W6bc7m+wDUpoTal8ywk+TjsMQwgijTwlcRD1xyD8LcbcoRCBmz2 NSlXi/lyMNuxajN8qNKmZoot0fsCdCo= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1701540746; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=YKKElGndb6jN6rikp3anJK9MKgurw4EhN7S3f9KMiUc=; b=1zhMsnvgSMeU8la4Atp2i3gCjqg1uEtRtc+ehyUAiGzJiqir6Zia+chgwKpS1vDnA1TI6p Tc1fKsaOEuor/8BA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 07E3513808; Sat, 2 Dec 2023 18:12:26 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id A+4tAYpza2WtbAAAD6G6ig (envelope-from ); Sat, 02 Dec 2023 18:12:26 +0000 Message-ID: <67b155dd-3731-489e-c3bd-333cb7e90801@suse.cz> Date: Sat, 2 Dec 2023 19:12:25 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [RFC PATCH 2/3] mm/slub: unify all sl[au]b parameters with "slab_$param" Content-Language: en-US To: "Song, Xiongwei" , Kees Cook , "sxwjean@me.com" Cc: "42.hyeyoo@gmail.com" <42.hyeyoo@gmail.com>, "cl@linux.com" , "linux-mm@kvack.org" , "penberg@kernel.org" , "rientjes@google.com" , "iamjoonsoo.kim@lge.com" , "roman.gushchin@linux.dev" , "corbet@lwn.net" , "arnd@arndb.de" , "akpm@linux-foundation.org" , "gregkh@linuxfoundation.org" , "linux-doc@vger.kernel.org" , "linux-kernel@vger.kernel.org" References: <20231201031505.286117-1-sxwjean@me.com> <20231201031505.286117-3-sxwjean@me.com> <202312010945.7C5DB1FBB@keescook> From: Vlastimil Babka In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: A3A06140009 X-Stat-Signature: xreaqm147ppr7y1zc5yf745t75fd9pm3 X-HE-Tag: 1701540748-591546 X-HE-Meta: U2FsdGVkX1+gGRdMXRgKBP9tI+0vbwL5SF/8egMolkWqGsHYL6hH0as+N3cQYOIy5s3uBb42qVZt1oorhJXf+lsA/Md5bBFJeWOVfFoDBkHpn95FDNE4o+d14oYBTL+jEAqrfqEzAumxsOHkzjBXEDQ0DUZ4nGwkx/b5cR47eyG4LLi1Oxb6mUdnH2FnQpxLB8wQZVh46nXkv53E8Eqq+Hr3GGl+7gpwmilKE3n+rS/AG8Ndam5J1oEbtc7kAh/0kycEO3O1xne9uBBNl33CBN0yi4NIED7OkrGPWJSDgXuEX0SAoSoON173S9Gg9pmM9W8FSRVd5Dr2dazpnzgcy5k4vHsVLBR8eTXF6wf3q9LQPEDtA0A0yVBE6SISGikM4VUrJlr5TEYw2pV84SB8SvXuT8Am3LTvMYzfC/h+obRI/2bM+986rixa0KpxpNPMljTYRrpWawe6KmQHlpnyggx0Vc5Lj/Qklb3nmw1inSp9C2u89Zv3DW9zJxPLUUGpQd0KmUK8usPy5gJw+o9J9XQhZPyJjoH/wW0nVq7rXBvOQ7AZpdmvzGAlXyfbDH9Ws5xG1uGuEvKJZM0E5KPTlb9YyZwUfpld0nZ+HfmMaZGf4Kp3sRvPt1nekzkfb8nzaiS5EFGbUwf4rUXwxZQKgW+FC8YGGABKnU9ZsRFXAUd5CrnIOH3bd6kLt0kOS5sb/IROhgBJxjAEn7keFNhobny5K+pRspDsfbZRgwjE3jB/7jgjMW2R3GD1mVvpQPRhOplSf37zeL9y3lmLUBQ4E9Ut1/ZJ7wBZWR2w26AAg86lb+K87Pj9lyyXLxsVdRByZQQC1eNGtDaEpPuFzXaC1sssWU2+CWJdmMfRsilgqXTYTl6cnLUT1xAYaTRR8upxAskWua+l1JoacHPfL1AWlM7auxhVRW8JCURIl2TwFrLy+BkTxoxJ1T1cx03F/Nwhg+ETZNibbDAwB/mIyFc 9OFAHiMr /Yuly905vEGCBu1fLGzhlWQxzexoJwzLhUwz3xdlb82Jk4aFgEGswOwcihe9hVk1XLOIEdcs5v4DxVPqTLDR1vgUm8TNNgA0QYV9vSXIm9aOvVyTwWs/d9Flpp0btT8YyLoPPi3pgZQyuOXzq8VcESKId/yMr/E+G7Az3EyGvOLxac1jOX/UxHAjHJBa0Fxw1tbIwA7aqAQGh5Xiv55dH6Jj36SKJPddgfJaoXkbLHmWpXvnRRDIim4yOJINyk2hWjcX1OHVWIo3hAwmKPBt3OfV6iVs+siRJPmJW7AhtLUMl4FUOaNRLnanzp8cumsE185Ag5WSKZpvmaE8MdI3ZFgLpjC4bBIYN4zGFKsVrvZJ4Tl3VngxpEAtUTSu7D4FTS4ewUPWPa58NcULJRpUReIrIx++mNmx1NJ4TFAyZzx0cQRD4WunwRDJ15dTxo1UiPjlgAZhqRX2e27+llsTXXPPphtsD4RttRCLKxgpcxXQrLe6dQR3Ul5cIOZrA86tifI2iZgwQ6OFEc/j5+W668ePeP55nUp4LqLXwZEoXwY2CNBLOCjDe9UUqzch+wtP88+oKSBoVFYtKG0xU4zKztuGWn/5CCYs0PbmLT5cxje2Wo94NVyysWe6r8Cy1vvrTMwgNFk7nVon3wRhQkaAXOtCLw7h8QWWalcaD3avbWihFhux/kbQdxua1Tlf4VKFK84CvQj2UZfyiz15VCevWDWmwoa5dI17VERH4VbfW4MZH8I5X4Lp5mjTSZRgM6sxG2njO4qd7fM7poGuIrWEThRmPE24ZJ0dSJN+pxb1TLXem7PY2eSj7eMVaDAMNF0LYD6gvHY46B/+YrDx4N+kJmoFYs+46KAlGN8+ClMqlMGbSqWmtRmMlqII7xmjiaqcMMRpq2vqe6aIw474y9rW4sjAsagLFn7g7tWxbV1uGLMqfdvYwMNATP9hFowyW/m0ubfsbgjM7BX22MYm6TrmstD65iC1J NN2nfmmk F0IgOnHU8rNDJ1HD5l3BcsuYBLJyqd1hibDuSOj5z1BY0Nzz+lg3iA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 12/2/23 05:23, Song, Xiongwei wrote: > > >> -----Original Message----- >> From: Kees Cook >> Sent: Saturday, December 2, 2023 1:48 AM >> To: sxwjean@me.com >> Cc: vbabka@suse.cz; 42.hyeyoo@gmail.com; cl@linux.com; linux-mm@kvack.org; >> penberg@kernel.org; rientjes@google.com; iamjoonsoo.kim@lge.com; >> roman.gushchin@linux.dev; corbet@lwn.net; arnd@arndb.de; akpm@linux- >> foundation.org; gregkh@linuxfoundation.org; linux-doc@vger.kernel.org; linux- >> kernel@vger.kernel.org; Song, Xiongwei >> Subject: Re: [RFC PATCH 2/3] mm/slub: unify all sl[au]b parameters with "slab_$param" >> >> CAUTION: This email comes from a non Wind River email account! >> Do not click links or open attachments unless you recognize the sender and know the >> content is safe. >> >> On Fri, Dec 01, 2023 at 11:15:04AM +0800, sxwjean@me.com wrote: >> > From: Xiongwei Song >> > >> > Since the SLAB allocator has been removed, so we need to clean up the >> > sl[au]b_$params. However, the "slab/SLAB" terms should be keep for >> > long-term rather than "slub/SLUB". Hence, we should use "slab_$param" >> > as the primary prefix, which is pointed out by Vlastimil Babka. For more >> > information please see [1]. >> > >> > This patch is changing the following slab parameters >> > - slub_max_order >> > - slub_min_order >> > - slub_min_objects >> > - slub_debug >> > to >> > - slab_max_order >> > - slab_min_order >> > - slab_min_objects >> > - slab_debug >> > as the primary slab parameters in >> > Documentation/admin-guide/kernel-parameters.txt and source, and rename all >> > setup functions of them too. Meanwhile, "slub_$params" can also be passed >> > by command line, which is to keep backward compatibility. Also mark all >> > "slub_$params" as legacy. >> >> *If* we do this, I think the old names need to be recognized, perhaps Yes, they are already recognized by the patch. >> with a boot pr_warn() about their deprecation/renaming for several >> releases (likely across LTSes). I think it's not a good idea to >> wholesale rename these with no warning. That's going to cause a lot of >> surprises and broken userspace... > > Oh, yes, that's a good idea. Will update. I'd wait for a while with the warnings, no need to rush. > Regards, > Xiongwei >> >> -- >> Kees Cook