From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AE864C021A6 for ; Fri, 14 Feb 2025 23:26:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 45F75280003; Fri, 14 Feb 2025 18:26:38 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 40F7E280001; Fri, 14 Feb 2025 18:26:38 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1774A280006; Fri, 14 Feb 2025 18:26:38 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id E6B30280003 for ; Fri, 14 Feb 2025 18:26:37 -0500 (EST) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 9C4E9140B3B for ; Fri, 14 Feb 2025 23:26:37 +0000 (UTC) X-FDA: 83120136834.07.FFC79D0 Received: from mail-il1-f205.google.com (mail-il1-f205.google.com [209.85.166.205]) by imf08.hostedemail.com (Postfix) with ESMTP id D8BF816000D for ; Fri, 14 Feb 2025 23:26:35 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=appspotmail.com (policy=none); spf=pass (imf08.hostedemail.com: domain of 3K9GvZwkbANAEKL6w770DwBB4z.2AA270GE0DyA9F09F.yA8@M3KW2WVRGUFZ5GODRSRYTGD7.apphosting.bounces.google.com designates 209.85.166.205 as permitted sender) smtp.mailfrom=3K9GvZwkbANAEKL6w770DwBB4z.2AA270GE0DyA9F09F.yA8@M3KW2WVRGUFZ5GODRSRYTGD7.apphosting.bounces.google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1739575595; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references; bh=+DfAjOjRw7Y0HLFEro9UMHSNaJuO8GYVmY5IQL+N1p0=; b=3oKPqe8gF1csjllvWZnRP9BkhbjOcoJ0Wm85m7rL2qbXVoV93DZQg/gdPR721Oea+pevs3 XVF/nwbstRXPzyMQW7RhH/crCanFutDrXFOevK1d20ipQWdVL0x7Vbb1WiBagwN69JF8KI pNslvopZ2hdklmfWcLAESrgMQ63Q9CQ= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1739575595; a=rsa-sha256; cv=none; b=fkNK429F0E74uO8vEIERHRsOK3JnUv98kmOv9bbNBn3DkXH7eCJ/37N2bTiQlGLz6OaPyW Pq4HG1+RbuQnZ+djpeFcKSpsABEuAN/4ZLuAr6T81PBYqqY9yia5HR1s/L2IIb2oYQxiiR iBYXl0Y9s+g1XDHKXPQv7G5uhRwTKfE= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=appspotmail.com (policy=none); spf=pass (imf08.hostedemail.com: domain of 3K9GvZwkbANAEKL6w770DwBB4z.2AA270GE0DyA9F09F.yA8@M3KW2WVRGUFZ5GODRSRYTGD7.apphosting.bounces.google.com designates 209.85.166.205 as permitted sender) smtp.mailfrom=3K9GvZwkbANAEKL6w770DwBB4z.2AA270GE0DyA9F09F.yA8@M3KW2WVRGUFZ5GODRSRYTGD7.apphosting.bounces.google.com Received: by mail-il1-f205.google.com with SMTP id e9e14a558f8ab-3d18e28a0c1so43743925ab.3 for ; Fri, 14 Feb 2025 15:26:35 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739575595; x=1740180395; h=cc:to:from:subject:message-id:in-reply-to:date:mime-version :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=+DfAjOjRw7Y0HLFEro9UMHSNaJuO8GYVmY5IQL+N1p0=; b=fwAGAmPncTuf+lCOsT/d6t2FsoQXdGfOAkbf9zTsC1uxQ2h03uwbVhJFSAP4fknC+0 O+wdrj8f0KDpqamPvfDPez8kXKkWbZE4rsIvFnM7X849FPlhyp8qoSDwNWBspZpjGDXA 4TqCuxNW9alWPbdlgtOHus2eM+OJWxLnGsD7BRKTivAcLoWrVicPGhhu/+d5CsK0GzT5 XnO0iNHDjc+x4wjWYemu2kNczbdyAj5uFtrVjTgBXbWtWKMKZ7eVOxDUFq7cKMOXamPD iQ4R3WLDDwcaET1mVhdMs+pCaJeLEk6ht4SHR+szwhnpqAhC/z33GmWrgZZTDnS/wzTn xgTQ== X-Forwarded-Encrypted: i=1; AJvYcCVNnCOv1fYTX1KISFIt0i9VImr01uc73lFleCws9WcbleYY52+tC6eRjbGEyNJ/xz9GgrxLvuZ4gA==@kvack.org X-Gm-Message-State: AOJu0YyljuFgfnnB7EraqGiHuHYcQ8n6MfXrSLIgO4gb0vCfYkPNWRiL ZgOdGkOVsNeh91DeL/oeRFttQHpXm6cg2RIU+gG4Gu41Kly4vplSUo8230ufuofaPJCePv24ej8 V9Sxq1pQudQF0Nv4SkcKJLs7ZG+GIwWRHCM0Aw2rQclFeRYpkSAxy2z8= X-Google-Smtp-Source: AGHT+IG/TmCCj+h2nTTIlWGTHYmi1lpvtqVzPHCaSgTFVClI5u5M4/u6moidlvgx5gYgHo13HStlVjc1gAiUeGNcroWV5T0fpaqK MIME-Version: 1.0 X-Received: by 2002:a05:6e02:3103:b0:3d1:9015:f585 with SMTP id e9e14a558f8ab-3d2807ab699mr11651135ab.1.1739575595039; Fri, 14 Feb 2025 15:26:35 -0800 (PST) Date: Fri, 14 Feb 2025 15:26:35 -0800 In-Reply-To: <742701F5-3B2E-45AA-BBEC-69C76E49E3AC@nvidia.com> X-Google-Appengine-App-Id: s~syzkaller X-Google-Appengine-App-Id-Alias: syzkaller Message-ID: <67afd12b.050a0220.21dd3.0059.GAE@google.com> Subject: Re: [syzbot] [mm?] general protection fault in shmem_mapping From: syzbot To: ziy@nvidia.com Cc: akpm@linux-foundation.org, hughd@google.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, syzkaller-bugs@googlegroups.com, ziy@nvidia.com Content-Type: text/plain; charset="UTF-8" X-Rspam-User: X-Rspamd-Queue-Id: D8BF816000D X-Rspamd-Server: rspam07 X-Stat-Signature: 3oow4z8r776b1qzx497xrocwnhbzssrp X-HE-Tag: 1739575595-398488 X-HE-Meta: U2FsdGVkX18txqArLpcJRWkKiPHTedwiwh9JrpB2jw6Ca/zZ3york3hM9quNRpjIZBd12YjIZWwhQx9caGGVgDKQpJ6VfNMSiDn2kBUWJzAB13ZccrCPtlIcFgRqsjzASqiNUukROpcoHzF/2GV5JBAdotOTSZuw4rjs9Nb+4WIiCZhgvVVSrAH4xt0AK5ZZQjOkDsmRN44GVU4Y75p/kGKwIDW3DjK8Il44sgMLdTOQAffUN/SaFZeuGOxLgXEQwr60WO8mC10caWMmQPViBUdiwxRdG47crSrDzE6ZYW2aJxsQti86wfv1+WsnJNZ3PtsBUhoB47fhV7FWHzAGfYGR1q+AaNDX7hTJq7hdWCbKJDr7xfm4CWaai91qsYgAXApVj210XR7AbhAmHRFlhe+0YL6VKwynS4JGiFInn1R+nbsrklc5V793lH+ap46c7cVAqALZnvTP7OSetA2vg7SrYhg2AheFLyqWeRuu/EiM9/wDQgx66QnQKoWTQx4x45+FLDVO+pkcE9Do4FLgtbF8s4pTzxQBMcrmYkdh0oKHLKgSVeYrdkkop0YYuxFVAfny3v+5c6NAgsjq+ceE+f9N04Z86nJZkGfb2ynQBZWDNOb62xvYrfwR84kXKqeuIAv/KdQoTjtNhR7TeErq6MZq+lvCeE17JcX9d8IKIRkT8F/rEUPTLkPWBb8nNVLwwBgna7f/SRRJd9Uvp30hmoxijWBiDR51fuMocgDsaIaBdjCjsic7zlJ04NrsqhD+4UBCD5UB8ADWrP0LE0IHeDbWjDafNzOj5oXr7HdsSAOmA62TUD8y0L0QutMTwnzh0PnqjFymHENcEjdwsQkqnZYf9pQ3w/pREe8Lqa37488cyEkDi7msgcUTGhyKE9SARnduNHfZRUy8h8Ko/aJRh/psZ4T4f9j21BnpUgH/UIrlhpr63vPKXCt0GARwlika/KcfNwUkjj0jLcRV4Zl RbkU5hPP 6XuCvUEPPCZTOJ5++kAyg7TPsgKYrDxYvMKjmVWo+gOqv1VkJBUOMSk4PVvYFaP34UeRMBzqK+JrUfyFgD+vQibLAi8hGg8msvVMgrWZUBZ03KWwWcdpekDcTxf4hqQTmTZdQYqFXO/nPpZ8sQ291Qedl7BPbmPJlDnLKhh/98NCuVPhrkdJ+vGZtWjEO9RvKtAPmoJY63orPgJWJ6lCDnJAVzKPNuf0BO7Yzhd2y2/CfhDjQsnOrnMggrR5KM4LLcCgluBk//NEDSZNxbk3RGxYhuN/0k9ilEadHkaoG+VE1VFb50ZDBWQTcnXWMowS9SFvXFCM/COJnnRaHDAX2DHiSsfVn/CdfN+1ZZvW83xAqkB9OOlTGXq0GYgHMq0KIngK1+Cl+u2YJt7CecNOtLU+SgZNYhD5mmzxbrsI5ymksx5HhSwM8SM8XfJQgTcc61xdO07oEmS9o/3lnNz7y+UU6HYGQZlHqw6w5y9lwIRdWGOrC3+0efHxDacVGfIsgrg5Q/WVFopPMheWoGYgyRD2+Mf+eKcIrz0+30jk9IIPZRd8eUXZKNOrXp76BT6iZrt8MKcY3Ek8qrcjzLI5+oN9oWChSWZv24Q+/6fHn2lgw+AliPM3KSGstqSrkxrNQB00LY3GjW0VFYPXze1QNsBW0l4S0BcKfOOsfgkQFf842nu5Z2n9D+d+YutSH+27pMME91+WgtQuURqA6NHS0m3jMWANHTQ4SXb9qq+KCLakQ54H7sveO2SMJmbOn25xgugbIn/cDeZ7H8ajINfPOqz8iykNx56WWxtfqTAmup+xxJfRovLa80skkr9jZw4nZsFhu1e4UG9p3ynaVyp+qsof7d5ub3UgoCoqAGXXhIWDaqfaUwjddhUXwzg1mDGj2n81X0tW09E9tlpK1A026P1oargK41pqu1CJhgHG/ZdvR6RME+rLM4FowHOnDlKg/vDRtcnMQPnfE4436sz+H7a8XuBtv WLxs0EGC HllzqMl01b3xT0g1iCoxJuyWduV1TJYr7VnrQxtHit7q+J3pj0RyeDSo7ZlyELOz5RizQHaRnZ0JJUljmDEoNZ4EwLi/raXGQ8lNtCrgpaM5iK+TatoQi0f4Mv7avugLylVikOBLennVn3Jg+BZuteaeJi1PPkH9xAadTvVp8y9lM4Cwo9sCZQC5e2rGts9iqRX+gVUx7IG8nl/2fo8aB7h6gawyIZhs173T4Ha11y43PaCKx7gH9liRWc6em1YQVIJxojqisKk= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: > On 14 Feb 2025, at 10:48, syzbot wrote: > >> Hello, >> >> syzbot found the following issue on: >> >> HEAD commit: df5d6180169a Add linux-next specific files for 20250210 >> git tree: linux-next >> console+strace: https://syzkaller.appspot.com/x/log.txt?x=16d343f8580000 >> kernel config: https://syzkaller.appspot.com/x/.config?x=2cd616b6e736ca7 >> dashboard link: https://syzkaller.appspot.com/bug?extid=012c6245eaea0e23f7f9 >> compiler: Debian clang version 15.0.6, GNU ld (GNU Binutils for Debian) 2.40 >> syz repro: https://syzkaller.appspot.com/x/repro.syz?x=138972a4580000 >> C reproducer: https://syzkaller.appspot.com/x/repro.c?x=11737b18580000 >> >> Downloadable assets: >> disk image: https://storage.googleapis.com/syzbot-assets/92495cf20271/disk-df5d6180.raw.xz >> vmlinux: https://storage.googleapis.com/syzbot-assets/4b3656161842/vmlinux-df5d6180.xz >> kernel image: https://storage.googleapis.com/syzbot-assets/7fbc4e7a0f5d/bzImage-df5d6180.xz >> >> The issue was bisected to: >> >> commit 19c067c8a0f18b62d4a4235b0b327624c86f2e40 >> Author: Zi Yan >> Date: Wed Feb 5 03:14:13 2025 +0000 >> >> mm/huge_memory: add buddy allocator like folio_split() >> >> bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=102f9bdf980000 >> final oops: https://syzkaller.appspot.com/x/report.txt?x=122f9bdf980000 >> console output: https://syzkaller.appspot.com/x/log.txt?x=142f9bdf980000 >> >> IMPORTANT: if you fix the issue, please add the following tag to the commit: >> Reported-by: syzbot+012c6245eaea0e23f7f9@syzkaller.appspotmail.com >> Fixes: 19c067c8a0f1 ("mm/huge_memory: add buddy allocator like folio_split()") >> >> Oops: general protection fault, probably for non-canonical address 0xdffffc0000000024: 0000 [#1] PREEMPT SMP KASAN PTI >> KASAN: null-ptr-deref in range [0x0000000000000120-0x0000000000000127] >> CPU: 1 UID: 0 PID: 5949 Comm: syz-executor163 Not tainted 6.14.0-rc2-next-20250210-syzkaller #0 >> Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 12/27/2024 >> RIP: 0010:shmem_mapping+0x25/0x50 mm/shmem.c:281 >> Code: 90 90 90 90 90 f3 0f 1e fa 53 48 89 fb e8 c3 3a bd ff 48 81 c3 20 01 00 00 48 89 d8 48 c1 e8 03 48 b9 00 00 00 00 00 fc ff df <80> 3c 08 00 74 08 48 89 df e8 dd 35 24 00 48 c7 c0 80 6c 14 8c 48 >> RSP: 0018:ffffc90004036dd8 EFLAGS: 00010006 >> RAX: 0000000000000024 RBX: 0000000000000120 RCX: dffffc0000000000 >> RDX: 0000000000000000 RSI: 0000000000000600 RDI: 0000000000000000 >> RBP: 0000000000000600 R08: ffffffff822bcf18 R09: 1ffffd4000331008 >> R10: dffffc0000000000 R11: fffff94000331009 R12: ffffea0001988018 >> R13: ffffea0001988080 R14: ffffea0001988018 R15: ffffea0001988000 >> FS: 00007f5e045316c0(0000) GS:ffff8880b8700000(0000) knlGS:0000000000000000 >> CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 >> CR2: 00007f5e0458dae0 CR3: 0000000023c78000 CR4: 00000000003526f0 >> DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 >> DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 >> Call Trace: >> >> __split_unmapped_folio+0x238a/0x3e50 mm/huge_memory.c:3587 >> __folio_split+0x1267/0x16d0 mm/huge_memory.c:3871 >> try_folio_split include/linux/huge_mm.h:374 [inline] >> truncate_inode_partial_folio+0x55d/0xdc0 mm/truncate.c:230 >> shmem_undo_range+0xab7/0x1820 mm/shmem.c:1144 >> shmem_truncate_range mm/shmem.c:1224 [inline] >> shmem_fallocate+0x431/0xf20 mm/shmem.c:3674 >> vfs_fallocate+0x623/0x7a0 fs/open.c:338 >> madvise_remove mm/madvise.c:1034 [inline] >> madvise_vma_behavior mm/madvise.c:1269 [inline] >> madvise_walk_vmas mm/madvise.c:1511 [inline] >> madvise_do_behavior+0x1f29/0x3c00 mm/madvise.c:1646 >> do_madvise mm/madvise.c:1744 [inline] >> __do_sys_madvise mm/madvise.c:1752 [inline] >> __se_sys_madvise mm/madvise.c:1750 [inline] >> __x64_sys_madvise+0x11b/0x140 mm/madvise.c:1750 >> do_syscall_x64 arch/x86/entry/common.c:52 [inline] >> do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83 >> entry_SYSCALL_64_after_hwframe+0x77/0x7f >> RIP: 0033:0x7f5e04576519 >> Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 51 18 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b0 ff ff ff f7 d8 64 89 01 48 >> RSP: 002b:00007f5e04531218 EFLAGS: 00000246 ORIG_RAX: 000000000000001c >> RAX: ffffffffffffffda RBX: 00007f5e04600308 RCX: 00007f5e04576519 >> RDX: 0000000000000009 RSI: 0000000000600003 RDI: 0000400000000000 >> RBP: 00007f5e04600300 R08: 0000000000000000 R09: 0000000000000000 >> R10: 0000000000000000 R11: 0000000000000246 R12: 00007f5e045cd074 >> R13: 0000400000000000 R14: 0000400000000140 R15: 0000400000000040 >> >> Modules linked in: >> ---[ end trace 0000000000000000 ]--- >> RIP: 0010:shmem_mapping+0x25/0x50 mm/shmem.c:281 >> Code: 90 90 90 90 90 f3 0f 1e fa 53 48 89 fb e8 c3 3a bd ff 48 81 c3 20 01 00 00 48 89 d8 48 c1 e8 03 48 b9 00 00 00 00 00 fc ff df <80> 3c 08 00 74 08 48 89 df e8 dd 35 24 00 48 c7 c0 80 6c 14 8c 48 >> RSP: 0018:ffffc90004036dd8 EFLAGS: 00010006 >> RAX: 0000000000000024 RBX: 0000000000000120 RCX: dffffc0000000000 >> RDX: 0000000000000000 RSI: 0000000000000600 RDI: 0000000000000000 >> RBP: 0000000000000600 R08: ffffffff822bcf18 R09: 1ffffd4000331008 >> R10: dffffc0000000000 R11: fffff94000331009 R12: ffffea0001988018 >> R13: ffffea0001988080 R14: ffffea0001988018 R15: ffffea0001988000 >> FS: 00007f5e045316c0(0000) GS:ffff8880b8700000(0000) knlGS:0000000000000000 >> CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 >> CR2: 00007f5e0458dae0 CR3: 0000000023c78000 CR4: 00000000003526f0 >> DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 >> DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 >> ---------------- >> Code disassembly (best guess): >> 0: 90 nop >> 1: 90 nop >> 2: 90 nop >> 3: 90 nop >> 4: 90 nop >> 5: f3 0f 1e fa endbr64 >> 9: 53 push %rbx >> a: 48 89 fb mov %rdi,%rbx >> d: e8 c3 3a bd ff call 0xffbd3ad5 >> 12: 48 81 c3 20 01 00 00 add $0x120,%rbx >> 19: 48 89 d8 mov %rbx,%rax >> 1c: 48 c1 e8 03 shr $0x3,%rax >> 20: 48 b9 00 00 00 00 00 movabs $0xdffffc0000000000,%rcx >> 27: fc ff df >> * 2a: 80 3c 08 00 cmpb $0x0,(%rax,%rcx,1) <-- trapping instruction >> 2e: 74 08 je 0x38 >> 30: 48 89 df mov %rbx,%rdi >> 33: e8 dd 35 24 00 call 0x243615 >> 38: 48 c7 c0 80 6c 14 8c mov $0xffffffff8c146c80,%rax >> 3f: 48 rex.W >> > > > #syz test: github.com:x-y-z/linux-1gb-thp.git syzkaller_fix_20250114 "github.com:x-y-z/linux-1gb-thp.git" does not look like a valid git repo address. > > origin_folio->mapping becomes NULL, since it was dropped, and the remaining > after-split folios are still trying to use origin_folio->mapping. It leads > to the error. And the original __split_huge_page() did not check > origin_folio->index nor dropped it. __split_unmapped_folio() should keep > the original behavior. > > Fixed it by not dropping origin_folio. > > My local test do not fail and I am triggering syzbot to test the change > to confirm it. > > Best Regards, > Yan, Zi