From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D6914C433E1 for ; Mon, 25 May 2020 06:58:18 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id A305A206DD for ; Mon, 25 May 2020 06:58:18 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A305A206DD Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 39BF18001D; Mon, 25 May 2020 02:58:18 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 34B568000E; Mon, 25 May 2020 02:58:18 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 260548001D; Mon, 25 May 2020 02:58:18 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0049.hostedemail.com [216.40.44.49]) by kanga.kvack.org (Postfix) with ESMTP id 0E5608000E for ; Mon, 25 May 2020 02:58:18 -0400 (EDT) Received: from smtpin05.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id C588C181AEF09 for ; Mon, 25 May 2020 06:58:17 +0000 (UTC) X-FDA: 76854337434.05.desk98_8270821a7705e X-HE-Tag: desk98_8270821a7705e X-Filterd-Recvd-Size: 2546 Received: from huawei.com (szxga04-in.huawei.com [45.249.212.190]) by imf30.hostedemail.com (Postfix) with ESMTP for ; Mon, 25 May 2020 06:58:16 +0000 (UTC) Received: from DGGEMS405-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id 968702E8603D2EE3E816; Mon, 25 May 2020 14:58:07 +0800 (CST) Received: from [127.0.0.1] (10.173.220.25) by DGGEMS405-HUB.china.huawei.com (10.3.19.205) with Microsoft SMTP Server id 14.3.487.0; Mon, 25 May 2020 14:58:00 +0800 Subject: Re: [PATCH v2 3/6] arm64: Add tlbi_user_level TLB invalidation helper To: Catalin Marinas CC: , , , , , , , , , , , , , , , , , , , , , , , , References: <20200423135656.2712-1-yezhenyu2@huawei.com> <20200423135656.2712-4-yezhenyu2@huawei.com> <20200522154925.GE26492@gaia> From: Zhenyu Ye Message-ID: <67ac92a2-d37b-d472-3cbc-0bc855235c3f@huawei.com> Date: Mon, 25 May 2020 14:57:58 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.3.0 MIME-Version: 1.0 In-Reply-To: <20200522154925.GE26492@gaia> Content-Type: text/plain; charset="gbk" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.173.220.25] X-CFilter-Loop: Reflected X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2020/5/22 23:49, Catalin Marinas wrote: > On Thu, Apr 23, 2020 at 09:56:53PM +0800, Zhenyu Ye wrote: >> @@ -190,8 +196,8 @@ static inline void flush_tlb_page_nosync(struct vm_area_struct *vma, >> unsigned long addr = __TLBI_VADDR(uaddr, ASID(vma->vm_mm)); >> >> dsb(ishst); >> - __tlbi(vale1is, addr); >> - __tlbi_user(vale1is, addr); >> + __tlbi_level(vale1is, addr, 0); >> + __tlbi_user_level(vale1is, addr, 0); >> } > > This one remains with a level 0 throughout the series. Is this > intentional? If we can't guarantee the level here, better to use the > non-level __tlbi(). > OK, I will change it back to non-level __tlbi(). Thanks, Zhenyu