From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6DEDAD3C538 for ; Thu, 17 Oct 2024 23:42:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B45146B0082; Thu, 17 Oct 2024 19:42:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AF5CE6B0083; Thu, 17 Oct 2024 19:42:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9E41C6B0085; Thu, 17 Oct 2024 19:42:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 7FBE56B0082 for ; Thu, 17 Oct 2024 19:42:00 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 173BE403F8 for ; Thu, 17 Oct 2024 23:41:53 +0000 (UTC) X-FDA: 82684719306.12.5736183 Received: from out30-118.freemail.mail.aliyun.com (out30-118.freemail.mail.aliyun.com [115.124.30.118]) by imf25.hostedemail.com (Postfix) with ESMTP id 769E6A0018 for ; Thu, 17 Oct 2024 23:41:49 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=J1rrqGLn; spf=pass (imf25.hostedemail.com: domain of xueshuai@linux.alibaba.com designates 115.124.30.118 as permitted sender) smtp.mailfrom=xueshuai@linux.alibaba.com; dmarc=pass (policy=none) header.from=linux.alibaba.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1729208469; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=0aawDGjGNZQE0Mn+vyxLbUtklTzFw7RqZEkL6wKmfks=; b=Mm/DSX+sYbDP9/os9i7wnw6gPz6UrA6o3zlRBe8akvpHGYmTMN+8LJxszkwKOJr+pBSVj/ O8BrqCg+yTr6UbOywkm/yVLjTVh8exJg+nOEj4JFGny2JCHbg5z5QwKRmwXOj5pbtm22w9 Ux8Oe4N+XqbbVQK3o4KmZWjuTaRa0RQ= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=J1rrqGLn; spf=pass (imf25.hostedemail.com: domain of xueshuai@linux.alibaba.com designates 115.124.30.118 as permitted sender) smtp.mailfrom=xueshuai@linux.alibaba.com; dmarc=pass (policy=none) header.from=linux.alibaba.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1729208469; a=rsa-sha256; cv=none; b=edt7vummzBxEnv4v5hJG5UfxGFqZutt02DNbzLP81G6XBXb9K/TIxkzGdhc7CVO69qc50w kmvc4w5Z02p7ltG3C9ccAHiacTnxm9S+9hUMF+kQbrVMNMBEJ4mjacqHk8RftkeBMbFIau W901pobb4xTnPfc2KFvg5Xotb7ag7PQ= DKIM-Signature:v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.alibaba.com; s=default; t=1729208512; h=Message-ID:Date:MIME-Version:Subject:To:From:Content-Type; bh=0aawDGjGNZQE0Mn+vyxLbUtklTzFw7RqZEkL6wKmfks=; b=J1rrqGLnvWJkz8uIrPbobfLCGxm+MPAsOmmwOoTaOElI8N4wOTZmhrmqG+wU367O9PmslGZwk5Pz/lt0QlK0pnd8L4wr3EffwTqEK3ry6egZS5ijkeUEZrPXKFKPQbyA1l3+gGMrsEEgNmHBpe5KB8dXrjdLN3iGZe21IX5qqCY= Received: from 30.246.161.56(mailfrom:xueshuai@linux.alibaba.com fp:SMTPD_---0WHLxo66_1729208507 cluster:ay36) by smtp.aliyun-inc.com; Fri, 18 Oct 2024 07:41:50 +0800 Message-ID: <679e9acc-3d76-43dc-a00f-9301a1da0ce6@linux.alibaba.com> Date: Fri, 18 Oct 2024 07:41:47 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v14 1/3] ACPI: APEI: send SIGBUS to current task if synchronous memory error not recovered To: Jonathan Cameron Cc: mark.rutland@arm.com, catalin.marinas@arm.com, mingo@redhat.com, robin.murphy@arm.com, bp@alien8.de, rafael@kernel.org, wangkefeng.wang@huawei.com, tanxiaofei@huawei.com, mawupeng1@huawei.com, tony.luck@intel.com, linmiaohe@huawei.com, naoya.horiguchi@nec.com, james.morse@arm.com, tongtiangen@huawei.com, gregkh@linuxfoundation.org, will@kernel.org, jarkko@kernel.org, linux-acpi@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, akpm@linux-foundation.org, linux-edac@vger.kernel.org, x86@kernel.org, justin.he@arm.com, ardb@kernel.org, ying.huang@intel.com, ashish.kalra@amd.com, baolin.wang@linux.alibaba.com, tglx@linutronix.de, dave.hansen@linux.intel.com, lenb@kernel.org, hpa@zytor.com, robert.moore@intel.com, lvying6@huawei.com, xiexiuqi@huawei.com, zhuo.song@linux.alibaba.com, linux-cxl@vger.kernel.org References: <20221027042445.60108-1-xueshuai@linux.alibaba.com> <20241014084240.18614-2-xueshuai@linux.alibaba.com> <20241017103923.00007033@Huawei.com> From: Shuai Xue In-Reply-To: <20241017103923.00007033@Huawei.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspam-User: X-Stat-Signature: zxbzcmjb13j6gwdpshug5dzo6m1jkk1m X-Rspamd-Queue-Id: 769E6A0018 X-Rspamd-Server: rspam11 X-HE-Tag: 1729208509-575448 X-HE-Meta: U2FsdGVkX183H1+0wau6GnV3au0wCFfqUqbAq6rhNt7g87vPxUWWGS+EgdJ51JS1ecOKGnT+Ez0rhgUXZOGbs7PQKW8ImUCDpQ3yWlF0y7tLccYN0KFGOi/8X4F9RXiur7MqtWGSRadCR1B/LG4rW3ukEpuZWZPXPo9pWO9A4iGr91FoT9Tb4O/I4hpjEK+v/KK72RwIbSSbeAliDDBfQy2jz9oz7JqJfmrBZLZnXTbi4kX5qoELGgmVyCvJP+1p6RPQ/CLoycy9d3jYoyNe4qNbRbxSotGKpt6/09whLpkDPU1jG6h2Q9xhnpom4hB2OuVP3feqmEr7ShMe/GUz5iuSrnvSGcRnF79SZlGHE3BrXc38EmPgeAMbnJKlsq/Cuz82mqTnI4YjzexgqjnvMt6FdcPrwSxt2XU+odx0APrkIV9mnfFwzf5rv91hEO7vkJ05KK4BfyBv8s25R3L/uvezBxsdwAFaKUkP9V9t3vmGXoMnbnKUUVKz4mPjz0fVXgGBThTQVZEFPPV41zVxsbQRWGoRD7KWbT7lWBjAFkZBnpzCsMQP2QSbCntwoASSK1EHvFMvzk9zW7RVb7arhcDWyTUPGKMBT7QUaEjt+stOMQys3+9oyyJxEQviRThHT16OC4XU84O8tBAf2J/L5Qg5/2/3a+7+XyqJHeVa8e+npcCsR1WLSShrT2FKKw10iXtLmg7WT9vRGht0mc6MOd7D8XHfKRTJKhaFqgbsfE/wT3Y4zhWn1lG9BL1uOmxgGw3kJ571FDkcZwF61fY34LSsw35EigVo0eueo6qbyi1A/ZGkSwhxL8CoZXUPWjlxFi8VLEh+OjB0UBJkuIAVJieHFy8m1M/lRygy0JXMMa1egM0pIBdxSjHYNMMRcLYEwv5t8YIkWXTqBPYIRJFjVjtx7cKUyaQdAetBumGQVZ6iPccNdm3jwSCaEJdTFjy979pS1bWtfYTSs4HuZQB WYl91BAZ xWVxMxrlnH2MHXUc415GEHXydVmIC8KjeGnf4fLLke27RVP0e8TRxOAFLsOhoU6Bd1vyhV1PxRClNvkLHuN1Ra4qq9osN1Ujk3EbCvD1td4+rIF/qoa9c8T29zfzhCRo8ndem+Ruoh72rR50NSNnTFqsmD7P30oAandrHKhIZhx27Q2HxgiFvtIilArA6cbRbRBN5W4Sx6gh8jpmNlvi+oil0WQzthoXvfsOalI4JYCFM9sFnA57Kx7R16/HQcX0fA/Zp4vSqxShjLU62xNIXTOpfL8yR48cI7/NSdl7ILoaybXpSIypLke6fsNW8uOiedcSYCXoc+7S3dVlrcBP4uYDj5bJOcZgmdDL2 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: 在 2024/10/17 17:39, Jonathan Cameron 写道: > On Mon, 14 Oct 2024 16:42:38 +0800 > Shuai Xue wrote: > >> Synchronous error was detected as a result of user-space process accessing >> a 2-bit uncorrected error. The CPU will take a synchronous error exception >> such as Synchronous External Abort (SEA) on Arm64. The kernel will queue a >> memory_failure() work which poisons the related page, unmaps the page, and >> then sends a SIGBUS to the process, so that a system wide panic can be >> avoided. >> >> However, no memory_failure() work will be queued when abnormal synchronous >> errors occur. These errors can include situations such as invalid PA, >> unexpected severity, no memory failure config support, invalid GUID >> section, etc. In such case, the user-space process will trigger SEA again. >> This loop can potentially exceed the platform firmware threshold or even >> trigger a kernel hard lockup, leading to a system reboot. >> >> Fix it by performing a force kill if no memory_failure() work is queued >> for synchronous errors. >> >> Signed-off-by: Shuai Xue >> Reviewed-by: Jarkko Sakkinen > > The subtle cases in here are the various other forms of delayed handling > buried in some of the record handling that don't set queued. > I've been through them all and have convinced myself that either > hey should never be synchronous or that there is no attempt to > recover in kernel today (non memory things such as CXL protocol > collapse, which might I guess be detected synchronously on a read > - though I'd expect poison and a memory error first) so the correct > thing to do is what you have here. > > Fiddly code though with a lot of paths, so more eyes welcome! > > Reviewed-by: Jonathan Cameron > > +CC linux-cxl for info. Thanks :) Best Regards, Shuai