From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7D189C4332F for ; Wed, 13 Dec 2023 00:54:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 18F026B00CD; Tue, 12 Dec 2023 19:54:10 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 13F366B00CE; Tue, 12 Dec 2023 19:54:10 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EFA5C6B00D4; Tue, 12 Dec 2023 19:54:09 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id DA3AB6B00CD for ; Tue, 12 Dec 2023 19:54:09 -0500 (EST) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id AF67740955 for ; Wed, 13 Dec 2023 00:54:09 +0000 (UTC) X-FDA: 81559973418.26.DE9264F Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by imf16.hostedemail.com (Postfix) with ESMTP id 46813180014 for ; Wed, 13 Dec 2023 00:54:06 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b="ao/jdpu2"; dmarc=pass (policy=none) header.from=ibm.com; spf=pass (imf16.hostedemail.com: domain of iii@linux.ibm.com designates 148.163.156.1 as permitted sender) smtp.mailfrom=iii@linux.ibm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1702428846; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=lbS2sOhFO9H2/jPqcY5CcYk1fjHyj8RVG0VTiN5eHDE=; b=X3i3wE0ksC3/yCH0/ujLVqqoMLRrOkGgUxT1Oi5096doNMIhg935Ey0Wd6h3QXo0o/4QbQ nDnFat0TllTydEgXgC+dUnXgyvJy/SYX+aa6zkyXsD5DUS1zpzjC0ugZ7ONSSjFglD82gV 8XTbGZ33I66rARLHpiT5sRe0iy0ugqY= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b="ao/jdpu2"; dmarc=pass (policy=none) header.from=ibm.com; spf=pass (imf16.hostedemail.com: domain of iii@linux.ibm.com designates 148.163.156.1 as permitted sender) smtp.mailfrom=iii@linux.ibm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1702428846; a=rsa-sha256; cv=none; b=h5cwETiUyx31OweMGaxjkkdoDTHH+jS33R5dcBa7y+tg7YAEppqzZ6//AQR2clKpb1amsF XXD/TkKRR0pqOwnJ5RW9ZLsc2GvOOtmuFHJKnYVOreFrbRtNwD5TE/mtNN/lug8KucGCw4 5ArsUPtmzjaJcg9hV70JKw06RKEwWo0= Received: from pps.filterd (m0353727.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 3BCMv1DX002263; Wed, 13 Dec 2023 00:53:58 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : subject : from : to : cc : date : in-reply-to : references : content-type : content-transfer-encoding : mime-version; s=pp1; bh=lbS2sOhFO9H2/jPqcY5CcYk1fjHyj8RVG0VTiN5eHDE=; b=ao/jdpu2hZt3J9owEiX4iHbmvAEUN4JfD/u6ng6C8n9tR+ctw1emwbC0SMYXm/R0Ep2r dLil8U64b294FtxyB/9bn2k4LVctv80bqBByC2OMEXLDdkqmYI/Fv7adjHyOwv+T1V/e zA0cd4VOeN2iautx0zv9gzrI2ll9ETQXvxWu8dWS+VYITQ7dP/PzeI5lVc+GPC/2esJx n7+gu6fyQ7lHDGtv3IxOWMoDv+eiObGE73khBaLn1gFBOHC1iz1QIooOSDa7XwLJyfEU wFITkKyW+BZ0Os+RgaD+mzwDe5+J37gIEsvaGHzbfQgB4kd4ifB89QqHDOTvAsgRLBBm Cg== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3uy0rv2k3s-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 13 Dec 2023 00:53:58 +0000 Received: from m0353727.ppops.net (m0353727.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 3BD0diKk022697; Wed, 13 Dec 2023 00:53:57 GMT Received: from ppma11.dal12v.mail.ibm.com (db.9e.1632.ip4.static.sl-reverse.com [50.22.158.219]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3uy0rv2k35-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 13 Dec 2023 00:53:57 +0000 Received: from pps.filterd (ppma11.dal12v.mail.ibm.com [127.0.0.1]) by ppma11.dal12v.mail.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 3BCN7OsC013874; Wed, 13 Dec 2023 00:53:56 GMT Received: from smtprelay07.fra02v.mail.ibm.com ([9.218.2.229]) by ppma11.dal12v.mail.ibm.com (PPS) with ESMTPS id 3uw5924m32-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 13 Dec 2023 00:53:55 +0000 Received: from smtpav01.fra02v.mail.ibm.com (smtpav01.fra02v.mail.ibm.com [10.20.54.100]) by smtprelay07.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 3BD0rr0214221950 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 13 Dec 2023 00:53:53 GMT Received: from smtpav01.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 307E92004B; Wed, 13 Dec 2023 00:53:53 +0000 (GMT) Received: from smtpav01.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id E28A720040; Wed, 13 Dec 2023 00:53:51 +0000 (GMT) Received: from [9.171.70.156] (unknown [9.171.70.156]) by smtpav01.fra02v.mail.ibm.com (Postfix) with ESMTP; Wed, 13 Dec 2023 00:53:51 +0000 (GMT) Message-ID: <679e7142d4ed4da34b6b4b756216170d6c789e84.camel@linux.ibm.com> Subject: Re: [PATCH v2 18/33] lib/string: Add KMSAN support to strlcpy() and strlcat() From: Ilya Leoshkevich To: Alexander Potapenko Cc: Alexander Gordeev , Andrew Morton , Christoph Lameter , David Rientjes , Heiko Carstens , Joonsoo Kim , Marco Elver , Masami Hiramatsu , Pekka Enberg , Steven Rostedt , Vasily Gorbik , Vlastimil Babka , Christian Borntraeger , Dmitry Vyukov , Hyeonggon Yoo <42.hyeyoo@gmail.com>, kasan-dev@googlegroups.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-s390@vger.kernel.org, linux-trace-kernel@vger.kernel.org, Mark Rutland , Roman Gushchin , Sven Schnelle Date: Wed, 13 Dec 2023 01:53:51 +0100 In-Reply-To: References: <20231121220155.1217090-1-iii@linux.ibm.com> <20231121220155.1217090-19-iii@linux.ibm.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.48.4 (3.48.4-1.fc38) MIME-Version: 1.0 X-TM-AS-GCONF: 00 X-Proofpoint-GUID: CoFzpVB1hjayWnb5EoMT-xEl3omYP96D X-Proofpoint-ORIG-GUID: hDPpadErq5XkPzsxCdCzkDyCXRSYxuts X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.997,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2023-12-12_14,2023-12-12_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 impostorscore=0 suspectscore=0 spamscore=0 lowpriorityscore=0 mlxlogscore=812 malwarescore=0 priorityscore=1501 phishscore=0 bulkscore=0 mlxscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311290000 definitions=main-2312130004 X-Rspamd-Queue-Id: 46813180014 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: jxbbf5ingnpdnjwrwtoe6psaxho5ttwy X-HE-Tag: 1702428846-690541 X-HE-Meta: U2FsdGVkX19O02SiJYttF1GqI6ythp098XbbYmmxwB055SqvzWbL2DAR1iAQb5SlgOMMgWIxUs75GRi2DFm1A6RqED59PUTr0HcfbA2QNvSfc6FtdrwbuskvkqnMZA+v+PYX3TG3aS3ZJk7+DKa6ACeFJ0222zbnNN0epUqlthRWjO6GuWYbz2yvCS4QpIsI3yXp6yPkxF24Hm/8vsFMOWBGGsv0a4v3o5FwdAhSMLm93aISiiL/ZtGso/v6DFnyQ6PE6Lgf+cHFDFfp4xq8r7d6lZxqNfixHVkmQ1TD1ha5CdOUbEKGwjsdge05zlcggA8r6tu8j+pbFJ2h6GSaUCm3nyMYTj/+17COOkFbe8SK9MNMqqZfSWdh3ceM+YH0j94Ox95uj1s0K+U/AV9+UPAdPmzhZvWXpV/D4erl8wvQoPJpNldrs1Wn1htipx7QIA5kUIgEzmpbRxI5vVaVfpJkkzdvQHQV9gMgsXa+d4MJ/Nlp7uvCPfsgm4kCjSYRIyC/QF/We/YitSjUfnbbMB5EFpu2Jlnlma4LofLnuuu8aItibg59581Fa+MezRGJK/DP7NBBpo91C8AripVWIVlkrRZkB71xem8f/TDdITq52diWIz2RUiJZ9L6A2/ysDOglawg9Du14HeQq7dsiREaHMQuwRBop8MVDfI5cC2KTQhRituFyu0BQVNAvF7hq8KNzt2SY65JL1FiQe/nOeo46QLZVcT7XaiP3amXkMFoad5/QZnJ0znk0MU2J93WLbVN3xT2ec5UCPeJaJckuBI9n96C4YIr+CIE17fFLdk42KfllrgGF8XW7qbr56P1tZsemPwlWb1FEur9cyxKGc0Mf2MBxGSeaYtfoaxPKK78iD/z9STwxLMjqOI7T2RWywV5V9YDR1H5tksdoqHJ+ksOK+yZ47OfNrcBRpLsrhW1Zh0w01TiQ07+7IHmbp264Mo+YKWprF1dwUqlY45v DMKwRQid SFaG0Xwjkplknhw3d8zFSrPnDX0e/+xnUstZnw6vtJldOmnELL0bl8ejKRC0tm4isT3rTGsUqufxZZy6g4rnYFigIY+nj4g/3sjQyu3JyhB4B9ef6AWfb/DyTxltTbKmVwXvYPX4DK/QHbZjkIkH39pzKT0bfWPtPbXua/73M/K/IY/86gibN9fxXTYs1SC8VKUzG3Bcmywkr+tOHopGlWMchiS5YZ+rZgO7f1vEWEx6YV57f//r7Jrk+V8NPUr/Btq8eaOelOLxz6l98HfqdxcEJhbeT9l7iaewQhiXXvkFYM3UzTGs5+mB9sixjPEG2Yrne X-Bogosity: Ham, tests=bogofilter, spamicity=0.000571, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, 2023-12-08 at 17:50 +0100, Alexander Potapenko wrote: > On Tue, Nov 21, 2023 at 11:02=E2=80=AFPM Ilya Leoshkevich > wrote: > >=20 > > Currently KMSAN does not fully propagate metadata in strlcpy() and > > strlcat(), because they are built with -ffreestanding and call > > memcpy(). In this combination memcpy() calls are not instrumented. >=20 > Is this something specific to s390? Nice catch - I can't reproduce this behavior anymore. Even if I go back to the clang version that first introduced KMSAN on s390x, the memset() instrumentation with -ffreestanding is still there. I should have written down more detailed notes after investigating this, but here we are. I will drop this patch as well as 10/33. [...]