From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5D6ECE77188 for ; Tue, 14 Jan 2025 17:22:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D2D976B0083; Tue, 14 Jan 2025 12:22:31 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id CDC8D6B0085; Tue, 14 Jan 2025 12:22:31 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B56636B0088; Tue, 14 Jan 2025 12:22:31 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 97C916B0083 for ; Tue, 14 Jan 2025 12:22:31 -0500 (EST) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 25171160BAC for ; Tue, 14 Jan 2025 17:22:31 +0000 (UTC) X-FDA: 83006726502.11.007E546 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.16]) by imf25.hostedemail.com (Postfix) with ESMTP id 1E148A0009 for ; Tue, 14 Jan 2025 17:22:25 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=FUdxUoB5; spf=pass (imf25.hostedemail.com: domain of dan.j.williams@intel.com designates 192.198.163.16 as permitted sender) smtp.mailfrom=dan.j.williams@intel.com; dmarc=pass (policy=none) header.from=intel.com; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}") ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736875347; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=+MDNtgjNBZVepTC3H9C7JeaFP4iRlgmSBT03oo+pp1c=; b=AZMSd+QxgCJPqerpw9I1/L6uQe/uBWKDLoAD+5H9zbiavObQliZ2J8JSYREISuFa3P9Bgg kSYAhYyln2AxUZQq1ccLb2O2ENtjmdByXWZB9KNKh87yubbE6NU3t+Z/2vU8Ui2N+zhMJO jmBD0y+16BOoywxBS0LBl0zSqOJvHMk= ARC-Authentication-Results: i=2; imf25.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=FUdxUoB5; spf=pass (imf25.hostedemail.com: domain of dan.j.williams@intel.com designates 192.198.163.16 as permitted sender) smtp.mailfrom=dan.j.williams@intel.com; dmarc=pass (policy=none) header.from=intel.com; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}") ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1736875347; a=rsa-sha256; cv=fail; b=rL/RnySFVmsZfVkKoAJtvRfnPWcg3fXJWcfiR/LpB55fB481PuUQZN+NuQcMCBPzMZXWr2 hA1IDn2RrnnJcy4kE7yRRcpuI8qD+T8cRT+8c2LanTIfKC39/yVM8oZzBaKZyWhyy3jqE+ 2iD4rjAUXr6TZO5DxmYFnVqPBRDSD9o= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1736875346; x=1768411346; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=55Tmtt7WV0v75h5Q4ImId8+D+r7M42EB0y1c5a4Cp7E=; b=FUdxUoB5vTuPI3qPEpqWX4TsMpv4T2RwqqQ3HZ/kAarkTuX5Icec6f++ WN7QkEU5aXyFhSbIOhWet7LwW0HJeJ2wS9s4IPqrh3HOBM6fLBsVBMLBB kwdkuxam5bmP5ByrXz7QSM2W1kA1vP2bSbomA8sc/isCDvHdz/ueCv8Fw uWHMuzVyclD32I6+uw/0hjETGz2tuPhgb413ZDHU13LUl9ahvHqK24WBF EquvvV+Qxu1Ne1Byz0uCGLHkY8OvOCpeuB8+EOg3C0hEphAEBVw2cKF3S RrPgMxH31/LjnT5GgtDqZKxzlnSz/vlZnIX66k+FEb0ZNEn5rYZYdv4fN w==; X-CSE-ConnectionGUID: /FNc7a6GTly7ipXhtDidxw== X-CSE-MsgGUID: Th7n/hOFRPihMQFYeQ1YaA== X-IronPort-AV: E=McAfee;i="6700,10204,11315"; a="24786156" X-IronPort-AV: E=Sophos;i="6.12,314,1728975600"; d="scan'208";a="24786156" Received: from orviesa004.jf.intel.com ([10.64.159.144]) by fmvoesa110.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Jan 2025 09:22:24 -0800 X-CSE-ConnectionGUID: ulDrRzrLTkSrE6olRx3c3A== X-CSE-MsgGUID: 3+huWwa7QoS7SADjX0Q+9g== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.12,314,1728975600"; d="scan'208";a="109836181" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orviesa004.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 14 Jan 2025 09:22:24 -0800 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.44; Tue, 14 Jan 2025 09:22:22 -0800 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.44 via Frontend Transport; Tue, 14 Jan 2025 09:22:22 -0800 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.176) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.44; Tue, 14 Jan 2025 09:22:21 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=q20tXiRkm+A9bhYqer+nwsEec2fsXhrBz+4TWdPDTdcA98yvvfJGJgKmjndxgC2YOObxDFUWwrkbZgmaLGb+TmZWnTJu1hK62u9ZOgiz2VpaKV1DNumLmho3WOyLorpO9LfMgjebHk6Faj7lJmIRGwfr365+AcNm29r6U479RrUtd5EGj9WmBuElM/juLwgT44ay43JvGdBVdNYOmSyz4aUxrhBMgLVk5giX+cv8O4NfzBtKc93fRx/FgFyYgh3VHwg8+vOAp7xw6DpV4XosWjZXmG/A3TPE+pTQlIoEMzlc3DhIiOV4gZ69N7iGWEy6OOybrVBR6U5fAA2vZvmWtQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+MDNtgjNBZVepTC3H9C7JeaFP4iRlgmSBT03oo+pp1c=; b=pbTEDNjVqOUR1ydOPHP09U5QmbLImwGUuCkOSYI7j8QSBjmv7JHp+eZguPkrSkqD9OccTo+zh9LaOuqya/SdrotbS9uRGNtNX8e1YbIE26DNlNey/lo6YwfqKqWmMsoumE32cgWUuyc377KQro/TI9K32SpUp4GMvYMo/cU1lEGGKqQTB39ItkWV7CUd9SIeuWg2GBwdaHw3Kh+MNHLTxjbKrr7i8isoVgM6YnGd58bQQG4tEOjBTtd5WWd8EiY4l+Ub2RbCZVpbO3vs8UkPZU5XfK1y7Vw8uPdsfKZt1QreyUubXyanjEDNS1+LqN3pAZoofGMzdhemKgarS58Blg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from PH8PR11MB8107.namprd11.prod.outlook.com (2603:10b6:510:256::6) by SA1PR11MB5873.namprd11.prod.outlook.com (2603:10b6:806:228::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8335.18; Tue, 14 Jan 2025 17:22:05 +0000 Received: from PH8PR11MB8107.namprd11.prod.outlook.com ([fe80::6b05:74cf:a304:ecd8]) by PH8PR11MB8107.namprd11.prod.outlook.com ([fe80::6b05:74cf:a304:ecd8%5]) with mapi id 15.20.8356.010; Tue, 14 Jan 2025 17:22:05 +0000 Date: Tue, 14 Jan 2025 09:22:00 -0800 From: Dan Williams To: David Hildenbrand , Alistair Popple , , , CC: , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , Subject: Re: [PATCH v6 16/26] huge_memory: Add vmf_insert_folio_pmd() Message-ID: <67869d3878ee0_20fa294ae@dwillia2-xfh.jf.intel.com.notmuch> References: <02216c30a733ecc84951f9aeb1130cef7497125d.1736488799.git-series.apopple@nvidia.com> <31919e6c-0cec-4e3a-a0c6-a80be53d6ccc@redhat.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <31919e6c-0cec-4e3a-a0c6-a80be53d6ccc@redhat.com> X-ClientProxiedBy: MW2PR16CA0024.namprd16.prod.outlook.com (2603:10b6:907::37) To PH8PR11MB8107.namprd11.prod.outlook.com (2603:10b6:510:256::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH8PR11MB8107:EE_|SA1PR11MB5873:EE_ X-MS-Office365-Filtering-Correlation-Id: 2e5d487e-ff93-45b8-ce77-08dd34bff744 X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|376014|7416014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?WbGgDYXPANWGSmONmqU1arjDKtlFEtfdQiRjGtZAx6WshijJ6AHm7CFFT9it?= =?us-ascii?Q?7LupFap4U4K7EG0gViDa+zZ3pR/eWSG+mdZZarq1c+xA2qGoJypklZ5iNwt6?= =?us-ascii?Q?0zgrRjj5CuQwxfkzZEU4lMYfI4EIgojGPovspIdzlGVXQ368T4TRLgNN2hJB?= =?us-ascii?Q?doioSv8P6FrYJnSgonPtR+bIuhoxbp9blOq9UcA0Tnb71CjIC52ynaNeFUao?= =?us-ascii?Q?Pgs6IM5qCgS3qjgMTKRfilgWVqSdxm7XTlQx1od0LIsAQ4fbwx1iJ0n5eHsH?= =?us-ascii?Q?7etU1mWrPsLSnq5procZrUwXhO0cCifg6PuFSIwSFQdHGUycmNLf9lQePcRN?= =?us-ascii?Q?KZytPDseuGJ/ADauihKAoF/+oGJDBmFVTpIAdcF6ngc8sIAu+ETdF/Og7LNv?= =?us-ascii?Q?axJo9NfkIoFuI9DhEAPi6+Z69BZMuPjZobOcqZ91Sh5fO254TuXq8awc5Oej?= =?us-ascii?Q?inek0VNmtHERb53a70IDDibeXOMRpzYbsB+9rVMZvAe+uvHLTa0BfxjVFqui?= =?us-ascii?Q?J5H66NNi6JX0FwX0Pf2G9yUDmVyBDhyW3/HPjyiv+l3pbynX8LSHLLpsz4r9?= =?us-ascii?Q?lW2NYRvMHo50Ydbfekei+CXFILVkbVJv+hGtakVbGwezdu89T+V+X4+Turd0?= =?us-ascii?Q?XJrvaAIgEXBR0+wv6I192Pxwn1LEb/tvaFB23LZnz4OEZWPR1t6SWB9wHsS2?= =?us-ascii?Q?I+hJYwNxULZsmEgVyExXVu8Mg2yW2agQUSMluyJmiFGAi9ddKwuRaIAGOplG?= =?us-ascii?Q?HEjiDO+vJMjbihkZybG0kUcxEqKf9lWpBocuFvj+E0vmS/snz74MkKSw5lVM?= =?us-ascii?Q?SUCkm37qK/ityIZ8bD//CXcl5X5Wh/SgdnZ0/ZiJPV9QnO7+ojGyQ1SWBpU3?= =?us-ascii?Q?fOu4rDNEbIgezPFcvsutEkinjBeB98y6sV5Xi69R3vuU2uN6q9f0hDHwS8Pz?= =?us-ascii?Q?N9Bro+5OoB+XYCW2clz2/Qpc2wAFpF8N60kR2h3aHLAEmsgklxYIg2iVvRNd?= =?us-ascii?Q?z9ZioEqhq9XFSDd1br2RJoZ5t/bGnSNybAcJZnHTOCSawNBC0zNOp9Wsdph3?= =?us-ascii?Q?7WAKrdqJbdLDzEzB7U2uVlItR33l/uCd/UdF252RfXenw6s7ZU9Szt3KpiwG?= =?us-ascii?Q?QGfdSsLNMRu6Egnf+RpzF/IxwScybOmHodEk3T6kqZSakuH5EIF3GL4SeqBd?= =?us-ascii?Q?ZXOEsPIt5f6WQWz60dx6cby3WnBzmRVMUayJTdqF/+Jkrba+tsnMgkrWOoE8?= =?us-ascii?Q?xfR25QmJ7wnVEsUwvrIYXSHBWsrUKp6g6BLswcnpN0nBd3H2LNKa1rZJL8N6?= =?us-ascii?Q?37DTWlPipJZATwnFokUfk+GNj2oN8UXmKWtMdPvXB+4jh7LEmDoun0MkfXC/?= =?us-ascii?Q?EWLwEtIlTP68/sVPdVW+ln0L+0H3?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH8PR11MB8107.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(1800799024)(376014)(7416014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?SZjLKMWKlgUKXvcgaC9tMG8p5kfXmkyLVYFvna800zBrIofDYi5q+gJ0+ugf?= =?us-ascii?Q?HZr7O6FqENnE33Qi1t6r2o0GAB2YtZeDiRXYog8sF9U1soMIib1m+yRB41Wq?= =?us-ascii?Q?XFcwZcB5usBE7jCDHESzBDLypjBDXnhG60yWDOrBoMZSe/a7YtWar6Mjc4uh?= =?us-ascii?Q?vVMX9bzE7WrU1Yi1gBQztWpX7x/0ZBZPrTWEbytOronG8i5VUeABk1zIPGoK?= =?us-ascii?Q?49oLcPXf+93rj04qMjbp+LjdkWchNR50ucMn4l2BwiplQo6H/MYUC43g6Zr5?= =?us-ascii?Q?NzxYjxrpVwkJQGMOWdMQrAFvoXQfFOba4VDyvaLWxsnU7S9yAYA3y4niBuIa?= =?us-ascii?Q?ykbz3U8IdStPs24kjYyBh6l154y9Vd+cT1zA4LrRbRhdG7mZU/LPJJHAJpSS?= =?us-ascii?Q?FCk1rWYw/fEY/DcYmSVaWNzFWvSxnwxWFuERDqQ9b11AwnqELHtxhi+MEa7V?= =?us-ascii?Q?DV7TsG5dD87dWJhwbUwbo8GpXuMKhoiM8YhgUDJJOdTtknlIls9hq9JRkBuf?= =?us-ascii?Q?J7FYtBW9YOc0uB36BF8HfVm/G6F6713MxkLu8NpoIU3jwPS3s840fRC8V3+F?= =?us-ascii?Q?wdEiSZqlcx2/x8pQtIrIYF/cXfAJLPSx+16uDHKO4TPI+zkgC+nLXQxN9GN8?= =?us-ascii?Q?pUvkT5WWMAxUy8d9+cymkWPMsECjg/1Kai9SdKT3v/F4wqvj9TXZjb/qOtkl?= =?us-ascii?Q?hZScnyFCuqt1WltJnJGFK9tq5qGTH1KvRE6IRrjiVBUgQ2Q3rPsIitqew7Hd?= =?us-ascii?Q?U2MoAFbTyTd4UR9c2o1meuPMnQsVEVPuM/YkUiW+f4YCooEqKxKQmKG0TLMZ?= =?us-ascii?Q?m+RVEPfxX5eqaWYER5gjSC4PuVQJyQoPAAYHLx6JtMml/qcZOddJ/IbF/fqI?= =?us-ascii?Q?qbVx+WXx6P+Li5LBC62vxuKEZBWgsEbjhGpWgWn//xSk7eMM8ZgzsPbLrWeF?= =?us-ascii?Q?CSaSpq2W8MhjXSTL+oGzJW/l6OTQAL84qZuiZOJe5vXnwgwU8McQ5av1BL+V?= =?us-ascii?Q?d4jLL0i1EjIz8pYmPNaOVeIgRR6YzYtZedc5Sv8S2CYzLppMRDXvyeYdnznN?= =?us-ascii?Q?QbLTyhq2Me//GbsYbTzDP1mVG3+OyBdxB4yg5/iPdVgbfGODI5qvcJd6Kpgc?= =?us-ascii?Q?Y29QkDKcWTStkaTrJduvsTuqHwAHqq0aOyZWhkXH6I6ZpnKtkJyp5QlAWmse?= =?us-ascii?Q?lYz1KRpwmv23Vr+WXszFoNWvum4PuBSGAgmXYBIX10QBpiF8O8tnzhNoHDa5?= =?us-ascii?Q?5SXhhPT4bH1m2kY7COLff/FrQf88LzKjusocNXUFuUR7odMtZwLLOoRL0gb4?= =?us-ascii?Q?QPU4FCtfrH/8GsYtvDhwb2CgSHXADmieOJuiaRBNkYRGT7vWm1xvLRlVTjdq?= =?us-ascii?Q?wwAQTi3u63RStQI3JkGXnFuTEltiV3mfACKPmR6yUrd4ehsMAOUzubUcgFBn?= =?us-ascii?Q?zTTEvYwpWXT8WD0SFRENObTwUY1lVQW3AyP6stJMZxx7lhhia3QHLGQQeVbo?= =?us-ascii?Q?baYdd9TbewrXrqFE49ZDaOLr6nGdDHks91zYzubNU4mBXYKMB/GASUHXGTfh?= =?us-ascii?Q?yZAlaDC0VFaij3X96vtt7qS4b4wfBYvfxEj/toRFKqy3L1Luu9E3ZGaUQWt/?= =?us-ascii?Q?KA=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 2e5d487e-ff93-45b8-ce77-08dd34bff744 X-MS-Exchange-CrossTenant-AuthSource: PH8PR11MB8107.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Jan 2025 17:22:05.0163 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: JX3YB0KV4p5Lb8ftCWmM12cKh1hS1y4TJCn6dunwT8m8z4ET8MyT8tgeoJXt3bEKRfpfUlzbX43AH/ChuNwWL1bIEf/iCloIApmGOENIV7U= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR11MB5873 X-OriginatorOrg: intel.com X-Rspamd-Server: rspam05 X-Stat-Signature: ry84rhu73jofkngw4czzqqzsxefke3hj X-Rspamd-Queue-Id: 1E148A0009 X-Rspam-User: X-HE-Tag: 1736875345-747918 X-HE-Meta: U2FsdGVkX1+LMbiMkQhpU3H4t8pMYH2WOI6Mc2Hh0gkh/3FsOJ7uHM1ztL6YIe2e2j+62k/MaKtfeENNQlSzuqrvkBdvRXtOuttThdFobORyrA+SDzCIuzhAXCg2nwyYUxI/Ay0I2+FuIYGlOeiDPGmVp0Im16LAlhr2WzpZ9+k6xtLDqS5OSlI0j/tZo7AwUQiHPrL6bl4iB45xdM9qzk8xOy72LPhTQGEPgbcMUl0bkm9EKqoiKoJaT52AwV19BR567lnatJR0ntikl3VW3p6BIsDWLai1FD1cfBDvdlhoay6inxrkKI1rNLRfkXXkVVBzQJc+dJlxsYXhueNY/ykFYHp0acyKs8saSZ4fTWhbsvnZJ2ZI+06Dx3Tc5qP+1IXN6idrgbHI+zi7u9RzXrTnX+VEowBawsQ60ZlsZhAkQvbbUiz4b0fJRem8QuagOG/NWrsi7xVvZAkDnxjleVQA5PrGplgnoOx0eZZmR/CWxe86BqPqX2vGYY4ckGrAne2vcoka6QcR/Z39FWTDYzoWz31eIik4taZCOBYdUfYaKHMkDmHGjRCu0tFqeaGf/X1xG4qvvxnDAq7DA211FIGD/jjCqmergqFdWT5Zo2yF8HWlRTYtI6Z/5zYxUQXKZbSJZuqm73QsYGI8AzMUxe0YZiniTpSion2rLXLOPZsdbkvIE4c17fdvhA45xfeO2KEtnbJeHnVSkJIBXxeghrxGs1VJp7SWqS00Frc3uafX/GJrAeCoOLkRLpLFI/CxSMcN+B17ScXCpeQzfURhCc9OG/fnf9YlTic9DE5o5Fi0opuqTs8JMfSVFQyH8nTmOzQzy02P9dkh5ZPwYNdLcINLcD85qHL03k74oxf58R3DMs005r2OJyZSpmXvOyaf4IOYKQCtOkiJbCFqUQHVEP7GIg+Fd4KTN7kE2kAy0b5OH9/B8UDEAhfZgDlk2aaB4wuzW3wmDOr74AgoeA1 p7FFWFhw sikzv76lRhyS6gxcVRQENt+7vYA4wqL05JKd5FkFo3ENW0tfQFxBUU7fJ5qi8cMaaMZdmFzpqDge11bvRxEtBde4MxYfSYrYx41xG3Ludk78AmE7D+THo0pSRR9Bb9MuQNVwtFvs3kYhXNe5vP0JUZDgq3DoeWtbF982qZ9W8POV85lx4NiLbMVMcw2f7KWXrIyFjDvUVdzIAtUzJn+bthORp+QeDnD3JLktszynwSKE/zTIk27iq0P+/0DhGqjZU8ohFFQf7bUOeoW30Uh54bPxRR3AtmP3oNA3iflCVzMuzrdOtaN+ZsuFje6lrOy7J3Mzo3Nq+xPvy101CShFSjDSO7+YZvafJf4hvV70NV+bWnm8Ab8cTYPyAvdyzQ/P3JobgFrBCZk6YH4ZRZoUl6S+cW7lQk0ilVbjHD/bhRRecLwzYHMKuTw7ht4dvHiq4EiI6UDL6CZohhaWjTv09vMUs7cHsuoC6ZyISqeQsgSL0wZPtomXdhxAdR17Qsl6QBFjIk6w3t9Q7SjOuTwcyjQDS9s5XwuqOOEdaWUj3nwfnDOUl2Hi5srSuwg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: David Hildenbrand wrote: > > +vm_fault_t vmf_insert_folio_pmd(struct vm_fault *vmf, struct folio *folio, bool write) > > +{ > > + struct vm_area_struct *vma = vmf->vma; > > + unsigned long addr = vmf->address & PMD_MASK; > > + struct mm_struct *mm = vma->vm_mm; > > + spinlock_t *ptl; > > + pgtable_t pgtable = NULL; > > + > > + if (addr < vma->vm_start || addr >= vma->vm_end) > > + return VM_FAULT_SIGBUS; > > + > > + if (WARN_ON_ONCE(folio_order(folio) != PMD_ORDER)) > > + return VM_FAULT_SIGBUS; > > + > > + if (arch_needs_pgtable_deposit()) { > > + pgtable = pte_alloc_one(vma->vm_mm); > > + if (!pgtable) > > + return VM_FAULT_OOM; > > + } > > This is interesting and nasty at the same time (only to make ppc64 boo3s > with has tables happy). But it seems to be the right thing to do. > > > + > > + ptl = pmd_lock(mm, vmf->pmd); > > + if (pmd_none(*vmf->pmd)) { > > + folio_get(folio); > > + folio_add_file_rmap_pmd(folio, &folio->page, vma); > > + add_mm_counter(mm, mm_counter_file(folio), HPAGE_PMD_NR); > > + } > > + insert_pfn_pmd(vma, addr, vmf->pmd, pfn_to_pfn_t(folio_pfn(folio)), > > + vma->vm_page_prot, write, pgtable); > > + spin_unlock(ptl); > > + if (pgtable) > > + pte_free(mm, pgtable); > > Ehm, are you unconditionally freeing the pgtable, even if consumed by > insert_pfn_pmd() ? > > Note that setting pgtable to NULL in insert_pfn_pmd() when consumed will > not be visible here. > > You'd have to pass a pointer to the ... pointer (&pgtable). > > ... unless I am missing something, staring at the diff. In fact I glazed over the fact that this has been commented on before and assumed it was fixed: http://lore.kernel.org/66f61ce4da80_964f2294fb@dwillia2-xfh.jf.intel.com.notmuch So, yes, insert_pfn_pmd needs to take &pgtable to report back if the allocation got consumed. Good catch.