From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7B8F4C30658 for ; Fri, 5 Jul 2024 09:08:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 14FD56B00A2; Fri, 5 Jul 2024 05:08:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0FE8C6B00A3; Fri, 5 Jul 2024 05:08:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EE0C26B00A4; Fri, 5 Jul 2024 05:08:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id D0FF26B00A2 for ; Fri, 5 Jul 2024 05:08:41 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 4917DA2408 for ; Fri, 5 Jul 2024 09:08:41 +0000 (UTC) X-FDA: 82305123642.10.DF00571 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf09.hostedemail.com (Postfix) with ESMTP id 13BDF14000F for ; Fri, 5 Jul 2024 09:08:38 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=IsLSy0xU; spf=pass (imf09.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1720170505; a=rsa-sha256; cv=none; b=IWGP91aqIN9vJqWIXrhWZwROApstBoGQ27vn/mT6q/mmNtN/fm0ogwV8bszr8XATO+3fwH oMZJSS1TIdz041WBDF3IWGgQDQRnFcR3SU12HygJ5YS+15B5YK8/f2EOgll0ZKHBesrnl1 ihXi/y6j746unqI58xiNcvySKfU8y9I= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=IsLSy0xU; spf=pass (imf09.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1720170505; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=kLSncZW2G47dCrYrw0elH8PWHvRnnZSmTqNmYVPtGkk=; b=UfONn86t4cP4SsC2bS61OZv85nV049sYam+AyxL/zigYigCxBArKE8YiotTMWATRsmzYnb DUpICQhFz25Uafrn1YNQ/BcILAyhQV88RqMMooDhnaQOMz/u4YIYFCSgDpL/lwBrVvKee4 ewqMsVujKmPsLvhRfjfN5fyCDzIZnYs= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1720170518; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=kLSncZW2G47dCrYrw0elH8PWHvRnnZSmTqNmYVPtGkk=; b=IsLSy0xUUWy/tWoDbxHOFDQoo4Blr4PgjxsZ45GdOR/mKyiZRuN6nunGpXdMthtmxeHkRl N+Mybhst90VjxbBrleiW176TTm5UhOtUR3x4fRkf1T4Li6zeWYbcdMdea3q7LWcG9ae6Sw 3LP3CPBk6Ok72yx7+FPdpP8eswCMDeQ= Received: from mail-lf1-f72.google.com (mail-lf1-f72.google.com [209.85.167.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-134-8Ht-1FvRO86ynfLCB2wE-Q-1; Fri, 05 Jul 2024 05:08:35 -0400 X-MC-Unique: 8Ht-1FvRO86ynfLCB2wE-Q-1 Received: by mail-lf1-f72.google.com with SMTP id 2adb3069b0e04-52e993e31a9so1380842e87.1 for ; Fri, 05 Jul 2024 02:08:35 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720170514; x=1720775314; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=kLSncZW2G47dCrYrw0elH8PWHvRnnZSmTqNmYVPtGkk=; b=r0dQ8aSreevEXDOgvNtI3ACSB6/kQgyz3+vi5N4ucFiuiVmkreIz5A1ebt+fpd/BXU bsiVvFmeph28vgv+EFc+SbXQ5wY/2vvScbzyyVmFJZ6+wj5RjqvHgfvpNMqFBHFgbyH+ gbttNxTucBPrMfm6JSER+Q34HZd0DGY81bZr/JxZRn3qsYUfPImIPAdglmoLVuZoh8AS Cs+wkyqIVbu214a+xSZBrb1Zm3e4HyuzQgk7RNzr5RTNjgo1JDo9+YX2QawZq99OlI5T hL2UtvY5oU8xOG5UusUr5Qia+9aOdvabCrfGP5n/WtbiMQw6EZMAG3nJDBIbH+0cPQkf j1WQ== X-Forwarded-Encrypted: i=1; AJvYcCWnw9wUMBkK6DQnPWevj5TZ5UmLHWvNFwU/6depg++pC6RJktrflaNrcVQ8/CSXfsz310pdHnVdc+3GthKgQ7LwCzc= X-Gm-Message-State: AOJu0YzExeivhEZsZOIkzDLn6vSLnaPQ2F0VxuWNamMS4Q7pwCLiUqYB zp0Ws7UsqPctRocslowc8Nd5CIFtQLU+LgGxQPc4mWglApKZSYJdZM+MJ1wocud9QHngdVA6K5q dVu9aXAFi+NiE+ubQ5ihEXf19gZNuUgNX8h6JWYtRQkxCcsaf X-Received: by 2002:a05:6512:3c98:b0:52e:a60e:3a0a with SMTP id 2adb3069b0e04-52ea60e3be2mr1192762e87.2.1720170514418; Fri, 05 Jul 2024 02:08:34 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGAoAwUORgLXzI29Jn7/prnFy2lTBG1PmjslR57Y6P0FC0SYvvTAA92CwIBmUODU5uxxuWjOQ== X-Received: by 2002:a05:6512:3c98:b0:52e:a60e:3a0a with SMTP id 2adb3069b0e04-52ea60e3be2mr1192743e87.2.1720170513944; Fri, 05 Jul 2024 02:08:33 -0700 (PDT) Received: from ?IPV6:2003:cb:c702:b500:3ed7:a1c7:447e:2279? (p200300cbc702b5003ed7a1c7447e2279.dip0.t-ipconnect.de. [2003:cb:c702:b500:3ed7:a1c7:447e:2279]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4264a2ca5casm53422175e9.32.2024.07.05.02.08.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 05 Jul 2024 02:08:33 -0700 (PDT) Message-ID: <677fc803-0bb9-48dc-a1ff-3ca1fb0dea15@redhat.com> Date: Fri, 5 Jul 2024 11:08:32 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 1/2] mm: add per-order mTHP split counters To: Lance Yang , akpm@linux-foundation.org Cc: dj456119@gmail.com, 21cnbao@gmail.com, ryan.roberts@arm.com, shy828301@gmail.com, ziy@nvidia.com, libang.li@antgroup.com, baolin.wang@linux.alibaba.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Barry Song , Mingzhe Yang References: <20240704012905.42971-1-ioworker0@gmail.com> <20240704012905.42971-2-ioworker0@gmail.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20240704012905.42971-2-ioworker0@gmail.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: s33uji7s89c8ohrsqxfr75ndbdk8hnf3 X-Rspamd-Queue-Id: 13BDF14000F X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1720170518-164367 X-HE-Meta: U2FsdGVkX1+OblAACs1eZZ+DlpClKNIsm6Ph4xH71bDZzwUu0UfD5Nr+rWA6+PcB9BHlvXRsnGf/6soJUCyC68/p2NeGNug8skBNIVG9gCJUOx3YpYEflacGaUpD+I/6IU37g97YVhydRJkKaA6ccF7XzIDLoHm5cIBXJbDvQRpHwknrRuhJ2//5rbDkd4Z9A6lP+EsAI0vzrzA4zh5PhFHLc3eHeFycINVjjOMMj3x9dWfnVDp5qMwtdpOwESVBepAW7HoTt6SYYUzrgfNmMw/UHYgGRHV0RXkw/DWm1gjTtSim/2qLFuqDUbI+zoXcVESbgeOpwmoJIyF3yVPrvX0bvgIqyVicHCc7rCpE8L5V0RKGfxM7JdH6CSivVIJMFXXODoSOKEhw9VI9DKRgCvTIEync992qocPh8HstsjumYcxY5q7v1R1pEoUIhCyEyROeCpO0ypW0kBi8bIyz+7fBgh/+0TMyEbiJOgwRF0tBK7aruL8qGJ98VwJCBmI+J8NckAdBnHufpga/DH/TsCF77/JRdlDTnH4ylXfKDIMhUgKEhc0QuRNhq7RLiK1tSvR2E+w8g4A8v5mmDCNCPmUNhxkCf77ap4gCrzLYUF3YZo4ohr2J36Xkn/oIUf/Rp1CgPTM56D7s6cxH8LQNGOKfNue2/+GOMvlZX4AoQ+20C0yAP7C0Vv7GL2zeWzkXExylILXIsWpt05618CCMVvwJ9d0J0Q97NTqdaKBVnUAcqEtahIXNI+Eqx/yLv+hYqZqLqLdokGoXMYxWAWlMzGbS7cPYfjwCpaWuSuHbYYShQfiLS+tgw0/wuKHdTKicdJurNnGyepDQ9Zpf/MbuUbN9OUrGKV8NxYGhJHrbYVMSNP/U2AT5wmZji/WX6JxsnpIGY9TQ1h7XqwMV5z0vXUz1jqoXvw8cT6f5LI/rw5QS+zz5YxWADOCsNgt2qhsSZxuNp18ntTr04ygE7TI xYQePj4N 5PZjFY5GV6rJtJiB57pbuci81D2aOvhLlvUqoB4F+NizORiXHZd6NDOVgCnaq7mtZb7OT7fMlfFvje04WZX4wUOOKSmI7D8gK8sTY89HCssZ6yefF6gqPXl8/yquEbrO0yLUf+xJ9gGdlJIJJxxTFcoewFNFLRZcyRFAeRYoB6Vor0525S7ZMEJ7QskPNWknRXmsB0pKqAKBUmUoTTvT8FvWoP6p/HTwMaGN0DjDGzymVhgUqEfQDgArIpjSMmjA0EJ+vOS8RQ05MnblVHEsRtbjqsGDrpFKTo+Bt8cB77YxQVSktUJDWNAOIBCiPbXfHYaZb7KC2by1izvUOqTXWtfxu/leWcAJZSzDWxz7ZJtfxYBDF96cIBMf5knN2j+REPu90MewMXWkEiqF1GLryfZSEs8qsXDz01wsxmxFdVcTWo0g= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: > @@ -3253,8 +3259,9 @@ int split_huge_page_to_list_to_order(struct page *page, struct list_head *list, > i_mmap_unlock_read(mapping); > out: > xas_destroy(&xas); > - if (is_thp) > + if (order >= HPAGE_PMD_ORDER) We likely should be using "== HPAGE_PMD_ORDER" here, to be safe for the future. Acked-by: David Hildenbrand -- Cheers, David / dhildenb