From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5C737EB64D9 for ; Wed, 28 Jun 2023 03:02:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9040A8D0002; Tue, 27 Jun 2023 23:02:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8B4048D0001; Tue, 27 Jun 2023 23:02:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 754448D0002; Tue, 27 Jun 2023 23:02:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 656618D0001 for ; Tue, 27 Jun 2023 23:02:00 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 1662780B39 for ; Wed, 28 Jun 2023 03:02:00 +0000 (UTC) X-FDA: 80950657200.26.F8C266D Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by imf27.hostedemail.com (Postfix) with ESMTP id 206C940004 for ; Wed, 28 Jun 2023 03:01:56 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=obsBC9q2; spf=pass (imf27.hostedemail.com: domain of aneesh.kumar@linux.ibm.com designates 148.163.156.1 as permitted sender) smtp.mailfrom=aneesh.kumar@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1687921317; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=wvqgE6t+NcWFSXTcKQuUFx+7achVimLTTzLAxvns4SY=; b=rdZ0czhbNfob4niHCE8kjZ/4Cb/ObiGEkya4WOfHkgFc/t0KYnZ0F60Tmd+T1LdG00Vvio dTMwaLNOX67bQWUjBzwtrx2cY7jFj7hcy66bB+2ZpLqp9oRmrX1ZwzorA/DAYe6a7//5JB 8Oqv3z2ZRoqbWpj54LYPunR9Jc9mC7s= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1687921317; a=rsa-sha256; cv=none; b=gGM2hKodDY63xU5+hDHuKMA5UQ/TMYS2i2bwyS6KYkUBBRsWVXJVxELkWaYLEtJoGy/kWg ilvvO8MTemjgEql1DJZrNk1vStU6VS6zaH5AztlFWtjf3SWmxeMFZsc6+Oo9cO+INwqvnB 8/KPzSP/yBeLlYnl+4lZKtdD10BCESE= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=obsBC9q2; spf=pass (imf27.hostedemail.com: domain of aneesh.kumar@linux.ibm.com designates 148.163.156.1 as permitted sender) smtp.mailfrom=aneesh.kumar@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com Received: from pps.filterd (m0353727.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 35S2lY7q031019; Wed, 28 Jun 2023 03:01:38 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=pp1; bh=wvqgE6t+NcWFSXTcKQuUFx+7achVimLTTzLAxvns4SY=; b=obsBC9q2s0UcFqMcYbqV1rO/Nq+4tuYm9YQv6LUWCQYzFuR6Uu8wqjDHr63uqERQ49mk DnHXYe4SfntFJzjuQ++K037f39w2RS5skLae0+oCyk5L6K0twSEgX9jAJqH7yMdgN+5u GSf3jrjgkT3eNSCLVoIKyv5ztOQosPDViyxZMMz2wiCrgfUMVD9+X/+6hXSm54GNzCLr UfHQmRS2n+G5m2p48aNugqHhBvykFWRA36u4liJ3QU7mzGPKAWnhSzciJaIL14efkCwj /StnrUq6E+KHK0jA9c8mBBgPJrJJ30mVdrKmi1z5Zi73vVXt1YaPPVV3inXd91elcC3k QA== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3rgccsr7y9-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 28 Jun 2023 03:01:37 +0000 Received: from m0353727.ppops.net (m0353727.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 35S2qgAo012502; Wed, 28 Jun 2023 03:01:36 GMT Received: from ppma03ams.nl.ibm.com (62.31.33a9.ip4.static.sl-reverse.com [169.51.49.98]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3rgccsr7tg-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 28 Jun 2023 03:01:36 +0000 Received: from pps.filterd (ppma03ams.nl.ibm.com [127.0.0.1]) by ppma03ams.nl.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 35RNQe1i003383; Wed, 28 Jun 2023 03:01:21 GMT Received: from smtprelay04.fra02v.mail.ibm.com ([9.218.2.228]) by ppma03ams.nl.ibm.com (PPS) with ESMTPS id 3rdr4529yb-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 28 Jun 2023 03:01:21 +0000 Received: from smtpav07.fra02v.mail.ibm.com (smtpav07.fra02v.mail.ibm.com [10.20.54.106]) by smtprelay04.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 35S31JkF45220528 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 28 Jun 2023 03:01:19 GMT Received: from smtpav07.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id E4F8520040; Wed, 28 Jun 2023 03:01:18 +0000 (GMT) Received: from smtpav07.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 13D1820043; Wed, 28 Jun 2023 03:01:16 +0000 (GMT) Received: from [9.43.54.216] (unknown [9.43.54.216]) by smtpav07.fra02v.mail.ibm.com (Postfix) with ESMTP; Wed, 28 Jun 2023 03:01:15 +0000 (GMT) Message-ID: <677132e9-6c99-4d55-1eea-15555dc10c2f@linux.ibm.com> Date: Wed, 28 Jun 2023 08:31:15 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH v2 12/16] mm/vmemmap optimization: Split hugetlb and devdax vmemmap optimization Content-Language: en-US To: "Ritesh Harjani (IBM)" , linux-mm@kvack.org, akpm@linux-foundation.org, mpe@ellerman.id.au, linuxppc-dev@lists.ozlabs.org, npiggin@gmail.com, christophe.leroy@csgroup.eu Cc: Oscar Salvador , Mike Kravetz , Dan Williams , Joao Martins , Catalin Marinas , Muchun Song , Will Deacon References: <87wmzoo0j9.fsf@doe.com> From: Aneesh Kumar K V In-Reply-To: <87wmzoo0j9.fsf@doe.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-GUID: 2CxgRxFpsVPyvHbVioSz92R_xZclGdeg X-Proofpoint-ORIG-GUID: xwPkfiBs1NUrWg9D8z9n2Ht4XZOquBrf X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26 definitions=2023-06-27_16,2023-06-27_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 spamscore=0 impostorscore=0 malwarescore=0 mlxlogscore=999 phishscore=0 suspectscore=0 clxscore=1015 adultscore=0 bulkscore=0 priorityscore=1501 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2305260000 definitions=main-2306280027 X-Rspamd-Queue-Id: 206C940004 X-Rspam-User: X-Stat-Signature: phmsp43ur6y3p4dwqjm168ymhtdwdu68 X-Rspamd-Server: rspam03 X-HE-Tag: 1687921316-759469 X-HE-Meta: U2FsdGVkX18Qn8UjCybZ/6sksKbuGnPOsbKel/+Sk+QSvBYbr7Pilnr1eUAOJopb+MSV7xvSyJwQ6j7lSBgo5dEpa4GjBrgn1B1O1onU74wDP4MrYo3LGeJlSIp4xQ5SHMoTbr8XO5DS+9oeFR6O0Ud/y5jFK4XpLbmGO17MaA/MsZo22vC8K675+Ynuqw8nxRrkVzO0Fj8yjQrMTr9MORwRhvReATisNap+VbayMV73bXmmSj11nYngf6jwm2WZJck1DxxzGMpXItsYFgfJ3yjTgebXk0tAgY1R8wVGnmNHUU5DzH+XrRZBtkQYpbLYbGv7T5flW7cQ1LcMhcx52KKzyDSwvjDLwti5u+78W8cXa9U/nmPOZLNpGzv3tHVdyRnyWvoXOCd/E0yrpQ68TQxGUNm7R/Kh9EXSEfvmLCV8Men31LptRRvo0ljcicsVzoNIEhFin123xNu+juioG/34sqow30UiJ2RMZlDw5LFp96GTKIzGycVDzsCouoKLTxVCdlyepkUzsn2k2hA8P7Fs1c/XU5moAqG4CMeq/kh6t5WZkFmTcx67ZSS7dy01WeUQwTdSzCN5hkYmqd7Ot9xTCnt2buI6u9MgAJrmsTC1lUvpXfcI9JBSjfnAHoY9K5G4eEb6wgfpg/iFZbp2MU9bjOCcywHt+mGDMJp1BvCOTrE93Nu9SeY518ZKhAGCH7pXSK+Bs7LrEpdDI0p+uqBURmwUDE0txFpnbLbC4d7wl+1tTm7aL/WMHbpHF4jNFny+6O2qu1AyKkth09pc1gmmuq/M0HsVjpKtQabinZhygZtQZHUTRKXTT0t0ONviwoHpwcyQssIVpwF0UVtr9XXsTsOF/1jNIXLfR5xzUBkJVK+pSP2Qg9oS1WdPGWEWYN50JqY7DLqydtgzBo/CN6axRjv27LxUlQ+Ki0YZwXJB+a4sVTWQb5LdG0NfzT+rrA+CC9xbmW8OZ+Gp5+V HgS6+ztX RDS8uO+52jEI0W8NuBqUY4IH/b7CqhVkmgMYWR76d7mdrTGMke2E3QMb9QlzQgflXrYD//23UDVwE1qI60pt6Z68G1yRxYcjtdSE92NC74FnaWKqWEE2Tmbq4sOYh9q1Muetp7J1jNSqqMsp2cCtZKFRwUuKgEiEShdpYOvjSO3ukoyag1n4VMx8SwACIR9gA8Icm8W45B+yQ0Hq7V6KrJLAMmASCUoOFjB0XelV02GcnDbtmtIVFKeUy/g== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 6/28/23 6:39 AM, Ritesh Harjani (IBM) wrote: > "Aneesh Kumar K.V" writes: > >> Arm disabled hugetlb vmemmap optimization [1] because hugetlb vmemmap >> optimization includes an update of both the permissions (writeable to >> read-only) and the output address (pfn) of the vmemmap ptes. That is not >> supported without unmapping of pte(marking it invalid) by some >> architectures. >> >> With DAX vmemmap optimization we don't require such pte updates and >> architectures can enable DAX vmemmap optimization while having hugetlb >> vmemmap optimization disabled. Hence split DAX optimization support into a >> different config. >> >> loongarch and riscv don't have devdax support. So the DAX config is not >> enabled for them. With this change, arm64 should be able to select DAX >> optimization >> >> [1] commit 060a2c92d1b6 ("arm64: mm: hugetlb: Disable HUGETLB_PAGE_OPTIMIZE_VMEMMAP") >> >> Signed-off-by: Aneesh Kumar K.V >> --- >> arch/loongarch/Kconfig | 2 +- >> arch/riscv/Kconfig | 2 +- >> arch/x86/Kconfig | 3 ++- >> fs/Kconfig | 2 +- >> include/linux/mm.h | 2 +- >> mm/Kconfig | 5 ++++- >> 6 files changed, 10 insertions(+), 6 deletions(-) > > what about s390? > > git grep "ARCH_WANT_OPTIMIZE_VMEMMAP" . > arch/s390/Kconfig: select ARCH_WANT_OPTIMIZE_VMEMMAP > Thanks for catching that. Updated -aneesh