From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2DE01C3DA4A for ; Thu, 15 Aug 2024 03:00:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BA1D86B0088; Wed, 14 Aug 2024 23:00:05 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B52B46B0089; Wed, 14 Aug 2024 23:00:05 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A1A266B008A; Wed, 14 Aug 2024 23:00:05 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 84A2C6B0088 for ; Wed, 14 Aug 2024 23:00:05 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 426CAA7DDF for ; Thu, 15 Aug 2024 03:00:05 +0000 (UTC) X-FDA: 82452975570.09.6C5094A Received: from szxga05-in.huawei.com (szxga05-in.huawei.com [45.249.212.191]) by imf20.hostedemail.com (Postfix) with ESMTP id DB6351C000C for ; Thu, 15 Aug 2024 03:00:01 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf20.hostedemail.com: domain of linyunsheng@huawei.com designates 45.249.212.191 as permitted sender) smtp.mailfrom=linyunsheng@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1723690721; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=tVGgtAeIU797BlAn1ZjEHpddsnFBZFqZOqJ+L03TlXk=; b=nCLiTFBBdPfzkfELaqZCFuESkx4j7RYHfT7dpk9vVBf4GwI/cImiaSXUQq7IXtyizDAdYh 9+4ZupYkQX0R8mI1EpH4lVA3/RW7bjv/jxcCSucqYb/ckGlD+brfop/oRcADoe4G/gCPvj rlwcJh8hlsEUIwetfJWDryev1lZjeSc= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1723690721; a=rsa-sha256; cv=none; b=8MKuNfuOPDgt/RMhfzZwCp4kG5oiXG0Vxfu5V7DzKAkhsP+OrFq1VpZj6g195EwTlgzhMG C8UkcugItAu+8WUGcbaymjJ1alzhugSZtpDyDX7KgrNeEOOWoYKwzGfYBWip3XA6X99xWe ovpGV9/Uja3c2tTKCxdNaxkPToSrj84= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf20.hostedemail.com: domain of linyunsheng@huawei.com designates 45.249.212.191 as permitted sender) smtp.mailfrom=linyunsheng@huawei.com Received: from mail.maildlp.com (unknown [172.19.163.17]) by szxga05-in.huawei.com (SkyGuard) with ESMTP id 4WkqXP209yz1HGKB; Thu, 15 Aug 2024 10:56:53 +0800 (CST) Received: from dggpemf200006.china.huawei.com (unknown [7.185.36.61]) by mail.maildlp.com (Postfix) with ESMTPS id 5EBEA1A0188; Thu, 15 Aug 2024 10:59:58 +0800 (CST) Received: from [10.67.120.129] (10.67.120.129) by dggpemf200006.china.huawei.com (7.185.36.61) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Thu, 15 Aug 2024 10:59:57 +0800 Message-ID: <676a2a15-d390-48a7-a8d7-6e491c89e200@huawei.com> Date: Thu, 15 Aug 2024 10:59:57 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next v13 04/14] mm: page_frag: add '_va' suffix to page_frag API To: Alexander H Duyck , , , CC: , , Subbaraya Sundeep , Chuck Lever , Sagi Grimberg , Jeroen de Borst , Praveen Kaligineedi , Shailend Chand , Eric Dumazet , Tony Nguyen , Przemek Kitszel , Sunil Goutham , Geetha sowjanya , hariprasad , Felix Fietkau , Sean Wang , Mark Lee , Lorenzo Bianconi , Matthias Brugger , AngeloGioacchino Del Regno , Keith Busch , Jens Axboe , Christoph Hellwig , Chaitanya Kulkarni , "Michael S. Tsirkin" , Jason Wang , =?UTF-8?Q?Eugenio_P=C3=A9rez?= , Andrew Morton , Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend , Andrii Nakryiko , Martin KaFai Lau , Eduard Zingerman , Song Liu , Yonghong Song , KP Singh , Stanislav Fomichev , Hao Luo , Jiri Olsa , David Howells , Marc Dionne , Jeff Layton , Neil Brown , Olga Kornievskaia , Dai Ngo , Tom Talpey , Trond Myklebust , Anna Schumaker , Shuah Khan , , , , , , , , , , , References: <20240808123714.462740-1-linyunsheng@huawei.com> <20240808123714.462740-5-linyunsheng@huawei.com> Content-Language: en-US From: Yunsheng Lin In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.67.120.129] X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To dggpemf200006.china.huawei.com (7.185.36.61) X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: DB6351C000C X-Stat-Signature: hf8korskzfrp1s6srkd4wiquxciqzzaf X-Rspam-User: X-HE-Tag: 1723690801-690276 X-HE-Meta: U2FsdGVkX1/zZjjUwC6vScFcDExLjL2+VyQrZ8EhxZqhx6r2jz6I8TJuoZ72HM6fxhBbuGeQQXRAmJi2Qa+1OmYzvoaJjjbEshIIsCVBu9h6GrY/W6JqqQEH8btp2O/M+3Aj8uakQft+h0dR8RKXRHoLYFIdYGZzwBcgS2POQQ0x9bHJp1Hsthj1R/7zsyxqj9UPFJIfvuVIh5sYzQV6IUhD2yXXqDSjn1MGfWOKk6zX+gG8ZWM/5FW4LOSMB+UWiglGb7Ia5q2g3gEzLKqwMH/wElRu//VcrK180q1kBXrFFGn6Z4vOGO27ywijmgEW95RspRgrqQOjJ9mUOm5jRt4k7VSN0xaBsQUcJsPyyGtuyESf0/Sq/f02oXimfsLUiIdyiYGH4n3FWZ0ZFgwAQd+FvQyzu07sdIZSanzW6BXAxq53+p7W7/9/lbYYtIpqXQiGMM1qxurNOFFh5N32yQZXdGnnJQ6TZfoyipNvROkaLNTMC7w4jIxRceo/VvHJcLm4g6jIuBJXdLJSPGe3+/truvI16p0TAN1V4hqIbXhJTgtvL7t2ouddfm1ZqX8CQiRnMZnH+0Z+7C0ClffVIlVnGaK1X94kLePZC1OKjrHE4hXv1sji7+r+wBKKbpxNG7HxxfykVYprC1OM67MMhw5eO7OwrCBXnXF23K+mfqqSqG9J0G8AvDF0mYN81pRPX4+71ksvQOEU4rPApJ4GoFF9yHne/449SJN+0Ohe37pzHKioG0DW10S94cdnnrKStz4J27eZiUPC9KaVvE7I3/Mq7duBGzzcMXVnmvePou0/YEhCTmdI2fJdDNbsYUElCq3Gr5g/BJlKZ5RFkwMAOYOQhkmeJ2ih4GGxNiiy+o3k+l4a8tdZnDX3GaaGqQ0LsfM5OrVR+ueX7Zg2nI50ALNxe8RLctJc4LMIHZOdnT56tHBwuPQq7XTweDKaL3sYPF/1hTYwzyATfsFIrhg fG0D3F/+ f/VFlIh7jX+rJJjBEQqInNVXowPobX5sT2BheFc/ln9ddometG6v1Ck3AsdwD+tzZ4U28VFIIAr6H9NyxwnsaQbUhB6WgoOUvEzlvL5JcG31ax08NMfF6pF4AFqv9v5JIzY4zz2rd3Uktwj3QWl2HfwE1d6IS+2R89R2PnhrF2AgVYvX9yMaSJT770uD6R9VDcn39Rnr8cdBR4Qx5vSK7gj47bY7cBgIT3gPA6wWNdtIYUO99dXYjeJ2jpwxWjO3wggPkHngZjuw7t8VJmjIKMEuS2iGk1GHw6MQUcfRZlJmXM9YJCVdC5QMUK1a2brbjzQndqkwOmEAIs4JSURlzZtYzU0eZDbIb+dG5i5yUAtMHlckhF5lrQkPNTyUE5JPPZ3CMIhgAz1ijHDlblw0nKFIEmjSTjFvHR9JWU74PGnCGmJVyVNRFGB7yneF9ayeN6H6qlDjVnfPaybvwSMmhXJQoB1Pskl1ez7Ab X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/8/14 23:49, Alexander H Duyck wrote: > On Thu, 2024-08-08 at 20:37 +0800, Yunsheng Lin wrote: >> Currently the page_frag API is returning 'virtual address' >> or 'va' when allocing and expecting 'virtual address' or >> 'va' as input when freeing. >> >> As we are about to support new use cases that the caller >> need to deal with 'struct page' or need to deal with both >> 'va' and 'struct page'. In order to differentiate the API >> handling between 'va' and 'struct page', add '_va' suffix >> to the corresponding API mirroring the page_pool_alloc_va() >> API of the page_pool. So that callers expecting to deal with >> va, page or both va and page may call page_frag_alloc_va*, >> page_frag_alloc_pg*, or page_frag_alloc* API accordingly. >> >> CC: Alexander Duyck >> Signed-off-by: Yunsheng Lin >> Reviewed-by: Subbaraya Sundeep >> Acked-by: Chuck Lever >> Acked-by: Sagi Grimberg >> --- >> drivers/net/ethernet/google/gve/gve_rx.c | 4 ++-- >> drivers/net/ethernet/intel/ice/ice_txrx.c | 2 +- >> drivers/net/ethernet/intel/ice/ice_txrx.h | 2 +- >> drivers/net/ethernet/intel/ice/ice_txrx_lib.c | 2 +- >> .../net/ethernet/intel/ixgbevf/ixgbevf_main.c | 4 ++-- >> .../marvell/octeontx2/nic/otx2_common.c | 2 +- >> drivers/net/ethernet/mediatek/mtk_wed_wo.c | 4 ++-- >> drivers/nvme/host/tcp.c | 8 +++---- >> drivers/nvme/target/tcp.c | 22 +++++++++---------- >> drivers/vhost/net.c | 6 ++--- >> include/linux/page_frag_cache.h | 21 +++++++++--------- >> include/linux/skbuff.h | 2 +- >> kernel/bpf/cpumap.c | 2 +- >> mm/page_frag_cache.c | 12 +++++----- >> net/core/skbuff.c | 16 +++++++------- >> net/core/xdp.c | 2 +- >> net/rxrpc/txbuf.c | 15 +++++++------ >> net/sunrpc/svcsock.c | 6 ++--- >> .../selftests/mm/page_frag/page_frag_test.c | 13 ++++++----- >> 19 files changed, 75 insertions(+), 70 deletions(-) >> > > I still say no to this patch. It is an unnecessary name change and adds > no value. If you insist on this patch I will reject the set every time. > > The fact is it is polluting the git history and just makes things > harder to maintain without adding any value as you aren't changing what > the function does and there is no need for this. In addition it just I guess I have to disagree with the above 'no need for this' part for now, as mentioned in [1]: "There are three types of API as proposed in this patchset instead of two types of API: 1. page_frag_alloc_va() returns [va]. 2. page_frag_alloc_pg() returns [page, offset]. 3. page_frag_alloc() returns [va] & [page, offset]. You seemed to miss that we need a third naming for the type 3 API. Do you see type 3 API as a valid API? if yes, what naming are you suggesting for it? if no, why it is not a valid API?" 1. https://lore.kernel.org/all/ca6be29e-ab53-4673-9624-90d41616a154@huawei.com/ > makes it that much harder to backport fixes in the future as people > will have to work around the rename. >