From: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
To: Mark Brown <broonie@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Shuah Khan <shuah@kernel.org>,
David Hildenbrand <david@redhat.com>,
linux-mm@kvack.org, linux-kselftest@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/4] selftests/mm: Report unique test names for each cow test
Date: Tue, 27 May 2025 12:53:30 +0100 [thread overview]
Message-ID: <675ce51b-a218-4fe9-a571-56387d72fffb@lucifer.local> (raw)
In-Reply-To: <3729c741-fd02-41f9-9668-7575871e7acb@sirena.org.uk>
On Tue, May 27, 2025 at 12:49:57PM +0100, Mark Brown wrote:
> On Tue, May 27, 2025 at 11:08:05AM +0100, Lorenzo Stoakes wrote:
> > On Thu, May 22, 2025 at 06:38:52PM +0100, Mark Brown wrote:
>
> > > ret = setup_comm_pipes(&comm_pipes);
> > > if (ret) {
> > > - ksft_test_result_fail("pipe() failed\n");
> > > + log_test_result(KAFT_FAIL);
> >
> > Looks like a typo here :) Should be KSFT not KAFT.
> >
> > This is breaking the mm self test build for mm-new, could you fix-patch/respin?
> > Thanks!
>
> Ugh, this was masked because it's part of a series and among the
> problems with the kselftest build system is the fact that it eats
> errors.
Compile errors too? That's... not great.
>
> Please delete unneeded context from mails when replying. Doing this
> makes it much easier to find your reply in the message, helping ensure
> it won't be missed by people scrolling through the irrelevant quoted
> material.
Yup I normally do, I sent this out quick and dirty because I just happened
to hit it when trying to do other work.
next prev parent reply other threads:[~2025-05-27 11:53 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-22 17:38 [PATCH 0/4] selftests/mm: cow and gup_longterm cleanups Mark Brown
2025-05-22 17:38 ` [PATCH 1/4] selftests/mm: Use standard ksft_finished() in cow and gup_longterm Mark Brown
2025-05-27 12:34 ` David Hildenbrand
2025-05-22 17:38 ` [PATCH 2/4] selftest/mm: Add helper for logging test start and results Mark Brown
2025-05-22 17:38 ` [PATCH 3/4] selftests/mm: Report unique test names for each cow test Mark Brown
2025-05-27 10:08 ` Lorenzo Stoakes
2025-05-27 11:49 ` Mark Brown
2025-05-27 11:53 ` Lorenzo Stoakes [this message]
2025-05-27 12:06 ` Mark Brown
2025-05-27 13:06 ` Mark Brown
2025-05-22 17:38 ` [PATCH 4/4] selftests/mm: Fix test result reporting in gup_longterm Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=675ce51b-a218-4fe9-a571-56387d72fffb@lucifer.local \
--to=lorenzo.stoakes@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=broonie@kernel.org \
--cc=david@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox