linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Ralph Campbell <rcampbell@nvidia.com>
To: Ethon Paul <ethp@qq.com>, <akpm@linux-foundation.org>,
	<linux-mm@kvack.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mm/hugetlb: Fix a typo in comment "manitained"->"maintained"
Date: Fri, 10 Apr 2020 11:42:33 -0700	[thread overview]
Message-ID: <6757f060-01c4-0537-4f65-bee8d976c674@nvidia.com> (raw)
In-Reply-To: <20200410163714.14085-1-ethp@qq.com>


On 4/10/20 9:37 AM, Ethon Paul wrote:
> There is a typo in comment, fix it.
> 
> Signed-off-by: Ethon Paul <ethp@qq.com>

Looks good but you could add a few more fixes for typos below.
Either way,
Reviewed-by: Ralph Campbell <rcampbell@nvidia.com>

> ---
>   mm/hugetlb.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/mm/hugetlb.c b/mm/hugetlb.c
> index f5fb53fdfa02..8c979854c0a0 100644
> --- a/mm/hugetlb.c
> +++ b/mm/hugetlb.c
> @@ -129,7 +129,7 @@ void hugepage_put_subpool(struct hugepage_subpool *spool)
>    * the request.  Otherwise, return the number of pages by which the
>    * global pools must be adjusted (upward).  The returned value may
>    * only be different than the passed value (delta) in the case where
> - * a subpool minimum size must be manitained.
> + * a subpool minimum size must be maintained.
>    */
>   static long hugepage_subpool_get_pages(struct hugepage_subpool *spool,
>   				      long delta)
> 

line 83, s/mased on/based on
line 472, s/ruturns/returns
line 987, s/reverves/reserves
line 1489, s/ Otherwse/Otherwise,
line 4431, s/a active/an active


  reply	other threads:[~2020-04-10 18:42 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-10 16:37 Ethon Paul
2020-04-10 18:42 ` Ralph Campbell [this message]
2020-04-11  1:36   ` Ethon Paul

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6757f060-01c4-0537-4f65-bee8d976c674@nvidia.com \
    --to=rcampbell@nvidia.com \
    --cc=akpm@linux-foundation.org \
    --cc=ethp@qq.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox