From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AB50FC433EF for ; Thu, 14 Oct 2021 21:55:55 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 34C8461090 for ; Thu, 14 Oct 2021 21:55:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 34C8461090 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id A0B9C6B006C; Thu, 14 Oct 2021 17:55:54 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9BB43900002; Thu, 14 Oct 2021 17:55:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 882CB6B0072; Thu, 14 Oct 2021 17:55:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0203.hostedemail.com [216.40.44.203]) by kanga.kvack.org (Postfix) with ESMTP id 760236B006C for ; Thu, 14 Oct 2021 17:55:54 -0400 (EDT) Received: from smtpin10.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 244781801ABF6 for ; Thu, 14 Oct 2021 21:55:54 +0000 (UTC) X-FDA: 78696401028.10.1A047FE Received: from mail-pg1-f173.google.com (mail-pg1-f173.google.com [209.85.215.173]) by imf03.hostedemail.com (Postfix) with ESMTP id 2487C30000A4 for ; Thu, 14 Oct 2021 21:55:53 +0000 (UTC) Received: by mail-pg1-f173.google.com with SMTP id s136so3504047pgs.4 for ; Thu, 14 Oct 2021 14:55:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=8KCBa22fzebnliwJ53TUX2fQlBe4pRKtp4NpVWdwOr8=; b=qUWezM8050J0V+GxuKsquuBbgOIDJEj7el0dJXeJoiutXaMGaRuOSzpGcdgBNrQHVf Hk2+d3Et4utpx4syAAEgMErJrUkWVGjER3d9Hq4u9QqTS+Jfk83VJcq9PHZ/1a3sxvwV QQEFip53cP0GFBRzGI5k82Cf7xmB2BUbpDD/BrxzLrL0/j/JauN4XI6kPKoU+jttAvUs Hfr+S31m8dvMQbpf4RAbKyZATHNG5ad9Mq8L4FJnZma7yFY+/S6XDKIBFNe2jXtBUaxh Wf2t9OAIwC4mJHCW26FUAUTpb0z+N7EoX+0WSzC5X5ATVbNnNQr0Q6AlsmaaJSA7lR/G FcJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=8KCBa22fzebnliwJ53TUX2fQlBe4pRKtp4NpVWdwOr8=; b=s3DeyL2BJhthaZiWMkci/YYj4xTPZarOxg9XiBslwW5xJl1QzYvP9omr1jT9/ZtqGV w/Yd8NM5PTUt5CHIJ8SYHpQ982/16+XKljzpdNH+EHCOvozIj5z1szf7ru7wsPfRvRDR qGixTfuHTa+ywEdXk1Xw0dt58RVFRJRgosBcUNt3QGpSeqyMe4CQnw2P3ycFdekzn+u4 8uAw8ntogwvrLhs6h9NO4Mamn4Gp4//rAJCN0NyZsizDxi2A15ZRIrAuMTMQzfKIUIWO elUwgxPShUEVU/x4y32/jeUAXLdUIei/vCdP+AzkhxgfTS81eIW3ufKkmRx/dTCMZZvj dCWw== X-Gm-Message-State: AOAM533JWTgvx4ilcG4DFLhL7MoZWGHVAK4qKPwayN+uN3ENh4imWgzj fKBabt0zYQUkxxZMfV7C5wE= X-Google-Smtp-Source: ABdhPJxAw8w0toZYCzOK18nFgbk71QjmGJspCXMOt1ZD3VHqX62T/T7iJhAdlQgIb3G/xO/y/3S52w== X-Received: by 2002:a65:6854:: with SMTP id q20mr6239818pgt.228.1634248552634; Thu, 14 Oct 2021 14:55:52 -0700 (PDT) Received: from [10.67.48.245] ([192.19.223.252]) by smtp.googlemail.com with ESMTPSA id y22sm3288178pjj.5.2021.10.14.14.55.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 14 Oct 2021 14:55:52 -0700 (PDT) Subject: Re: [PM] bfcc1e67ff: kernel-selftests.breakpoints.step_after_suspend_test.fail To: "Rafael J. Wysocki" Cc: LKML , Linux Memory Management List , lkp@lists.01.org, lkp@intel.com, kernel test robot References: <20211014075731.GB18719@xsang-OptiPlex-9020> <51c0a15f-1941-f161-dcec-a7a9acc726f2@gmail.com> From: Florian Fainelli Message-ID: <6755cf07-fa5a-cbb7-c076-57c162a08c99@gmail.com> Date: Thu, 14 Oct 2021 14:55:42 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US X-Rspamd-Queue-Id: 2487C30000A4 X-Stat-Signature: sy5i5azcgh6j4qqe5upjwwannzw1cww4 Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=qUWezM80; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf03.hostedemail.com: domain of f.fainelli@gmail.com designates 209.85.215.173 as permitted sender) smtp.mailfrom=f.fainelli@gmail.com X-Rspamd-Server: rspam02 X-HE-Tag: 1634248553-434777 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 10/14/21 12:23 PM, Rafael J. Wysocki wrote: > On 10/14/2021 6:26 PM, Florian Fainelli wrote: >> On 10/14/21 12:57 AM, kernel test robot wrote: >>> >>> Greeting, >>> >>> FYI, we noticed the following commit (built with gcc-9): >>> >>> commit: bfcc1e67ff1e4aa8bfe2ca57f99390fc284c799d ("PM: sleep: Do not >>> assume that "mem" is always present") >>> https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git mast= er >>> >>> >>> in testcase: kernel-selftests >>> version: kernel-selftests-x86_64-c8c9111a-1_20210929 >>> with following parameters: >>> >>> =C2=A0=C2=A0=C2=A0=C2=A0group: group-00 >>> =C2=A0=C2=A0=C2=A0=C2=A0ucode: 0x11 >>> >>> test-description: The kernel contains a set of "self tests" under the >>> tools/testing/selftests/ directory. These are intended to be small >>> unit tests to exercise individual code paths in the kernel. >>> test-url: https://www.kernel.org/doc/Documentation/kselftest.txt >>> >>> >>> on test machine: 288 threads 2 sockets Intel(R) Xeon Phi(TM) CPU 7295 >>> @ 1.50GHz with 80G memory >>> >>> caused below changes (please refer to attached dmesg/kmsg for entire >>> log/backtrace): >>> >>> >>> >>> >>> If you fix the issue, kindly add following tag >>> Reported-by: kernel test robot >> Thanks for your report. Assuming that the code responsible for >> registering the suspend operations is drivers/acpi/sleep.c for your >> platform, and that acpi_sleep_suspend_setup() iterated over all possib= le >> sleep states, your platform must somehow be returning that ACPI_STATE_= S3 >> is not a supported state somehow? >> >> Rafael have you ever encountered something like that? >=20 > Yes, there are systems with ACPI that don't support S3. OK and do you know what happens when we enter suspend with "mem" in those cases? Do we immediately return because ultimately the firmware does not support ACPI S3? I will rework tools/testing/selftests/breakpoints/step_after_suspend_test.c not to assume that "mem" is always available, since it may not be. --=20 Florian