From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AE35AC02181 for ; Mon, 20 Jan 2025 20:03:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3AC9C280002; Mon, 20 Jan 2025 15:03:17 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 35CDF280001; Mon, 20 Jan 2025 15:03:17 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1B013280002; Mon, 20 Jan 2025 15:03:17 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id F2DD0280001 for ; Mon, 20 Jan 2025 15:03:16 -0500 (EST) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 992D143763 for ; Mon, 20 Jan 2025 20:03:16 +0000 (UTC) X-FDA: 83028904392.21.4B0487A Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf04.hostedemail.com (Postfix) with ESMTP id 0F6B140017 for ; Mon, 20 Jan 2025 20:03:13 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=NkyoXnFN; spf=pass (imf04.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1737403394; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ZFAY5uBJJnBWzNnEkK6XnydfXBF4X+nYIIy676o8zFY=; b=ziqpYJctGnuJMBrBvvKi3nXuWIr7Xrhbm2bFWnODjfOVetLJYLdE1BQ0m0FhCsKrMSj8Vm Yh6OCr+pterx2n48WCNhjzeD/tWxaUGqle8reGsa3XXdp0drPhiYNeMBQ7AClVTtDU+nqg mA59ohWHWjlT465bxMAzG4DqNxBV1L4= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=NkyoXnFN; spf=pass (imf04.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1737403394; a=rsa-sha256; cv=none; b=q0YjFom22K7ohNZASy5OYpkTU0i2VJ3H6tqT5PGj13eeUlF12wpv/6NMPsV+xAMKIITjDJ /jSjBieglWrhkJQvnt2t6JIkiG7uo05sgwuwlvdPJddg/Tgo1nwTvXNHP/zFhxSnfolAwm cML14Cf0Y74EWWnBOHmM7yQIZc9veXE= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1737403393; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=ZFAY5uBJJnBWzNnEkK6XnydfXBF4X+nYIIy676o8zFY=; b=NkyoXnFNKsZLhzZeFRxYTpfhtUnLIdJljE+WFuqDq/ZS2gi+GLurCU0LYN6H21q5zyLare twTBbNZxtqca0GcMEVGmjWL3nKYUTf8Ta9nF7IV4hWBXh/tLOSNvHse7kWlLKbJb08SiHT jDZOWClF0Z6QqF6zvuQwvD7nb/IAqVg= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-180-RpwZ3WU-M-emRAJ-LoTeaw-1; Mon, 20 Jan 2025 15:03:10 -0500 X-MC-Unique: RpwZ3WU-M-emRAJ-LoTeaw-1 X-Mimecast-MFC-AGG-ID: RpwZ3WU-M-emRAJ-LoTeaw Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-3862be3bfc9so3031728f8f.3 for ; Mon, 20 Jan 2025 12:03:09 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737403389; x=1738008189; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=ZFAY5uBJJnBWzNnEkK6XnydfXBF4X+nYIIy676o8zFY=; b=YzTdqiqzCRDnBXWdl2NMPTU3K4lOVmDTHxjjiEbu7NICQVmd/QqT1Crtmin/YJuWhw 7BS4rBMRE4YVpjq+BOuv+L31zGcxt+OAtIpqtQVe/UA6Iyj/LaXTotZjNHfvUJc3qNws vHWtvxWaRbpZy95ixOHBoCXlDiEg9qCCAZlN3DFA6vbq0d9LvK3dp9+nMYtvUqHfz8Pu SYdQGtoXrH3wlz+/DLMcZDhyODdqLsVHoHray4KflIxZgZiwVWhGxjmwyTl6+ZXJBG6U dfK1cottqfuAgS6C1G+xQp5hFOJuoUHpSVk7cmhQKYkxid+E4/r9D++/UJiBzbsMa/Jz 7/RA== X-Forwarded-Encrypted: i=1; AJvYcCVsVrKNwgn8ODTOjNKrbtFLchUGc2oNFrTKLUJ+ev1Y/OdfXlMIvq3Ke6jR+LfGePoZsTcDQOXVzw==@kvack.org X-Gm-Message-State: AOJu0YxiA8w4LxOjPkJRjy2kpYS2asMU39kLYVWDnJnNv0YeNbT8GNJ/ 458HdFJ1iOne9mdC9GOpA3aHW0jPxyA9mpnRUx6G6UDpAFBIWiP1fJx6ZggRGcOVsSpxdd7k9re CDp1MWhuq4zQ9mbUL2ij5TjBWarwAyf4ms2+NFh/UcLX+0I6S X-Gm-Gg: ASbGncuisuCCYSqpb8BNcokRd0EuflM+qRvhnIq+Y1CTBKpfIhemhikyymGNc026440 qxMzN+3g2EyXJ7cVwZub700nsLLVdh0GFJIw/WOy5WXO9etwWfb/nODc2IVeL2VYpgTgDcuMOS5 EXscKXEScfSl4ig1kTkBAqty8K5pWHOMAYV7jb0RfBcmqPIWGlF21a2PEGJHUuf5dzzfT7pPqw6 +0zsXx8PiAp58wizgNeTIMUpEwEpyHcFwgyazNajdaQ/EvcLLhAldVbXquYr/Pf1xLIPgZTapqk pgcjFxnN/8qdM1Q9vU268cTa9Qfd/V8YwvjHc99YHMHEi16fyB7vNYP0iwZYjCEQmjp4rTgq+3K 31UvOFtZjeMfbKTftuFZ9pg== X-Received: by 2002:a5d:5848:0:b0:385:e37a:2a56 with SMTP id ffacd0b85a97d-38bf57c0551mr13101358f8f.52.1737403388894; Mon, 20 Jan 2025 12:03:08 -0800 (PST) X-Google-Smtp-Source: AGHT+IH3tIXVvaYDZzUGMIl9b8cUCq3X52IGYsbbdwLXmrBsQ70DS6pinYv9AFzYLBQBY4u2TAOhCA== X-Received: by 2002:a5d:5848:0:b0:385:e37a:2a56 with SMTP id ffacd0b85a97d-38bf57c0551mr13101337f8f.52.1737403388551; Mon, 20 Jan 2025 12:03:08 -0800 (PST) Received: from ?IPV6:2003:cb:c72e:e400:431d:9c08:5611:693c? (p200300cbc72ee400431d9c085611693c.dip0.t-ipconnect.de. [2003:cb:c72e:e400:431d:9c08:5611:693c]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4389041fe29sm150701265e9.22.2025.01.20.12.03.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 20 Jan 2025 12:03:07 -0800 (PST) Message-ID: <6750d7d8-0b21-4f0b-88a6-c4c8ad98f9a4@redhat.com> Date: Mon, 20 Jan 2025 21:03:05 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 2/2] mm/damon: introduce DAMOS filter type hugepage To: Usama Arif , SeongJae Park Cc: akpm@linux-foundation.org, damon@lists.linux.dev, linux-mm@kvack.org References: <20250120193015.38753-1-sj@kernel.org> <3b461f19-45b7-4e74-969d-1cdf4d324353@gmail.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <3b461f19-45b7-4e74-969d-1cdf4d324353@gmail.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: eEKqnY1XKHytjdCmMgTnqJKZ59x0r1uj3XOzBWyM8SE_1737403389 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 0F6B140017 X-Stat-Signature: q1cr6n1jreiphrkn741174o3bpuak38j X-Rspamd-Server: rspam08 X-Rspam-User: X-HE-Tag: 1737403393-132480 X-HE-Meta: U2FsdGVkX18uCnvJTsFUQFt6Zi73NU7aueer96wc1zNxoFXYpbCsNjtIoHR3xwh9bN9NetDuBeum0i+KwUHrpNBbxkTwY+vtQHst2vnxfuvyTqXodKx6Sh51H8nLZPRaIZqsFg6/Y9yEb+L6ewiQ3qrx5YIXxtQu+xoZOPDotlNUf9NT7w8pR0aeTRp/MCIcRbwLzkOuwkd+jAD2ZDI6MgnmOX+LUt1d2VGOOPte03gHvpKmRMcsfgqoXiR43OxCZaqEmI/IPhWPdExCK3u50Cl9jsPoNNEnws8t4Xpep/KaIni2Z8N4gYIrNDnQsckNiFTYi1OAAOxIi9iHGaqKE/Qu8/rIFfY5UZYLkfflPlR5mZBYW9/umuY2aZ0Ys1pdUzpWNRn9/++3vPXUtWOnxIw6ZnVtZ1VhZg8Vv30EpQ+54tWQsRlu/rFilPz4zTLrn+d7no0tNWIBfd54wtxo3PE3/DSk+qoMAGND7r0ulTMV0otZQHPZqIK1W27gv/Jd4Koouz4uCdOSiGOfaHS7tN+IDaFk9t1fZmYLsWKqIktCgXgWp6GK8I5d+9UkxPHkMfy/LOWGZzAFpvIY/QUK6MzyFZSZCTlgx40zYQFGULiZMSGZ/IeKFa9J8fW0ca1TrQxTYxPSC9oZTK15mDfLmcfIGv+CQprUxGrYNg6ppsLAdGWhrnD/Ojrku+eCQo68dVSvndz4ctSGJSlse9CpTtg9jwmgyA4rf1SqLG4ACbFYRz+ztgw+pD8QCCfgdDQiI7VlojO4cNznONdMKLTG/NtRQ4i8y6HjvjuUjbv1+70oWZ1z8Ut8qosz5xXRRNFzaqcsSYn/kSXz3qfQvh+jM9k8vLouNV18MHZuHGkN0VAYcMa8N7B/OqlpdSA5CbfvD5tMwOZG3S/h7/7knSLIh6aKtk8SGDlF6/9ZGNb3BW2JX3s3B2kEDTcZN8RDbaI+k+TZYvEzxyAbSYmKEuw QloULWV9 QBAqCLFgKQmE0Rsi8JWAfFCG+JCGgQ87v26obwcfn4lDPqF8QmkhPjiw9Y2lWx7hD1XTit9MoQT29JTGeDVOtq4qlPdVbnUSQ+VaRntUQSC+t1SKagJELy5d214QnYr42RLwPFaksfOMrmm/vuRy7tqgfoDpM+wTz2TXPcJwWSgBfbBrI7/n6qRrDvagA+3q6yr/wEcjzgcvmQptuwUYMt23u4K7/yNHVJKthnRTkjCQXGnT7XNUREFpqvwUcy1vLHpJ0jQs76N3p+ZmUM2GVfvTEyBZq+m00/eio/Lbmy8gsB2f75zoaFYoMYvc5dafLM78NRsPqb1dyV9kCxMyLiJjINOstbBaLQtZEzDMyBlbxvnrZv+0JB1TudCOxlL/UBdEZzEIRSYLQd091OrsieWdbhMdbXo34KI7L X-Bogosity: Ham, tests=bogofilter, spamicity=0.000002, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 20.01.25 20:58, Usama Arif wrote: > > > On 20/01/2025 19:30, SeongJae Park wrote: >> On Mon, 20 Jan 2025 20:23:20 +0100 David Hildenbrand wrote: >> >>> On 20.01.25 20:16, SeongJae Park wrote: >>>> On Mon, 20 Jan 2025 19:57:10 +0100 David Hildenbrand wrote: >>>> >>>>> On 20.01.25 19:19, Usama Arif wrote: >> [...] >>>>>> +#if defined(CONFIG_PGTABLE_HAS_HUGE_LEAVES) >>>>>> + case DAMOS_FILTER_TYPE_HUGEPAGE: >>>>>> + matched = folio_size(folio) == HPAGE_PMD_SIZE; >>>>> >>>>> >>>>> Can we directly embed in the name and the comments/docs that we are only >>>>> talking about PMD size (both, THP and hugetlb)? >>>>> >>>>> DAMOS_FILTER_TYPE_PMD_HUGEPAGE or sth. like that. >>>> >>>> Nice suggestion, thank you! And we might later add more filter types for >>>> different size huge pages. What about extending this to handle more general >>>> case, though? That is, we can let the filter receives a range of the folio >>>> size to match, like DAMOS_FILTER_TYPE_ADDR does. Then, the filter could be >>>> used for any size of interest. >>> >>> That would probably be future proof: either a range or explicitly >>> specified sizes (ranges?). >> >> DAMON supports installing multiple DAMOS filters. So multiple DAMOS filters >> that each matching single range can be used for the multiple sizes or ranges >> use case. >> >> > > Does creating something like schemes//access_pattern/page_size/{min,max} > sound good? with the default value being pmd size? "page_size" might be misleading. Not sure if we want to use the word "folio_size" here, so far it's more an internal detail that evolved from compound pages. "hugepage_size" would at least match /sys/kernel/mm/hugepages/ and /sys/kernel/mm/transparent_hugepage/. But if you would also support "single page" == e.g., 4K, "hugepage" would be wrong. -- Cheers, David / dhildenb