* Re: [PATCH] mm: cma: Fix stub for cma_skip_dt_default_reserved_mem()
2026-01-28 16:28 ` [PATCH] mm: cma: Fix stub for cma_skip_dt_default_reserved_mem() Mark Brown
@ 2026-01-28 17:09 ` Mike Rapoport
2026-01-28 23:31 ` Marek Szyprowski
2026-02-09 8:11 ` David Hildenbrand (Arm)
2 siblings, 0 replies; 6+ messages in thread
From: Mike Rapoport @ 2026-01-28 17:09 UTC (permalink / raw)
To: Mark Brown
Cc: Andrew Morton, David Hildenbrand, Lorenzo Stoakes,
Liam R. Howlett, Vlastimil Babka, Suren Baghdasaryan,
Michal Hocko, Rob Herring (Arm),
Oreoluwa Babatunde, Marek Szyprowski, linux-mm, linux-kernel
On Wed, Jan 28, 2026 at 04:28:35PM +0000, Mark Brown wrote:
> The stub for cma_skip_dt_default_reserved_mem() is not inlined so
> triggers build warnings:
>
> In file included from /tmp/next/build/fs/proc/meminfo.c:18:
> /tmp/next/build/include/linux/cma.h:68:13: warning: 'cma_skip_dt_default_reserved_mem' defined but not used [-Wunused-function]
> 68 | static bool cma_skip_dt_default_reserved_mem(void)
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>
> which are fatal with -Werror.
>
> Fixes: 26332ae848f08 ("of: reserved_mem: Allow reserved_mem framework detect "cma=" kernel param")
> Signed-off-by: Mark Brown <broonie@kernel.org>
Acked-by: Mike Rapoport (Microsoft) <rppt@kernel.org>
> ---
> include/linux/cma.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/cma.h b/include/linux/cma.h
> index 0bf408360641..d0793eaaadaa 100644
> --- a/include/linux/cma.h
> +++ b/include/linux/cma.h
> @@ -65,7 +65,7 @@ extern void cma_reserve_pages_on_error(struct cma *cma);
> #ifdef CONFIG_DMA_CMA
> extern bool cma_skip_dt_default_reserved_mem(void);
> #else
> -static bool cma_skip_dt_default_reserved_mem(void)
> +static inline bool cma_skip_dt_default_reserved_mem(void)
> {
> return false;
> }
>
> ---
> base-commit: d0d97f0b2b2b4633022dfaef4ac08af0b7917efe
> change-id: 20260128-cma-fix-stubs-26b13ce1471d
>
> Best regards,
> --
> Mark Brown <broonie@kernel.org>
>
--
Sincerely yours,
Mike.
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] mm: cma: Fix stub for cma_skip_dt_default_reserved_mem()
2026-01-28 16:28 ` [PATCH] mm: cma: Fix stub for cma_skip_dt_default_reserved_mem() Mark Brown
2026-01-28 17:09 ` Mike Rapoport
@ 2026-01-28 23:31 ` Marek Szyprowski
2026-02-09 8:11 ` David Hildenbrand (Arm)
2 siblings, 0 replies; 6+ messages in thread
From: Marek Szyprowski @ 2026-01-28 23:31 UTC (permalink / raw)
To: Mark Brown, Andrew Morton, David Hildenbrand, Lorenzo Stoakes,
Liam R. Howlett, Vlastimil Babka, Mike Rapoport,
Suren Baghdasaryan, Michal Hocko, Rob Herring (Arm),
Oreoluwa Babatunde
Cc: linux-mm, linux-kernel
On 28.01.2026 17:28, Mark Brown wrote:
> The stub for cma_skip_dt_default_reserved_mem() is not inlined so
> triggers build warnings:
>
> In file included from /tmp/next/build/fs/proc/meminfo.c:18:
> /tmp/next/build/include/linux/cma.h:68:13: warning: 'cma_skip_dt_default_reserved_mem' defined but not used [-Wunused-function]
> 68 | static bool cma_skip_dt_default_reserved_mem(void)
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>
> which are fatal with -Werror.
>
> Fixes: 26332ae848f08 ("of: reserved_mem: Allow reserved_mem framework detect "cma=" kernel param")
> Signed-off-by: Mark Brown <broonie@kernel.org>
I'm really sorry for this build break and thanks for applying this fix
for today's release.
This issue has been introduced by my amendment to the original patch, so
if You don't mind, I will amend it again and squash with this fix to
avoid messing the last minute fix with potentially not bisectable branch.
> ---
> include/linux/cma.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/cma.h b/include/linux/cma.h
> index 0bf408360641..d0793eaaadaa 100644
> --- a/include/linux/cma.h
> +++ b/include/linux/cma.h
> @@ -65,7 +65,7 @@ extern void cma_reserve_pages_on_error(struct cma *cma);
> #ifdef CONFIG_DMA_CMA
> extern bool cma_skip_dt_default_reserved_mem(void);
> #else
> -static bool cma_skip_dt_default_reserved_mem(void)
> +static inline bool cma_skip_dt_default_reserved_mem(void)
> {
> return false;
> }
>
> ---
> base-commit: d0d97f0b2b2b4633022dfaef4ac08af0b7917efe
> change-id: 20260128-cma-fix-stubs-26b13ce1471d
>
> Best regards,
> --
> Mark Brown <broonie@kernel.org>
>
>
Best regards
--
Marek Szyprowski, PhD
Samsung R&D Institute Poland
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] mm: cma: Fix stub for cma_skip_dt_default_reserved_mem()
2026-01-28 16:28 ` [PATCH] mm: cma: Fix stub for cma_skip_dt_default_reserved_mem() Mark Brown
2026-01-28 17:09 ` Mike Rapoport
2026-01-28 23:31 ` Marek Szyprowski
@ 2026-02-09 8:11 ` David Hildenbrand (Arm)
2026-02-09 9:59 ` Marek Szyprowski
2 siblings, 1 reply; 6+ messages in thread
From: David Hildenbrand (Arm) @ 2026-02-09 8:11 UTC (permalink / raw)
To: Mark Brown, Andrew Morton, Lorenzo Stoakes, Liam R. Howlett,
Vlastimil Babka, Mike Rapoport, Suren Baghdasaryan, Michal Hocko,
Rob Herring (Arm),
Oreoluwa Babatunde, Marek Szyprowski
Cc: linux-mm, linux-kernel
On 1/28/26 17:28, Mark Brown wrote:
> The stub for cma_skip_dt_default_reserved_mem() is not inlined so
> triggers build warnings:
>
> In file included from /tmp/next/build/fs/proc/meminfo.c:18:
> /tmp/next/build/include/linux/cma.h:68:13: warning: 'cma_skip_dt_default_reserved_mem' defined but not used [-Wunused-function]
> 68 | static bool cma_skip_dt_default_reserved_mem(void)
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>
> which are fatal with -Werror.
>
> Fixes: 26332ae848f08 ("of: reserved_mem: Allow reserved_mem framework detect "cma=" kernel param")
> Signed-off-by: Mark Brown <broonie@kernel.org>
$ git show 26332ae848f08
fatal: ambiguous argument '26332ae848f08': unknown revision or path not
in the working tree.
This is not upstream or against an mm tree. Against which tree is it?
--
Cheers,
David
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] mm: cma: Fix stub for cma_skip_dt_default_reserved_mem()
2026-02-09 8:11 ` David Hildenbrand (Arm)
@ 2026-02-09 9:59 ` Marek Szyprowski
2026-02-09 10:01 ` David Hildenbrand (Arm)
0 siblings, 1 reply; 6+ messages in thread
From: Marek Szyprowski @ 2026-02-09 9:59 UTC (permalink / raw)
To: David Hildenbrand (Arm),
Mark Brown, Andrew Morton, Lorenzo Stoakes, Liam R. Howlett,
Vlastimil Babka, Mike Rapoport, Suren Baghdasaryan, Michal Hocko,
Rob Herring (Arm),
Oreoluwa Babatunde
Cc: linux-mm, linux-kernel
On 09.02.2026 09:11, David Hildenbrand (Arm) wrote:
> On 1/28/26 17:28, Mark Brown wrote:
>> The stub for cma_skip_dt_default_reserved_mem() is not inlined so
>> triggers build warnings:
>>
>> In file included from /tmp/next/build/fs/proc/meminfo.c:18:
>> /tmp/next/build/include/linux/cma.h:68:13: warning:
>> 'cma_skip_dt_default_reserved_mem' defined but not used
>> [-Wunused-function]
>> 68 | static bool cma_skip_dt_default_reserved_mem(void)
>> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>>
>> which are fatal with -Werror.
>>
>> Fixes: 26332ae848f08 ("of: reserved_mem: Allow reserved_mem framework
>> detect "cma=" kernel param")
>> Signed-off-by: Mark Brown <broonie@kernel.org>
>
> $ git show 26332ae848f08
> fatal: ambiguous argument '26332ae848f08': unknown revision or path
> not in the working tree.
>
> This is not upstream or against an mm tree. Against which tree is it?
The fix for this issue has been squashed into commit 0fd17e598333 ("of:
reserved_mem: Allow reserved_mem framework detect "cma=" kernel param")
and merged to v6.19-rc8, so the above fix is not longer needed.
Best regards
--
Marek Szyprowski, PhD
Samsung R&D Institute Poland
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] mm: cma: Fix stub for cma_skip_dt_default_reserved_mem()
2026-02-09 9:59 ` Marek Szyprowski
@ 2026-02-09 10:01 ` David Hildenbrand (Arm)
0 siblings, 0 replies; 6+ messages in thread
From: David Hildenbrand (Arm) @ 2026-02-09 10:01 UTC (permalink / raw)
To: Marek Szyprowski, Mark Brown, Andrew Morton, Lorenzo Stoakes,
Liam R. Howlett, Vlastimil Babka, Mike Rapoport,
Suren Baghdasaryan, Michal Hocko, Rob Herring (Arm),
Oreoluwa Babatunde
Cc: linux-mm, linux-kernel
On 2/9/26 10:59, Marek Szyprowski wrote:
> On 09.02.2026 09:11, David Hildenbrand (Arm) wrote:
>> On 1/28/26 17:28, Mark Brown wrote:
>>> The stub for cma_skip_dt_default_reserved_mem() is not inlined so
>>> triggers build warnings:
>>>
>>> In file included from /tmp/next/build/fs/proc/meminfo.c:18:
>>> /tmp/next/build/include/linux/cma.h:68:13: warning:
>>> 'cma_skip_dt_default_reserved_mem' defined but not used
>>> [-Wunused-function]
>>> 68 | static bool cma_skip_dt_default_reserved_mem(void)
>>> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>>>
>>> which are fatal with -Werror.
>>>
>>> Fixes: 26332ae848f08 ("of: reserved_mem: Allow reserved_mem framework
>>> detect "cma=" kernel param")
>>> Signed-off-by: Mark Brown <broonie@kernel.org>
>>
>> $ git show 26332ae848f08
>> fatal: ambiguous argument '26332ae848f08': unknown revision or path
>> not in the working tree.
>>
>> This is not upstream or against an mm tree. Against which tree is it?
>
> The fix for this issue has been squashed into commit 0fd17e598333 ("of:
> reserved_mem: Allow reserved_mem framework detect "cma=" kernel param")
> and merged to v6.19-rc8, so the above fix is not longer needed.
Ah, that's just what I wanted to ask: can this be squashed :)
Thanks!
--
Cheers,
David
^ permalink raw reply [flat|nested] 6+ messages in thread