linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Marek Szyprowski <m.szyprowski@samsung.com>
To: "David Hildenbrand (Arm)" <david@kernel.org>,
	Mark Brown <broonie@kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Lorenzo Stoakes <lorenzo.stoakes@oracle.com>,
	"Liam R. Howlett" <Liam.Howlett@oracle.com>,
	Vlastimil Babka <vbabka@suse.cz>, Mike Rapoport <rppt@kernel.org>,
	Suren Baghdasaryan <surenb@google.com>,
	Michal Hocko <mhocko@suse.com>,
	"Rob Herring (Arm)" <robh@kernel.org>,
	Oreoluwa Babatunde <oreoluwa.babatunde@oss.qualcomm.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm: cma: Fix stub for cma_skip_dt_default_reserved_mem()
Date: Mon, 9 Feb 2026 10:59:49 +0100	[thread overview]
Message-ID: <67426771-7df6-4544-a77c-97f44ee08d99@samsung.com> (raw)
In-Reply-To: <4fc5e312-b56a-4664-9722-81163ecef515@kernel.org>

On 09.02.2026 09:11, David Hildenbrand (Arm) wrote:
> On 1/28/26 17:28, Mark Brown wrote:
>> The stub for cma_skip_dt_default_reserved_mem() is not inlined so
>> triggers build warnings:
>>
>> In file included from /tmp/next/build/fs/proc/meminfo.c:18:
>> /tmp/next/build/include/linux/cma.h:68:13: warning: 
>> 'cma_skip_dt_default_reserved_mem' defined but not used 
>> [-Wunused-function]
>>     68 | static bool cma_skip_dt_default_reserved_mem(void)
>>        |             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>>
>> which are fatal with -Werror.
>>
>> Fixes: 26332ae848f08 ("of: reserved_mem: Allow reserved_mem framework 
>> detect "cma=" kernel param")
>> Signed-off-by: Mark Brown <broonie@kernel.org>
>
> $ git show 26332ae848f08
> fatal: ambiguous argument '26332ae848f08': unknown revision or path 
> not in the working tree.
>
> This is not upstream or against an mm tree. Against which tree is it?

The fix for this issue has been squashed into commit 0fd17e598333 ("of: 
reserved_mem: Allow reserved_mem framework detect "cma=" kernel param") 
and merged to v6.19-rc8, so the above fix is not longer needed.

Best regards
-- 
Marek Szyprowski, PhD
Samsung R&D Institute Poland



  reply	other threads:[~2026-02-09  9:59 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20260128163207eucas1p15d5e6380ad65350de185ded053d0ed2d@eucas1p1.samsung.com>
2026-01-28 16:28 ` Mark Brown
2026-01-28 17:09   ` Mike Rapoport
2026-01-28 23:31   ` Marek Szyprowski
2026-02-09  8:11   ` David Hildenbrand (Arm)
2026-02-09  9:59     ` Marek Szyprowski [this message]
2026-02-09 10:01       ` David Hildenbrand (Arm)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=67426771-7df6-4544-a77c-97f44ee08d99@samsung.com \
    --to=m.szyprowski@samsung.com \
    --cc=Liam.Howlett@oracle.com \
    --cc=akpm@linux-foundation.org \
    --cc=broonie@kernel.org \
    --cc=david@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=lorenzo.stoakes@oracle.com \
    --cc=mhocko@suse.com \
    --cc=oreoluwa.babatunde@oss.qualcomm.com \
    --cc=robh@kernel.org \
    --cc=rppt@kernel.org \
    --cc=surenb@google.com \
    --cc=vbabka@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox