From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3CD77C52D7C for ; Wed, 21 Aug 2024 21:35:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BB3CD6B01F4; Wed, 21 Aug 2024 17:35:13 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B641A6B01F5; Wed, 21 Aug 2024 17:35:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A52EF6B01F7; Wed, 21 Aug 2024 17:35:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 805B96B01F4 for ; Wed, 21 Aug 2024 17:35:13 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 0EF26A081C for ; Wed, 21 Aug 2024 21:35:13 +0000 (UTC) X-FDA: 82477558506.04.4ADB908 Received: from mail-40131.protonmail.ch (mail-40131.protonmail.ch [185.70.40.131]) by imf16.hostedemail.com (Postfix) with ESMTP id 97E3218000E for ; Wed, 21 Aug 2024 21:35:10 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=proton.me header.s=elpwtff7wzd6rj5x2nakqkxmrq.protonmail header.b=PblfomLE; dmarc=pass (policy=quarantine) header.from=proton.me; spf=pass (imf16.hostedemail.com: domain of benno.lossin@proton.me designates 185.70.40.131 as permitted sender) smtp.mailfrom=benno.lossin@proton.me ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1724276052; a=rsa-sha256; cv=none; b=SgrlBMxzFnvlKQlgFjR6h6IDGTECZqblze+vrSGcoTJMNkZRz6WizxVpSz6UuiOv5+Hmja ArDSmF2nKqJP6/YkLmy4+sQuMq1DVMt7meowu4nsddjB30upmnNTRdD28O0KeKduzYcRIz nT+emwuwR0W0yPjpH9n2jto3q1ErrmM= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=proton.me header.s=elpwtff7wzd6rj5x2nakqkxmrq.protonmail header.b=PblfomLE; dmarc=pass (policy=quarantine) header.from=proton.me; spf=pass (imf16.hostedemail.com: domain of benno.lossin@proton.me designates 185.70.40.131 as permitted sender) smtp.mailfrom=benno.lossin@proton.me ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1724276052; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ibH9qiCDNlATlyikpueGmgp5dRHSsxzU+yLNl06j6EE=; b=HNIL+Aki9EWQeF5G/FN6D+EaMY9V16Ra/VxfqEPikCR0hkhz6lzfLXel0Li5NRo2NiCHmH AvfHI/QcM5zEfzNV4ofJbs91jgTiPsqPm9A+B2rLM9rpldiAeeK4NgWduilYQaS0ZNz/z4 4QuvCCTdzpzBRLXM2KIglh1stD/r2Yw= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=proton.me; s=elpwtff7wzd6rj5x2nakqkxmrq.protonmail; t=1724276107; x=1724535307; bh=ibH9qiCDNlATlyikpueGmgp5dRHSsxzU+yLNl06j6EE=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=PblfomLE6muBkqfRqWh7GiLpLnZUsZGj3i/GaUEXcFLUOWqmqoJMN8L8RJZhNbwhu CTi1x+I9d+QByJAElnUKqL6FZ9ShyZxJmudG9NpU+EehoUYSUN3f4vwJMcgTd5f7SL /BUtrqaxLKj6Q0nE9RzqAeRzBUYZE7Vp/aNessljOp+pM8q45EmgI9rgvPdmLLmz4x ryd6cC3fK6AiQ4NwkRPe1Dzabkhektu5tOu3GJA5U/ZjbmpwICZMmuYUP6pCUX/CJz 1E3wqGBkVwRGQ32EZIqd5f8tUqVXFSkmQzP6UD8s21te+8NJBwEzrjiiVSpliwB1f4 R+Ac7pSD+sbtA== Date: Wed, 21 Aug 2024 21:34:58 +0000 To: Danilo Krummrich , ojeda@kernel.org, alex.gaynor@gmail.com, wedsonaf@gmail.com, boqun.feng@gmail.com, gary@garyguo.net, bjorn3_gh@protonmail.com, a.hindborg@samsung.com, aliceryhl@google.com, akpm@linux-foundation.org From: Benno Lossin Cc: daniel.almeida@collabora.com, faith.ekstrand@collabora.com, boris.brezillon@collabora.com, lina@asahilina.net, mcanal@igalia.com, zhiw@nvidia.com, cjia@nvidia.com, jhubbard@nvidia.com, airlied@redhat.com, ajanulgu@redhat.com, lyude@redhat.com, linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v6 25/26] kbuild: rust: remove the `alloc` crate and `GlobalAlloc` Message-ID: <67403b75-682c-4851-8a76-b87fa8e4053b@proton.me> In-Reply-To: <20240816001216.26575-26-dakr@kernel.org> References: <20240816001216.26575-1-dakr@kernel.org> <20240816001216.26575-26-dakr@kernel.org> Feedback-ID: 71780778:user:proton X-Pm-Message-ID: 0eb86b58bf0acf7a80c2b51d282863a30a584ccc MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 97E3218000E X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: ycbx1jju1nmpmaj6fmsnkkf841fgpbjz X-HE-Tag: 1724276110-524799 X-HE-Meta: U2FsdGVkX18+WV9nAf9JQRMCmmYE6N56q2hN2PaHoCxGyP7kQFJdAz4glZMsdJZb+P1SDKMg6TB2G5PC0/tLqWwNvXOb8Tj0JA+U2hJ6bLcMp8yV2vBef0nfwF2zFgPat1sDq/BlCB4PCfnZeg0fIwxGbtek9nuJwPiuDZqSsCVX4lIGvwyDfcWadGxfzWq9oFNym0gb+0ubfaj/3TwsjGJtS3V+FmFYr+1zRCdmMKnCHiX4YjyqR0M50qD6kViXh6LJ0F8HDGRH3r89ohinf7izR7r5Q4xDSZ8SXvOMpe2GAmNOg3+MzIIh2Tk/3Np59KnV5FQfd/IR8LWqaV1b41sz+w9OKmsUj5/8fSfJb2q6WGTFHXFHphI+4TGJlMgoAVEQC0xJ4iJkTDkOY7vOa7b9D3Y/reifJv/2ySPS6OOnS9iGkz7J2H4Shb9L9osNzXncO+z5ip+Tpjzzi318bt/XlDgoPVSyIPzaB77xVTVAHtuLO2Ls2895G26D6sFzoQtx22DTnfU5komF8MMUQbimFr0jYyhtQ4Ofr7fAW9JM1Y6LJsXPcYgXJKVktakcAlx/TNZ8qUjLQ/W09fZF5q+9NfEzVboHvNgbouZMqUv0kDHU35L11prfqYjPUrD6UcpMK4zJnjIDTquGVCUlPK1PL1vFegsJOauhreZqtEgNjiXS0Cq9pntEEfhmAIczJiZNIUKisqMw5fcLnx4+XmJQpVKWtBEmt4KwbmmTmPtazt9vn+bUKTUScU2su5/eqP0nHk7potTsU1aVRmePoHR/ZC5kckcn+WMtPlmMdgcBNKvWkYyGG/MMU11Jq7jKCw1dCK5pS+I/VWV0uRbxKDjKJNSPkenfb/DYo/jL10qcYJzhrkOg82/FxMvZRzCaYjHeiL2kD/5WKAsNdiFrvfK7VMYZIwVx+4cCwZ57tgBkoV7G79e6jUFqx1HJ7e8SD8MIET3A0KxwnNIOyj9 HEPUCsMI 0a/e8qVGViJPPUJdvhQ0U0CQUSZJ1DpyMpBFUjvq9WiIM6/2EODRBXIGrBJWTE67oSsJvFr3nszBe5FmgmQg9f6o/LZhgV9jgBb9qSO9DnEUSUl5Ss5TdpwrbQBZ9KPYJWXVv0rgdLmUmsX1nXzqEkPVBepmLtC/VgpvMRPqTFQQyahz+dciFQdulkMogmkVRhPvqWNL2xKXYp06zTXXfmqDEnsb7DkxNh9N2+OoMwkAiaeeUQiAtb6wz2/tLr2rFIztHComqB/fAbxV2HqD6PTwEe4VyYyDjCQegHMMjiJYJOV4UDb3S1YnPTSV4Dv0fn3bOyjQbTT0gW5jXoSnKFewfEyuOa5fx45RV64+hQ9kzUXxcbrvUu0swJJsm1g+XeRRnTr/FvhAeX2LnP9eoSXJQDa/9wLBsut5j X-Bogosity: Ham, tests=bogofilter, spamicity=0.029832, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 16.08.24 02:11, Danilo Krummrich wrote: > @@ -204,9 +152,6 @@ unsafe fn realloc( > } > } >=20 > -#[global_allocator] > -static ALLOCATOR: Kmalloc =3D Kmalloc; > - > // See . > #[no_mangle] > static __rust_no_alloc_shim_is_unstable: u8 =3D 0; I think Bjorn already mentioned this, but you can also remove this static, since it was also something that alloc needed. --- Cheers, Benno