From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 40D4CC433FE for ; Fri, 30 Sep 2022 08:44:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D1DA28D0003; Fri, 30 Sep 2022 04:44:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CCD6E8D0001; Fri, 30 Sep 2022 04:44:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B96398D0003; Fri, 30 Sep 2022 04:44:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id A76B18D0001 for ; Fri, 30 Sep 2022 04:44:29 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 6096BA07F1 for ; Fri, 30 Sep 2022 08:44:29 +0000 (UTC) X-FDA: 79968115458.24.2A22A94 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf10.hostedemail.com (Postfix) with ESMTP id 0ADE8C000C for ; Fri, 30 Sep 2022 08:44:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1664527468; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+5P7WxpX9YzqjSjpN3Cg4iRUb1rI33yeq0uhwQY+XFQ=; b=KrZS29AVzpDj6NqxEBQOocUNANukTx8PoWXkVvQGRW89Zfu/UdCOigshFPpIIqTdU8m4VB 3l9dxhwNWBcG/RHRhOqgLTlZ3U8QYB1xh6kBuJ48otWXEYq9Uu1uSJ+jMhBWWTaI5CaLHa OMShFMmdgufUZVoh2pZl7DvCuf/fsNc= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-381-XodDLdfVPc6-Qe3nuGDxdQ-1; Fri, 30 Sep 2022 04:44:24 -0400 X-MC-Unique: XodDLdfVPc6-Qe3nuGDxdQ-1 Received: by mail-wr1-f69.google.com with SMTP id j17-20020adfb311000000b0022cd036c497so1322293wrd.14 for ; Fri, 30 Sep 2022 01:44:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date; bh=+5P7WxpX9YzqjSjpN3Cg4iRUb1rI33yeq0uhwQY+XFQ=; b=4TuSAEyTmLK03VOYymMbIXoLwwy+UXG6ayxe0qxqFI+JSOTE3ERJ7DrEu35J03O/CM ftD6Zb9+Nxtqo93uGZHVQqyB/4+54xnytw5wZwJYwyJVSmbUe9b5/o43oLA8WFzhH/2Z 5hOp6NOJ9IWYnJAQ9ENbX1r6K/Y0Xt7RttgQqjiU+G7kxQ7zGOPnqt6FGU1NkdbRPchE Cn1l0ozoE37l09eauKBgEaMX4lLIaklZDe1U5o21mes2gWrFHIedGRnYXEMktIIAPAiM K+E1hx3ZRSVr53j5MizLxIjdDYlOaPpJf2fOezahWTa3i/auNi8Il6FAGymiECAMtutV yVyw== X-Gm-Message-State: ACrzQf3BIovZ1fzHmUuoZibUJ6pxeDZLQxg/syWnssrM6tVnkx61pJmI h9L3FmK9M6CM/I1gqRp0EvoRckDHs8nqPUlY/yK+48VQu8kGBgBAPJTPFhGLGQ1vyhNUqa17t/G ZhyX2apFaDNQ= X-Received: by 2002:a05:600c:500d:b0:3b5:234:d7e9 with SMTP id n13-20020a05600c500d00b003b50234d7e9mr5096882wmr.57.1664527463087; Fri, 30 Sep 2022 01:44:23 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4lSPxx9RSmxEw3e5Wn9C1Knh20ngmmeuWzgTOZVepdksSmhhhH7ldVQWOsiUQ6w2s0/Weahg== X-Received: by 2002:a05:600c:500d:b0:3b5:234:d7e9 with SMTP id n13-20020a05600c500d00b003b50234d7e9mr5096870wmr.57.1664527462765; Fri, 30 Sep 2022 01:44:22 -0700 (PDT) Received: from ?IPV6:2003:cb:c70c:c00:48b:b68a:f9e0:ebce? (p200300cbc70c0c00048bb68af9e0ebce.dip0.t-ipconnect.de. [2003:cb:c70c:c00:48b:b68a:f9e0:ebce]) by smtp.gmail.com with ESMTPSA id v10-20020a5d43ca000000b00228aea99efcsm1456462wrr.14.2022.09.30.01.44.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 30 Sep 2022 01:44:22 -0700 (PDT) Message-ID: <673e494c-eb91-470a-026b-59e414d0916e@redhat.com> Date: Fri, 30 Sep 2022 10:44:21 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: Re: [PATCH v3 1/2] mm: use update_mmu_tlb() on the second thread To: Qi Zheng , akpm@linux-foundation.org, maobibo@loongson.cn, chenhuacai@loongson.cn, songmuchun@bytedance.com Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, loongarch@lists.linux.dev, chris@zankel.net, jcmvbkbc@gmail.com References: <20220929112318.32393-1-zhengqi.arch@bytedance.com> <20220929112318.32393-2-zhengqi.arch@bytedance.com> <0fecbcdc-7324-2d76-8452-b60b4638d074@redhat.com> <32a53a8f-f6f8-6efc-a5f6-a004ffab8c99@bytedance.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <32a53a8f-f6f8-6efc-a5f6-a004ffab8c99@bytedance.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1664527469; a=rsa-sha256; cv=none; b=VoVq0pbb9PkdRnCqTCvR3EE5ymBQM++pIRr2d96uqYCq5z4ssOQzWq848IX+ORJk+Ce++6 ln/0KlELnWKcPA2zNiW3RKT5kVahB5OmT11Jn6YiteYFx0AKtnnGo2ITXikv1I+O394D1I b2Za3lauW5Am7kvqf93gHesrAV86+sY= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=KrZS29AV; spf=pass (imf10.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1664527469; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=+5P7WxpX9YzqjSjpN3Cg4iRUb1rI33yeq0uhwQY+XFQ=; b=gON9YCC7VaPAs8kiX5zw8KLf7YTycPbhdo+VYiVxov5NeYs8T7uhGIugxFRSh2PGTLlED/ FHenBL7svw94L43DUj/Nmn02QYMtLCjQQUI7mXAA+sNlKTmS7Q2DJyU1vgzG8hR1HLKaGH 8WkXKRO3LLjJQtQNV0BdAmuEiAIaXNM= X-Stat-Signature: b3hcfkqg5uao4s9eymakcwb59fwxihen X-Rspamd-Queue-Id: 0ADE8C000C X-Rspam-User: Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=KrZS29AV; spf=pass (imf10.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-Rspamd-Server: rspam01 X-HE-Tag: 1664527468-495827 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 30.09.22 10:43, Qi Zheng wrote: > > > On 2022/9/30 16:30, David Hildenbrand wrote: >> On 29.09.22 13:23, Qi Zheng wrote: >>> As message in commit 7df676974359 ("mm/memory.c: Update local TLB >>> if PTE entry exists") said, we should update local TLB only on the >>> second thread. So in the do_anonymous_page() here, we should use >>> update_mmu_tlb() instead of update_mmu_cache() on the second thread. >>> >> >> Maybe mention here "This only affects performance, but not correctness." > > Oh, this is better. Hi Andrew, do I need to resend the v4? > I assume he can squash it, most probably no need to resend. :) -- Thanks, David / dhildenb