From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 95E3CE77180 for ; Mon, 9 Dec 2024 18:12:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0973B8D0099; Mon, 9 Dec 2024 13:12:37 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 047ED8D0058; Mon, 9 Dec 2024 13:12:36 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E037F8D0099; Mon, 9 Dec 2024 13:12:36 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id BEDBF8D0058 for ; Mon, 9 Dec 2024 13:12:36 -0500 (EST) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 4A068AE146 for ; Mon, 9 Dec 2024 18:12:36 +0000 (UTC) X-FDA: 82876215492.16.D58AB2F Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf28.hostedemail.com (Postfix) with ESMTP id D3121C000B for ; Mon, 9 Dec 2024 18:12:09 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=wIirroJa; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=hrJgg6Rc; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=FoVJX4xB; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=ikgIDxGI; spf=pass (imf28.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1733767932; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=VQPkznA0FVUFZF6eGPKAlkIpnOf0SrzKpjb9fYMd8BA=; b=tuB9Luu7/PkHJSSDW0dxfwLRDbFgMYPvd6hmOr0FKJoI/yBReU1Dw6IJk8vv1gvMs+Yc16 1yOvwOB8hq+0dGt518beMHIeWJnXHXtPAuzIdCC15W9LJ2p/NgLTVevJ+vSWISwwaelizd XyBeTjRXyelGjXCoI9n+gYyycffOjyg= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1733767932; a=rsa-sha256; cv=none; b=WgHq4k5vA+BsvdXviPh1frHo8vug12W1WGUVbNR5Mmpurc58Qp8VI8+D8iJZkmvaFWL12V fbs9/rdxjhDbugd4a06Yy30MG4R1TSbKBfdQGWAoiQvhQDUMM2rYWIRMjhqnqoIHEQ22Ya w6ieB9OMesHe9ufXQ8vGIo9gmvnkc/Q= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=wIirroJa; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=hrJgg6Rc; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=FoVJX4xB; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=ikgIDxGI; spf=pass (imf28.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 9AD4C1F45B; Mon, 9 Dec 2024 18:12:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1733767952; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=VQPkznA0FVUFZF6eGPKAlkIpnOf0SrzKpjb9fYMd8BA=; b=wIirroJaznmu10uGKPNkqnnOIywG5bJFtGjH4MLDaDkNKAxJuP25Zkas4tQQhulOO6Pok+ 6odSqlOgArBRMuev3TaS/kGr0b3kNWfSdzEu8xLkv8DCT3vLae7/xlOAcfWjxIPrLflSGc f7JpwUiUoqmG+lZhVzfwi5li/Q/QsK4= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1733767952; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=VQPkznA0FVUFZF6eGPKAlkIpnOf0SrzKpjb9fYMd8BA=; b=hrJgg6RcdtQI7cZlWPt+aDLMZVBfSgkRw/sJsOfw5WFq1IFJyXxAtll2Zow6H0V6lw99F+ rIjqgNPUFtTBn1CA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1733767951; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=VQPkznA0FVUFZF6eGPKAlkIpnOf0SrzKpjb9fYMd8BA=; b=FoVJX4xBdxyP6DbYkQrJlKSMSy6TQ5CHl9rsWbQvIp8psFdGVCFS8+H0RO+jnrMkpgTIiG n8C7uvO3rdBTztx+qm6eTSOObnvrVBOytddb2WpZBjlg+ro02W0SCC/G/KKGsJg04vvfGZ 25Ns3xXVE3QunR0dB2J+EO96nhvE4Q0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1733767951; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=VQPkznA0FVUFZF6eGPKAlkIpnOf0SrzKpjb9fYMd8BA=; b=ikgIDxGIv4W6kCh+JQ5VAJ5bY2hL5fpCqt4amKW9LPNxPwp64GqP8oodts1PxlPy897tMh 2bAk/sm3SSLyLOBA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id DA364138D2; Mon, 9 Dec 2024 18:12:30 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id khWaNA4zV2cdRwAAD6G6ig (envelope-from ); Mon, 09 Dec 2024 18:12:30 +0000 Message-ID: <673d05d5-276d-4b65-941c-6c9295e276b1@suse.cz> Date: Mon, 9 Dec 2024 19:12:30 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 2/2] mm: use clear_user_(high)page() for arch with special user folio handling Content-Language: en-US To: Zi Yan , linux-mm@kvack.org, Andrew Morton , Geert Uytterhoeven , Mathieu Desnoyers Cc: David Hildenbrand , "Matthew Wilcox (Oracle)" , Miaohe Lin , Kefeng Wang , John Hubbard , "Huang, Ying" , Ryan Roberts , Alexander Potapenko , Kees Cook , Vineet Gupta , linux-kernel@vger.kernel.org, linux-snps-arc@lists.infradead.org, Geert Uytterhoeven References: <20241207171631.2853336-1-ziy@nvidia.com> <20241207171631.2853336-2-ziy@nvidia.com> From: Vlastimil Babka Autocrypt: addr=vbabka@suse.cz; keydata= xsFNBFZdmxYBEADsw/SiUSjB0dM+vSh95UkgcHjzEVBlby/Fg+g42O7LAEkCYXi/vvq31JTB KxRWDHX0R2tgpFDXHnzZcQywawu8eSq0LxzxFNYMvtB7sV1pxYwej2qx9B75qW2plBs+7+YB 87tMFA+u+L4Z5xAzIimfLD5EKC56kJ1CsXlM8S/LHcmdD9Ctkn3trYDNnat0eoAcfPIP2OZ+ 9oe9IF/R28zmh0ifLXyJQQz5ofdj4bPf8ecEW0rhcqHfTD8k4yK0xxt3xW+6Exqp9n9bydiy tcSAw/TahjW6yrA+6JhSBv1v2tIm+itQc073zjSX8OFL51qQVzRFr7H2UQG33lw2QrvHRXqD Ot7ViKam7v0Ho9wEWiQOOZlHItOOXFphWb2yq3nzrKe45oWoSgkxKb97MVsQ+q2SYjJRBBH4 8qKhphADYxkIP6yut/eaj9ImvRUZZRi0DTc8xfnvHGTjKbJzC2xpFcY0DQbZzuwsIZ8OPJCc LM4S7mT25NE5kUTG/TKQCk922vRdGVMoLA7dIQrgXnRXtyT61sg8PG4wcfOnuWf8577aXP1x 6mzw3/jh3F+oSBHb/GcLC7mvWreJifUL2gEdssGfXhGWBo6zLS3qhgtwjay0Jl+kza1lo+Cv BB2T79D4WGdDuVa4eOrQ02TxqGN7G0Biz5ZLRSFzQSQwLn8fbwARAQABzSBWbGFzdGltaWwg QmFia2EgPHZiYWJrYUBzdXNlLmN6PsLBlAQTAQoAPgIbAwULCQgHAwUVCgkICwUWAgMBAAIe AQIXgBYhBKlA1DSZLC6OmRA9UCJPp+fMgqZkBQJkBREIBQkRadznAAoJECJPp+fMgqZkNxIQ ALZRqwdUGzqL2aeSavbum/VF/+td+nZfuH0xeWiO2w8mG0+nPd5j9ujYeHcUP1edE7uQrjOC Gs9sm8+W1xYnbClMJTsXiAV88D2btFUdU1mCXURAL9wWZ8Jsmz5ZH2V6AUszvNezsS/VIT87 AmTtj31TLDGwdxaZTSYLwAOOOtyqafOEq+gJB30RxTRE3h3G1zpO7OM9K6ysLdAlwAGYWgJJ V4JqGsQ/lyEtxxFpUCjb5Pztp7cQxhlkil0oBYHkudiG8j1U3DG8iC6rnB4yJaLphKx57NuQ PIY0Bccg+r9gIQ4XeSK2PQhdXdy3UWBr913ZQ9AI2usid3s5vabo4iBvpJNFLgUmxFnr73SJ KsRh/2OBsg1XXF/wRQGBO9vRuJUAbnaIVcmGOUogdBVS9Sun/Sy4GNA++KtFZK95U7J417/J Hub2xV6Ehc7UGW6fIvIQmzJ3zaTEfuriU1P8ayfddrAgZb25JnOW7L1zdYL8rXiezOyYZ8Fm ZyXjzWdO0RpxcUEp6GsJr11Bc4F3aae9OZtwtLL/jxc7y6pUugB00PodgnQ6CMcfR/HjXlae h2VS3zl9+tQWHu6s1R58t5BuMS2FNA58wU/IazImc/ZQA+slDBfhRDGYlExjg19UXWe/gMcl De3P1kxYPgZdGE2eZpRLIbt+rYnqQKy8UxlszsBNBFsZNTUBCACfQfpSsWJZyi+SHoRdVyX5 J6rI7okc4+b571a7RXD5UhS9dlVRVVAtrU9ANSLqPTQKGVxHrqD39XSw8hxK61pw8p90pg4G /N3iuWEvyt+t0SxDDkClnGsDyRhlUyEWYFEoBrrCizbmahOUwqkJbNMfzj5Y7n7OIJOxNRkB IBOjPdF26dMP69BwePQao1M8Acrrex9sAHYjQGyVmReRjVEtv9iG4DoTsnIR3amKVk6si4Ea X/mrapJqSCcBUVYUFH8M7bsm4CSxier5ofy8jTEa/CfvkqpKThTMCQPNZKY7hke5qEq1CBk2 wxhX48ZrJEFf1v3NuV3OimgsF2odzieNABEBAAHCwXwEGAEKACYCGwwWIQSpQNQ0mSwujpkQ PVAiT6fnzIKmZAUCZAUSmwUJDK5EZgAKCRAiT6fnzIKmZOJGEACOKABgo9wJXsbWhGWYO7mD 8R8mUyJHqbvaz+yTLnvRwfe/VwafFfDMx5GYVYzMY9TWpA8psFTKTUIIQmx2scYsRBUwm5VI EurRWKqENcDRjyo+ol59j0FViYysjQQeobXBDDE31t5SBg++veI6tXfpco/UiKEsDswL1WAr tEAZaruo7254TyH+gydURl2wJuzo/aZ7Y7PpqaODbYv727Dvm5eX64HCyyAH0s6sOCyGF5/p eIhrOn24oBf67KtdAN3H9JoFNUVTYJc1VJU3R1JtVdgwEdr+NEciEfYl0O19VpLE/PZxP4wX PWnhf5WjdoNI1Xec+RcJ5p/pSel0jnvBX8L2cmniYnmI883NhtGZsEWj++wyKiS4NranDFlA HdDM3b4lUth1pTtABKQ1YuTvehj7EfoWD3bv9kuGZGPrAeFNiHPdOT7DaXKeHpW9homgtBxj 8aX/UkSvEGJKUEbFL9cVa5tzyialGkSiZJNkWgeHe+jEcfRT6pJZOJidSCdzvJpbdJmm+eED w9XOLH1IIWh7RURU7G1iOfEfmImFeC3cbbS73LQEFGe1urxvIH5K/7vX+FkNcr9ujwWuPE9b 1C2o4i/yZPLXIVy387EjA6GZMqvQUFuSTs/GeBcv0NjIQi8867H3uLjz+mQy63fAitsDwLmR EP+ylKVEKb0Q2A== In-Reply-To: <20241207171631.2853336-2-ziy@nvidia.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Action: no action X-Rspamd-Queue-Id: D3121C000B X-Rspam-User: X-Rspamd-Server: rspam07 X-Stat-Signature: ejyoidy5hgc7sbcefnroemittfmkx6xd X-HE-Tag: 1733767929-957334 X-HE-Meta: U2FsdGVkX1/agHORJXDAtnlKFSgXWjfUdzTM04/ib1DgLxlvQCr1/5VEnC72bb03FpaDQXRPubJbbZwLyMXTiUjvOY1y/0uZEi4PuXaofskkFHmgH8ds+nyK4VYQghlpVxeDpb0BPRzBoN+vvwDzOtocG4pjeb5qrdhL8NLrgWwApE2JxXsdxAJY+fTvX7ychgliHPQn49S4DB/wPmYIm8xfv9RLTpUcFE1mqt8E1TzFJ482htlIpBoI/KZgVIKwL2oeWOJov6WuXFmgU/C5iQLiL8bAjowtTgn8HXKpXy+rPHUzt1Xre2NOd0vC56YJeP3WCYqHZ6GMSF8mvjuaC2hQ6kHIQ2QzPqa9hspYxv8m6YQCXksFUUwRR03csdI66zb1pPktvNXrSmUB1nfS8j9NnmA6A41x2TnLPq0DrptmQvMw8f0unHwyLPAeLOpaaGMfiAaEbbzxA6n9xswuRPWUnYdlKGqCDOLu69Oo2Fwpyqz8KjlHYVkX1Dcu6zmXmh4vQQp93wE3AGGbWfkxbbxQYJoJ2M5j3Ig2t7blDLCNyp795X+ml3G4JtfWd67oTLpsKeQQV01EEnDRiMKPBtKKP26NTDAmRJOISG7iBlJ76UyRgtYnPrahgInjIq2EM6OyuF4CDT+cb9reRfr2a2EeydQ6CD6d3v7SW3L2daZrJv4mIGcKzs2ivvj9ZeNXIzIjw4UrxCeEHuGvKdQLMP2eMY4Rc+E0dvEjrY0Azntv5Ieua2eg5kImrsK5j/c3S329vowY7+zAgakShalrzuf8QVWP9a05citOtOWPtpSOQeQwYTlnOTii84bfGis8VWxwZIeWFaoCeQbMTmxuzGAmWXxFAwyhnd3l1AbP8OcAvUUHD5/gvo2mSuM71EcQT/wmJpeqarxlLVA4QEgTbCML4sT6wNA4WTqZnBDH00bx1Xsbsp/RXcQOHbQnhIUelEREOTKtUw189FfuoP6 2TEv4zr8 404ATg3FQ/2GvqYw0Tm136m/63pQMrC4uKEWY8Vx0wG9o/lpraGRQil9sYhAt2ivpib5ALnIzhTEOalpPsm0g0Y1lAbL8TwQhBavd6jlCOdOC9ht1Ure19ce7DSX1sKvLOXC/E39f5XJL3Kaet+ECT0Q2774fv40xhWFQMWyb9h7Yqth5sga7b23re0XGPU3H8bQeiKpTWGqlI9vdy0sUkd8nibT4+36XTnJwETx676pKXEALp3nUsJxhlKxrGPfAyjwCHIhtzJhL7q2tE4eUP6/0rXy3Ns0bTc6Yx+qbtTzZsKpRZ4muk/f35R2LcsFleP4+ARiHD71rZ9+SRaSJKw6xzJl03VazA4CVJwmagK/GB/Ggsa1RrJxT8idQ9roChoKL4ZpjbYRefmNjj6g0+YJplFyTmjhI7xsqNxTqOm6AgpKsEmQTxBhkx19ND8rk3mTrPG6XMxGNECG1Xkh74eRp7F+WuFIQRgCNPgFrmLQELUA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 12/7/24 18:16, Zi Yan wrote: > Some architectures have special handling after clearing user folios: > architectures, which set cpu_dcache_is_aliasing() to true, require > flushing dcache; arc, which sets cpu_icache_is_aliasing() to true, changes > folio->flags to make icache coherent to dcache. So __GFP_ZERO using only > clear_page() is not enough to zero user folios and clear_user_(high)page() > must be used. Otherwise, user data will be corrupted. > > Fix it by always clearing user folios with clear_user_(high)page() when > cpu_dcache_is_aliasing() is true or cpu_icache_is_aliasing() is true. > Rename alloc_zeroed() to alloc_need_zeroing() and invert the logic to > clarify its intend. user_alloc_needs_zeroing() would be perhaps more descriptive? > Fixes: 5708d96da20b ("mm: avoid zeroing user movable page twice with init_on_alloc=1") > Reported-by: Geert Uytterhoeven > Closes: https://lore.kernel.org/linux-mm/CAMuHMdV1hRp_NtR5YnJo=HsfgKQeH91J537Gh4gKk3PFZhSkbA@mail.gmail.com/ > Tested-by: Geert Uytterhoeven > Signed-off-by: Zi Yan Acked-by: Vlastimil Babka