From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 260F3CD1292 for ; Thu, 4 Apr 2024 20:19:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B49716B009C; Thu, 4 Apr 2024 16:19:50 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AF9B46B009D; Thu, 4 Apr 2024 16:19:50 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9E8386B009E; Thu, 4 Apr 2024 16:19:50 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 7EE376B009C for ; Thu, 4 Apr 2024 16:19:50 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 36A1216020F for ; Thu, 4 Apr 2024 20:19:50 +0000 (UTC) X-FDA: 81972965340.07.7F972A8 Received: from mail3-relais-sop.national.inria.fr (mail3-relais-sop.national.inria.fr [192.134.164.104]) by imf19.hostedemail.com (Postfix) with ESMTP id 4969D1A0008 for ; Thu, 4 Apr 2024 20:19:47 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=inria.fr header.s=dc header.b=Z92D4Stc; dmarc=pass (policy=none) header.from=inria.fr; spf=pass (imf19.hostedemail.com: domain of julia.lawall@inria.fr designates 192.134.164.104 as permitted sender) smtp.mailfrom=julia.lawall@inria.fr ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712261987; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding:in-reply-to: references:dkim-signature; bh=y/kdsN/mgtgTqBkmER+4H45uRDUQn83rvjEd+cxD8PM=; b=jgqN1ACrhhC8Dagp/FoxZ2YNBdRMRtCTZ0hCs7t8y4m6hoqfN2e2EmeQUbHnBIHH1Ew2Er +R3aXN3gwEg/TbaU9lLvOa9cnKO3WFCQoRazWzSuxzkmaGEW2XnZrnyzedgLPj0w4PP3JN KeVbpitxhAV3tQaLPpCn6rWemHqR4UM= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=inria.fr header.s=dc header.b=Z92D4Stc; dmarc=pass (policy=none) header.from=inria.fr; spf=pass (imf19.hostedemail.com: domain of julia.lawall@inria.fr designates 192.134.164.104 as permitted sender) smtp.mailfrom=julia.lawall@inria.fr ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1712261987; a=rsa-sha256; cv=none; b=VdWThOU8afZe7kcan+OQ7vDt8H8esFF5UabNATjSB+95u9Zs/HjZPlITCxjRFUHxlOl8UQ htGtIYiwNuBA8Gzqw2aoJCuqw6K4pv60VVWlz5NVIhUkIfQp2cT8vbf6JIJZBSAlISudBG hqrXfKYPf7CSAfS9VhSPgyx7ssrz0W0= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=inria.fr; s=dc; h=date:from:to:cc:subject:message-id:mime-version; bh=y/kdsN/mgtgTqBkmER+4H45uRDUQn83rvjEd+cxD8PM=; b=Z92D4StchdFVdCctGMoXBS+UkggW88XRDdzyr9lx67meG+akgxsb/OCh IBh9BE8i0NK0TTWoxpV8z+ZqB/Kq6lLpBnmqcjeu25Rt5UaGRbfMsAMKy KydqOEAi2EodyZN+26URyb1voUEUgE6E46PFD1KKrvjHXptC58EBWGFMU Q=; X-IronPort-AV: E=Sophos;i="6.07,180,1708383600"; d="scan'208";a="83928678" Received: from 205.153.92.156.ipyx-135073-zyo.above.net (HELO hadrien) ([205.153.92.156]) by mail3-relais-sop.national.inria.fr with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Apr 2024 22:19:45 +0200 Date: Thu, 4 Apr 2024 16:19:42 -0400 (EDT) From: Julia Lawall To: "Uladzislau Rezki (Sony)" , Andrew Morton , Linux Memory Management List cc: oe-kbuild-all@lists.linux.dev Subject: [linux-next:master 2674/3921] mm/vmalloc.c:1079:3-9: preceding lock on line 1075 (fwd) Message-ID: <673197af-61f4-669b-e0f2-b229603498f1@inria.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Rspamd-Queue-Id: 4969D1A0008 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: atwidmfbcq7r3fq4sgxroqfgdam4nt9e X-HE-Tag: 1712261987-105959 X-HE-Meta: U2FsdGVkX1+TLlsNqwm9KfSIApIb9CXuU0dW8dJ1pGcBR/xrZ4yOATVEFmcfRpEPKMZtsRzJtY8OoSJ6+oU4YaDUd8hBXNWrh8lGUITo7bRPg+ZJCPobRMTQinlEeVXvQTFMfiYN/ypDi0tywSHrQPW37SIuLulW1mwxdBgi/xItCb34fbhul/qLD/HgZkfrcsYG3htWfkJwuKx2UpUCNGQL6dDC1m0cadoy8jJmvNUrsK746RUIUDiJ+ZhJl+yn8d8RBt7SAtiuWcZlMAcONeS6c5VxySzhIdNIFaXJU/Keb7NhGxOVtSi9bTzK7c4DWs+4naMJhBtww/LI/pFstMsOyIdlaMry/UvMaTqEvFHhE1iqVc/C6R/vALW4baN4KUn5sMMTOQUSXAVTcUgI2rT7cHyN6VJWAiP9I68nLQTWtga6NOjvES6ZoG+6bXlb1QP3bW7yFqy2gGkQHBkSzUm7CZEY6wSnIdYOL165eiyIiTjC2jNA7twjxY/5WTBawUwm8T5ipQvZVD3dm9iNzCenrk7BtoprbyI8d9Q7x/EedXhmngpDiqhgqwQLmxLu9/OYwSLwG14XZfkrevu9Br1cEK1LAnOmwWS/Yo2G4QvvqPEw8e+OcFVDELKuSuHAioKizGMsSnasCUayEiuc/zJx9HFF/rslMGK1M+9vZ5kyGBCGlLo7hGylWqmH0AhnyysLXyJ+gGayr0hBxVAtfpT0OB1/5ocBUoON0TZ1xK40IM7aMaQ8wBVflOZxHAn16RW3yVnaiiIyJv6smnz7ill+47VcMjgWbbSXGMVTa1LzsSkFxuB1tMaSlSC+2N+iQ75rySwKb7xt/OL2TtD9QDQWzD5YFr0XpoWv5fzH6ympDJ0ArVQgg2QAvWkHYUNQtLBQhEkn6tNMCkk6e09XK+vKhAoXX8qPdUEWoYAgfnFrVuGTiEJl80v51W/ORdKd2rm9VdCRxQKR1bHVuc7 pgHi+iX0 VgC7C83Rwho53EKlB1Hx5jT2gEL+Zsb5kgXPfaQ3t2nnFyKqSM5S4NuwXR08fEDOb/blF89MqQtSXFG1blvHj80I/Nk5rwbufa17rHC/eX/DNYrM+cN3l7xlrJNUkePG2iFg3YErXr3nTfwrbZhjbp0I71Cm9PzIQq1qXTtownkwbXQ9wn1ylRuNToARlTCb2boC0//yhF26RUiMoz2VWVI6GQ5sd3oJlqlug0D4gY2v7Q0pXXYJ84UMXoVLdTHUXO/26fVvOg+oiqlIcu8xevKKXvEUne/ybMalu0i/N3cZFLDGYxalNSBn7zlosJ0Jb3F2DYydr15ChUsvydXefeqrbeT4cIGUW0UzRvD/5PJ0+dghgCAIj3jMa9T6OK286qwIYzh48qBgzylIJmxlrELAuuvRRBbbbbE/HwqSF2OCj7R1JFrEn5tyf5A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Please check whether an unlock is needed before the return on line 1079. julia ---------- Forwarded message ---------- Date: Fri, 5 Apr 2024 04:15:36 +0800 From: kernel test robot To: oe-kbuild@lists.linux.dev Cc: lkp@intel.com, Julia Lawall Subject: [linux-next:master 2674/3921] mm/vmalloc.c:1079:3-9: preceding lock on line 1075 BCC: lkp@intel.com CC: oe-kbuild-all@lists.linux.dev CC: Linux Memory Management List TO: "Uladzislau Rezki (Sony)" CC: Andrew Morton CC: Linux Memory Management List tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master head: 2b3d5988ae2cb5cd945ddbc653f0a71706231fdd commit: 936eedaeacdee6663fa552fc650df4cd4d75d3e4 [2674/3921] mm: vmalloc: fix lockdep warning :::::: branch date: 17 hours ago :::::: commit date: 3 days ago config: x86_64-randconfig-104-20240405 (https://download.01.org/0day-ci/archive/20240405/202404050445.yVFqmYIK-lkp@intel.com/config) compiler: gcc-13 (Ubuntu 13.2.0-4ubuntu3) 13.2.0 If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Reported-by: Julia Lawall | Closes: https://lore.kernel.org/r/202404050445.yVFqmYIK-lkp@intel.com/ cocci warnings: (new ones prefixed by >>) >> mm/vmalloc.c:1079:3-9: preceding lock on line 1075 vim +1079 mm/vmalloc.c f181234a5a21fd Chen Wandun 2021-09-02 1038 53becf32aec1c8 Uladzislau Rezki (Sony 2024-01-02 1039) /* 53becf32aec1c8 Uladzislau Rezki (Sony 2024-01-02 1040) * Returns a node where a first VA, that satisfies addr < va_end, resides. 53becf32aec1c8 Uladzislau Rezki (Sony 2024-01-02 1041) * If success, a node is locked. A user is responsible to unlock it when a 53becf32aec1c8 Uladzislau Rezki (Sony 2024-01-02 1042) * VA is no longer needed to be accessed. 53becf32aec1c8 Uladzislau Rezki (Sony 2024-01-02 1043) * 53becf32aec1c8 Uladzislau Rezki (Sony 2024-01-02 1044) * Returns NULL if nothing found. 53becf32aec1c8 Uladzislau Rezki (Sony 2024-01-02 1045) */ 53becf32aec1c8 Uladzislau Rezki (Sony 2024-01-02 1046) static struct vmap_node * 53becf32aec1c8 Uladzislau Rezki (Sony 2024-01-02 1047) find_vmap_area_exceed_addr_lock(unsigned long addr, struct vmap_area **va) 53becf32aec1c8 Uladzislau Rezki (Sony 2024-01-02 1048) { 936eedaeacdee6 Uladzislau Rezki (Sony 2024-03-28 1049) unsigned long va_start_lowest; 936eedaeacdee6 Uladzislau Rezki (Sony 2024-03-28 1050) struct vmap_node *vn; 53becf32aec1c8 Uladzislau Rezki (Sony 2024-01-02 1051) int i; 53becf32aec1c8 Uladzislau Rezki (Sony 2024-01-02 1052) 936eedaeacdee6 Uladzislau Rezki (Sony 2024-03-28 1053) repeat: 936eedaeacdee6 Uladzislau Rezki (Sony 2024-03-28 1054) for (i = 0, va_start_lowest = 0; i < nr_vmap_nodes; i++) { 53becf32aec1c8 Uladzislau Rezki (Sony 2024-01-02 1055) vn = &vmap_nodes[i]; 53becf32aec1c8 Uladzislau Rezki (Sony 2024-01-02 1056) 53becf32aec1c8 Uladzislau Rezki (Sony 2024-01-02 1057) spin_lock(&vn->busy.lock); 936eedaeacdee6 Uladzislau Rezki (Sony 2024-03-28 1058) *va = __find_vmap_area_exceed_addr(addr, &vn->busy.root); 53becf32aec1c8 Uladzislau Rezki (Sony 2024-01-02 1059) 936eedaeacdee6 Uladzislau Rezki (Sony 2024-03-28 1060) if (*va) 936eedaeacdee6 Uladzislau Rezki (Sony 2024-03-28 1061) if (!va_start_lowest || (*va)->va_start < va_start_lowest) 936eedaeacdee6 Uladzislau Rezki (Sony 2024-03-28 1062) va_start_lowest = (*va)->va_start; 936eedaeacdee6 Uladzislau Rezki (Sony 2024-03-28 1063) spin_unlock(&vn->busy.lock); 53becf32aec1c8 Uladzislau Rezki (Sony 2024-01-02 1064) } 53becf32aec1c8 Uladzislau Rezki (Sony 2024-01-02 1065) 936eedaeacdee6 Uladzislau Rezki (Sony 2024-03-28 1066) /* 936eedaeacdee6 Uladzislau Rezki (Sony 2024-03-28 1067) * Check if found VA exists, it might it is gone away. 936eedaeacdee6 Uladzislau Rezki (Sony 2024-03-28 1068) * In this case we repeat the search because a VA has 936eedaeacdee6 Uladzislau Rezki (Sony 2024-03-28 1069) * been removed concurrently thus we need to proceed 936eedaeacdee6 Uladzislau Rezki (Sony 2024-03-28 1070) * with next one what is a rare case. 936eedaeacdee6 Uladzislau Rezki (Sony 2024-03-28 1071) */ 936eedaeacdee6 Uladzislau Rezki (Sony 2024-03-28 1072) if (va_start_lowest) { 936eedaeacdee6 Uladzislau Rezki (Sony 2024-03-28 1073) vn = addr_to_node(va_start_lowest); db64fe02258f15 Nicholas Piggin 2008-10-18 1074 936eedaeacdee6 Uladzislau Rezki (Sony 2024-03-28 @1075) spin_lock(&vn->busy.lock); 936eedaeacdee6 Uladzislau Rezki (Sony 2024-03-28 1076) *va = __find_vmap_area(va_start_lowest, &vn->busy.root); 4aff1dc4fb3a5a Andrey Konovalov 2022-03-24 1077 936eedaeacdee6 Uladzislau Rezki (Sony 2024-03-28 1078) if (*va) 936eedaeacdee6 Uladzislau Rezki (Sony 2024-03-28 @1079) return vn; db64fe02258f15 Nicholas Piggin 2008-10-18 1080 936eedaeacdee6 Uladzislau Rezki (Sony 2024-03-28 1081) spin_unlock(&vn->busy.lock); 936eedaeacdee6 Uladzislau Rezki (Sony 2024-03-28 1082) goto repeat; db64fe02258f15 Nicholas Piggin 2008-10-18 1083 } db64fe02258f15 Nicholas Piggin 2008-10-18 1084 db64fe02258f15 Nicholas Piggin 2008-10-18 1085 return NULL; db64fe02258f15 Nicholas Piggin 2008-10-18 1086 } db64fe02258f15 Nicholas Piggin 2008-10-18 1087 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki