From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 25224C77B73 for ; Wed, 31 May 2023 01:44:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 70723900003; Tue, 30 May 2023 21:44:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 69023900002; Tue, 30 May 2023 21:44:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5578D900003; Tue, 30 May 2023 21:44:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 4391A900002 for ; Tue, 30 May 2023 21:44:11 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 0EB0DA0390 for ; Wed, 31 May 2023 01:44:11 +0000 (UTC) X-FDA: 80848854702.10.62E0F1F Received: from out30-97.freemail.mail.aliyun.com (out30-97.freemail.mail.aliyun.com [115.124.30.97]) by imf19.hostedemail.com (Postfix) with ESMTP id 170F51A0010 for ; Wed, 31 May 2023 01:44:07 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=none; spf=pass (imf19.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.97 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com; dmarc=pass (policy=none) header.from=alibaba.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1685497449; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Ta9g3gkYxNR3NDRP0hSjLtg1DRWXZjsdilXOX76aDbY=; b=t9mZzUwnJIBmPZ5bVgYr6Xt3iUHcDvOiZwTpWCiZv10TtGIjBsOmPeMonDg0YQsUdKu2xv P6Atwh/9gk3c/++4az3VuX5smHNj4cShUuGxXTj1H31vWaZMbiFRFwtKCh3sK1PioVG5Ty mgzQFU610qypDUukjGP29d7ObZHEhCA= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=none; spf=pass (imf19.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.97 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com; dmarc=pass (policy=none) header.from=alibaba.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1685497449; a=rsa-sha256; cv=none; b=EEOmqSUfUnp6zeeG5FhZDi5RQTXnJJFxkilOsYi+yp1JVgcmA674C9XcJznRgLCnGGGcQk pUwx8N1T6/gOzhT0O7PgVjHQgYdKRRcRUYIyCNXEYesFU/3TJV2XoRMzBhjhGApMtkEecd b4s+KUngL04p9ai+M7fIp6VkgC+CNRM= X-Alimail-AntiSpam:AC=PASS;BC=-1|-1;BR=01201311R201e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018046049;MF=baolin.wang@linux.alibaba.com;NM=1;PH=DS;RN=5;SR=0;TI=SMTPD_---0VjvObJY_1685497442; Received: from 30.97.48.48(mailfrom:baolin.wang@linux.alibaba.com fp:SMTPD_---0VjvObJY_1685497442) by smtp.aliyun-inc.com; Wed, 31 May 2023 09:44:03 +0800 Message-ID: <67234104-c059-1262-1c69-10b966700036@linux.alibaba.com> Date: Wed, 31 May 2023 09:44:19 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.11.2 Subject: Re: [PATCH 1/6] mm: compaction: drop the redundant page validation in update_pageblock_skip() To: Vlastimil Babka , akpm@linux-foundation.org Cc: mgorman@techsingularity.net, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <5142e15b9295fe8c447dbb39b7907a20177a1413.1685018752.git.baolin.wang@linux.alibaba.com> <6feab6b0-ec49-8651-bc8e-14ec40249017@suse.cz> From: Baolin Wang In-Reply-To: <6feab6b0-ec49-8651-bc8e-14ec40249017@suse.cz> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 170F51A0010 X-Rspam-User: X-Stat-Signature: phkhuswmma1fkd9anout3xxy1ahneto6 X-Rspamd-Server: rspam01 X-HE-Tag: 1685497447-410344 X-HE-Meta: U2FsdGVkX1/TrCBCe80ByN2+EFeWIChsZM2Dz/NpGDswo4SOuUq37/Zbl7BKvnucLA6zDIN1S4cmCd81kf+dQW+OCRdIOUpa/K/kswuFGfR3YlDkHW9o6TuUClbc1Lc1+vVRx3epNdegMS2CLmZk8qBBuGOWU19ssw9+SFouI1L6Cv9tqzLHeIKhrxysHX/7nhkagVBJVtSNYeBL3vgW+Snsq2W06j9amkp81tlnrAPsFrJtxpZa9ZQsA2EYFZL1Fae+sAnhc7eSlTCkNzhhoAsWL7OeQveVZcvTe4bMaMSsHnCoiNqyRgvi+ZA6XWgUpz7zpidUtml+P1rad4VSbdSo+SV1vsXbMrMK0d7rtwLbJVy8qzj9WmRAD6lzjcn9F5hMqnppQTYHmX7ozawdpInHfvsO+wbN0fyPuvykBFwNTtqtfYFi3ZXkDPo8pFlPe/CmIhhKRJDf5DCDrp9Hu4bQj2uB71ZB96jbMpO8FZF3Wj6DDQut7j9LJdJorsjAlICy0f1r1S4H53e3fTtDKIFbUmpYGOOQEvhrBFzk6C2G7x8VjQeGGyVyGaMkbx8Lp3Qew5JSS8wXyJriWiq3+eVTLagz7qkBBzOGPtgfT6gZ86FBE0mzIgG4xoMvwSH5NeDZhvpwml6Y8zFC0DlIIkyUQMoOmrDhAHCmwPgBFKSGGcMG5KdFpq6KNfrqQUfTdDre55hHByNFIEx4W7KVPozhdExdk0VAe2i1zKBMXbwKlpr9bfqJ4hSj7EL1zndtOGYJ3Ui76faJ2gwf0ddoj9iDlLXoN+l6/C7BkSLRxJdbu0EEW/Ht7q7RPrrC405JLZGNlY1P/023Bx8hCLkoCQiGvH3PXJ+4qtmuuZI7MDXPbnapNznX5B5LJ7RmYiX4R6fL/qkAdWDJZzj2U3O0BXJ0TzaLfZhum3ccvtxBUWacv4sfOeEZ6u2nrLrGP7zuTZy6FcW58bPuTQP1XvS AWgMMeGP 8AOl3FQp+qsmbZ+YMN68MFYBov/igDx0+3i4qfXnOaOoUTZNsQhzbMo6YaL6ldVuBvm3exZtJqrJE+gm8Ry5buYy0u7/p/RQjCoEXBWwJKQRvAmpprhxNUlj6KB0pJ/dEn1IrNM2B/6KEZy8HSJm087EbLA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 5/30/2023 3:27 PM, Vlastimil Babka wrote: > On 5/25/23 14:53, Baolin Wang wrote: >> The caller has validated the page before calling pdate_pageblock_skip(), > ^ u Ah, sorry for typos. And I see Andrew has already helped to correct this typo. Thanks Andrew :) >> thus drop the redundant page validation in update_pageblock_skip(). >> >> Signed-off-by: Baolin Wang > > Acked-by: Vlastimil Babka Thanks for your reviewing. >> --- >> mm/compaction.c | 3 --- >> 1 file changed, 3 deletions(-) >> >> diff --git a/mm/compaction.c b/mm/compaction.c >> index 163e2ec70aff..426bb6ce070b 100644 >> --- a/mm/compaction.c >> +++ b/mm/compaction.c >> @@ -436,9 +436,6 @@ static void update_pageblock_skip(struct compact_control *cc, >> if (cc->no_set_skip_hint) >> return; >> >> - if (!page) >> - return; >> - >> set_pageblock_skip(page); >> >> /* Update where async and sync compaction should restart */