From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 052DEE77198 for ; Tue, 7 Jan 2025 10:33:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8FFC16B0089; Tue, 7 Jan 2025 05:33:19 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8AEF76B00AC; Tue, 7 Jan 2025 05:33:19 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 728676B00AD; Tue, 7 Jan 2025 05:33:19 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 50CE66B0089 for ; Tue, 7 Jan 2025 05:33:19 -0500 (EST) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id F3C05160894 for ; Tue, 7 Jan 2025 10:33:18 +0000 (UTC) X-FDA: 82980293676.15.4C51557 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf25.hostedemail.com (Postfix) with ESMTP id 7C5BDA0003 for ; Tue, 7 Jan 2025 10:33:16 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=c2+mCTPG; spf=pass (imf25.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736245996; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=46xrDz1NEoXlBWxQO9+lozwpqQWVqsK1PYCSnaS3tk0=; b=NOdCl+bE3A3xwCiSh8y06gP1nNG9ew4YboaW+rx/8LEtOuqveHLpiQvbuLDJklZy1GjFUA h4uVl6os8RwUI/63tIvJlDqmjInzFZy3bXGSwnjZkD5SzfVZ661I094TMK0S24NJ3U5pcB yclYXr2GjIgyyhdQ6/8Eimc4h2patUM= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=c2+mCTPG; spf=pass (imf25.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1736245996; a=rsa-sha256; cv=none; b=qMidq87ArLNhRXtjHmvkQnlnLbJOX6T1Q4KTGuxBY2KkQPf349sEZwzLqFR9CTPrN9dWsX QW+EaIvSxcwStlNyLXIEci139rHXXdQRntupsQjn7G8hhzfduXqabhwlSKRXcawpH7vnzc tiOkwei2m00EzMALNmqkoWT4lkcDIrw= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1736245995; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=46xrDz1NEoXlBWxQO9+lozwpqQWVqsK1PYCSnaS3tk0=; b=c2+mCTPG2xDUo5j4pJ18O5fcbtvE6Frk6digR3xddJFUWRtWw+Sk18ukLQfzRnxZ++cIbr kczk/1Mn4jBYiaxILk3XOAGBctyDYekLAE8WizG1yVWg5xBSuMjlFNPn/QJs5nAoFz3Rqf KjcbqWVUJDOBj0r0VRLaCiZKBPbxmOI= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-362-Wc63lOqVMFWcyQEgsDYmSA-1; Tue, 07 Jan 2025 05:33:14 -0500 X-MC-Unique: Wc63lOqVMFWcyQEgsDYmSA-1 X-Mimecast-MFC-AGG-ID: Wc63lOqVMFWcyQEgsDYmSA Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-43626224274so46446105e9.0 for ; Tue, 07 Jan 2025 02:33:14 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736245993; x=1736850793; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=46xrDz1NEoXlBWxQO9+lozwpqQWVqsK1PYCSnaS3tk0=; b=rlwgjsr6REVdLy+CNRuAa7MP/KrEbD3hRqCXshWiF8ZjEYIFNJdOOUysdr4O0unwFv 0RXgKe4h0uXtl9zuCfOlKBio+tWUa8BDtXc6qRk+twlA+14Uaf33J3lE2gpnFoGyzo/0 EOC+qpuE0ajcKrFJIBezOyl9+rXRXo/WE3px0YB/Ac9VHjwby/pciRmBPQb9kQYRJJ7r liq5UfOpfB1Xqx8T19BWIQZAJGfIk7oeLQcdUXAn0L7/79SnlAw7v1EKl8fvO4Y0pefG tSCGgVtzB9vLZXM/x4eNDakgosBS3iUng1Nz9/9BwX15GnO2OaLVRLmZU/5nn0K4redN ZKBw== X-Gm-Message-State: AOJu0YzSi3LVSHXE3Dzhiij5Zl2MEt5qdImF8MltpQH3ZBGVBsWfde0c +fGKTQYEzd58ECPSLR9/OhzQpP5t8mBqi99OZZ+LxuRybBHQxyIiqJqRFUCx59O/k6NYeZoFwvB hlItmy223BgnBX9n7PmjAWqMFlzgWOJtRcype2AopJgiv9Lnl X-Gm-Gg: ASbGncv1oCe+C3J9RuIxaCU/A3Zz61UqXmxYMA4fmG35xeRslA7QD49wbQ30g1TaGyt Ogp3G32/Ma1CDOduoVIRH0zTYchPDgzKwp5yAek95H5kOomj0i1kCkpnaBe3BOvpgf21++tH9NU yQ069msLCXmwv7UvCHNfVe3M0UplRX/KIdh5ywMqgGtKG2SmzBOi8zutSDV5Zv0pZuHrt5m318j eusKeCDR4LUB7hXQxpi23IJa62mu3ZPhScQ71z2IDjARDbDFBEo9dlUUbeeU+00sQoIsnchITIS W983/d9wX5FEHG/t98x6TNT9NeQwAVzLR2P52GN96KCJqPPU97JbLyuWtOAYbt2YoKO6Q2qEVHJ M6qHO13Bj X-Received: by 2002:a05:600c:3c97:b0:434:a734:d268 with SMTP id 5b1f17b1804b1-4366864346fmr512018425e9.14.1736245993242; Tue, 07 Jan 2025 02:33:13 -0800 (PST) X-Google-Smtp-Source: AGHT+IGpajFTAPh9sGYUYFnNeElOfVLWKKCy5YjRzw1tge9ABR/u+9fEbBe0egXDaMdq0vmyobZM5w== X-Received: by 2002:a05:600c:3c97:b0:434:a734:d268 with SMTP id 5b1f17b1804b1-4366864346fmr512018205e9.14.1736245992816; Tue, 07 Jan 2025 02:33:12 -0800 (PST) Received: from ?IPV6:2003:cb:c719:1700:56dc:6a88:b509:d3f3? (p200300cbc719170056dc6a88b509d3f3.dip0.t-ipconnect.de. [2003:cb:c719:1700:56dc:6a88:b509:d3f3]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-436604e9c2csm593784385e9.43.2025.01.07.02.33.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 07 Jan 2025 02:33:12 -0800 (PST) Message-ID: <6710b03e-7bfa-4852-9555-ad5b9b8b85cd@redhat.com> Date: Tue, 7 Jan 2025 11:33:10 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] drivers/base/memory: simplify outputting of valid_zones_show() To: Shiyang Ruan Cc: linux-mm@kvack.org, osalvador@suse.de, rafael@kernel.org References: <20250107100941.1169222-1-ruansy.fnst@fujitsu.com> <40951175-01df-49bf-9dbe-29fbdd114aed@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: onevWB-HnsqSd7CCakUqkOR1fzBvQ8y9PBEa_evxYOs_1736245993 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 7C5BDA0003 X-Stat-Signature: ysa9d4xpd3rmxsmqncf3gqktjj5rc9cn X-Rspam-User: X-Rspamd-Server: rspam11 X-HE-Tag: 1736245996-39750 X-HE-Meta: U2FsdGVkX1+Gn1Y/uknROCEPzEeX/1NqsD1wttzGsgwDr2fDF7X7gNjrRFTXPp/KrxV3ZGjy3CgAajQcMHBBfNpDKbM+OeP/Np6YyaxR9eGsXWJdjaPQPY8frybiMY8/nMpP+LT7VxX5UHtDAaSeGe4Qlf6uKx+Vp4A8l37H/4+ZsTYng2W0NawL2Vv57uJ9cH3V/GWgmEyAiSu/Jprc71ZOb14RREsom+PgOB0fVAWEdnTNxMSmchLWJ/PJUWHwFQBQ8GsGvzdLG+uq+7SRM6LF1IIa1AIq1UP/uyIaI9HkOQuhYZLaeS+9L1wZ21CdxOZNCL58lUqgx3vP0/ObdFcLylykz/B8BECmtb445qyMFOc0e5DddmES3IM7YFr2A800aSg+D4JFJnn+7mcgAKIJMF/lWF2Z/Of40TJ9Gq1XnBj122CUWLrxOOgm3nIiAnHM9K5KbpiL38MFvIOnMviHe3Cfc3UiKCcW0d2ju2/1NEPfL5zIEsQeL8cy43tjSJg0XfKjXp7jmJpm00yExslpvV48AtOFbhey6lnZLtWXXiURy7kZzdG8ujvhV4wIbdKBMcPnH0zEpdAnWYozFikxEiBEcMyOKLPxvi7FUURIqkKsN+c5cpIgpi/z01arfeYXD3iJ86lgL0DRBgYTnnOJDOpeZADaRykWSIdx6ySqUo+fscsJ/+92gWAPAvUKJrFPjrGm99ZLrB5Q+k7IYNEVfn+QNGmWj4XpGXB47vGDcnL5TwB1y7KxYE4aKx4nUmAYBRVMPqklairc2gOh+kTHywhec70UZnhZkQMhmEykPnjOKtuMsD4jKz9YhMF0FPipGTkNra8OVR0sgXapmPImzJCbYeYSD//hA4H9Ng19y0fGSBeeBfM9mG6GUZ0X6133lqtH48Wdl3b6N1cfZ/6dNElFJGkrSztYahi3LftyL5l13VUAKrxm0GBj77sCdSUUJKc5e3CxSka85VW xR9Tw9Az HgqfpHuRGV7t6UCWVpZ4ogGS2lnP4IjV1gKX85BOcNdS3u2AhgCwmt0m13+oU18sJNJUiE+u9hzfcWJDRcmkGF3jqp57ILfZpLUCTIldZEjW40qzn9TcZj9t+Y5Lb3ZdOvFjBb6XgV7Gp7qg1tXdm9FZ0cTNDNmR3v56kP8zlFfSvQ7sDTK3j2jgu9UEMeghWO0g/mSdleScD0eEze2js1YygmD1T4ppQxe6D/ttIiD4/huFbiA1PPmTVpTaWg0YxAviClFrE4HAiAPNlzScDcP8VNGxh7HSwMBXin86p6gZtIA3iQ9xafMryVRxOkXMOsfs30NP6S3Q202Q1Wb6j95mNH2GIlOr+2HVUEWcQ2C+KaJqPM1beONlj/lUIlIheXrjCej+0AIaZO0kuBLUvw3uOlCv/zRAI8JDDKIqVJ0Dk8FQEuCaFgOLwhvhXMHX6Ax3TQFtQLphF0BqP6SFB2uvCXfwrzmWiF18EslxhWbCWBB8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.010523, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 07.01.25 11:28, Shiyang Ruan wrote: > > > 在 2025/1/7 18:15, David Hildenbrand 写道: >> On 07.01.25 11:09, Shiyang Ruan wrote: >>> No need to specific position at the first writing to the buf because the >>> @len is always 0 at this time.  Use sysfs_emit() instead to simplify it. >>> >>> Signed-off-by: Shiyang Ruan >>> --- >>>   drivers/base/memory.c | 6 ++---- >>>   1 file changed, 2 insertions(+), 4 deletions(-) >>> >>> diff --git a/drivers/base/memory.c b/drivers/base/memory.c >>> index 67858eeb92ed..d77a83c9af39 100644 >>> --- a/drivers/base/memory.c >>> +++ b/drivers/base/memory.c >>> @@ -469,19 +469,17 @@ static ssize_t valid_zones_show(struct device *dev, >>>           default_zone = mem->zone; >>>           if (!default_zone) >>>               return sysfs_emit(buf, "%s\n", "none"); >>> -        len += sysfs_emit_at(buf, len, "%s", default_zone->name); >>> -        goto out; >>> +        return sysfs_emit(buf, "%s\n", default_zone->name); >> >> We can go one step further and do: >> >> return sysfs_emit(buf, "%s\n", >>           mem->zone ? mem->zone->name : "none"); >> >> Avoiding setting/checking default_zone. > > I have thought about it but it would cause the line over long. I think it fits even into 80 chars just fine if you split it across two lines like I suggested. But yeah, a single line might be fine as well. -- Cheers, David / dhildenb